HangyuanLiu commented on a change in pull request #3705:
URL: https://github.com/apache/incubator-doris/pull/3705#discussion_r431551350
##########
File path: fe/src/main/java/org/apache/doris/analysis/StatementBase.java
##########
@@ -153,7 +156,17 @@ public String getClusterName() {
public void setClusterName(String clusterName) {
this.clusterName = clusterName;
- }
+ }
+
+ public void setOrigStmt(OriginStatement origStmt) {
+ this.origStmt = origStmt;
+ }
+
+ public OriginStatement getOrigStmt() {
+ Preconditions.checkState(origStmt != null);
Review comment:
NULL should be judged in set, it may be too late to judge in get function
##########
File path: fe/src/main/java/org/apache/doris/catalog/MaterializedIndexMeta.java
##########
@@ -46,9 +55,11 @@
private TStorageType storageType;
@SerializedName(value = "keysType")
private KeysType keysType;
+ @SerializedName(value = "defineStmt")
+ private OriginStatement defineStmt;
Review comment:
The name defineStmt can easily cause ambiguity with DefineExpr. But this
statement may not only parse the semantics of defineExpr in the
future。MaterializedViewStmt is a better name ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
