morningman commented on a change in pull request #3724:
URL: https://github.com/apache/incubator-doris/pull/3724#discussion_r432806370
##########
File path: be/src/exprs/bitmap_function.cpp
##########
@@ -488,7 +488,8 @@ StringVal
BitmapFunctions::bitmap_from_string(FunctionContext* ctx, const String
}
std::vector<uint64_t> bits;
- if (!SplitStringAndParse({(const char*)input.ptr, input.len}, ",",
&safe_strtou64, &bits)) {
+ // TODO(hkp): I think StringPiece's len should also be uint64_t
Review comment:
Could you explain why not changing this to int64? You can just add
comment here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
