[GitHub] [incubator-doris] yangzhg commented on a change in pull request #3638: Supoort utf-8 encoding in instr, locate, locate_pos, lpad, rpad

2020-05-21 Thread GitBox
yangzhg commented on a change in pull request #3638: URL: https://github.com/apache/incubator-doris/pull/3638#discussion_r428580401 ## File path: be/src/exprs/string_functions.cpp ## @@ -49,6 +49,17 @@ size_t get_utf8_byte_length(unsigned char byte) { } return

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #3638: Supoort utf-8 encoding in instr, locate, locate_pos, lpad, rpad

2020-05-21 Thread GitBox
yangzhg commented on a change in pull request #3638: URL: https://github.com/apache/incubator-doris/pull/3638#discussion_r428494034 ## File path: be/src/exprs/string_functions.cpp ## @@ -196,28 +196,56 @@ StringVal StringFunctions::lpad( if (str.is_null || len.is_null ||

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #3638: Supoort utf-8 encoding in instr, locate, locate_pos, lpad, rpad

2020-05-20 Thread GitBox
yangzhg commented on a change in pull request #3638: URL: https://github.com/apache/incubator-doris/pull/3638#discussion_r428406815 ## File path: be/src/exprs/string_functions.cpp ## @@ -196,28 +196,56 @@ StringVal StringFunctions::lpad( if (str.is_null || len.is_null ||