zhannngchen merged PR #34871:
URL: https://github.com/apache/doris/pull/34871
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.
github-actions[bot] commented on PR #34871:
URL: https://github.com/apache/doris/pull/34871#issuecomment-2123749065
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
Yukang-Lian commented on PR #34871:
URL: https://github.com/apache/doris/pull/34871#issuecomment-2121856256
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Yukang-Lian commented on PR #34871:
URL: https://github.com/apache/doris/pull/34871#issuecomment-2121763707
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Yukang-Lian commented on PR #34871:
URL: https://github.com/apache/doris/pull/34871#issuecomment-2121662137
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Yukang-Lian commented on PR #34871:
URL: https://github.com/apache/doris/pull/34871#issuecomment-2121641770
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
github-actions[bot] commented on PR #34871:
URL: https://github.com/apache/doris/pull/34871#issuecomment-2121634573
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
Yukang-Lian commented on PR #34871:
URL: https://github.com/apache/doris/pull/34871#issuecomment-2120813875
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
github-actions[bot] commented on code in PR #34871:
URL: https://github.com/apache/doris/pull/34871#discussion_r1606899567
##
be/test/olap/segment_cache_test.cpp:
##
@@ -0,0 +1,361 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
Yukang-Lian commented on PR #34871:
URL: https://github.com/apache/doris/pull/34871#issuecomment-2120632515
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Yukang-Lian commented on PR #34871:
URL: https://github.com/apache/doris/pull/34871#issuecomment-2120484582
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Yukang-Lian commented on PR #34871:
URL: https://github.com/apache/doris/pull/34871#issuecomment-2120311489
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Yukang-Lian commented on PR #34871:
URL: https://github.com/apache/doris/pull/34871#issuecomment-2120285044
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
github-actions[bot] commented on PR #34871:
URL: https://github.com/apache/doris/pull/34871#issuecomment-2120252887
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on PR #34871:
URL: https://github.com/apache/doris/pull/34871#issuecomment-2120252780
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
github-actions[bot] commented on code in PR #34871:
URL: https://github.com/apache/doris/pull/34871#discussion_r1606539914
##
be/test/olap/segment_cache_test.cpp:
##
@@ -0,0 +1,352 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
zhannngchen commented on code in PR #34871:
URL: https://github.com/apache/doris/pull/34871#discussion_r1606480311
##
be/src/olap/base_tablet.cpp:
##
@@ -538,10 +538,10 @@ Status BaseTablet::lookup_row_key(const Slice&
encoded_key, bool with_seq_col,
continue;
github-actions[bot] commented on PR #34871:
URL: https://github.com/apache/doris/pull/34871#issuecomment-2116937736
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Yukang-Lian commented on PR #34871:
URL: https://github.com/apache/doris/pull/34871#issuecomment-2116929775
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
zhannngchen commented on code in PR #34871:
URL: https://github.com/apache/doris/pull/34871#discussion_r1604265672
##
be/src/olap/base_tablet.cpp:
##
@@ -548,6 +553,15 @@ Status BaseTablet::lookup_row_key(const Slice&
encoded_key, bool with_seq_col,
for (auto id : pi
zhannngchen commented on code in PR #34871:
URL: https://github.com/apache/doris/pull/34871#discussion_r1604265672
##
be/src/olap/base_tablet.cpp:
##
@@ -548,6 +553,15 @@ Status BaseTablet::lookup_row_key(const Slice&
encoded_key, bool with_seq_col,
for (auto id : pi
zhannngchen commented on code in PR #34871:
URL: https://github.com/apache/doris/pull/34871#discussion_r1604265672
##
be/src/olap/base_tablet.cpp:
##
@@ -548,6 +553,15 @@ Status BaseTablet::lookup_row_key(const Slice&
encoded_key, bool with_seq_col,
for (auto id : pi
github-actions[bot] commented on PR #34871:
URL: https://github.com/apache/doris/pull/34871#issuecomment-2116004161
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Yukang-Lian commented on PR #34871:
URL: https://github.com/apache/doris/pull/34871#issuecomment-2115994745
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
github-actions[bot] commented on PR #34871:
URL: https://github.com/apache/doris/pull/34871#issuecomment-2115968112
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on code in PR #34871:
URL: https://github.com/apache/doris/pull/34871#discussion_r1601669912
##
be/src/olap/rowset/segment_v2/segment.cpp:
##
@@ -282,14 +282,20 @@ Status Segment::_parse_footer(SegmentFooterPB* footer) {
return Status::OK();
}
Yukang-Lian commented on PR #34871:
URL: https://github.com/apache/doris/pull/34871#issuecomment-2112548726
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
zhannngchen commented on code in PR #34871:
URL: https://github.com/apache/doris/pull/34871#discussion_r1601279443
##
be/src/olap/rowset/segment_v2/segment.cpp:
##
@@ -290,6 +290,10 @@ Status Segment::_load_pk_bloom_filter() {
return _load_pk_bf_once.call([this] {
zhannngchen commented on code in PR #34871:
URL: https://github.com/apache/doris/pull/34871#discussion_r1601275238
##
be/src/olap/rowset/segment_v2/segment.cpp:
##
@@ -290,6 +290,10 @@ Status Segment::_load_pk_bloom_filter() {
return _load_pk_bf_once.call([this] {
github-actions[bot] commented on PR #34871:
URL: https://github.com/apache/doris/pull/34871#issuecomment-2111456092
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #34871:
URL: https://github.com/apache/doris/pull/34871#issuecomment-2111456079
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Yukang-Lian commented on PR #34871:
URL: https://github.com/apache/doris/pull/34871#issuecomment-2111451448
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
github-actions[bot] commented on PR #34871:
URL: https://github.com/apache/doris/pull/34871#issuecomment-2110772482
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Yukang-Lian commented on PR #34871:
URL: https://github.com/apache/doris/pull/34871#issuecomment-2110764304
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
doris-robot commented on PR #34871:
URL: https://github.com/apache/doris/pull/34871#issuecomment-2110764019
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
Yukang-Lian opened a new pull request, #34871:
URL: https://github.com/apache/doris/pull/34871
## Proposed changes
Issue Number: close #xxx
## Further comments
If this is a relatively large or complex change, kick off the discussion at
[d...@doris.apache.org](mai
36 matches
Mail list logo
