zhiqiang- commented on PR #35115:
URL: https://github.com/apache/doris/pull/35115#issuecomment-2121963328
@adonis0147 I made a test, and modified as your suggestion, it works. So
this one is closed.
--
This is an automated message from the Apache Git Service.
To respond to the message
zhiqiang- closed pull request #35115: [compile](mac) Fix compile on mac os
URL: https://github.com/apache/doris/pull/35115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
zhiqiang- commented on PR #35115:
URL: https://github.com/apache/doris/pull/35115#issuecomment-2121944207
> ```c++
> frac_value
> ```
`T` could be Int128, `std::abs` seems not support using `__int128` directly
unless we are using libstdc++. I am wondering whether the fix you
adonis0147 commented on PR #35115:
URL: https://github.com/apache/doris/pull/35115#issuecomment-2121913411
> > I don't think this fix is suitable.
>
> Please add some suggestion instead of just giving a conclusion.
Hi @zhiqiang- , I feel sorry for the reply. I validated anot
doris-robot commented on PR #35115:
URL: https://github.com/apache/doris/pull/35115#issuecomment-2121909660
TeamCity be ut coverage result:
Function Coverage: 35.70% (9018/25263)
Line Coverage: 27.34% (74557/272666)
Region Coverage: 26.56% (38543/145114)
Branch Coverage: 23.4
zhiqiang- commented on PR #35115:
URL: https://github.com/apache/doris/pull/35115#issuecomment-2121894930
> I don't think this fix is suitable.
Please add some suggestion instead of just giving a conclusion.
--
This is an automated message from the Apache Git Service.
To respond
github-actions[bot] commented on PR #35115:
URL: https://github.com/apache/doris/pull/35115#issuecomment-2121863334
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zhiqiang- commented on PR #35115:
URL: https://github.com/apache/doris/pull/35115#issuecomment-2121854969
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
doris-robot commented on PR #35115:
URL: https://github.com/apache/doris/pull/35115#issuecomment-2121854861
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
zhiqiang- opened a new pull request, #35115:
URL: https://github.com/apache/doris/pull/35115
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
10 matches
Mail list logo
