[GitHub] andresgomezfrr commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension

2018-07-30 Thread GitBox
andresgomezfrr commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#discussion_r206037888 ## File path: processing/src/main/java/io/druid/query/aggregation/first/StringFirstAggrega

[GitHub] andresgomezfrr commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension

2018-07-30 Thread GitBox
andresgomezfrr commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#discussion_r206040987 ## File path: processing/src/main/java/io/druid/query/aggregation/first/StringFirstBufferA

[GitHub] andresgomezfrr commented on issue #5789: Add stringLast and stringFirst aggregators extension

2018-07-30 Thread GitBox
andresgomezfrr commented on issue #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#issuecomment-408778293 @jihoonson Fixed: * https://github.com/apache/incubator-druid/pull/5789#discussion_r205263503 * htt

[GitHub] gaodayue commented on issue #6036: use S3 as a backup storage for hdfs deep storage

2018-07-30 Thread GitBox
gaodayue commented on issue #6036: use S3 as a backup storage for hdfs deep storage URL: https://github.com/apache/incubator-druid/pull/6036#issuecomment-408800788 > So this backup deep storage technique would improve availability for writes (because you can write to either deep storage) b

[GitHub] gaodayue commented on issue #6036: use S3 as a backup storage for hdfs deep storage

2018-07-30 Thread GitBox
gaodayue commented on issue #6036: use S3 as a backup storage for hdfs deep storage URL: https://github.com/apache/incubator-druid/pull/6036#issuecomment-408802762 Btw, not sure whether composite-deep-storage is the right name or not, since it's not writing to all components as composite-e

[GitHub] varaga opened a new issue #6069: BUG: intermediate persist directories are not cleaned up

2018-07-30 Thread GitBox
varaga opened a new issue #6069: BUG: intermediate persist directories are not cleaned up URL: https://github.com/apache/incubator-druid/issues/6069 I am using Druid 0.13.0-SNAPSHOT version of Druid and it's deployed into AWS. The middle managers run Kafka Indexing Task. The task base di

[GitHub] gianm commented on issue #6036: use S3 as a backup storage for hdfs deep storage

2018-07-30 Thread GitBox
gianm commented on issue #6036: use S3 as a backup storage for hdfs deep storage URL: https://github.com/apache/incubator-druid/pull/6036#issuecomment-408899333 >Agreed. Earlier I tried to load primary and secondary deep storage extensions inside composite-deep-storage module and found it d

[GitHub] gianm commented on issue #6058: Remove some unnecessary task storage internal APIs.

2018-07-30 Thread GitBox
gianm commented on issue #6058: Remove some unnecessary task storage internal APIs. URL: https://github.com/apache/incubator-druid/pull/6058#issuecomment-408899571 @asdf2014 I will fix them and re-push. Anything that makes the CI failure message more useful sounds great 😄 -

[GitHub] gianm commented on a change in pull request #6062: Fix a bug in GroupByQueryEngine

2018-07-30 Thread GitBox
gianm commented on a change in pull request #6062: Fix a bug in GroupByQueryEngine URL: https://github.com/apache/incubator-druid/pull/6062#discussion_r206202261 ## File path: processing/src/main/java/io/druid/query/groupby/GroupByQueryEngine.java ## @@ -178,37 +178,33 @@

[GitHub] yuppie-flu opened a new pull request #6070: Use JUnit TemporaryFolder rule instead of system temp folder

2018-07-30 Thread GitBox
yuppie-flu opened a new pull request #6070: Use JUnit TemporaryFolder rule instead of system temp folder URL: https://github.com/apache/incubator-druid/pull/6070 This should help to avoid transient failures, mentioned in #6013 ([comment](https://github.com/apache/incubator-druid/issues/601

[GitHub] gianm commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument

2018-07-30 Thread GitBox
gianm commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument URL: https://github.com/apache/incubator-druid/pull/6068#discussion_r206212482 ## File path: indexing-service/src/main/java/io/druid/indexing/common/task/Tasks.java ##

[GitHub] gianm commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument

2018-07-30 Thread GitBox
gianm commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument URL: https://github.com/apache/incubator-druid/pull/6068#discussion_r206212950 ## File path: processing/src/main/java/io/druid/collections/spatial/Node.java ## @@ -56,7

[GitHub] gianm commented on issue #6069: BUG: intermediate persist directories are not cleaned up

2018-07-30 Thread GitBox
gianm commented on issue #6069: BUG: intermediate persist directories are not cleaned up URL: https://github.com/apache/incubator-druid/issues/6069#issuecomment-408912020 Hi @varaga, The MiddleManager processes themselves are meant to clean up these directories when tasks exit. Are

[incubator-druid] branch master updated: CompactionTask: Reject empty intervals on construction. (#6059)

2018-07-30 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 63be028 CompactionTask: Reject empty int

[GitHub] gianm closed pull request #6059: CompactionTask: Reject empty intervals on construction.

2018-07-30 Thread GitBox
gianm closed pull request #6059: CompactionTask: Reject empty intervals on construction. URL: https://github.com/apache/incubator-druid/pull/6059 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] gianm commented on issue #6070: Use JUnit TemporaryFolder rule instead of system temp folder

2018-07-30 Thread GitBox
gianm commented on issue #6070: Use JUnit TemporaryFolder rule instead of system temp folder URL: https://github.com/apache/incubator-druid/pull/6070#issuecomment-408925522 Hi @yuppie-flu, there seems to be some problem with the new forbidden-api check: ```[ERROR] Failed to execute

[GitHub] gianm edited a comment on issue #6070: Use JUnit TemporaryFolder rule instead of system temp folder

2018-07-30 Thread GitBox
gianm edited a comment on issue #6070: Use JUnit TemporaryFolder rule instead of system temp folder URL: https://github.com/apache/incubator-druid/pull/6070#issuecomment-408925522 Hi @yuppie-flu, there seems to be some problem with the new forbidden-api check: ``` [ERROR] Failed

[GitHub] chengchengpei opened a new issue #6071: DerivativeDataSourceMetadata allows adding empty string baseDataSource

2018-07-30 Thread GitBox
chengchengpei opened a new issue #6071: DerivativeDataSourceMetadata allows adding empty string baseDataSource URL: https://github.com/apache/incubator-druid/issues/6071 similar to https://github.com/apache/incubator-druid/issues/5903. `baseDataSource` should not be empty string. I

[GitHub] chengchengpei opened a new pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

2018-07-30 Thread GitBox
chengchengpei opened a new pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072 https://github.com/apache/incubator-druid/issues/6071 the following two tests failed: Tests in error:

[GitHub] gianm commented on issue #5903: Druid allows adding empty string dataSources (it shouldn't)

2018-07-30 Thread GitBox
gianm commented on issue #5903: Druid allows adding empty string dataSources (it shouldn't) URL: https://github.com/apache/incubator-druid/issues/5903#issuecomment-408942682 Fixed by #5785. This is an automated message from

[GitHub] gianm closed issue #5903: Druid allows adding empty string dataSources (it shouldn't)

2018-07-30 Thread GitBox
gianm closed issue #5903: Druid allows adding empty string dataSources (it shouldn't) URL: https://github.com/apache/incubator-druid/issues/5903 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] chengchengpei commented on issue #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

2018-07-30 Thread GitBox
chengchengpei commented on issue #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072#issuecomment-408943015 how to add WIP tag? This is an

[GitHub] jihoonson commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument

2018-07-30 Thread GitBox
jihoonson commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument URL: https://github.com/apache/incubator-druid/pull/6068#discussion_r206272902 ## File path: indexing-service/src/main/java/io/druid/indexing/common/task/Tasks.java

[GitHub] leventov commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument

2018-07-30 Thread GitBox
leventov commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument URL: https://github.com/apache/incubator-druid/pull/6068#discussion_r206274500 ## File path: indexing-service/src/main/java/io/druid/indexing/common/task/Tasks.java #

[GitHub] jihoonson commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument

2018-07-30 Thread GitBox
jihoonson commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument URL: https://github.com/apache/incubator-druid/pull/6068#discussion_r206274914 ## File path: processing/src/main/java/io/druid/collections/spatial/Node.java ## @@ -5

[GitHub] jihoonson commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument

2018-07-30 Thread GitBox
jihoonson commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument URL: https://github.com/apache/incubator-druid/pull/6068#discussion_r206277090 ## File path: indexing-service/src/main/java/io/druid/indexing/common/task/Tasks.java

[GitHub] yuppie-flu commented on issue #6070: Use JUnit TemporaryFolder rule instead of system temp folder

2018-07-30 Thread GitBox
yuppie-flu commented on issue #6070: Use JUnit TemporaryFolder rule instead of system temp folder URL: https://github.com/apache/incubator-druid/pull/6070#issuecomment-408965777 Thank you @gianm I had to remove this check, cause there are some modules, which do not depend on apache com

[GitHub] jihoonson commented on issue #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

2018-07-30 Thread GitBox
jihoonson commented on issue #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072#issuecomment-408966069 Hi @chengchengpei, thank you for the contribution! I've added `WIP` tag. --

[GitHub] Caroline1000 opened a new pull request #6073: Query gran0730

2018-07-30 Thread GitBox
Caroline1000 opened a new pull request #6073: Query gran0730 URL: https://github.com/apache/incubator-druid/pull/6073 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub a

[GitHub] chengchengpei commented on issue #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

2018-07-30 Thread GitBox
chengchengpei commented on issue #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072#issuecomment-408974324 @jihoonson Hi, Thanks. It seems that the failed tests are not related to my change. most of them fa

[GitHub] jihoonson commented on issue #6061: skip travis on doc only changes

2018-07-30 Thread GitBox
jihoonson commented on issue #6061: skip travis on doc only changes URL: https://github.com/apache/incubator-druid/pull/6061#issuecomment-408976290 @clintropolis it sounds good. This is an automated message from the Apache Git

[GitHub] jihoonson commented on issue #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

2018-07-30 Thread GitBox
jihoonson commented on issue #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072#issuecomment-408980333 @chengchengpei I restarted failed jobs. You can also close and reopen this PR to trigger another test.

[GitHub] yuppie-flu commented on issue #6013: Fix transient test failures

2018-07-30 Thread GitBox
yuppie-flu commented on issue #6013: Fix transient test failures URL: https://github.com/apache/incubator-druid/issues/6013#issuecomment-408986589 ``` Tests run: 12, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 21.763 sec <<< FAILURE! - in io.druid.data.input.impl.prefetch.Prefetc

[GitHub] jon-wei commented on a change in pull request #6065: Fix CombiningFirehoseFactory with IngestSegmentFirehoseFactory in IndexTask

2018-07-30 Thread GitBox
jon-wei commented on a change in pull request #6065: Fix CombiningFirehoseFactory with IngestSegmentFirehoseFactory in IndexTask URL: https://github.com/apache/incubator-druid/pull/6065#discussion_r206308816 ## File path: indexing-service/src/main/java/io/druid/indexing/common/task

[GitHub] jihoonson commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries

2018-07-30 Thread GitBox
jihoonson commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries URL: https://github.com/apache/incubator-druid/pull/5857#discussion_r206301783 ## File path: processing/src/main/java/io/druid/query/aggregation/AggregatorFact

[GitHub] jihoonson commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries

2018-07-30 Thread GitBox
jihoonson commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries URL: https://github.com/apache/incubator-druid/pull/5857#discussion_r206303526 ## File path: processing/src/main/java/io/druid/query/aggregation/SuppressedAggr

[GitHub] jihoonson commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries

2018-07-30 Thread GitBox
jihoonson commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries URL: https://github.com/apache/incubator-druid/pull/5857#discussion_r206301554 ## File path: processing/src/main/java/io/druid/query/PerSegmentQueryOptimizatio

[GitHub] jihoonson commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries

2018-07-30 Thread GitBox
jihoonson commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries URL: https://github.com/apache/incubator-druid/pull/5857#discussion_r206304373 ## File path: processing/src/main/java/io/druid/query/aggregation/FilteredAggreg

[GitHub] jihoonson commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries

2018-07-30 Thread GitBox
jihoonson commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries URL: https://github.com/apache/incubator-druid/pull/5857#discussion_r206302230 ## File path: processing/src/main/java/io/druid/query/aggregation/FilteredAggreg

[incubator-druid] branch master updated: skip travis on doc only changes (#6061)

2018-07-30 Thread jihoonson
This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 66af403 skip travis on doc only cha

[GitHub] jihoonson closed pull request #6061: skip travis on doc only changes

2018-07-30 Thread GitBox
jihoonson closed pull request #6061: skip travis on doc only changes URL: https://github.com/apache/incubator-druid/pull/6061 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pu

[GitHub] chengchengpei opened a new pull request #6075: validate non-empty String baseDataSource in MaterializedViewSuperviso…

2018-07-30 Thread GitBox
chengchengpei opened a new pull request #6075: validate non-empty String baseDataSource in MaterializedViewSuperviso… URL: https://github.com/apache/incubator-druid/pull/6075 re: https://github.com/apache/incubator-druid/issues/6074 I am working on this.

[GitHub] chengchengpei opened a new issue #6074: MaterializedViewSupervisorSpec should not allow empty baseDataSource

2018-07-30 Thread GitBox
chengchengpei opened a new issue #6074: MaterializedViewSupervisorSpec should not allow empty baseDataSource URL: https://github.com/apache/incubator-druid/issues/6074 similar to https://github.com/apache/incubator-druid/issues/5903. `baseDataSource` should not be empty string. I am

[GitHub] chengchengpei commented on issue #6075: validate non-empty String baseDataSource in MaterializedViewSuperviso…

2018-07-30 Thread GitBox
chengchengpei commented on issue #6075: validate non-empty String baseDataSource in MaterializedViewSuperviso… URL: https://github.com/apache/incubator-druid/pull/6075#issuecomment-409003017 @jihoonson could you please add WIP here? -

[GitHub] jihoonson commented on issue #5492: Native parallel batch indexing without shuffle

2018-07-30 Thread GitBox
jihoonson commented on issue #5492: Native parallel batch indexing without shuffle URL: https://github.com/apache/incubator-druid/pull/5492#issuecomment-409004658 @drcrallen do you have further comments? This is an automated

[GitHub] jihoonson commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension

2018-07-30 Thread GitBox
jihoonson commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#discussion_r206319063 ## File path: processing/src/main/java/io/druid/query/aggregation/first/StringFirstBufferAggreg

[GitHub] jihoonson commented on issue #5789: Add stringLast and stringFirst aggregators extension

2018-07-30 Thread GitBox
jihoonson commented on issue #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#issuecomment-409008347 @andresgomezfrr thanks. Please check my comment [here](https://github.com/apache/incubator-druid/pull/5789#discussion_r20

[GitHub] jihoonson commented on issue #5584: Decoupling FirehoseFactory and InputRowParser

2018-07-30 Thread GitBox
jihoonson commented on issue #5584: Decoupling FirehoseFactory and InputRowParser URL: https://github.com/apache/incubator-druid/issues/5584#issuecomment-409010765 @josephglanville, thanks for the comment. It sounds good to me. I also agree to support Reader for realtime ingestion too. Do

[incubator-druid] branch master updated: Add definition of 'NONE' to queryGranularity in ingestion.index doc (#6073)

2018-07-30 Thread jihoonson
This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 7f89c72 Add definition of 'NONE' to

[GitHub] jihoonson closed pull request #6073: Add definition of 'NONE' to queryGranularity in ingestion.index doc

2018-07-30 Thread GitBox
jihoonson closed pull request #6073: Add definition of 'NONE' to queryGranularity in ingestion.index doc URL: https://github.com/apache/incubator-druid/pull/6073 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] andresgomezfrr commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension

2018-07-30 Thread GitBox
andresgomezfrr commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#discussion_r206328302 ## File path: processing/src/main/java/io/druid/query/aggregation/first/StringFirstBufferA

[incubator-druid] branch master updated: Fix a bug in GroupByQueryEngine (#6062)

2018-07-30 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new f3595c9 Fix a bug in GroupByQueryEngine

[GitHub] gianm closed pull request #6062: Fix a bug in GroupByQueryEngine

2018-07-30 Thread GitBox
gianm closed pull request #6062: Fix a bug in GroupByQueryEngine URL: https://github.com/apache/incubator-druid/pull/6062 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull r

[GitHub] jihoonson commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension

2018-07-30 Thread GitBox
jihoonson commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#discussion_r206331467 ## File path: processing/src/main/java/io/druid/query/aggregation/first/StringFirstBufferAggreg

[GitHub] drcrallen commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-07-30 Thread GitBox
drcrallen commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r206339529 ## File path: common/src/main/java/io/druid/common/guava/GuavaUtil

[GitHub] drcrallen commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-07-30 Thread GitBox
drcrallen commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r206344133 ## File path: processing/src/main/java/io/druid/guice/ForkJoinPool

[GitHub] drcrallen commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-07-30 Thread GitBox
drcrallen commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r206344737 ## File path: processing/src/main/java/io/druid/query/ChainedExec

[GitHub] drcrallen commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-07-30 Thread GitBox
drcrallen commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r206344716 ## File path: processing/src/main/java/io/druid/query/ChainedExec

[GitHub] drcrallen commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-07-30 Thread GitBox
drcrallen commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r206345151 ## File path: common/src/main/java/io/druid/common/guava/GuavaUtil

[GitHub] drcrallen commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-07-30 Thread GitBox
drcrallen commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r206349829 ## File path: server/src/main/java/io/druid/client/CachingClustere

[GitHub] drcrallen commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-07-30 Thread GitBox
drcrallen commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r206350473 ## File path: java-util/src/main/java/io/druid/java/util/common/c

[GitHub] jon-wei opened a new pull request #6076: Mutual TLS support

2018-07-30 Thread GitBox
jon-wei opened a new pull request #6076: Mutual TLS support URL: https://github.com/apache/incubator-druid/pull/6076 This PR adds support for mutual TLS (https://en.wikipedia.org/wiki/Mutual_authentication). This adds a new "requireClientAuth" property and truststore properties on

[GitHub] jon-wei commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries

2018-07-30 Thread GitBox
jon-wei commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries URL: https://github.com/apache/incubator-druid/pull/5857#discussion_r206370115 ## File path: processing/src/main/java/io/druid/query/PerSegmentQueryOptimizationC

[GitHub] jon-wei commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries

2018-07-30 Thread GitBox
jon-wei commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries URL: https://github.com/apache/incubator-druid/pull/5857#discussion_r206370185 ## File path: processing/src/main/java/io/druid/query/aggregation/SuppressedAggreg

[GitHub] jon-wei commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries

2018-07-30 Thread GitBox
jon-wei commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries URL: https://github.com/apache/incubator-druid/pull/5857#discussion_r206370139 ## File path: processing/src/main/java/io/druid/query/aggregation/AggregatorFactor

[GitHub] jon-wei commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries

2018-07-30 Thread GitBox
jon-wei commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries URL: https://github.com/apache/incubator-druid/pull/5857#discussion_r206370165 ## File path: processing/src/main/java/io/druid/query/aggregation/FilteredAggregat

[GitHub] jon-wei opened a new pull request #6077: Revert "skip travis on doc only changes"

2018-07-30 Thread GitBox
jon-wei opened a new pull request #6077: Revert "skip travis on doc only changes" URL: https://github.com/apache/incubator-druid/pull/6077 Reverts apache/incubator-druid#6061 The change introduced there is skipping tests for non-doc only changes -

[GitHub] clintropolis commented on issue #6061: skip travis on doc only changes

2018-07-30 Thread GitBox
clintropolis commented on issue #6061: skip travis on doc only changes URL: https://github.com/apache/incubator-druid/pull/6061#issuecomment-409063965 reverting because this doesn't seem to work correctly This is an automated

[incubator-druid] branch master updated: Remove some unnecessary task storage internal APIs. (#6058)

2018-07-30 Thread jihoonson
This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 3aa7017 Remove some unnecessary tas

[GitHub] jihoonson closed pull request #6058: Remove some unnecessary task storage internal APIs.

2018-07-30 Thread GitBox
jihoonson closed pull request #6058: Remove some unnecessary task storage internal APIs. URL: https://github.com/apache/incubator-druid/pull/6058 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] jihoonson closed pull request #6045: Fix 'auto' encoded longs + compression serializer

2018-07-30 Thread GitBox
jihoonson closed pull request #6045: Fix 'auto' encoded longs + compression serializer URL: https://github.com/apache/incubator-druid/pull/6045 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As t

[GitHub] jihoonson closed issue #6044: 'auto' long encoding + compression is broken for some 'bits per value' sizes

2018-07-30 Thread GitBox
jihoonson closed issue #6044: 'auto' long encoding + compression is broken for some 'bits per value' sizes URL: https://github.com/apache/incubator-druid/issues/6044 This is an automated message from the Apache Git Service.

[incubator-druid] branch master updated: Fix 'auto' encoded longs + compression serializer (#6045)

2018-07-30 Thread jihoonson
This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 20ae8aa Fix 'auto' encoded longs +

[GitHub] asdf2014 opened a new pull request #6078: Add the '--fail-at-end' option to maven command for 'strictly compiled' part

2018-07-30 Thread GitBox
asdf2014 opened a new pull request #6078: Add the '--fail-at-end' option to maven command for 'strictly compiled' part URL: https://github.com/apache/incubator-druid/pull/6078 Add the `--fail-at-end` option into the maven command for the `strictly compiled' part, and then we can get all th

[GitHub] jon-wei commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries

2018-07-30 Thread GitBox
jon-wei commented on a change in pull request #5857: Optimize filtered aggs with interval filters in per-segment queries URL: https://github.com/apache/incubator-druid/pull/5857#discussion_r206380859 ## File path: processing/src/main/java/io/druid/query/aggregation/FilteredAggregat

[GitHub] asdf2014 commented on issue #6064: Duplicate DataSegmentTest

2018-07-30 Thread GitBox
asdf2014 commented on issue #6064: Duplicate DataSegmentTest URL: https://github.com/apache/incubator-druid/issues/6064#issuecomment-409079965 BTW, in addition to this place, there are a lot of `duplicate code` problems, about 349. :sweat_smile: ![image](https://user-images.githubu

[GitHub] leventov commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument

2018-07-30 Thread GitBox
leventov commented on a change in pull request #6068: Prohibit Lists.newArrayList() with a single argument URL: https://github.com/apache/incubator-druid/pull/6068#discussion_r206389509 ## File path: processing/src/main/java/io/druid/collections/spatial/Node.java ## @@ -56

[GitHub] xiongshiyan opened a new issue #6079: multi datasource occurs 'connection holder is null'

2018-07-30 Thread GitBox
xiongshiyan opened a new issue #6079: multi datasource occurs 'connection holder is null' URL: https://github.com/apache/incubator-druid/issues/6079 it occurs a error 'connection holder is null' after waiting a lot of time, but it wouldn't occur in single datasource with the same configrat

[GitHub] es1220 opened a new pull request #6080: Accept total rows over Integer.MAX_VALUE.

2018-07-30 Thread GitBox
es1220 opened a new pull request #6080: Accept total rows over Integer.MAX_VALUE. URL: https://github.com/apache/incubator-druid/pull/6080 The type of the row is declared as an int, so it can only generate indexes up to Integer.MAX_VALUE rows. So I changed the `int` to `long` to allow t

[GitHub] magor commented on issue #5574: coordinator web console not work

2018-07-30 Thread GitBox
magor commented on issue #5574: coordinator web console not work URL: https://github.com/apache/incubator-druid/issues/5574#issuecomment-409115258 hey @terry19850829 , I stumbled upon the same problem, how did you deal with it?