[GitHub] waixiaoyu commented on issue #6252: Deadlock may be in TaskMaster when stopping

2018-08-28 Thread GitBox
waixiaoyu commented on issue #6252: Deadlock may be in TaskMaster when stopping URL: https://github.com/apache/incubator-druid/issues/6252#issuecomment-416838393 @himanshug No, my zookeeper is used by other programs. So I just wanna shutdown Druid cluster, except Zookeeper. --

[GitHub] QiuMM commented on issue #6254: fix opentsdb emitter occupy 100%(#6247)

2018-08-28 Thread GitBox
QiuMM commented on issue #6254: fix opentsdb emitter occupy 100%(#6247) URL: https://github.com/apache/incubator-druid/pull/6254#issuecomment-416835680 I have fixed what you mentioned @zhaojiandong. This is an automated messa

[GitHub] QiuMM commented on a change in pull request #6251: fix opentsdb emitter always be running

2018-08-28 Thread GitBox
QiuMM commented on a change in pull request #6251: fix opentsdb emitter always be running URL: https://github.com/apache/incubator-druid/pull/6251#discussion_r213553407 ## File path: docs/content/development/extensions-contrib/opentsdb-emitter.md ## @@ -18,10 +18,11 @@ All

[GitHub] QiuMM commented on a change in pull request #6251: fix opentsdb emitter always be running

2018-08-28 Thread GitBox
QiuMM commented on a change in pull request #6251: fix opentsdb emitter always be running URL: https://github.com/apache/incubator-druid/pull/6251#discussion_r213552927 ## File path: extensions-contrib/opentsdb-emitter/src/main/java/io/druid/emitter/opentsdb/OpentsdbSender.java ##

[GitHub] QiuMM commented on a change in pull request #6251: fix opentsdb emitter always be running

2018-08-28 Thread GitBox
QiuMM commented on a change in pull request #6251: fix opentsdb emitter always be running URL: https://github.com/apache/incubator-druid/pull/6251#discussion_r213552927 ## File path: extensions-contrib/opentsdb-emitter/src/main/java/io/druid/emitter/opentsdb/OpentsdbSender.java ##

[GitHub] zhaojiandong commented on issue #6254: fix opentsdb emitter occupy 100%(#6247)

2018-08-28 Thread GitBox
zhaojiandong commented on issue #6254: fix opentsdb emitter occupy 100%(#6247) URL: https://github.com/apache/incubator-druid/pull/6254#issuecomment-416825059 [#6251](https://github.com/apache/incubator-druid/pull/6251/files) uses ScheduledExecutorService to schedule. But if emitter has lar

[GitHub] zhaojiandong commented on a change in pull request #6251: fix opentsdb emitter always be running

2018-08-28 Thread GitBox
zhaojiandong commented on a change in pull request #6251: fix opentsdb emitter always be running URL: https://github.com/apache/incubator-druid/pull/6251#discussion_r213538511 ## File path: extensions-contrib/opentsdb-emitter/src/main/java/io/druid/emitter/opentsdb/OpentsdbSender.j

[GitHub] QiuMM commented on a change in pull request #6251: fix opentsdb emitter always be running

2018-08-28 Thread GitBox
QiuMM commented on a change in pull request #6251: fix opentsdb emitter always be running URL: https://github.com/apache/incubator-druid/pull/6251#discussion_r213537407 ## File path: extensions-contrib/opentsdb-emitter/src/main/java/io/druid/emitter/opentsdb/OpentsdbSender.java ##

[GitHub] QiuMM commented on issue #6254: fix opentsdb emitter occupy 100%(#6247)

2018-08-28 Thread GitBox
QiuMM commented on issue #6254: fix opentsdb emitter occupy 100%(#6247) URL: https://github.com/apache/incubator-druid/pull/6254#issuecomment-416813124 In #6251 I use `ScheduledExecutorService` to schedule metrics consuming which is same as other emitter extensions do, e.g kafka-emitter and

[incubator-druid] branch 0.12.3 updated: SQL: Fix post-aggregator naming logic for sort-project. (#6250) (#6257)

2018-08-28 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch 0.12.3 in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/0.12.3 by this push: new 142e384 SQL: Fix post-aggregator naming l

[GitHub] fjy closed pull request #6257: [Backport] SQL: Fix post-aggregator naming logic for sort-project.

2018-08-28 Thread GitBox
fjy closed pull request #6257: [Backport] SQL: Fix post-aggregator naming logic for sort-project. URL: https://github.com/apache/incubator-druid/pull/6257 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of proven

[GitHub] gaodayue commented on issue #6246: add a sql option to force user to specify time condition

2018-08-28 Thread GitBox
gaodayue commented on issue #6246: add a sql option to force user to specify time condition URL: https://github.com/apache/incubator-druid/pull/6246#issuecomment-416800294 Hi @gianm , could you take a look at this? This is an

[GitHub] gaodayue commented on issue #6256: RowBasedKeySerde should use empty dictionary in constructor

2018-08-28 Thread GitBox
gaodayue commented on issue #6256: RowBasedKeySerde should use empty dictionary in constructor URL: https://github.com/apache/incubator-druid/pull/6256#issuecomment-416799333 > Could you please add a comment about why the map is starting out empty (avoiding allocating too much when it's no

[GitHub] jihoonson closed pull request #6261: [Backport] RowBasedKeySerde should use empty dictionary in constructor

2018-08-28 Thread GitBox
jihoonson closed pull request #6261: [Backport] RowBasedKeySerde should use empty dictionary in constructor URL: https://github.com/apache/incubator-druid/pull/6261 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[incubator-druid] branch 0.12.3 updated: RowBasedKeySerde should use empty dictionary in constructor (#6256) (#6261)

2018-08-28 Thread jihoonson
This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a commit to branch 0.12.3 in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/0.12.3 by this push: new af61373 RowBasedKeySerde should use

[GitHub] jihoonson commented on issue #6255: Heavy GC activities after upgrading to 0.12

2018-08-28 Thread GitBox
jihoonson commented on issue #6255: Heavy GC activities after upgrading to 0.12 URL: https://github.com/apache/incubator-druid/issues/6255#issuecomment-416798810 @gaodayue thank you for the details! Probably we can optimize the initial dictionary size based on 1) spilling is enabled, 2) th

[GitHub] gaodayue commented on issue #6255: Heavy GC activities after upgrading to 0.12

2018-08-28 Thread GitBox
gaodayue commented on issue #6255: Heavy GC activities after upgrading to 0.12 URL: https://github.com/apache/incubator-druid/issues/6255#issuecomment-416798257 As I mentioned above, the creation rate of merging dictionary is roughly `2 (forward and reverse dict) x processing.numThreads (C

[GitHub] gaodayue commented on issue #6255: Heavy GC activities after upgrading to 0.12

2018-08-28 Thread GitBox
gaodayue commented on issue #6255: Heavy GC activities after upgrading to 0.12 URL: https://github.com/apache/incubator-druid/issues/6255#issuecomment-416797137 > @gaodayue thank you for catching this. Could you share some more details of your use case? I wonder especially how large the di

[GitHub] gianm closed pull request #5280: add "subtotalsSpec" attribute to groupBy query

2018-08-28 Thread GitBox
gianm closed pull request #5280: add "subtotalsSpec" attribute to groupBy query URL: https://github.com/apache/incubator-druid/pull/5280 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] gianm closed issue #5179: [Proposal] Add support for multiple grouping specs in groupBy query

2018-08-28 Thread GitBox
gianm closed issue #5179: [Proposal] Add support for multiple grouping specs in groupBy query URL: https://github.com/apache/incubator-druid/issues/5179 This is an automated message from the Apache Git Service. To respond to

[incubator-druid] branch master updated: add "subtotalsSpec" attribute to groupBy query (#5280)

2018-08-28 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 1fae651 add "subtotalsSpec" attribute to

[GitHub] fjy closed pull request #6260: [Backport] Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner

2018-08-28 Thread GitBox
fjy closed pull request #6260: [Backport] Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/6260 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is d

[incubator-druid] branch 0.12.3 updated: Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner (#6260)

2018-08-28 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch 0.12.3 in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/0.12.3 by this push: new 05c802d Don't let catch/finally suppress

[GitHub] gianm opened a new pull request #6261: [Backport] RowBasedKeySerde should use empty dictionary in constructor

2018-08-28 Thread GitBox
gianm opened a new pull request #6261: [Backport] RowBasedKeySerde should use empty dictionary in constructor URL: https://github.com/apache/incubator-druid/pull/6261 Backport of #6256 to 0.12.3. This is an automated message

[GitHub] gianm closed issue #6255: Heavy GC activities after upgrading to 0.12

2018-08-28 Thread GitBox
gianm closed issue #6255: Heavy GC activities after upgrading to 0.12 URL: https://github.com/apache/incubator-druid/issues/6255 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] gianm closed pull request #6256: RowBasedKeySerde should use empty dictionary in constructor

2018-08-28 Thread GitBox
gianm closed pull request #6256: RowBasedKeySerde should use empty dictionary in constructor URL: https://github.com/apache/incubator-druid/pull/6256 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[incubator-druid] branch master updated: RowBasedKeySerde should use empty dictionary in constructor (#6256)

2018-08-28 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new fcf8c8d RowBasedKeySerde should use empt

[GitHub] gianm commented on issue #6257: [Backport] SQL: Fix post-aggregator naming logic for sort-project.

2018-08-28 Thread GitBox
gianm commented on issue #6257: [Backport] SQL: Fix post-aggregator naming logic for sort-project. URL: https://github.com/apache/incubator-druid/pull/6257#issuecomment-416780459 Had to fix a test-- repushed. This is an autom

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213474326 ## File path: processing/src/main/java/io/druid/query/QueryContext

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213502827 ## File path: processing/src/main/java/io/druid/query/ChainedExec

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213156952 ## File path: common/src/test/java/io/druid/concurrent/ExecsTest.j

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213472699 ## File path: processing/src/main/java/io/druid/query/ChainedExec

[GitHub] jon-wei opened a new pull request #6260: [Backport] Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner

2018-08-28 Thread GitBox
jon-wei opened a new pull request #6260: [Backport] Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/6260 Backport of #6258 to 0.12.3

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213461237 ## File path: java-util/src/main/java/io/druid/java/util/common/g

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213157965 ## File path: java-util/src/main/java/io/druid/java/util/common/c

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213156930 ## File path: common/src/test/java/io/druid/concurrent/ExecsTest.j

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213502966 ## File path: processing/src/main/java/io/druid/query/ChainedExec

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213469905 ## File path: processing/src/main/java/io/druid/guice/ForkJoinPool

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213499301 ## File path: server/src/main/java/io/druid/client/CachingClustere

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213502018 ## File path: server/src/main/java/io/druid/client/DirectDruidClie

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213484372 ## File path: server/src/main/java/io/druid/client/CachingClustere

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213490673 ## File path: processing/src/main/java/io/druid/guice/LifecycleFor

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213496363 ## File path: server/src/main/java/io/druid/client/CachingClustere

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213460949 ## File path: java-util/src/main/java/io/druid/java/util/common/g

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213503720 ## File path: server/src/main/java/io/druid/client/CachingClustere

[GitHub] jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r213495920 ## File path: server/src/main/java/io/druid/client/CachingClustere

[GitHub] jon-wei closed pull request #6258: Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner

2018-08-28 Thread GitBox
jon-wei closed pull request #6258: Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/6258 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displaye

[incubator-druid] branch master updated: Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner (#6258)

2018-08-28 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new c9a27e3 Don't let catch/finally suppre

[GitHub] jon-wei opened a new pull request #6259: Docs consistency cleanup

2018-08-28 Thread GitBox
jon-wei opened a new pull request #6259: Docs consistency cleanup URL: https://github.com/apache/incubator-druid/pull/6259 This PR: * Fixes various broken links and references. * Moves the "Overlord" section from the `design/indexing-service.md` into its own page * Moves task types

[GitHub] amalakar commented on issue #5150: Druid-parquet-extensions fails on timestamps (stored as INT96) in parquet files

2018-08-28 Thread GitBox
amalakar commented on issue #5150: Druid-parquet-extensions fails on timestamps (stored as INT96) in parquet files URL: https://github.com/apache/incubator-druid/issues/5150#issuecomment-416762573 @shaharck in our case we ended up converting to csv and then importing into druid, which is

[GitHub] himanshug commented on issue #5280: add "subtotalsSpec" attribute to groupBy query

2018-08-28 Thread GitBox
himanshug commented on issue #5280: add "subtotalsSpec" attribute to groupBy query URL: https://github.com/apache/incubator-druid/pull/5280#issuecomment-416745224 @gianm updated the docs. This is an automated message from the

[GitHub] himanshug commented on issue #6252: Deadlock may be in TaskMaster when stopping

2018-08-28 Thread GitBox
himanshug commented on issue #6252: Deadlock may be in TaskMaster when stopping URL: https://github.com/apache/incubator-druid/issues/6252#issuecomment-416743373 did you shutdown zookeeper processes along with druid or did Overlord somehow lost connection to zookeeper ? from a quick loo

[GitHub] jihoonson commented on a change in pull request #6258: Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #6258: Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/6258#discussion_r213473735 ## File path: extensions-core/kafka-indexing-service/sr

[GitHub] jon-wei commented on a change in pull request #6258: Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner

2018-08-28 Thread GitBox
jon-wei commented on a change in pull request #6258: Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/6258#discussion_r213468683 ## File path: extensions-core/kafka-indexing-service/src/

[GitHub] jihoonson commented on a change in pull request #6258: Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #6258: Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/6258#discussion_r213467270 ## File path: extensions-core/kafka-indexing-service/sr

[GitHub] jihoonson commented on a change in pull request #6258: Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner

2018-08-28 Thread GitBox
jihoonson commented on a change in pull request #6258: Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/6258#discussion_r213467072 ## File path: extensions-core/kafka-indexing-service/sr

[GitHub] shaharck commented on issue #5150: Druid-parquet-extensions fails on timestamps (stored as INT96) in parquet files

2018-08-28 Thread GitBox
shaharck commented on issue #5150: Druid-parquet-extensions fails on timestamps (stored as INT96) in parquet files URL: https://github.com/apache/incubator-druid/issues/5150#issuecomment-416733014 is there an existing work around if you do not need that column? doesn't seem like excluding

[GitHub] jon-wei opened a new pull request #6258: Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner

2018-08-28 Thread GitBox
jon-wei opened a new pull request #6258: Don't let catch/finally suppress main exception in IncrementalPublishingKafkaIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/6258 This is an automated message from

[GitHub] clintropolis commented on issue #6256: RowBasedKeySerde should use empty dictionary in constructor

2018-08-28 Thread GitBox
clintropolis commented on issue #6256: RowBasedKeySerde should use empty dictionary in constructor URL: https://github.com/apache/incubator-druid/pull/6256#issuecomment-416731586 We should probably backport this to 0.12.3 Thi

[GitHub] gianm opened a new pull request #6257: SQL: Fix post-aggregator naming logic for sort-project. (#6250)

2018-08-28 Thread GitBox
gianm opened a new pull request #6257: SQL: Fix post-aggregator naming logic for sort-project. (#6250) URL: https://github.com/apache/incubator-druid/pull/6257 The old code assumes that post-aggregator prefixes are one character long followed by numbers. This isn't always true (we may pa

[GitHub] gianm commented on issue #6254: fix opentsdb emitter occupy 100%(#6247)

2018-08-28 Thread GitBox
gianm commented on issue #6254: fix opentsdb emitter occupy 100%(#6247) URL: https://github.com/apache/incubator-druid/pull/6254#issuecomment-416729102 What are the pros and cons of this approach vs. the approach in #6251? (Sorry, I haven't had a chance to study how the OpenTSDB emitter wor

[GitHub] b-slim commented on a change in pull request #6251: fix opentsdb emitter always be running

2018-08-28 Thread GitBox
b-slim commented on a change in pull request #6251: fix opentsdb emitter always be running URL: https://github.com/apache/incubator-druid/pull/6251#discussion_r213460483 ## File path: extensions-contrib/opentsdb-emitter/src/main/java/io/druid/emitter/opentsdb/OpentsdbSender.java #

[GitHub] b-slim commented on a change in pull request #6251: fix opentsdb emitter always be running

2018-08-28 Thread GitBox
b-slim commented on a change in pull request #6251: fix opentsdb emitter always be running URL: https://github.com/apache/incubator-druid/pull/6251#discussion_r213459729 ## File path: docs/content/development/extensions-contrib/opentsdb-emitter.md ## @@ -18,10 +18,11 @@ Al

[GitHub] himanshug commented on a change in pull request #5872: add method getRequiredColumns for DimFilter

2018-08-28 Thread GitBox
himanshug commented on a change in pull request #5872: add method getRequiredColumns for DimFilter URL: https://github.com/apache/incubator-druid/pull/5872#discussion_r213452493 ## File path: processing/src/main/java/io/druid/query/filter/DimFilter.java ## @@ -75,4 +77,9 @

[GitHub] jihoonson commented on issue #6255: Heavy GC activities after upgrading to 0.12

2018-08-28 Thread GitBox
jihoonson commented on issue #6255: Heavy GC activities after upgrading to 0.12 URL: https://github.com/apache/incubator-druid/issues/6255#issuecomment-416695564 @gaodayue I've approved #6256, but I'm still curious about my question. It would help to decide the more proper initial size of

[GitHub] fjy closed pull request #6250: SQL: Fix post-aggregator naming logic for sort-project.

2018-08-28 Thread GitBox
fjy closed pull request #6250: SQL: Fix post-aggregator naming logic for sort-project. URL: https://github.com/apache/incubator-druid/pull/6250 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As t

[incubator-druid] branch master updated: SQL: Fix post-aggregator naming logic for sort-project. (#6250)

2018-08-28 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 80224df SQL: Fix post-aggregator naming l

[GitHub] himanshug commented on a change in pull request #5280: add "subtotalsSpec" attribute to groupBy query

2018-08-28 Thread GitBox
himanshug commented on a change in pull request #5280: add "subtotalsSpec" attribute to groupBy query URL: https://github.com/apache/incubator-druid/pull/5280#discussion_r213413936 ## File path: docs/content/querying/groupbyquery.md ## @@ -113,6 +114,94 @@ improve performa

[GitHub] himanshug commented on a change in pull request #5280: add "subtotalsSpec" attribute to groupBy query

2018-08-28 Thread GitBox
himanshug commented on a change in pull request #5280: add "subtotalsSpec" attribute to groupBy query URL: https://github.com/apache/incubator-druid/pull/5280#discussion_r213413907 ## File path: docs/content/querying/groupbyquery.md ## @@ -113,6 +114,94 @@ improve performa

[GitHub] himanshug commented on a change in pull request #5280: add "subtotalsSpec" attribute to groupBy query

2018-08-28 Thread GitBox
himanshug commented on a change in pull request #5280: add "subtotalsSpec" attribute to groupBy query URL: https://github.com/apache/incubator-druid/pull/5280#discussion_r213413800 ## File path: docs/content/querying/groupbyquery.md ## @@ -113,6 +114,94 @@ improve performa

[GitHub] himanshug commented on a change in pull request #5280: add "subtotalsSpec" attribute to groupBy query

2018-08-28 Thread GitBox
himanshug commented on a change in pull request #5280: add "subtotalsSpec" attribute to groupBy query URL: https://github.com/apache/incubator-druid/pull/5280#discussion_r213413760 ## File path: docs/content/querying/groupbyquery.md ## @@ -70,6 +70,7 @@ There are 11 main p

[GitHub] jihoonson commented on issue #6124: KafkaIndexTask can delete published segments on restart

2018-08-28 Thread GitBox
jihoonson commented on issue #6124: KafkaIndexTask can delete published segments on restart URL: https://github.com/apache/incubator-druid/issues/6124#issuecomment-416669984 @gianm I think it makes sense to close this issue since the title is about kafka tasks deleting pushed segments. Ho

[GitHub] jihoonson commented on issue #6256: RowBasedKeySerde should use empty dictionary in constructor

2018-08-28 Thread GitBox
jihoonson commented on issue #6256: RowBasedKeySerde should use empty dictionary in constructor URL: https://github.com/apache/incubator-druid/pull/6256#issuecomment-416668830 Hi @gaodayue, I left a comment on https://github.com/apache/incubator-druid/issues/6255.

[GitHub] jihoonson commented on issue #6255: Heavy GC activities after upgrading to 0.12

2018-08-28 Thread GitBox
jihoonson commented on issue #6255: Heavy GC activities after upgrading to 0.12 URL: https://github.com/apache/incubator-druid/issues/6255#issuecomment-416668676 @gaodayue thank you for catching this. Could you share some more details of your use case? I wonder especially how large the dic

[GitHub] gianm closed issue #6124: KafkaIndexTask can delete published segments on restart

2018-08-28 Thread GitBox
gianm closed issue #6124: KafkaIndexTask can delete published segments on restart URL: https://github.com/apache/incubator-druid/issues/6124 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] gianm commented on issue #6124: KafkaIndexTask can delete published segments on restart

2018-08-28 Thread GitBox
gianm commented on issue #6124: KafkaIndexTask can delete published segments on restart URL: https://github.com/apache/incubator-druid/issues/6124#issuecomment-416667501 Got it, I think we can close this then. This is an aut

[GitHub] himanshug closed issue #2406: [proposal]datasketches lib based quantiles/histogram support in druid

2018-08-28 Thread GitBox
himanshug closed issue #2406: [proposal]datasketches lib based quantiles/histogram support in druid URL: https://github.com/apache/incubator-druid/issues/2406 This is an automated message from the Apache Git Service. To resp

[GitHub] QiuMM edited a comment on issue #6254: fix opentsdb emitter occupy 100%(#6247)

2018-08-28 Thread GitBox
QiuMM edited a comment on issue #6254: fix opentsdb emitter occupy 100%(#6247) URL: https://github.com/apache/incubator-druid/pull/6254#issuecomment-416634103 I have opened #6251 to solve same issue. This is an automated messa

[GitHub] himanshug commented on issue #6255: Heavy GC activities after upgrading to 0.12

2018-08-28 Thread GitBox
himanshug commented on issue #6255: Heavy GC activities after upgrading to 0.12 URL: https://github.com/apache/incubator-druid/issues/6255#issuecomment-416662430 #4704 did run the benchmarks for performance, unfortunately benchmarks don't report memory allocation or else it would be notice

[GitHub] shaharck commented on issue #3435: Consider including hadoop-aws in the lib folder

2018-08-28 Thread GitBox
shaharck commented on issue #3435: Consider including hadoop-aws in the lib folder URL: https://github.com/apache/incubator-druid/issues/3435#issuecomment-416660766 +1 This is an automated message from the Apache Git Service

[GitHub] himanshug commented on issue #6212: fix TaskQueue-HRTR deadlock

2018-08-28 Thread GitBox
himanshug commented on issue #6212: fix TaskQueue-HRTR deadlock URL: https://github.com/apache/incubator-druid/pull/6212#issuecomment-416659850 @gianm sure, thanks. This is an automated message from the Apache Git Service. To

[GitHub] himanshug commented on issue #6219: Add optional `name` to top level of FilteredAggregatorFactory

2018-08-28 Thread GitBox
himanshug commented on issue #6219: Add optional `name` to top level of FilteredAggregatorFactory URL: https://github.com/apache/incubator-druid/pull/6219#issuecomment-416659072 @drcrallen I added the `compatibility` label to this PR for the catch that you [mentioned](https://github.com/a

[GitHub] QiuMM commented on a change in pull request #6254: fix opentsdb emitter occupy 100%(#6247)

2018-08-28 Thread GitBox
QiuMM commented on a change in pull request #6254: fix opentsdb emitter occupy 100%(#6247) URL: https://github.com/apache/incubator-druid/pull/6254#discussion_r213372654 ## File path: extensions-contrib/opentsdb-emitter/src/main/java/io/druid/emitter/opentsdb/OpentsdbSender.java #

[GitHub] gianm commented on issue #6253: Multiple datasources with multiple topic in one spec file

2018-08-28 Thread GitBox
gianm commented on issue #6253: Multiple datasources with multiple topic in one spec file URL: https://github.com/apache/incubator-druid/issues/6253#issuecomment-416635332 Hi @Harish346, currently the model is 1 supervisor and 1 set of tasks per datasource. --

[GitHub] gianm commented on a change in pull request #6254: fix opentsdb emitter occupy 100%(#6247)

2018-08-28 Thread GitBox
gianm commented on a change in pull request #6254: fix opentsdb emitter occupy 100%(#6247) URL: https://github.com/apache/incubator-druid/pull/6254#discussion_r213366682 ## File path: extensions-contrib/opentsdb-emitter/src/main/java/io/druid/emitter/opentsdb/OpentsdbSender.java #

[GitHub] QiuMM commented on issue #6254: fix opentsdb emitter occupy 100%(#6247)

2018-08-28 Thread GitBox
QiuMM commented on issue #6254: fix opentsdb emitter occupy 100%(#6247) URL: https://github.com/apache/incubator-druid/pull/6254#issuecomment-416634103 It have been solved in #6251 . This is an automated message from the Apach

[GitHub] QiuMM commented on a change in pull request #6254: fix opentsdb emitter occupy 100%(#6247)

2018-08-28 Thread GitBox
QiuMM commented on a change in pull request #6254: fix opentsdb emitter occupy 100%(#6247) URL: https://github.com/apache/incubator-druid/pull/6254#discussion_r213365894 ## File path: extensions-contrib/opentsdb-emitter/src/main/java/io/druid/emitter/opentsdb/OpentsdbSender.java #

[GitHub] gianm commented on issue #6255: Heavy GC activities after upgrading to 0.12

2018-08-28 Thread GitBox
gianm commented on issue #6255: Heavy GC activities after upgrading to 0.12 URL: https://github.com/apache/incubator-druid/issues/6255#issuecomment-416616545 Great catch! Btw, I think you meant to link to #4704 instead of #4707. --

[GitHub] gaodayue opened a new pull request #6256: RowBasedKeySerde should use empty dictionary in constructor

2018-08-28 Thread GitBox
gaodayue opened a new pull request #6256: RowBasedKeySerde should use empty dictionary in constructor URL: https://github.com/apache/incubator-druid/pull/6256 Fixes #6255 This is an automated message from the Apache Git Serv

[GitHub] gaodayue edited a comment on issue #6255: Heavy GC activities after upgrading to 0.12

2018-08-28 Thread GitBox
gaodayue edited a comment on issue #6255: Heavy GC activities after upgrading to 0.12 URL: https://github.com/apache/incubator-druid/issues/6255#issuecomment-416583814 In order to find out which class puts too much pressure on garbage collector, I captured flight record (60s) before and a

[GitHub] gaodayue commented on issue #6255: Heavy GC activities after upgrading to 0.12

2018-08-28 Thread GitBox
gaodayue commented on issue #6255: Heavy GC activities after upgrading to 0.12 URL: https://github.com/apache/incubator-druid/issues/6255#issuecomment-416583814 In order to find out which class puts too much pressure on garbage collector, I captured flight record (60s) before and after upg

[GitHub] gaodayue opened a new issue #6255: Heavy GC activities after upgrading to 0.12

2018-08-28 Thread GitBox
gaodayue opened a new issue #6255: Heavy GC activities after upgrading to 0.12 URL: https://github.com/apache/incubator-druid/issues/6255 After upgrading some of our historical nodes from 0.11.0 to 0.12, we observed significant performance degradation on these nodes. Below is a graph showi

[GitHub] zhaojiandong opened a new pull request #6254: fix opentsdb emitter occupy 100%(#6247)

2018-08-28 Thread GitBox
zhaojiandong opened a new pull request #6254: fix opentsdb emitter occupy 100%(#6247) URL: https://github.com/apache/incubator-druid/pull/6254 we found sending event thread of opentsdb emitter will cause cpu occupy 100%, as follow. And format this extension's code to pass code style check

[GitHub] Harish346 edited a comment on issue #6113: Inserting Nested Json into Druid

2018-08-28 Thread GitBox
Harish346 edited a comment on issue #6113: Inserting Nested Json into Druid URL: https://github.com/apache/incubator-druid/issues/6113#issuecomment-411507775 Hi @gianm **This is my ingestion spec file** { "type": "index_hadoop", "spec": { "ioConfig": { "

[GitHub] Harish346 edited a comment on issue #6113: Inserting Nested Json into Druid

2018-08-28 Thread GitBox
Harish346 edited a comment on issue #6113: Inserting Nested Json into Druid URL: https://github.com/apache/incubator-druid/issues/6113#issuecomment-411507775 Hi @gianm This is my ingestion spec file { "type": "index_hadoop", "spec": { "ioConfig": { "type

[GitHub] Harish346 opened a new issue #6253: Multiple datasources with multiple topic in one spec file

2018-08-28 Thread GitBox
Harish346 opened a new issue #6253: Multiple datasources with multiple topic in one spec file URL: https://github.com/apache/incubator-druid/issues/6253 Hi, I have multiple datasources each corresponding to a kafka topic.When I create supervisor for each datasource,many supervisors a

[GitHub] waixiaoyu opened a new issue #6252: Deadlock may be in TaskMaster when stopping

2018-08-28 Thread GitBox
waixiaoyu opened a new issue #6252: Deadlock may be in TaskMaster when stopping URL: https://github.com/apache/incubator-druid/issues/6252 When I try to close the whole druid cluster, I found the Overlord process still remained in the system. The following info is part of stack.

[GitHub] sdimbsn commented on a change in pull request #6235: Druid with Oak supporting also plain mode v04

2018-08-28 Thread GitBox
sdimbsn commented on a change in pull request #6235: Druid with Oak supporting also plain mode v04 URL: https://github.com/apache/incubator-druid/pull/6235#discussion_r213227738 ## File path: processing/src/main/java/io/druid/segment/incremental/OakIncrementalIndex.java #

[GitHub] sdimbsn commented on a change in pull request #6235: Druid with Oak supporting also plain mode v04

2018-08-28 Thread GitBox
sdimbsn commented on a change in pull request #6235: Druid with Oak supporting also plain mode v04 URL: https://github.com/apache/incubator-druid/pull/6235#discussion_r213229161 ## File path: processing/src/main/java/io/druid/segment/incremental/OakIncrementalIndex.java #

[GitHub] sdimbsn commented on a change in pull request #6235: Druid with Oak supporting also plain mode v04

2018-08-28 Thread GitBox
sdimbsn commented on a change in pull request #6235: Druid with Oak supporting also plain mode v04 URL: https://github.com/apache/incubator-druid/pull/6235#discussion_r212994961 ## File path: processing/src/main/java/io/druid/segment/incremental/OakIncrementalIndex.java #

  1   2   >