[GitHub] shivtools commented on a change in pull request #6335: Added backpressure metric

2018-09-22 Thread GitBox
shivtools commented on a change in pull request #6335: Added backpressure metric URL: https://github.com/apache/incubator-druid/pull/6335#discussion_r219688146 ## File path: server/src/main/java/org/apache/druid/client/DirectDruidClient.java ## @@ -231,6 +234,11 @@ private

[GitHub] shivtools commented on a change in pull request #6335: Added backpressure metric

2018-09-22 Thread GitBox
shivtools commented on a change in pull request #6335: Added backpressure metric URL: https://github.com/apache/incubator-druid/pull/6335#discussion_r219687004 ## File path: server/src/main/java/org/apache/druid/client/DirectDruidClient.java ## @@ -231,6 +234,11 @@ private

[GitHub] shivtools commented on a change in pull request #6335: Added backpressure metric

2018-09-22 Thread GitBox
shivtools commented on a change in pull request #6335: Added backpressure metric URL: https://github.com/apache/incubator-druid/pull/6335#discussion_r219687001 ## File path: server/src/main/java/org/apache/druid/client/DirectDruidClient.java ## @@ -382,6 +397,7 @@ public In

[GitHub] clintropolis commented on a change in pull request #6222: Add ability to pass in Bloom filter from Hive Queries

2018-09-22 Thread GitBox
clintropolis commented on a change in pull request #6222: Add ability to pass in Bloom filter from Hive Queries URL: https://github.com/apache/incubator-druid/pull/6222#discussion_r219630382 ## File path: extensions-core/druid-bloom-filter/src/main/resources/META-INF/services/io.dr

[GitHub] clintropolis commented on a change in pull request #6222: Add ability to pass in Bloom filter from Hive Queries

2018-09-22 Thread GitBox
clintropolis commented on a change in pull request #6222: Add ability to pass in Bloom filter from Hive Queries URL: https://github.com/apache/incubator-druid/pull/6222#discussion_r219647307 ## File path: extensions-core/druid-bloom-filter/pom.xml ## @@ -0,0 +1,66 @@ + + +

[GitHub] clintropolis commented on a change in pull request #6222: Add ability to pass in Bloom filter from Hive Queries

2018-09-22 Thread GitBox
clintropolis commented on a change in pull request #6222: Add ability to pass in Bloom filter from Hive Queries URL: https://github.com/apache/incubator-druid/pull/6222#discussion_r219630555 ## File path: extensions-core/druid-bloom-filter/src/test/java/io/druid/query/filter/BloomD

[GitHub] gianm closed pull request #6357: Improve interning in SQLMetadataSegmentManager

2018-09-22 Thread GitBox
gianm closed pull request #6357: Improve interning in SQLMetadataSegmentManager URL: https://github.com/apache/incubator-druid/pull/6357 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-druid] branch master updated: Improve interning in SQLMetadataSegmentManager (#6357)

2018-09-22 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 9a3195e Improve interning in SQLMetadata

[GitHub] QiuMM commented on issue #6006: Kafka ingestion tasks are not killed and keep spawning after stopping Supervisor

2018-09-22 Thread GitBox
QiuMM commented on issue #6006: Kafka ingestion tasks are not killed and keep spawning after stopping Supervisor URL: https://github.com/apache/incubator-druid/issues/6006#issuecomment-423738296 Maybe it's the same issue with pr #6337. -

[GitHub] zhaojiandong commented on issue #6365: new feature: allows user to specify timeZone in TimestampSpec

2018-09-22 Thread GitBox
zhaojiandong commented on issue #6365: new feature: allows user to specify timeZone in TimestampSpec URL: https://github.com/apache/incubator-druid/pull/6365#issuecomment-423732169 Adding parameter 'timeZone' to TimestampSpec changes constructor signature, So this pr has involved many test

[GitHub] leventov commented on issue #6370: Introduce SegmentId class

2018-09-22 Thread GitBox
leventov commented on issue #6370: Introduce SegmentId class URL: https://github.com/apache/incubator-druid/pull/6370#issuecomment-423731847 For reviewers: key changed classes in this PR are `SegmentId`, `DataSegment`, `DruidDataSource`, `DruidServer` and `ImmutableDruidServer`. --

[GitHub] leventov commented on issue #6370: Introduce SegmentId class

2018-09-22 Thread GitBox
leventov commented on issue #6370: Introduce SegmentId class URL: https://github.com/apache/incubator-druid/pull/6370#issuecomment-423731030 This is also a blocker for me for fixing #6358 and making some improvements to `HttpServerInventoryView`. ---

[GitHub] leventov opened a new pull request #6370: Introduce SegmentId class

2018-09-22 Thread GitBox
leventov opened a new pull request #6370: Introduce SegmentId class URL: https://github.com/apache/incubator-druid/pull/6370 This PR introduces a `SegmentId` class for operating with segment ids in the codebase instead of Strings. Three reasons: - Memory efficiency: `SegmentId`'s