[GitHub] yurmix commented on issue #6430: Contributing Moving-Average Query to open source.

2019-02-23 Thread GitBox
yurmix commented on issue #6430: Contributing Moving-Average Query to open source. URL: https://github.com/apache/incubator-druid/pull/6430#issuecomment-466632938 > @yurmix thanks for the nice PR! I'm still looking at, but have a question for the general design. > > Why do we need a

[GitHub] yurmix commented on issue #6430: Contributing Moving-Average Query to open source.

2019-02-23 Thread GitBox
yurmix commented on issue #6430: Contributing Moving-Average Query to open source. URL: https://github.com/apache/incubator-druid/pull/6430#issuecomment-466633093 @jihoonson BTW, I have a couple of my own design concerns and I welcome your thoughts on the matter: 1. The complexity of `M

[GitHub] QiuMM commented on issue #7126: [DRAFT] 0.14.0-incubating release notes

2019-02-23 Thread GitBox
QiuMM commented on issue #7126: [DRAFT] 0.14.0-incubating release notes URL: https://github.com/apache/incubator-druid/issues/7126#issuecomment-42742 @jon-wei new metrics in #6587 and #6657. This is an automated message f

[GitHub] glasser commented on issue #7089: ParallelIndexSubTask: support ingestSegment in delegating factories

2019-02-23 Thread GitBox
glasser commented on issue #7089: ParallelIndexSubTask: support ingestSegment in delegating factories URL: https://github.com/apache/incubator-druid/pull/7089#issuecomment-466692840 All I did is squash it and Team City got sad :(

[GitHub] samarthjain commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing

2019-02-23 Thread GitBox
samarthjain commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r259593425 ## File path: server/src/main/java/org/apache/druid/server/coordination/ZkCoordin

[GitHub] kamaci commented on issue #7133: 6088 - Time Ordering On Scans

2019-02-23 Thread GitBox
kamaci commented on issue #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#issuecomment-466698425 Seems that you have to scan your PR for checkstyle rules: `mvn checkstyle:check` in order to get it successfully built. --

[GitHub] kamaci commented on issue #7131: Improve error message for integer overflow in compaction task

2019-02-23 Thread GitBox
kamaci commented on issue #7131: Improve error message for integer overflow in compaction task URL: https://github.com/apache/incubator-druid/pull/7131#issuecomment-466698512 Seems that you have to scan your PR for checkstyle rules: `mvn checkstyle:check` in order to get it su

[GitHub] jihoonson commented on issue #7089: ParallelIndexSubTask: support ingestSegment in delegating factories

2019-02-23 Thread GitBox
jihoonson commented on issue #7089: ParallelIndexSubTask: support ingestSegment in delegating factories URL: https://github.com/apache/incubator-druid/pull/7089#issuecomment-466721500 We usually squash commits when the PR is merged (please check https://github.com/apache/incubator-druid/bl

[GitHub] jihoonson merged pull request #7089: ParallelIndexSubTask: support ingestSegment in delegating factories

2019-02-23 Thread GitBox
jihoonson merged pull request #7089: ParallelIndexSubTask: support ingestSegment in delegating factories URL: https://github.com/apache/incubator-druid/pull/7089 This is an automated message from the Apache Git Service. To r

[incubator-druid] branch master updated: ParallelIndexSubTask: support ingestSegment in delegating factories (#7089)

2019-02-23 Thread jihoonson
This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 1c2753a ParallelIndexSubTask: suppo

[GitHub] clintropolis opened a new issue #7134: overhaul 'druid-orc-extensions' and move from 'contrib' to 'core'

2019-02-23 Thread GitBox
clintropolis opened a new issue #7134: overhaul 'druid-orc-extensions' and move from 'contrib' to 'core' URL: https://github.com/apache/incubator-druid/issues/7134 # Motivation The existing ORC hadoop indexing extension, while functional, is difficult to use and hard to troubleshoot

[GitHub] hpandeycodeit commented on issue #7118: Added checkstyle for "Methods starting with Capital Letters"

2019-02-23 Thread GitBox
hpandeycodeit commented on issue #7118: Added checkstyle for "Methods starting with Capital Letters" URL: https://github.com/apache/incubator-druid/pull/7118#issuecomment-466728587 @clintropolis So it passed finally :) Thanks for looking into this. ---

[GitHub] hpandeycodeit commented on issue #7067: Made IntelliJ Inspection "Iteration over keySet() could be replaced with entrySet()" a error & Fixed the violations

2019-02-23 Thread GitBox
hpandeycodeit commented on issue #7067: Made IntelliJ Inspection "Iteration over keySet() could be replaced with entrySet()" a error & Fixed the violations URL: https://github.com/apache/incubator-druid/pull/7067#issuecomment-466728751 @leventov it's failing at `Failed to handshake with ho

[GitHub] clintropolis merged pull request #7118: Added checkstyle for "Methods starting with Capital Letters"

2019-02-23 Thread GitBox
clintropolis merged pull request #7118: Added checkstyle for "Methods starting with Capital Letters" URL: https://github.com/apache/incubator-druid/pull/7118 This is an automated message from the Apache Git Service. To resp

[GitHub] hpandeycodeit commented on issue #7118: Added checkstyle for "Methods starting with Capital Letters"

2019-02-23 Thread GitBox
hpandeycodeit commented on issue #7118: Added checkstyle for "Methods starting with Capital Letters" URL: https://github.com/apache/incubator-druid/pull/7118#issuecomment-466732579 Thank you @leventov @clintropolis This is