[GitHub] [incubator-druid] xueyumusic commented on issue #7182: support sin cos etc trigonometric function in sql

xueyumusic commented on issue #7182: support sin cos etc trigonometric function in sql URL: https://github.com/apache/incubator-druid/pull/7182#issuecomment-469182968 Hi, @gianm , Thanks a lot for review. I have rebased on master and updated the codes, thank you. -

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7066: Support assign tasks to run on different tiers of MiddleManagers

egor-ryashin commented on a change in pull request #7066: Support assign tasks to run on different tiers of MiddleManagers URL: https://github.com/apache/incubator-druid/pull/7066#discussion_r262024357 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/

[GitHub] [incubator-druid] kamaci commented on a change in pull request #7121: Prohibit Throwables.propagate()

kamaci commented on a change in pull request #7121: Prohibit Throwables.propagate() URL: https://github.com/apache/incubator-druid/pull/7121#discussion_r262050980 ## File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/updater/HadoopConverterJob.java ## @@ -3

[GitHub] [incubator-druid] kamaci commented on issue #7120: Locale problem is fixed which fails tests.

kamaci commented on issue #7120: Locale problem is fixed which fails tests. URL: https://github.com/apache/incubator-druid/pull/7120#issuecomment-469248010 @leventov @gianm could you also check my PR if possible? This is an au

[GitHub] [incubator-druid] leventov closed issue #5381: DruidCoordinatorCleanupOvershadowed will be failed because of IllegalArgumentException

leventov closed issue #5381: DruidCoordinatorCleanupOvershadowed will be failed because of IllegalArgumentException URL: https://github.com/apache/incubator-druid/issues/5381 This is an automated message from the Apache Git

[GitHub] [incubator-druid] leventov commented on issue #5381: DruidCoordinatorCleanupOvershadowed will be failed because of IllegalArgumentException

leventov commented on issue #5381: DruidCoordinatorCleanupOvershadowed will be failed because of IllegalArgumentException URL: https://github.com/apache/incubator-druid/issues/5381#issuecomment-469276331 This is likely to be fixed in #3584 which is shipped in Druid 0.10.0, closing this is

[GitHub] [incubator-druid] leventov commented on issue #7073: Remove unnecessary check for contains() in LoadRule

leventov commented on issue #7073: Remove unnecessary check for contains() in LoadRule URL: https://github.com/apache/incubator-druid/pull/7073#issuecomment-469296307 Note that a similar check can *not* be removed (currently) in `DruidCoordinatorBalancer`, here: https://github.com/apac

[GitHub] [incubator-druid] gianm commented on a change in pull request #7181: Reduce # of max subTasks to 2

gianm commented on a change in pull request #7181: Reduce # of max subTasks to 2 URL: https://github.com/apache/incubator-druid/pull/7181#discussion_r262112562 ## File path: docs/content/ingestion/native_tasks.md ## @@ -181,7 +181,7 @@ The tuningConfig is optional and defau

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7181: Reduce # of max subTasks to 2

jihoonson commented on a change in pull request #7181: Reduce # of max subTasks to 2 URL: https://github.com/apache/incubator-druid/pull/7181#discussion_r262164264 ## File path: docs/content/ingestion/native_tasks.md ## @@ -181,7 +181,7 @@ The tuningConfig is optional and

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7181: Reduce default max # of subTasks to 2 for native parallel task

jihoonson commented on a change in pull request #7181: Reduce default max # of subTasks to 2 for native parallel task URL: https://github.com/apache/incubator-druid/pull/7181#discussion_r262164264 ## File path: docs/content/ingestion/native_tasks.md ## @@ -181,7 +181,7 @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7171: ITIndexerTest: validate new data source after reindex

jihoonson commented on a change in pull request #7171: ITIndexerTest: validate new data source after reindex URL: https://github.com/apache/incubator-druid/pull/7171#discussion_r262195156 ## File path: integration-tests/src/test/resources/indexer/wikipedia_reindex_queries.json ###

[GitHub] [incubator-druid] glasser commented on a change in pull request #7171: ITIndexerTest: validate new data source after reindex

glasser commented on a change in pull request #7171: ITIndexerTest: validate new data source after reindex URL: https://github.com/apache/incubator-druid/pull/7171#discussion_r262197495 ## File path: integration-tests/src/test/resources/indexer/wikipedia_reindex_queries.json #

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7171: ITIndexerTest: validate new data source after reindex

jihoonson commented on a change in pull request #7171: ITIndexerTest: validate new data source after reindex URL: https://github.com/apache/incubator-druid/pull/7171#discussion_r262199310 ## File path: integration-tests/src/test/resources/indexer/wikipedia_reindex_queries.json ###

[GitHub] [incubator-druid] jihoonson merged pull request #7171: ITIndexerTest: validate new data source after reindex

jihoonson merged pull request #7171: ITIndexerTest: validate new data source after reindex URL: https://github.com/apache/incubator-druid/pull/7171 This is an automated message from the Apache Git Service. To respond to the

[incubator-druid] branch master updated: ITIndexerTest: validate new data source after reindex (#7171)

This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 7bf1ee4 ITIndexerTest: validate new

[GitHub] [incubator-druid] leventov opened a new pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality

leventov opened a new pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality URL: https://github.com/apache/incubator-druid/pull/7185 This patch makes Coordinator avoid at least 6 places where collections containing all segments

[GitHub] [incubator-druid] leventov commented on issue #7073: Remove unnecessary check for contains() in LoadRule

leventov commented on issue #7073: Remove unnecessary check for contains() in LoadRule URL: https://github.com/apache/incubator-druid/pull/7073#issuecomment-469387816 > @samarthjain could you please add a comment to the check in DruidCoordinatorBalancer explaining this matter? Howev

[GitHub] [incubator-druid] leventov commented on a change in pull request #7038: Fix and document concurrency of EventReceiverFirehose and TimedShutoffFirehose; Refine concurrency specification of Fir

leventov commented on a change in pull request #7038: Fix and document concurrency of EventReceiverFirehose and TimedShutoffFirehose; Refine concurrency specification of Firehose URL: https://github.com/apache/incubator-druid/pull/7038#discussion_r262209940 ## File path: server/sr

[GitHub] [incubator-druid] leventov commented on issue #7038: Fix and document concurrency of EventReceiverFirehose and TimedShutoffFirehose; Refine concurrency specification of Firehose

leventov commented on issue #7038: Fix and document concurrency of EventReceiverFirehose and TimedShutoffFirehose; Refine concurrency specification of Firehose URL: https://github.com/apache/incubator-druid/pull/7038#issuecomment-469390634 @egor-ryashin, I addressed your latest comments.

[GitHub] [incubator-druid] leventov opened a new issue #7186: Caffeine-based remote cache with adaptive admission windows

leventov opened a new issue #7186: Caffeine-based remote cache with adaptive admission windows URL: https://github.com/apache/incubator-druid/issues/7186 [Caffeine 2.7.0](https://github.com/ben-manes/caffeine/releases/tag/v2.7.0) introduces a cool feature of adaptive admission window size

[GitHub] [incubator-druid] samarthjain opened a new pull request #7073: Remove unnecessary check for contains() in LoadRule

samarthjain opened a new pull request #7073: Remove unnecessary check for contains() in LoadRule URL: https://github.com/apache/incubator-druid/pull/7073 See https://github.com/apache/incubator-druid/issues/7072 This is an au

[GitHub] [incubator-druid] leventov closed pull request #7073: Remove unnecessary check for contains() in LoadRule

leventov closed pull request #7073: Remove unnecessary check for contains() in LoadRule URL: https://github.com/apache/incubator-druid/pull/7073 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [incubator-druid] leventov commented on issue #7186: Caffeine-based remote cache with adaptive admission windows

leventov commented on issue #7186: Caffeine-based remote cache with adaptive admission windows URL: https://github.com/apache/incubator-druid/issues/7186#issuecomment-469402364 Segments are served by multiple historicals, and although currently Brokers almost never take advantage of that,

[GitHub] [incubator-druid] leventov edited a comment on issue #7186: Caffeine-based remote cache with adaptive admission windows

leventov edited a comment on issue #7186: Caffeine-based remote cache with adaptive admission windows URL: https://github.com/apache/incubator-druid/issues/7186#issuecomment-469402364 Segments are served by multiple historicals, and although currently Brokers almost never take advantage o

[GitHub] [incubator-druid] leventov opened a new issue #7187: Improve topN algorithm

leventov opened a new issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187 # Description @leerho proposed how the topN algorithm can be improved here: https://github.com/apache/incubator-druid/issues/7161#issuecomment-468890906 # Motiv

[GitHub] [incubator-druid] leventov commented on issue #7161: Indicating time trends in topN results

leventov commented on issue #7161: Indicating time trends in topN results URL: https://github.com/apache/incubator-druid/issues/7161#issuecomment-469405229 @leerho yes, we do exactly the "old" algorithm that you described :) See #1135. Thank you for letting us know about how the algorithm

[GitHub] [incubator-druid] leventov opened a new pull request #7188: Adjust issue templates

leventov opened a new pull request #7188: Adjust issue templates URL: https://github.com/apache/incubator-druid/pull/7188 As per [this discussion](https://lists.apache.org/thread.html/e16528f7552826c2e3435b6a4ce4079d0a8f2670b5e0f7204ec81fc8@%3Cdev.druid.apache.org%3E) in the mailing list.

[GitHub] [incubator-druid] leventov commented on a change in pull request #7067: Made IntelliJ Inspection "Iteration over keySet() could be replaced with entrySet()" a error & Fixed the violations

leventov commented on a change in pull request #7067: Made IntelliJ Inspection "Iteration over keySet() could be replaced with entrySet()" a error & Fixed the violations URL: https://github.com/apache/incubator-druid/pull/7067#discussion_r262235987 ## File path: benchmarks/src/mai

[GitHub] [incubator-druid] leventov commented on a change in pull request #7067: Made IntelliJ Inspection "Iteration over keySet() could be replaced with entrySet()" a error & Fixed the violations

leventov commented on a change in pull request #7067: Made IntelliJ Inspection "Iteration over keySet() could be replaced with entrySet()" a error & Fixed the violations URL: https://github.com/apache/incubator-druid/pull/7067#discussion_r262237058 ## File path: extensions-contrib

[GitHub] [incubator-druid] leventov commented on a change in pull request #7067: Made IntelliJ Inspection "Iteration over keySet() could be replaced with entrySet()" a error & Fixed the violations

leventov commented on a change in pull request #7067: Made IntelliJ Inspection "Iteration over keySet() could be replaced with entrySet()" a error & Fixed the violations URL: https://github.com/apache/incubator-druid/pull/7067#discussion_r262236249 ## File path: benchmarks/src/tes

[GitHub] [incubator-druid] leventov commented on a change in pull request #7067: Made IntelliJ Inspection "Iteration over keySet() could be replaced with entrySet()" a error & Fixed the violations

leventov commented on a change in pull request #7067: Made IntelliJ Inspection "Iteration over keySet() could be replaced with entrySet()" a error & Fixed the violations URL: https://github.com/apache/incubator-druid/pull/7067#discussion_r262236612 ## File path: extensions-contrib

[GitHub] [incubator-druid] clintropolis commented on issue #7154: rename maintenance mode to decommission

clintropolis commented on issue #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#issuecomment-469429899 I _think_ all comments should be addressed as of the last commit. I couldn't find any remaining related uses of 'maintenance' or 'pr

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7188: Adjust issue templates

jon-wei commented on a change in pull request #7188: Adjust issue templates URL: https://github.com/apache/incubator-druid/pull/7188#discussion_r262252891 ## File path: .github/ISSUE_TEMPLATE/feature.md ## @@ -0,0 +1,22 @@ +--- +name: Feature/Change +about: A template for D

[GitHub] [incubator-druid] glasser commented on issue #7180: [PROPOSAL] Prevent historicals whose segment caches contain unknown segments from corrupting cluster

glasser commented on issue #7180: [PROPOSAL] Prevent historicals whose segment caches contain unknown segments from corrupting cluster URL: https://github.com/apache/incubator-druid/issues/7180#issuecomment-469434138 I updated the proposal to match my last comment. ---

[GitHub] [incubator-druid] leventov merged pull request #7038: Fix and document concurrency of EventReceiverFirehose and TimedShutoffFirehose; Refine concurrency specification of Firehose

leventov merged pull request #7038: Fix and document concurrency of EventReceiverFirehose and TimedShutoffFirehose; Refine concurrency specification of Firehose URL: https://github.com/apache/incubator-druid/pull/7038 This

[incubator-druid] branch master updated: Fix and document concurrency of EventReceiverFirehose and TimedShutoffFirehose; Refine concurrency specification of Firehose (#7038)

This is an automated email from the ASF dual-hosted git repository. leventov pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 10c9f6d Fix and document concurrency

[GitHub] [incubator-druid] leventov commented on issue #7038: Fix and document concurrency of EventReceiverFirehose and TimedShutoffFirehose; Refine concurrency specification of Firehose

leventov commented on issue #7038: Fix and document concurrency of EventReceiverFirehose and TimedShutoffFirehose; Refine concurrency specification of Firehose URL: https://github.com/apache/incubator-druid/pull/7038#issuecomment-469435657 @egor-ryashin @glasser thanks for review! ---

[GitHub] [incubator-druid] leerho commented on issue #7187: Improve topN algorithm

leerho commented on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-469439146 ### Objective - Replace the current internal heuristic algorithm for "TopN" with the DataSketches [Frequent Items Sketch (FIS)](https://datasketches

[GitHub] [incubator-druid] gianm commented on issue #7187: Improve topN algorithm

gianm commented on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-469454545 It sounds like the behavior of FIS is different enough from topN that 'replace' is not in the cards. But it does sound like something that would be real

[incubator-druid] branch master updated: fix intellij UnusedInspectionsScope.xml (#7158)

This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 3398d39 fix intellij UnusedInspections

[GitHub] [incubator-druid] clintropolis merged pull request #7158: fix intellij UnusedInspectionsScope.xml

clintropolis merged pull request #7158: fix intellij UnusedInspectionsScope.xml URL: https://github.com/apache/incubator-druid/pull/7158 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-druid] gianm commented on a change in pull request #7181: Reduce default max # of subTasks to 2 for native parallel task

gianm commented on a change in pull request #7181: Reduce default max # of subTasks to 2 for native parallel task URL: https://github.com/apache/incubator-druid/pull/7181#discussion_r262281540 ## File path: docs/content/ingestion/native_tasks.md ## @@ -181,7 +181,7 @@ The

[GitHub] [incubator-druid] leventov commented on a change in pull request #7154: rename maintenance mode to decommission

leventov commented on a change in pull request #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r262276521 ## File path: server/src/main/java/org/apache/druid/server/coordinator/CoordinatorDynamicConfig.java ###

[GitHub] [incubator-druid] leventov commented on a change in pull request #7154: rename maintenance mode to decommission

leventov commented on a change in pull request #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r262281741 ## File path: server/src/test/java/org/apache/druid/server/coordinator/rules/LoadRuleTest.java ## @

[GitHub] [incubator-druid] leventov commented on a change in pull request #7154: rename maintenance mode to decommission

leventov commented on a change in pull request #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r262282538 ## File path: docs/content/configuration/index.md ## @@ -803,9 +803,9 @@ Issuing a GET request at th

[GitHub] [incubator-druid] leventov commented on a change in pull request #7154: rename maintenance mode to decommission

leventov commented on a change in pull request #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r262281069 ## File path: server/src/main/java/org/apache/druid/server/coordinator/helper/DruidCoordinatorBalancer.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #7154: rename maintenance mode to decommission

leventov commented on a change in pull request #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r262280836 ## File path: server/src/main/java/org/apache/druid/server/coordinator/helper/DruidCoordinatorBalancer.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #7154: rename maintenance mode to decommission

leventov commented on a change in pull request #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r262281608 ## File path: server/src/test/java/org/apache/druid/server/coordinator/rules/BroadcastDistributionRuleTest.ja

[GitHub] [incubator-druid] leventov commented on a change in pull request #7154: rename maintenance mode to decommission

leventov commented on a change in pull request #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r262281629 ## File path: server/src/test/java/org/apache/druid/server/coordinator/rules/BroadcastDistributionRuleTest.ja

[GitHub] [incubator-druid] leventov commented on a change in pull request #7154: rename maintenance mode to decommission

leventov commented on a change in pull request #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r262276409 ## File path: docs/content/configuration/index.md ## @@ -803,9 +803,9 @@ Issuing a GET request at th

[GitHub] [incubator-druid] jon-wei opened a new pull request #7189: [Backport] Fix two SeekableStream serde issues. (#7176)

jon-wei opened a new pull request #7189: [Backport] Fix two SeekableStream serde issues. (#7176) URL: https://github.com/apache/incubator-druid/pull/7189 Backport of #7176 to 0.14.0-incubating This is an automated message fro

[GitHub] [incubator-druid] leventov commented on a change in pull request #7188: Adjust issue templates

leventov commented on a change in pull request #7188: Adjust issue templates URL: https://github.com/apache/incubator-druid/pull/7188#discussion_r262283905 ## File path: .github/ISSUE_TEMPLATE/feature.md ## @@ -0,0 +1,22 @@ +--- +name: Feature/Change +about: A template for

[GitHub] [incubator-druid] jon-wei opened a new pull request #7190: [Backport] Improve doc for auto compaction (#7117)

jon-wei opened a new pull request #7190: [Backport] Improve doc for auto compaction (#7117) URL: https://github.com/apache/incubator-druid/pull/7190 Backport #7117 to 0.14.0-incubating This is an automated message from the Ap

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7154: rename maintenance mode to decommission

clintropolis commented on a change in pull request #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r262284520 ## File path: server/src/main/java/org/apache/druid/server/coordinator/CoordinatorDynamicConfig.java ###

[GitHub] [incubator-druid] jon-wei opened a new pull request #7191: [Backport] add license checker to web-console (#7028)

jon-wei opened a new pull request #7191: [Backport] add license checker to web-console (#7028) URL: https://github.com/apache/incubator-druid/pull/7191 Backport of #7028 to 0.14.0-incubating This is an automated message from

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7154: rename maintenance mode to decommission

clintropolis commented on a change in pull request #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r262287102 ## File path: server/src/main/java/org/apache/druid/server/coordinator/helper/DruidCoordinatorBalancer.ja

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7154: rename maintenance mode to decommission

clintropolis commented on a change in pull request #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r262288162 ## File path: server/src/test/java/org/apache/druid/server/coordinator/rules/BroadcastDistributionRuleTes

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7154: rename maintenance mode to decommission

clintropolis commented on a change in pull request #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r262288117 ## File path: docs/content/configuration/index.md ## @@ -803,9 +803,9 @@ Issuing a GET request a

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7154: rename maintenance mode to decommission

clintropolis commented on a change in pull request #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r262288175 ## File path: server/src/test/java/org/apache/druid/server/coordinator/rules/LoadRuleTest.java #

[GitHub] [incubator-druid] shivtools edited a comment on issue #7174: Change reservoir sampling of segments to spliterator approach

shivtools edited a comment on issue #7174: Change reservoir sampling of segments to spliterator approach URL: https://github.com/apache/incubator-druid/pull/7174#issuecomment-469475814 Hey @leventov, @drcrallen, I've made the changes you've requested. I'm seeing one [Travis CI integration

[GitHub] [incubator-druid] shivtools commented on issue #7174: Change reservoir sampling of segments to spliterator approach

shivtools commented on issue #7174: Change reservoir sampling of segments to spliterator approach URL: https://github.com/apache/incubator-druid/pull/7174#issuecomment-469475814 Hey @leventov, @drcrallen, I've made the changes you've requested. I'm seeing one Travis CI integration test fai

[GitHub] [incubator-druid] jon-wei commented on issue #7174: Change reservoir sampling of segments to spliterator approach

jon-wei commented on issue #7174: Change reservoir sampling of segments to spliterator approach URL: https://github.com/apache/incubator-druid/pull/7174#issuecomment-469476041 @shivtools That test is known to be flaky, I've restarted it -

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7188: Adjust issue templates

jon-wei commented on a change in pull request #7188: Adjust issue templates URL: https://github.com/apache/incubator-druid/pull/7188#discussion_r262295746 ## File path: .github/ISSUE_TEMPLATE/bug_report.md ## @@ -1,19 +1,18 @@ --- -name: Bug Report -about: A template for D

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7188: Adjust issue templates

jon-wei commented on a change in pull request #7188: Adjust issue templates URL: https://github.com/apache/incubator-druid/pull/7188#discussion_r262295746 ## File path: .github/ISSUE_TEMPLATE/bug_report.md ## @@ -1,19 +1,18 @@ --- -name: Bug Report -about: A template for D

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7181: Reduce default max # of subTasks to 2 for native parallel task

jon-wei commented on a change in pull request #7181: Reduce default max # of subTasks to 2 for native parallel task URL: https://github.com/apache/incubator-druid/pull/7181#discussion_r262299318 ## File path: docs/content/ingestion/native_tasks.md ## @@ -181,7 +181,7 @@ Th

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7154: rename maintenance mode to decommission

clintropolis commented on a change in pull request #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r262300138 ## File path: docs/content/configuration/index.md ## @@ -803,9 +803,9 @@ Issuing a GET request a

[GitHub] [incubator-druid] jihoonson opened a new issue #7192: Segments are not cleaned up properly after unannouncing them in HTTP-based segment loading if numLoadingThreads > 1

jihoonson opened a new issue #7192: Segments are not cleaned up properly after unannouncing them in HTTP-based segment loading if numLoadingThreads > 1 URL: https://github.com/apache/incubator-druid/issues/7192 # Affected Version 0.12, 0.13, 0.14 # Description When `num

[GitHub] [incubator-druid] jihoonson commented on issue #7088: Improve parallelism of zookeeper based segment change processing

jihoonson commented on issue #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#issuecomment-469483744 Hi @samarthjain, I just noticed this bug: https://github.com/apache/incubator-druid/issues/7192. I'm not sure

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7181: Reduce default max # of subTasks to 2 for native parallel task

jihoonson commented on a change in pull request #7181: Reduce default max # of subTasks to 2 for native parallel task URL: https://github.com/apache/incubator-druid/pull/7181#discussion_r262306029 ## File path: docs/content/ingestion/native_tasks.md ## @@ -181,7 +181,7 @@

[GitHub] [incubator-druid] jihoonson commented on issue #7192: Segments are not cleaned up properly after unannouncing them in HTTP-based segment loading if numLoadingThreads > 1

jihoonson commented on issue #7192: Segments are not cleaned up properly after unannouncing them in HTTP-based segment loading if numLoadingThreads > 1 URL: https://github.com/apache/incubator-druid/issues/7192#issuecomment-469488086 This would be fixed in 0.15 because HTTP-based segment l

[GitHub] [incubator-druid] clintropolis commented on issue #6799: Druid watermark initial contribution

clintropolis commented on issue #6799: Druid watermark initial contribution URL: https://github.com/apache/incubator-druid/pull/6799#issuecomment-469488631 bump to defeat stale bot, I've been meaning to have a look here but have been too busy ---

[GitHub] [incubator-druid] clintropolis closed issue #6949: Create a proposal template

clintropolis closed issue #6949: Create a proposal template URL: https://github.com/apache/incubator-druid/issues/6949 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-druid] clintropolis commented on issue #6949: Create a proposal template

clintropolis commented on issue #6949: Create a proposal template URL: https://github.com/apache/incubator-druid/issues/6949#issuecomment-469489901 resolved by #7062 This is an automated message from the Apache Git Service. T

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7048: Make IngestSegmentFirehoseFactory splittable for parallel ingestion

jihoonson commented on a change in pull request #7048: Make IngestSegmentFirehoseFactory splittable for parallel ingestion URL: https://github.com/apache/incubator-druid/pull/7048#discussion_r262307439 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/firehose/

[GitHub] [incubator-druid] clintropolis commented on issue #6740: Zookeeper loss

clintropolis commented on issue #6740: Zookeeper loss URL: https://github.com/apache/incubator-druid/pull/6740#issuecomment-469494953 @leventov or @egor-ryashin any further comments on this PR? This is an automated message fro

[GitHub] [incubator-druid] justinborromeo opened a new issue #7193: KafkaSupervisorTest#testCheckpointForUnknownTaskGroup() is flaky

justinborromeo opened a new issue #7193: KafkaSupervisorTest#testCheckpointForUnknownTaskGroup() is flaky URL: https://github.com/apache/incubator-druid/issues/7193 # Affected Version `master` branch. # Description Transient failures observed by both me and @clintropoli

[GitHub] [incubator-druid] clintropolis commented on issue #6865: Densify swapped hll buffer

clintropolis commented on issue #6865: Densify swapped hll buffer URL: https://github.com/apache/incubator-druid/pull/6865#issuecomment-469503572 Hmm, so are we stuck here? I haven't had enough time to spare to dig in deep enough to the hll collector to have a strong opinion of my own, so m

[GitHub] [incubator-druid] fjy merged pull request #7191: [Backport] add license checker to web-console (#7028)

fjy merged pull request #7191: [Backport] add license checker to web-console (#7028) URL: https://github.com/apache/incubator-druid/pull/7191 This is an automated message from the Apache Git Service. To respond to the messag

[incubator-druid] branch 0.14.0-incubating updated: add license checker to web-console (#7028) (#7191)

This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch 0.14.0-incubating in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/0.14.0-incubating by this push: new d9e9f74 add license

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7181: Reduce default max # of subTasks to 2 for native parallel task

clintropolis commented on a change in pull request #7181: Reduce default max # of subTasks to 2 for native parallel task URL: https://github.com/apache/incubator-druid/pull/7181#discussion_r262328446 ## File path: docs/content/ingestion/native_tasks.md ## @@ -181,7 +190,7

[GitHub] [incubator-druid] jon-wei merged pull request #7026: Update LICENSE and NOTICE files

jon-wei merged pull request #7026: Update LICENSE and NOTICE files URL: https://github.com/apache/incubator-druid/pull/7026 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-druid] jon-wei commented on issue #7026: Update LICENSE and NOTICE files

jon-wei commented on issue #7026: Update LICENSE and NOTICE files URL: https://github.com/apache/incubator-druid/pull/7026#issuecomment-469513685 @clintropolis @gianm Thanks for the review, I'll update this area with more documentation/automation for future release managers after 0.14.0. -

[GitHub] [incubator-druid] glasser commented on a change in pull request #7048: Make IngestSegmentFirehoseFactory splittable for parallel ingestion

glasser commented on a change in pull request #7048: Make IngestSegmentFirehoseFactory splittable for parallel ingestion URL: https://github.com/apache/incubator-druid/pull/7048#discussion_r262329251 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/firehose/Wi

[GitHub] [incubator-druid] jon-wei opened a new pull request #7194: [Backport] Update LICENSE and NOTICE files (#7026)

jon-wei opened a new pull request #7194: [Backport] Update LICENSE and NOTICE files (#7026) URL: https://github.com/apache/incubator-druid/pull/7194 Backport #7026 to 0.14.0-incubating This is an automated message from the Ap

[GitHub] [incubator-druid] gianm merged pull request #7182: support sin cos etc trigonometric function in sql

gianm merged pull request #7182: support sin cos etc trigonometric function in sql URL: https://github.com/apache/incubator-druid/pull/7182 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-druid] branch master updated: support sin cos etc trigonometric function in sql (#7182)

This is an automated email from the ASF dual-hosted git repository. gian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 6511827 support sin cos etc trigonometri

[GitHub] [incubator-druid] jon-wei commented on issue #6984: Need to fix LICENSE and NOTICE for next release

jon-wei commented on issue #6984: Need to fix LICENSE and NOTICE for next release URL: https://github.com/apache/incubator-druid/issues/6984#issuecomment-469522597 Addressed by #7026 This is an automated message from the Ap

[GitHub] [incubator-druid] jon-wei closed issue #6984: Need to fix LICENSE and NOTICE for next release

jon-wei closed issue #6984: Need to fix LICENSE and NOTICE for next release URL: https://github.com/apache/incubator-druid/issues/6984 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7181: Reduce default max # of subTasks to 2 for native parallel task

jihoonson commented on a change in pull request #7181: Reduce default max # of subTasks to 2 for native parallel task URL: https://github.com/apache/incubator-druid/pull/7181#discussion_r262344624 ## File path: docs/content/ingestion/native_tasks.md ## @@ -181,7 +190,7 @@

[incubator-druid] branch 0.14.0-incubating updated: Fix two SeekableStream serde issues. (#7176) (#7189)

This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch 0.14.0-incubating in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/0.14.0-incubating by this push: new 59ceaf0 Fix two

[GitHub] [incubator-druid] clintropolis merged pull request #7189: [Backport] Fix two SeekableStream serde issues. (#7176)

clintropolis merged pull request #7189: [Backport] Fix two SeekableStream serde issues. (#7176) URL: https://github.com/apache/incubator-druid/pull/7189 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-druid] leerho commented on issue #7187: Improve topN algorithm

leerho commented on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-469548325 @gianm I think we may have some confusion here. FIS does not depend on `Comparable` at all, only `Identity`. And the weights are positive longs.

[GitHub] [incubator-druid] leerho edited a comment on issue #7187: Improve topN algorithm

leerho edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-469548325 @gianm I think we may have some confusion here. FIS does not depend on `Comparable` at all, only `Identity`. And the weights are positive lo

[GitHub] [incubator-druid] clintropolis merged pull request #7194: [Backport] Update LICENSE and NOTICE files (#7026)

clintropolis merged pull request #7194: [Backport] Update LICENSE and NOTICE files (#7026) URL: https://github.com/apache/incubator-druid/pull/7194 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-druid] leerho edited a comment on issue #7187: Improve topN algorithm

leerho edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-469548325 @gianm I think we may have some confusion here. FIS does not depend on `Comparable` at all, only `Identity`. And the weights are positive lo

[GitHub] [incubator-druid] fjy merged pull request #7190: [Backport] Improve doc for auto compaction (#7117)

fjy merged pull request #7190: [Backport] Improve doc for auto compaction (#7117) URL: https://github.com/apache/incubator-druid/pull/7190 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-druid] branch 0.14.0-incubating updated: Improve doc for auto compaction (#7117) (#7190)

This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch 0.14.0-incubating in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/0.14.0-incubating by this push: new cb4227d Improve doc

[GitHub] [incubator-druid] fjy commented on issue #7154: rename maintenance mode to decommission

fjy commented on issue #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#issuecomment-469554518 @leventov any more comments? This is an automated message from the Apache Gi

[GitHub] [incubator-druid] gianm commented on issue #7187: Improve topN algorithm

gianm commented on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-469569100 The current topN algorithm can be used for any query shaped like `SELECT x, AGG(y) FROM tbl ORDER BY AGG(y) DESC LIMIT N` when `useApproximateTopN` is e