[incubator-druid] 01/01: [maven-release-plugin] prepare release druid-0.14.0-incubating

2019-03-28 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to tag druid-0.14.0-incubating-rc3 in repository https://gitbox.apache.org/repos/asf/incubator-druid.git commit f169adae986a174cd52bf42c8b4246934eaff0d6 Author: jon-wei AuthorDate: Thu Mar 28 23:31:15 2019

[incubator-druid] tag druid-0.14.0-incubating-rc3 created (now f169ada)

2019-03-28 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a change to tag druid-0.14.0-incubating-rc3 in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. at f169ada (commit) This tag includes the following new commits: new f169ada [maven-r

[GitHub] [incubator-druid] pdeva edited a comment on issue #7337: DataSketches HLL is not a replacement for Cardinality aggregator

2019-03-28 Thread GitBox
pdeva edited a comment on issue #7337: DataSketches HLL is not a replacement for Cardinality aggregator URL: https://github.com/apache/incubator-druid/issues/7337#issuecomment-477879520 @jon-wei ok using `HLLSketchBuild` does work. though the documentation for this could definitely be im

[GitHub] [incubator-druid] pdeva commented on issue #7337: DataSketches HLL is not a replacement for Cardinality aggregator

2019-03-28 Thread GitBox
pdeva commented on issue #7337: DataSketches HLL is not a replacement for Cardinality aggregator URL: https://github.com/apache/incubator-druid/issues/7337#issuecomment-477879520 @jon-wei ok using `HLLSketchBuild` does work. though the documentation for this could definitely be improved.

[GitHub] [incubator-druid] jon-wei commented on issue #7379: [Backport] maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes

2019-03-28 Thread GitBox
jon-wei commented on issue #7379: [Backport] maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes URL: https://github.com/apache/incubator-druid/pull/7379#issuecomment-477877698 Unit and integration tests also pass locally for the backport.

[GitHub] [incubator-druid] jon-wei merged pull request #7379: [Backport] maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes

2019-03-28 Thread GitBox
jon-wei merged pull request #7379: [Backport] maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes URL: https://github.com/apache/incubator-druid/pull/7379 This is an automate

[incubator-druid] branch 0.14.0-incubating updated: [Backport] maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes (#7379)

2019-03-28 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to branch 0.14.0-incubating in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/0.14.0-incubating by this push: new 1e50319 [Backpor

[GitHub] [incubator-druid] vogievetsky commented on issue #7371: Support segment metadata query in SQL console

2019-03-28 Thread GitBox
vogievetsky commented on issue #7371: Support segment metadata query in SQL console URL: https://github.com/apache/incubator-druid/pull/7371#issuecomment-477860488 Please separate the docs change form the code PR, those do not belong together. Also the docs PR could be back ported much mor

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7371: Support segment metadata query in SQL console

2019-03-28 Thread GitBox
vogievetsky commented on a change in pull request #7371: Support segment metadata query in SQL console URL: https://github.com/apache/incubator-druid/pull/7371#discussion_r270275846 ## File path: docs/content/operations/druid-console.md ## @@ -86,5 +86,8 @@ The data server

[GitHub] [incubator-druid] QiuMM commented on a change in pull request #7066: Support assign tasks to run on different tiers of MiddleManagers

2019-03-28 Thread GitBox
QiuMM commented on a change in pull request #7066: Support assign tasks to run on different tiers of MiddleManagers URL: https://github.com/apache/incubator-druid/pull/7066#discussion_r270273195 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/setup/W

[GitHub] [incubator-druid] QiuMM commented on a change in pull request #7066: Support assign tasks to run on different tiers of MiddleManagers

2019-03-28 Thread GitBox
QiuMM commented on a change in pull request #7066: Support assign tasks to run on different tiers of MiddleManagers URL: https://github.com/apache/incubator-druid/pull/7066#discussion_r270273195 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/setup/W

[GitHub] [incubator-druid] jon-wei opened a new pull request #7379: [Backport] maxTotalRows should be checked in DataSourceCompactionConfig before s…

2019-03-28 Thread GitBox
jon-wei opened a new pull request #7379: [Backport] maxTotalRows should be checked in DataSourceCompactionConfig before s… URL: https://github.com/apache/incubator-druid/pull/7379 …etting targetCompactionSizeBytes (#7368) * maxTotalRows should be checked in DataSourceCompactionConfig

[GitHub] [incubator-druid] jon-wei commented on issue #7368: maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes

2019-03-28 Thread GitBox
jon-wei commented on issue #7368: maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes URL: https://github.com/apache/incubator-druid/pull/7368#issuecomment-477852554 TravisCI is still having issues today, merging as TeamCity has passed and

[GitHub] [incubator-druid] jon-wei closed issue #7356: Exception with auto compaction

2019-03-28 Thread GitBox
jon-wei closed issue #7356: Exception with auto compaction URL: https://github.com/apache/incubator-druid/issues/7356 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[incubator-druid] branch master updated: maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes (#7368)

2019-03-28 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 62c3e89 maxTotalRows should be checked

[GitHub] [incubator-druid] jon-wei merged pull request #7368: maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes

2019-03-28 Thread GitBox
jon-wei merged pull request #7368: maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes URL: https://github.com/apache/incubator-druid/pull/7368 This is an automated message f

[GitHub] [incubator-druid] lxqfy commented on issue #7338: Overwrite index task maxTotalRows with computed maxRowsPerSegments

2019-03-28 Thread GitBox
lxqfy commented on issue #7338: Overwrite index task maxTotalRows with computed maxRowsPerSegments URL: https://github.com/apache/incubator-druid/pull/7338#issuecomment-477842918 @jihoonson Thanks for the explanation. I will set to `Long.MAX_VALUE`.

[GitHub] [incubator-druid] quenlang commented on issue #7297: thetaSketch aggrgator handle null or "" into unexpected value at ingesting

2019-03-28 Thread GitBox
quenlang commented on issue #7297: thetaSketch aggrgator handle null or "" into unexpected value at ingesting URL: https://github.com/apache/incubator-druid/issues/7297#issuecomment-477838834 > @quenlang thanks for debugging. It sounds like a bug. I'll take a look. Thank you so muc

[GitHub] [incubator-druid] jihoonson commented on issue #7368: maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes

2019-03-28 Thread GitBox
jihoonson commented on issue #7368: maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes URL: https://github.com/apache/incubator-druid/pull/7368#issuecomment-477832317 I ran unit tests and integration tests locally and they passed. I also t

[GitHub] [incubator-druid] jihoonson commented on issue #6873: Kill Segment Grace Period

2019-03-28 Thread GitBox
jihoonson commented on issue #6873: Kill Segment Grace Period URL: https://github.com/apache/incubator-druid/issues/6873#issuecomment-477830539 Hi @capistrant, thank you for the proposal. It sounds useful, but I'm wondering how different it is from `druid.coordinator.kill.durationTo

[GitHub] [incubator-druid] jon-wei commented on issue #7362: Principles for choosing logging severity

2019-03-28 Thread GitBox
jon-wei commented on issue #7362: Principles for choosing logging severity URL: https://github.com/apache/incubator-druid/issues/7362#issuecomment-477828781 I think that's a pretty reasonable breakdown for logging conventions. Replacing "WTF" with the more professional-sounding "ASSE

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7368: maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes

2019-03-28 Thread GitBox
jihoonson commented on a change in pull request #7368: maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes URL: https://github.com/apache/incubator-druid/pull/7368#discussion_r270252750 ## File path: server/src/main/java/org/apache/

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7368: maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes

2019-03-28 Thread GitBox
jon-wei commented on a change in pull request #7368: maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes URL: https://github.com/apache/incubator-druid/pull/7368#discussion_r270251320 ## File path: server/src/main/java/org/apache/dr

[GitHub] [incubator-druid] clintropolis merged pull request #7314: Put all local storage keys and functions into one file in util

2019-03-28 Thread GitBox
clintropolis merged pull request #7314: Put all local storage keys and functions into one file in util URL: https://github.com/apache/incubator-druid/pull/7314 This is an automated message from the Apache Git Service. To res

[incubator-druid] branch master updated: Put all local storage keys and functions into one file in util (#7314)

2019-03-28 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new a09aa13 Put all local storage keys and

[GitHub] [incubator-druid] jon-wei edited a comment on issue #6972: Support LDAP authentication/authorization

2019-03-28 Thread GitBox
jon-wei edited a comment on issue #6972: Support LDAP authentication/authorization URL: https://github.com/apache/incubator-druid/pull/6972#issuecomment-48052 @mohammadjkhan @nishantmonu51 Given that the metadata store-backed and LDAP implementations have such different configu

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7371: Support segment metadata query in SQL console

2019-03-28 Thread GitBox
clintropolis commented on a change in pull request #7371: Support segment metadata query in SQL console URL: https://github.com/apache/incubator-druid/pull/7371#discussion_r270247141 ## File path: docs/content/operations/druid-console.md ## @@ -86,5 +86,8 @@ The data serve

[incubator-druid] branch master updated: Add scss linter in web console (#7365)

2019-03-28 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new be1d7f8 Add scss linter in web console

[GitHub] [incubator-druid] clintropolis merged pull request #7365: Add scss linter in web console

2019-03-28 Thread GitBox
clintropolis merged pull request #7365: Add scss linter in web console URL: https://github.com/apache/incubator-druid/pull/7365 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-druid] jon-wei commented on issue #6319: [Proposal] Minimizing the lock granularity for indexing

2019-03-28 Thread GitBox
jon-wei commented on issue #6319: [Proposal] Minimizing the lock granularity for indexing URL: https://github.com/apache/incubator-druid/issues/6319#issuecomment-477819795 For ` private final Set overshadowingSegments;`, I think it's worth mentioning that an alternative design would be to

[GitHub] [incubator-druid] jon-wei commented on issue #6319: [Proposal] Minimizing the lock granularity for indexing

2019-03-28 Thread GitBox
jon-wei commented on issue #6319: [Proposal] Minimizing the lock granularity for indexing URL: https://github.com/apache/incubator-druid/issues/6319#issuecomment-477818887 In this proposal, what happens in the following case? - Suppose we have two segments as partitions of a DAY gra

[GitHub] [incubator-druid] jihoonson commented on issue #7367: Lookback query

2019-03-28 Thread GitBox
jihoonson commented on issue #7367: Lookback query URL: https://github.com/apache/incubator-druid/pull/7367#issuecomment-477818743 I think `Feature/Change` label is for asking some new features or changes of existing features to the community. So, it is more about what is needed and why. `

[GitHub] [incubator-druid] niketh commented on issue #7378: Task killed by Overlord because it is not responding to Pause

2019-03-28 Thread GitBox
niketh commented on issue #7378: Task killed by Overlord because it is not responding to Pause URL: https://github.com/apache/incubator-druid/issues/7378#issuecomment-477818830 @jihoonson I agree. Need to investigate this further, opening an issue to track this.

[GitHub] [incubator-druid] justinborromeo commented on issue #7342: How to understand the broker node to get the segments from the MiddleManager node?

2019-03-28 Thread GitBox
justinborromeo commented on issue #7342: How to understand the broker node to get the segments from the MiddleManager node? URL: https://github.com/apache/incubator-druid/issues/7342#issuecomment-477818753 For the latter question, see the [clustering docs](http://druid.io/docs/latest/tuto

[GitHub] [incubator-druid] jihoonson commented on issue #7378: Task killed by Overlord because it is not responding to Pause

2019-03-28 Thread GitBox
jihoonson commented on issue #7378: Task killed by Overlord because it is not responding to Pause URL: https://github.com/apache/incubator-druid/issues/7378#issuecomment-477818536 This is intended. If a task doesn't respond, the supervisor will kill it and spawn a new one. Maybe it's more

[GitHub] [incubator-druid] niketh opened a new issue #7378: Task killed by Overlord because it is not responding to Pause

2019-03-28 Thread GitBox
niketh opened a new issue #7378: Task killed by Overlord because it is not responding to Pause URL: https://github.com/apache/incubator-druid/issues/7378 Tasks are being killed by overlord because peon is not responding to `pause`. Here are the logs (running druid-12.2-rc3) ``` 2

[GitHub] [incubator-druid] jon-wei commented on issue #6319: [Proposal] Minimizing the lock granularity for indexing

2019-03-28 Thread GitBox
jon-wei commented on issue #6319: [Proposal] Minimizing the lock granularity for indexing URL: https://github.com/apache/incubator-druid/issues/6319#issuecomment-477818116 In the `Changes to TaskLockbox` section, can you clarify the difference between `shared` and `mixed` locks?

[GitHub] [incubator-druid] jon-wei commented on issue #6319: [Proposal] Minimizing the lock granularity for indexing

2019-03-28 Thread GitBox
jon-wei commented on issue #6319: [Proposal] Minimizing the lock granularity for indexing URL: https://github.com/apache/incubator-druid/issues/6319#issuecomment-477817724 > If the task is overwriting existing segments, the new segmentIds would have those existing segments in their oversh

[GitHub] [incubator-druid] justinborromeo opened a new issue #7377: Unified web console cuts off long strings

2019-03-28 Thread GitBox
justinborromeo opened a new issue #7377: Unified web console cuts off long strings URL: https://github.com/apache/incubator-druid/issues/7377 ### Description and Motivation When a long string is returned by a SQL query, the unified web console will cut off part of the string. Afaik

[GitHub] [incubator-druid] niketh opened a new issue #7376: Failing Broker Queries - Faulty Channel

2019-03-28 Thread GitBox
niketh opened a new issue #7376: Failing Broker Queries - Faulty Channel URL: https://github.com/apache/incubator-druid/issues/7376 Broker queries fail with Faulty Channel Exception ### Description This error occurs when the broker queries fail on MM due to improper shutdown o

[GitHub] [incubator-druid] leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

2019-03-28 Thread GitBox
leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r270244690 ## File path: server/src/main/j

[GitHub] [incubator-druid] jihoonson commented on issue #7368: maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes

2019-03-28 Thread GitBox
jihoonson commented on issue #7368: maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes URL: https://github.com/apache/incubator-druid/pull/7368#issuecomment-477817138 I removed new integration tests I added in this PR because they are flaky

[GitHub] [incubator-druid] leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

2019-03-28 Thread GitBox
leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r270244412 ## File path: server/src/main/j

[GitHub] [incubator-druid] leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

2019-03-28 Thread GitBox
leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r270243312 ## File path: docs/content/confi

[GitHub] [incubator-druid] leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

2019-03-28 Thread GitBox
leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r270243230 ## File path: docs/content/opera

[GitHub] [incubator-druid] leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

2019-03-28 Thread GitBox
leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r270242918 ## File path: server/src/main/j

[GitHub] [incubator-druid] leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

2019-03-28 Thread GitBox
leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r270242686 ## File path: server/src/main/ja

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegment

2019-03-28 Thread GitBox
egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r270238488 ## File path: docs/content/c

[GitHub] [incubator-druid] leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

2019-03-28 Thread GitBox
leventov commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r270242574 ## File path: server/src/main/ja

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegment

2019-03-28 Thread GitBox
egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r270240394 ## File path: docs/content/o

[GitHub] [incubator-druid] niketh opened a new issue #7375: [Proposal] Auto load SSL Certs

2019-03-28 Thread GitBox
niketh opened a new issue #7375: [Proposal] Auto load SSL Certs URL: https://github.com/apache/incubator-druid/issues/7375 ### Motivation Whenever SSL certs expire a restart is required to load fresh certs. ### Proposed changes 1. Add property `druid.server.https.cert.au

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegment

2019-03-28 Thread GitBox
egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r270158904 ## File path: server/src/mai

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegment

2019-03-28 Thread GitBox
egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r269358749 ## File path: server/src/ma

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegment

2019-03-28 Thread GitBox
egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r270214182 ## File path: server/src/ma

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegment

2019-03-28 Thread GitBox
egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r270217068 ## File path: server/src/ma

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegment

2019-03-28 Thread GitBox
egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r270159469 ## File path: server/src/mai

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegment

2019-03-28 Thread GitBox
egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r270210291 ## File path: server/src/ma

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegment

2019-03-28 Thread GitBox
egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r270160919 ## File path: server/src/mai

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegment

2019-03-28 Thread GitBox
egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r270213438 ## File path: server/src/ma

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegment

2019-03-28 Thread GitBox
egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r269358199 ## File path: server/src/ma

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegment

2019-03-28 Thread GitBox
egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r270161584 ## File path: server/src/mai

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegment

2019-03-28 Thread GitBox
egor-ryashin commented on a change in pull request #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#discussion_r270215150 ## File path: server/src/ma

[GitHub] [incubator-druid] leventov commented on issue #6740: Zookeeper loss

2019-03-28 Thread GitBox
leventov commented on issue #6740: Zookeeper loss URL: https://github.com/apache/incubator-druid/pull/6740#issuecomment-477798278 @michael-trelinski you can try to merge master into your branch, it may help. This is an automat

[GitHub] [incubator-druid] leventov commented on a change in pull request #6943: InterruptedExceptions should never be ignored in the code.

2019-03-28 Thread GitBox
leventov commented on a change in pull request #6943: InterruptedExceptions should never be ignored in the code. URL: https://github.com/apache/incubator-druid/pull/6943#discussion_r270226445 ## File path: core/src/main/java/org/apache/druid/java/util/http/client/pool/ResourcePool.

[GitHub] [incubator-druid] michael-trelinski edited a comment on issue #7367: Lookback query

2019-03-28 Thread GitBox
michael-trelinski edited a comment on issue #7367: Lookback query URL: https://github.com/apache/incubator-druid/pull/7367#issuecomment-477795547 > @michael-trelinski thank you for your contribution! Would you please write a proposal for this PR? Here is the link: https://github.com/apache

[GitHub] [incubator-druid] michael-trelinski commented on issue #7367: Lookback query

2019-03-28 Thread GitBox
michael-trelinski commented on issue #7367: Lookback query URL: https://github.com/apache/incubator-druid/pull/7367#issuecomment-477795547 > @michael-trelinski thank you for your contribution! Would you please write a proposal for this PR? Here is the link: https://github.com/apache/incuba

[GitHub] [incubator-druid] leventov edited a comment on issue #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

2019-03-28 Thread GitBox
leventov edited a comment on issue #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#issuecomment-477794972 For reviewers: in the latest commits I've made some

[GitHub] [incubator-druid] leventov commented on issue #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

2019-03-28 Thread GitBox
leventov commented on issue #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#issuecomment-477794972 For reviewers: in the latest commits I've made some more cl

[GitHub] [incubator-druid] michael-trelinski opened a new issue #7374: Segment Loading on historical node startup

2019-03-28 Thread GitBox
michael-trelinski opened a new issue #7374: Segment Loading on historical node startup URL: https://github.com/apache/incubator-druid/issues/7374 ### Motivation The first query for a given datasource after historical node startup tends to take a very long time. Subsequent queries a

[GitHub] [incubator-druid] leventov commented on issue #7233: Set "is_published" to false for overshadowed segments in sys.segments table

2019-03-28 Thread GitBox
leventov commented on issue #7233: Set "is_published" to false for overshadowed segments in sys.segments table URL: https://github.com/apache/incubator-druid/issues/7233#issuecomment-477787296 Perhaps `is_actual` is better than `is_active`. Regarding the semantics of `is_overshadowe

[GitHub] [incubator-druid] jihoonson commented on issue #7367: Lookback query

2019-03-28 Thread GitBox
jihoonson commented on issue #7367: Lookback query URL: https://github.com/apache/incubator-druid/pull/7367#issuecomment-477784096 @michael-trelinski thank you for your contribution! Would you please write a proposal for this PR? Here is the link: https://github.com/apache/incubator-druid/

[GitHub] [incubator-druid] leventov commented on issue #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

2019-03-28 Thread GitBox
leventov commented on issue #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#issuecomment-477783437 @gianm I didn't question that "published in `sys.segments`"

[GitHub] [incubator-druid] jihoonson commented on issue #7338: Overwrite index task maxTotalRows with computed maxRowsPerSegments

2019-03-28 Thread GitBox
jihoonson commented on issue #7338: Overwrite index task maxTotalRows with computed maxRowsPerSegments URL: https://github.com/apache/incubator-druid/pull/7338#issuecomment-477780789 Oh, `maxTotalRows` and `numShards` look similar but different. An appenderator can append to multiple segme

[incubator-druid] branch master updated: Time Ordering On Scans (#7133)

2019-03-28 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new ad7862c Time Ordering On Scans (#7133)

[GitHub] [incubator-druid] jon-wei merged pull request #7133: Time Ordering On Scans

2019-03-28 Thread GitBox
jon-wei merged pull request #7133: Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #6972: Support LDAP authentication/authorization

2019-03-28 Thread GitBox
jon-wei commented on a change in pull request #6972: Support LDAP authentication/authorization URL: https://github.com/apache/incubator-druid/pull/6972#discussion_r270208298 ## File path: extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authenticat

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #6972: Support LDAP authentication/authorization

2019-03-28 Thread GitBox
jon-wei commented on a change in pull request #6972: Support LDAP authentication/authorization URL: https://github.com/apache/incubator-druid/pull/6972#discussion_r270208298 ## File path: extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authenticat

[GitHub] [incubator-druid] yurmix commented on issue #7279: Move dev-related files and instructions to dev/ directory; add committer's instructions

2019-03-28 Thread GitBox
yurmix commented on issue #7279: Move dev-related files and instructions to dev/ directory; add committer's instructions URL: https://github.com/apache/incubator-druid/pull/7279#issuecomment-49479 @leventov looks nice! two small suggestions: 1. There is no hyperlink to `committer-ins

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7133: Time Ordering On Scans

2019-03-28 Thread GitBox
clintropolis commented on a change in pull request #7133: Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r270205022 ## File path: docs/content/querying/scan-query.md ## @@ -24,7 +24,16 @@ title: "Scan query" # Scan query -Sca

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7133: Time Ordering On Scans

2019-03-28 Thread GitBox
clintropolis commented on a change in pull request #7133: Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r270201441 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQueryLimitRowIterator.java ## @@ -81,12 +1

[GitHub] [incubator-druid] justinborromeo opened a new pull request #7373: [WIP] SQL support for time-ordered scan

2019-03-28 Thread GitBox
justinborromeo opened a new pull request #7373: [WIP] SQL support for time-ordered scan URL: https://github.com/apache/incubator-druid/pull/7373 Do not review - Just want to see what tests blow up This is an automated message

[GitHub] [incubator-druid] jon-wei commented on issue #6972: Support LDAP authentication/authorization

2019-03-28 Thread GitBox
jon-wei commented on issue #6972: Support LDAP authentication/authorization URL: https://github.com/apache/incubator-druid/pull/6972#issuecomment-48052 @mohammadjkhan @nishantmonu51 Given that the metadata store-backed and LDAP implementations have such different configurations,

[GitHub] [incubator-druid] surekhasaharan opened a new pull request #7372: Rename SegmentMetadataHolder to AvailableSegmentMetadata

2019-03-28 Thread GitBox
surekhasaharan opened a new pull request #7372: Rename SegmentMetadataHolder to AvailableSegmentMetadata URL: https://github.com/apache/incubator-druid/pull/7372 Some refactoring to address #7305 Rename `SegmentMetadataHolder` to `AvailableSegmentMetadata` Removed extra fields `i

[GitHub] [incubator-druid] mohammadjkhan commented on a change in pull request #6972: Support LDAP authentication/authorization

2019-03-28 Thread GitBox
mohammadjkhan commented on a change in pull request #6972: Support LDAP authentication/authorization URL: https://github.com/apache/incubator-druid/pull/6972#discussion_r270199562 ## File path: extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/autho

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7368: maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes

2019-03-28 Thread GitBox
jihoonson commented on a change in pull request #7368: maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes URL: https://github.com/apache/incubator-druid/pull/7368#discussion_r270195899 ## File path: server/src/main/java/org/apache/

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7368: maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes

2019-03-28 Thread GitBox
jihoonson commented on a change in pull request #7368: maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes URL: https://github.com/apache/incubator-druid/pull/7368#discussion_r270193948 ## File path: server/src/main/java/org/apache/

[GitHub] [incubator-druid] gianm commented on issue #7370: Add SQL support for time-ordered scans

2019-03-28 Thread GitBox
gianm commented on issue #7370: Add SQL support for time-ordered scans URL: https://github.com/apache/incubator-druid/issues/7370#issuecomment-477763460 > Scan is used if ordering by __time is specified Scan is already used if ordering by `__time` is _not_ specified so I suppose thi

[GitHub] [incubator-druid] mohammadjkhan commented on a change in pull request #6972: Support LDAP authentication/authorization

2019-03-28 Thread GitBox
mohammadjkhan commented on a change in pull request #6972: Support LDAP authentication/authorization URL: https://github.com/apache/incubator-druid/pull/6972#discussion_r270141007 ## File path: extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authe

[GitHub] [incubator-druid] shuqi7 opened a new pull request #7371: Support segment metadata query in SQL console

2019-03-28 Thread GitBox
shuqi7 opened a new pull request #7371: Support segment metadata query in SQL console URL: https://github.com/apache/incubator-druid/pull/7371 - Added the support for segment metadata query in web console - Refers to http://druid.io/docs/latest/querying/segmentmetadataquery.html - The

[GitHub] [incubator-druid] justinborromeo opened a new issue #7370: Add SQL support for time-ordered scans

2019-03-28 Thread GitBox
justinborromeo opened a new issue #7370: Add SQL support for time-ordered scans URL: https://github.com/apache/incubator-druid/issues/7370 ### Motivation See https://github.com/apache/incubator-druid/issues/6088 for original idea. PR #7133 is close to completion and the next step is

[GitHub] [incubator-druid] nishantmonu51 commented on a change in pull request #6972: Support LDAP authentication/authorization

2019-03-28 Thread GitBox
nishantmonu51 commented on a change in pull request #6972: Support LDAP authentication/authorization URL: https://github.com/apache/incubator-druid/pull/6972#discussion_r270102810 ## File path: extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authe

[GitHub] [incubator-druid] nishantmonu51 commented on a change in pull request #6972: Support LDAP authentication/authorization

2019-03-28 Thread GitBox
nishantmonu51 commented on a change in pull request #6972: Support LDAP authentication/authorization URL: https://github.com/apache/incubator-druid/pull/6972#discussion_r270156604 ## File path: extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authe

[GitHub] [incubator-druid] nishantmonu51 commented on a change in pull request #6972: Support LDAP authentication/authorization

2019-03-28 Thread GitBox
nishantmonu51 commented on a change in pull request #6972: Support LDAP authentication/authorization URL: https://github.com/apache/incubator-druid/pull/6972#discussion_r270158035 ## File path: extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authe

[GitHub] [incubator-druid] nishantmonu51 commented on a change in pull request #6972: Support LDAP authentication/authorization

2019-03-28 Thread GitBox
nishantmonu51 commented on a change in pull request #6972: Support LDAP authentication/authorization URL: https://github.com/apache/incubator-druid/pull/6972#discussion_r270154140 ## File path: extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/autho

[GitHub] [incubator-druid] nishantmonu51 commented on a change in pull request #6972: Support LDAP authentication/authorization

2019-03-28 Thread GitBox
nishantmonu51 commented on a change in pull request #6972: Support LDAP authentication/authorization URL: https://github.com/apache/incubator-druid/pull/6972#discussion_r270160290 ## File path: extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/autho

[GitHub] [incubator-druid] jihoonson commented on issue #7297: thetaSketch aggrgator handle null or "" into unexpected value at ingesting

2019-03-28 Thread GitBox
jihoonson commented on issue #7297: thetaSketch aggrgator handle null or "" into unexpected value at ingesting URL: https://github.com/apache/incubator-druid/issues/7297#issuecomment-477723441 @quenlang thanks for debugging. It sounds like a bug. I'll take a look. ---

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7368: maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes

2019-03-28 Thread GitBox
surekhasaharan commented on a change in pull request #7368: maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes URL: https://github.com/apache/incubator-druid/pull/7368#discussion_r270143851 ## File path: integration-tests/src/test

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7368: maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes

2019-03-28 Thread GitBox
surekhasaharan commented on a change in pull request #7368: maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes URL: https://github.com/apache/incubator-druid/pull/7368#discussion_r270140658 ## File path: server/src/main/java/org/a

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7368: maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes

2019-03-28 Thread GitBox
surekhasaharan commented on a change in pull request #7368: maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes URL: https://github.com/apache/incubator-druid/pull/7368#discussion_r270132800 ## File path: server/src/main/java/org/a

[GitHub] [incubator-druid] mohammadjkhan commented on a change in pull request #6972: Support LDAP authentication/authorization

2019-03-28 Thread GitBox
mohammadjkhan commented on a change in pull request #6972: Support LDAP authentication/authorization URL: https://github.com/apache/incubator-druid/pull/6972#discussion_r270141007 ## File path: extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authe

  1   2   >