[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation

2019-07-22 Thread GitBox
jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r306090195 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation

2019-07-22 Thread GitBox
jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r306090009 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation

2019-07-22 Thread GitBox
jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r306090058 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation

2019-07-22 Thread GitBox
jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r306090154 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation

2019-07-22 Thread GitBox
jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r306089210 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation

2019-07-22 Thread GitBox
jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r306089074 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation

2019-07-22 Thread GitBox
jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r306088954 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation

2019-07-22 Thread GitBox
jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r306088857 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation

2019-07-22 Thread GitBox
jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r306088817 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation

2019-07-22 Thread GitBox
jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r306088717 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation

2019-07-22 Thread GitBox
jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r306088679 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation

2019-07-22 Thread GitBox
jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r306088453 ## File path: services/src/main/java/org/apache/druid/cli/CliIndexer.java

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation

2019-07-22 Thread GitBox
jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r306088540 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation

2019-07-22 Thread GitBox
jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r306088453 ## File path: services/src/main/java/org/apache/druid/cli/CliIndexer.java

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation

2019-07-22 Thread GitBox
jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r306088380 ## File path: services/src/main/java/org/apache/druid/cli/CliIndexer.java

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation

2019-07-22 Thread GitBox
jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r306088362 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation

2019-07-22 Thread GitBox
jon-wei commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r306087390 ## File path:

[GitHub] [incubator-druid] vikramarsid edited a comment on issue #8130: Is there a way to view converted native query for a given sql statement

2019-07-22 Thread GitBox
vikramarsid edited a comment on issue #8130: Is there a way to view converted native query for a given sql statement URL: https://github.com/apache/incubator-druid/issues/8130#issuecomment-514004618 @vogievetsky Thank you, appreciate your quick response. I have tried `EXPLAIN PLAN FOR`

[GitHub] [incubator-druid] vikramarsid commented on issue #8130: Is there a way to view converted native query for a given sql statement

2019-07-22 Thread GitBox
vikramarsid commented on issue #8130: Is there a way to view converted native query for a given sql statement URL: https://github.com/apache/incubator-druid/issues/8130#issuecomment-514004618 @vogievetsky Thank you, appreciate your quick response. I have tried `EXPLAIN PLAN FOR` for

[GitHub] [incubator-druid] arrawatia closed pull request #8131: Add opencensus extensions

2019-07-22 Thread GitBox
arrawatia closed pull request #8131: Add opencensus extensions URL: https://github.com/apache/incubator-druid/pull/8131 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-druid] vogievetsky commented on issue #8130: Is there a way to view converted native query for a given sql statement

2019-07-22 Thread GitBox
vogievetsky commented on issue #8130: Is there a way to view converted native query for a given sql statement URL: https://github.com/apache/incubator-druid/issues/8130#issuecomment-514000859 Yes! Search https://druid.apache.org/docs/latest/querying/sql.html for `EXPLAIN` Or in

[GitHub] [incubator-druid] vogievetsky commented on issue #8123: SQL where equals subquery cannot build query plan

2019-07-22 Thread GitBox
vogievetsky commented on issue #8123: SQL where equals subquery cannot build query plan URL: https://github.com/apache/incubator-druid/issues/8123#issuecomment-514000258 I think the issue in your query is that it can not build a query plan on an aggregate. I just tested this:

[GitHub] [incubator-druid] vikramarsid opened a new issue #8130: Is there a way to view converted native query for sql statement

2019-07-22 Thread GitBox
vikramarsid opened a new issue #8130: Is there a way to view converted native query for sql statement URL: https://github.com/apache/incubator-druid/issues/8130 Is it possible to convert a SQL statement to a native query? Can we view(any logging option) native queries generated by the

[GitHub] [incubator-druid] jon-wei edited a comment on issue #7962: Killing hadoop ingestion task does not kill spawned Hadoop MR task

2019-07-22 Thread GitBox
jon-wei edited a comment on issue #7962: Killing hadoop ingestion task does not kill spawned Hadoop MR task URL: https://github.com/apache/incubator-druid/issues/7962#issuecomment-513987633 @ankit0811 Cool, thanks for checking. I had tested with a tiny dataset (the wikipedia

[GitHub] [incubator-druid] jon-wei commented on issue #7962: Killing hadoop ingestion task does not kill spawned Hadoop MR task

2019-07-22 Thread GitBox
jon-wei commented on issue #7962: Killing hadoop ingestion task does not kill spawned Hadoop MR task URL: https://github.com/apache/incubator-druid/issues/7962#issuecomment-513987633 @ankit0811 Cool, thanks for checking. I had tested with a tiny dataset (the wikipedia tutorial

[GitHub] [incubator-druid] stale[bot] commented on issue #6472: Add support for SQL-compatible null handling to movingAverage query

2019-07-22 Thread GitBox
stale[bot] commented on issue #6472: Add support for SQL-compatible null handling to movingAverage query URL: https://github.com/apache/incubator-druid/issues/6472#issuecomment-513984452 This issue has been marked as stale due to 280 days of inactivity. It will be closed in 4 weeks if no

[GitHub] [incubator-druid] Fokko opened a new pull request #8129: Spotbugs: NP_NONNULL_PARAM_VIOLATION

2019-07-22 Thread GitBox
Fokko opened a new pull request #8129: Spotbugs: NP_NONNULL_PARAM_VIOLATION URL: https://github.com/apache/incubator-druid/pull/8129 Enables `NP_NONNULL_PARAM_VIOLATION` in Spotbugs This is an automated message from the

[GitHub] [incubator-druid] himanshug commented on a change in pull request #8109: fix merging of groupBy subtotal spec results

2019-07-22 Thread GitBox
himanshug commented on a change in pull request #8109: fix merging of groupBy subtotal spec results URL: https://github.com/apache/incubator-druid/pull/8109#discussion_r306059305 ## File path: processing/src/main/java/org/apache/druid/query/groupby/strategy/GroupByStrategyV2.java

[GitHub] [incubator-druid] himanshug commented on a change in pull request #8109: fix merging of groupBy subtotal spec results

2019-07-22 Thread GitBox
himanshug commented on a change in pull request #8109: fix merging of groupBy subtotal spec results URL: https://github.com/apache/incubator-druid/pull/8109#discussion_r306059186 ## File path: processing/src/main/java/org/apache/druid/query/groupby/strategy/GroupByStrategyV2.java

[GitHub] [incubator-druid] himanshug commented on a change in pull request #8109: fix merging of groupBy subtotal spec results

2019-07-22 Thread GitBox
himanshug commented on a change in pull request #8109: fix merging of groupBy subtotal spec results URL: https://github.com/apache/incubator-druid/pull/8109#discussion_r306058870 ## File path: processing/src/main/java/org/apache/druid/query/groupby/strategy/GroupByStrategyV2.java

[GitHub] [incubator-druid] gianm commented on issue #8125: Leave a single CachePopulator and choose sync/async mode automatically

2019-07-22 Thread GitBox
gianm commented on issue #8125: Leave a single CachePopulator and choose sync/async mode automatically URL: https://github.com/apache/incubator-druid/issues/8125#issuecomment-513972679 By the way, after writing the above comment, now I'm starting to wonder if the design of the background

[GitHub] [incubator-druid] gianm commented on issue #8125: Leave a single CachePopulator and choose sync/async mode automatically

2019-07-22 Thread GitBox
gianm commented on issue #8125: Leave a single CachePopulator and choose sync/async mode automatically URL: https://github.com/apache/incubator-druid/issues/8125#issuecomment-513971684 Maybe it's just me, but I find foreground/background and sync/async to be equally understandable.

[GitHub] [incubator-druid] gianm commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention

2019-07-22 Thread GitBox
gianm commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention URL: https://github.com/apache/incubator-druid/pull/8116#discussion_r306044913 ## File path:

[GitHub] [incubator-druid] gianm commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention

2019-07-22 Thread GitBox
gianm commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention URL: https://github.com/apache/incubator-druid/pull/8116#discussion_r306041975 ## File path: docs/content/configuration/index.md ## @@

[GitHub] [incubator-druid] gianm commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention

2019-07-22 Thread GitBox
gianm commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention URL: https://github.com/apache/incubator-druid/pull/8116#discussion_r306041975 ## File path: docs/content/configuration/index.md ## @@

[GitHub] [incubator-druid] gianm commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention

2019-07-22 Thread GitBox
gianm commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention URL: https://github.com/apache/incubator-druid/pull/8116#discussion_r306041975 ## File path: docs/content/configuration/index.md ## @@

[GitHub] [incubator-druid] gianm commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention

2019-07-22 Thread GitBox
gianm commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention URL: https://github.com/apache/incubator-druid/pull/8116#discussion_r306039479 ## File path: docs/content/configuration/index.md ## @@

[GitHub] [incubator-druid] gianm commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention

2019-07-22 Thread GitBox
gianm commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention URL: https://github.com/apache/incubator-druid/pull/8116#discussion_r306039479 ## File path: docs/content/configuration/index.md ## @@

[GitHub] [incubator-druid] gianm commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention

2019-07-22 Thread GitBox
gianm commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention URL: https://github.com/apache/incubator-druid/pull/8116#discussion_r306039479 ## File path: docs/content/configuration/index.md ## @@

[GitHub] [incubator-druid] gianm commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention

2019-07-22 Thread GitBox
gianm commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention URL: https://github.com/apache/incubator-druid/pull/8116#discussion_r306037681 ## File path: docs/content/configuration/index.md ## @@

[GitHub] [incubator-druid] himanshug edited a comment on issue #8071: add aggregators for computing mean/average

2019-07-22 Thread GitBox
himanshug edited a comment on issue #8071: add aggregators for computing mean/average URL: https://github.com/apache/incubator-druid/issues/8071#issuecomment-513954218 yeah that algorithm is to avoid overflowing `sum` . You are right that instructions for divisions are slower in theory

[GitHub] [incubator-druid] himanshug commented on issue #8071: add aggregators for computing mean/average

2019-07-22 Thread GitBox
himanshug commented on issue #8071: add aggregators for computing mean/average URL: https://github.com/apache/incubator-druid/issues/8071#issuecomment-513954218 yeah that algorithm is to avoid overflowing `sum` . You are right that instructions for divisions are slower in theory (but

[GitHub] [incubator-druid] himanshug commented on issue #8031: remove unnecessary synchronization overhead from complex Aggregators

2019-07-22 Thread GitBox
himanshug commented on issue #8031: remove unnecessary synchronization overhead from complex Aggregators URL: https://github.com/apache/incubator-druid/issues/8031#issuecomment-513949670 related to https://github.com/apache/incubator-druid/issues/8126 which removes usage of `Aggregator`

[GitHub] [incubator-druid] himanshug commented on issue #6743: IncrementalIndex generally overestimates theta sketch size

2019-07-22 Thread GitBox
himanshug commented on issue #6743: IncrementalIndex generally overestimates theta sketch size URL: https://github.com/apache/incubator-druid/issues/6743#issuecomment-513948436 @gianm https://github.com/apache/incubator-druid/issues/8126

[GitHub] [incubator-druid] ccaominh opened a new pull request #8128: Fix dependency analyze warnings

2019-07-22 Thread GitBox
ccaominh opened a new pull request #8128: Fix dependency analyze warnings URL: https://github.com/apache/incubator-druid/pull/8128 ### Description Update the maven dependency plugin to the latest version and fix all warnings for unused declared and used undeclared dependencies in

[GitHub] [incubator-druid] himanshug opened a new pull request #8127: [WIP]growable sketch aggregator support

2019-07-22 Thread GitBox
himanshug opened a new pull request #8127: [WIP]growable sketch aggregator support URL: https://github.com/apache/incubator-druid/pull/8127 WIP PR for https://github.com/apache/incubator-druid/issues/8126 to explain the idea in code.

[GitHub] [incubator-druid] himanshug opened a new issue #8126: [Proposal] BufferAggregator support for growable sketches.

2019-07-22 Thread GitBox
himanshug opened a new issue #8126: [Proposal] BufferAggregator support for growable sketches. URL: https://github.com/apache/incubator-druid/issues/8126 ### Motivation 1. From #6743 "Theta sketches have a very large max size by default, relative to typical row sizes (about

[GitHub] [incubator-druid] leventov edited a comment on issue #7458: New Coordinator segment balancing/loading algorithm

2019-07-22 Thread GitBox
leventov edited a comment on issue #7458: New Coordinator segment balancing/loading algorithm URL: https://github.com/apache/incubator-druid/issues/7458#issuecomment-482689404 > There was discussion previously about what can/should be done in an extension vs what must be done in core

[GitHub] [incubator-druid] leventov commented on issue #7383: Segments governed by BroadcastDistributionRules shouldn't be moved away from decommissioning servers until all non-broadcasted segments ar

2019-07-22 Thread GitBox
leventov commented on issue #7383: Segments governed by BroadcastDistributionRules shouldn't be moved away from decommissioning servers until all non-broadcasted segments are moved away URL: https://github.com/apache/incubator-druid/issues/7383#issuecomment-513915326 There are many small

[GitHub] [incubator-druid] leventov commented on issue #7392: Split MetadataSegmentView in two implementations: caching and direct RPC call

2019-07-22 Thread GitBox
leventov commented on issue #7392: Split MetadataSegmentView in two implementations: caching and direct RPC call URL: https://github.com/apache/incubator-druid/issues/7392#issuecomment-513914628 In the future, we may split it and add a third implementation: brokers polling metadata store

[GitHub] [incubator-druid] leventov opened a new issue #7391: MetadataSegmentView should correctly handle the situation of Coordinator being down or changed leadership

2019-07-22 Thread GitBox
leventov opened a new issue #7391: MetadataSegmentView should correctly handle the situation of Coordinator being down or changed leadership URL: https://github.com/apache/incubator-druid/issues/7391 Regardless of whether any of the designs proposed for `MetadataSegmentView` here:

[GitHub] [incubator-druid] stale[bot] commented on issue #7391: MetadataSegmentView should correctly handle the situation of Coordinator being down or changed leadership

2019-07-22 Thread GitBox
stale[bot] commented on issue #7391: MetadataSegmentView should correctly handle the situation of Coordinator being down or changed leadership URL: https://github.com/apache/incubator-druid/issues/7391#issuecomment-513913276 This issue is no longer marked as stale.

[GitHub] [incubator-druid] stale[bot] commented on issue #7361: Rename Overlord task "shutdown" to "cancel"

2019-07-22 Thread GitBox
stale[bot] commented on issue #7361: Rename Overlord task "shutdown" to "cancel" URL: https://github.com/apache/incubator-druid/issues/7361#issuecomment-513912788 This issue is no longer marked as stale. This is an

[GitHub] [incubator-druid] stale[bot] commented on issue #7382: BroadcastDistributionRules to load segments on whole tiers rather than making server-by-server decisions

2019-07-22 Thread GitBox
stale[bot] commented on issue #7382: BroadcastDistributionRules to load segments on whole tiers rather than making server-by-server decisions URL: https://github.com/apache/incubator-druid/issues/7382#issuecomment-513912923 This issue is no longer marked as stale.

[GitHub] [incubator-druid] leventov opened a new issue #7382: BroadcastDistributionRules to load segments on whole tiers rather than making server-by-server decisions

2019-07-22 Thread GitBox
leventov opened a new issue #7382: BroadcastDistributionRules to load segments on whole tiers rather than making server-by-server decisions URL: https://github.com/apache/incubator-druid/issues/7382 Broadcast rules which load segments on servers with colocated data sources

[GitHub] [incubator-druid] leventov opened a new issue #7361: Rename Overlord task "shutdown" to "cancel"

2019-07-22 Thread GitBox
leventov opened a new issue #7361: Rename Overlord task "shutdown" to "cancel" URL: https://github.com/apache/incubator-druid/issues/7361 It seems to be an unfortunate name because "shutdown" sounds like a type of task itself, not a task cancellation request. For retaining backward

[GitHub] [incubator-druid] leventov opened a new issue #7354: DruidCoordinatorBalancer shouldn't move broadcasted segments

2019-07-22 Thread GitBox
leventov opened a new issue #7354: DruidCoordinatorBalancer shouldn't move broadcasted segments URL: https://github.com/apache/incubator-druid/issues/7354 `DruidCoordinatorBalancer` shouldn't try to move segments which are broadcasted using any `BroadcastDistributionRule`. Similar

[GitHub] [incubator-druid] stale[bot] commented on issue #7354: DruidCoordinatorBalancer shouldn't move broadcasted segments

2019-07-22 Thread GitBox
stale[bot] commented on issue #7354: DruidCoordinatorBalancer shouldn't move broadcasted segments URL: https://github.com/apache/incubator-druid/issues/7354#issuecomment-513912344 This issue is no longer marked as stale.

[GitHub] [incubator-druid] leventov opened a new issue #7344: Coordinator to kick off a new run when loading queues are sufficiently empty

2019-07-22 Thread GitBox
leventov opened a new issue #7344: Coordinator to kick off a new run when loading queues are sufficiently empty URL: https://github.com/apache/incubator-druid/issues/7344 After #7159 is fixed, Coordinator can start a new run as soon as the total number of loading segments drops below the

[GitHub] [incubator-druid] stale[bot] commented on issue #7344: Coordinator to kick off a new run when loading queues are sufficiently empty

2019-07-22 Thread GitBox
stale[bot] commented on issue #7344: Coordinator to kick off a new run when loading queues are sufficiently empty URL: https://github.com/apache/incubator-druid/issues/7344#issuecomment-513912231 This issue is no longer marked as stale.

[GitHub] [incubator-druid] leventov opened a new issue #7159: On "balancing burst, then wait total loading" pattern and replication/loading cap in Coordinator balancing

2019-07-22 Thread GitBox
leventov opened a new issue #7159: On "balancing burst, then wait total loading" pattern and replication/loading cap in Coordinator balancing URL: https://github.com/apache/incubator-druid/issues/7159 Druid's segment balancing logic is split between two classes: `DruidCoordinatorBalancer`

[GitHub] [incubator-druid] stale[bot] commented on issue #7340: Facilitate testing AggregatorFactory (e. g. its makeAggregateCombiner() method) and AggregateCombiner

2019-07-22 Thread GitBox
stale[bot] commented on issue #7340: Facilitate testing AggregatorFactory (e. g. its makeAggregateCombiner() method) and AggregateCombiner URL: https://github.com/apache/incubator-druid/issues/7340#issuecomment-513912004 This issue is no longer marked as stale.

[GitHub] [incubator-druid] stale[bot] commented on issue #7159: On "balancing burst, then wait total loading" pattern and replication/loading cap in Coordinator balancing

2019-07-22 Thread GitBox
stale[bot] commented on issue #7159: On "balancing burst, then wait total loading" pattern and replication/loading cap in Coordinator balancing URL: https://github.com/apache/incubator-druid/issues/7159#issuecomment-513912143 This issue is no longer marked as stale.

[GitHub] [incubator-druid] leventov opened a new issue #7340: Facilitate testing AggregatorFactory (e. g. its makeAggregateCombiner() method) and AggregateCombiner

2019-07-22 Thread GitBox
leventov opened a new issue #7340: Facilitate testing AggregatorFactory (e. g. its makeAggregateCombiner() method) and AggregateCombiner URL: https://github.com/apache/incubator-druid/issues/7340 `AggregateCombiner` is currently hard to test because it accepts works with

[GitHub] [incubator-druid] leventov commented on issue #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention

2019-07-22 Thread GitBox
leventov commented on issue #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention URL: https://github.com/apache/incubator-druid/pull/8116#issuecomment-513911726 This PR inspired me to create this issue: #8125.

[GitHub] [incubator-druid] leventov opened a new issue #8125: Leave a single CachePopulator and choose sync/async mode automatically

2019-07-22 Thread GitBox
leventov opened a new issue #8125: Leave a single CachePopulator and choose sync/async mode automatically URL: https://github.com/apache/incubator-druid/issues/8125 In this issue, I list several ideas regarding refactoring/improvement of `CachePopulator` subsystem. 1. It seems to

[GitHub] [incubator-druid] leventov commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention

2019-07-22 Thread GitBox
leventov commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention URL: https://github.com/apache/incubator-druid/pull/8116#discussion_r305976377 ## File path: docs/content/configuration/index.md ## @@

[GitHub] [incubator-druid] leventov commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention

2019-07-22 Thread GitBox
leventov commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention URL: https://github.com/apache/incubator-druid/pull/8116#discussion_r305973396 ## File path: docs/content/configuration/index.md ## @@

[GitHub] [incubator-druid] leventov commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention

2019-07-22 Thread GitBox
leventov commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention URL: https://github.com/apache/incubator-druid/pull/8116#discussion_r305977397 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention

2019-07-22 Thread GitBox
leventov commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention URL: https://github.com/apache/incubator-druid/pull/8116#discussion_r305970857 ## File path: docs/content/configuration/index.md ## @@

[GitHub] [incubator-druid] leventov commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention

2019-07-22 Thread GitBox
leventov commented on a change in pull request #8116: remove unnecessary lock in ForegroundCachePopulator leading to a lot of contention URL: https://github.com/apache/incubator-druid/pull/8116#discussion_r305971958 ## File path: docs/content/configuration/index.md ## @@

[GitHub] [incubator-druid] Fokko commented on issue #8006: Bump commons-io from 2.5 to 2.6

2019-07-22 Thread GitBox
Fokko commented on issue #8006: Bump commons-io from 2.5 to 2.6 URL: https://github.com/apache/incubator-druid/pull/8006#issuecomment-513907299 @asdf2014 Any thoughts? This is an automated message from the Apache Git Service.

[GitHub] [incubator-druid] Fokko commented on issue #8076: Spotbugs: RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN

2019-07-22 Thread GitBox
Fokko commented on issue #8076: Spotbugs: RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN URL: https://github.com/apache/incubator-druid/pull/8076#issuecomment-513906370 @dclim Time to look at this one? This is an automated message

[GitHub] [incubator-druid] dclim commented on issue #8117: Web console added to docker-compose

2019-07-22 Thread GitBox
dclim commented on issue #8117: Web console added to docker-compose URL: https://github.com/apache/incubator-druid/pull/8117#issuecomment-513904395  This is an automated message from the Apache Git Service. To respond to

[incubator-druid] branch master updated: web console added to docker-compose (#8117)

2019-07-22 Thread davidlim
This is an automated email from the ASF dual-hosted git repository. davidlim pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new b2867c9 web console added to

[GitHub] [incubator-druid] dclim merged pull request #8117: Web console added to docker-compose

2019-07-22 Thread GitBox
dclim merged pull request #8117: Web console added to docker-compose URL: https://github.com/apache/incubator-druid/pull/8117 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-druid] acdn-mpreston commented on issue #7926: Kafka Indexing breaks due to Mismatched DatSourceMetadata types during InternalReset call

2019-07-22 Thread GitBox
acdn-mpreston commented on issue #7926: Kafka Indexing breaks due to Mismatched DatSourceMetadata types during InternalReset call URL: https://github.com/apache/incubator-druid/issues/7926#issuecomment-513903778 @gvsmirnov yes, the issue can happen on a clean install as well, the upgrade

[GitHub] [incubator-druid] sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations

2019-07-22 Thread GitBox
sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations URL: https://github.com/apache/incubator-druid/pull/8038#issuecomment-513899084 @jihoonson , @himanshug , @dclim , @nishantmonu51 have you had a chance to review this ?

[GitHub] [incubator-druid] AlexanderSaydakov commented on issue #8095: Incorrect quantiles result produced by quantilesDoublesSketch

2019-07-22 Thread GitBox
AlexanderSaydakov commented on issue #8095: Incorrect quantiles result produced by quantilesDoublesSketch URL: https://github.com/apache/incubator-druid/issues/8095#issuecomment-513898178 > is there other bugfixes for theta sketch to be released in 0.16.0? Yes, the fix in 14.2 was not

[GitHub] [incubator-druid] Fokko commented on issue #8005: Enable Spotbugs: WMI_WRONG_MAP_ITERATOR

2019-07-22 Thread GitBox
Fokko commented on issue #8005: Enable Spotbugs: WMI_WRONG_MAP_ITERATOR URL: https://github.com/apache/incubator-druid/pull/8005#issuecomment-513891014 @asdf2014 WDYT? This is an automated message from the Apache Git Service.

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation

2019-07-22 Thread GitBox
jihoonson commented on a change in pull request #8107: Add CliIndexer process type and initial task runner implementation URL: https://github.com/apache/incubator-druid/pull/8107#discussion_r305696049 ## File path:

[GitHub] [incubator-druid] mcbrewster opened a new pull request #8124: add lookups tile to home view

2019-07-22 Thread GitBox
mcbrewster opened a new pull request #8124: add lookups tile to home view URL: https://github.com/apache/incubator-druid/pull/8124 https://user-images.githubusercontent.com/37322608/61653579-78d3bb00-ac6f-11e9-8f72-3d095f914d94.png;> Adds a tile to the home view that takes the user

[GitHub] [incubator-druid] saulfrank commented on issue #8123: SQL where equals subquery cannot build query plan

2019-07-22 Thread GitBox
saulfrank commented on issue #8123: SQL where equals subquery cannot build query plan URL: https://github.com/apache/incubator-druid/issues/8123#issuecomment-513882565 There are multiple records so that would have to be in the subquery. I tried putting that in the subquery and it still

[GitHub] [incubator-druid] vogievetsky commented on issue #8123: SQL where equals subquery cannot build query plan

2019-07-22 Thread GitBox
vogievetsky commented on issue #8123: SQL where equals subquery cannot build query plan URL: https://github.com/apache/incubator-druid/issues/8123#issuecomment-513869264 Looks like you want to look at the last event (or few events) in your datasource. As of Druid 0.15.0 you can do:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8110: Response context refactoring

2019-07-22 Thread GitBox
leventov commented on a change in pull request #8110: Response context refactoring URL: https://github.com/apache/incubator-druid/pull/8110#discussion_r305919720 ## File path: processing/src/main/java/org/apache/druid/query/spec/SpecificSegmentQueryRunner.java ## @@

[GitHub] [incubator-druid] leventov commented on a change in pull request #8110: Response context refactoring

2019-07-22 Thread GitBox
leventov commented on a change in pull request #8110: Response context refactoring URL: https://github.com/apache/incubator-druid/pull/8110#discussion_r305919720 ## File path: processing/src/main/java/org/apache/druid/query/spec/SpecificSegmentQueryRunner.java ## @@

[GitHub] [incubator-druid] vogievetsky commented on issue #8121: Query statement generates an exception

2019-07-22 Thread GitBox
vogievetsky commented on issue #8121: Query statement generates an exception URL: https://github.com/apache/incubator-druid/issues/8121#issuecomment-513858220 you can not do a raw select query (non group by) in Druid that orders by something other than `__time`

[GitHub] [incubator-druid] saulfrank opened a new issue #8123: SQL where equals subquery cannot build query plan

2019-07-22 Thread GitBox
saulfrank opened a new issue #8123: SQL where equals subquery cannot build query plan URL: https://github.com/apache/incubator-druid/issues/8123 ### Affected Version Version 0.15.0 ### Description This query produces: Unknown exception

[GitHub] [incubator-druid] gvsmirnov commented on issue #7926: Kafka Indexing breaks due to Mismatched DatSourceMetadata types during InternalReset call

2019-07-22 Thread GitBox
gvsmirnov commented on issue #7926: Kafka Indexing breaks due to Mismatched DatSourceMetadata types during InternalReset call URL: https://github.com/apache/incubator-druid/issues/7926#issuecomment-513840688 @acdn-mpreston thanks for getting back to me. To clarify my case, I got this

[GitHub] [incubator-druid] gvsmirnov edited a comment on issue #7926: Kafka Indexing breaks due to Mismatched DatSourceMetadata types during InternalReset call

2019-07-22 Thread GitBox
gvsmirnov edited a comment on issue #7926: Kafka Indexing breaks due to Mismatched DatSourceMetadata types during InternalReset call URL: https://github.com/apache/incubator-druid/issues/7926#issuecomment-513840688 @acdn-mpreston thanks for getting back to me. To clarify my case, I got

[GitHub] [incubator-druid] acdn-mpreston commented on issue #7926: Kafka Indexing breaks due to Mismatched DatSourceMetadata types during InternalReset call

2019-07-22 Thread GitBox
acdn-mpreston commented on issue #7926: Kafka Indexing breaks due to Mismatched DatSourceMetadata types during InternalReset call URL: https://github.com/apache/incubator-druid/issues/7926#issuecomment-513837488 @gvsmirnov I am still unclear as to the root cause of the issue, but the way

[GitHub] [incubator-druid] anselvahle opened a new issue #8122: Allow for union of query data sources

2019-07-22 Thread GitBox
anselvahle opened a new issue #8122: Allow for union of query data sources URL: https://github.com/apache/incubator-druid/issues/8122 ### Description There are two concepts of `union` in Druid. There is `UNION ALL` in SQL, which concatenates the results of two or more SQL queries.

[GitHub] [incubator-druid] saulfrank commented on issue #1641: Inner Query should build on sub query

2019-07-22 Thread GitBox
saulfrank commented on issue #1641: Inner Query should build on sub query URL: https://github.com/apache/incubator-druid/issues/1641#issuecomment-513823295 I am still getting an error using a subquery - should this be doable? Unknown exception

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #8110: Response context refactoring

2019-07-22 Thread GitBox
esevastyanov commented on a change in pull request #8110: Response context refactoring URL: https://github.com/apache/incubator-druid/pull/8110#discussion_r305835327 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -0,0

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #8110: Response context refactoring

2019-07-22 Thread GitBox
esevastyanov commented on a change in pull request #8110: Response context refactoring URL: https://github.com/apache/incubator-druid/pull/8110#discussion_r305835052 ## File path: indexing-service/.gitignore ## @@ -0,0 +1,2 @@ +foo Review comment: removed

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #8110: Response context refactoring

2019-07-22 Thread GitBox
esevastyanov commented on a change in pull request #8110: Response context refactoring URL: https://github.com/apache/incubator-druid/pull/8110#discussion_r305834582 ## File path: indexing-service/.gitignore ## @@ -0,0 +1,2 @@ +foo Review comment: I'm not sure which

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #8110: Response context refactoring

2019-07-22 Thread GitBox
esevastyanov commented on a change in pull request #8110: Response context refactoring URL: https://github.com/apache/incubator-druid/pull/8110#discussion_r305824066 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -0,0

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #8110: Response context refactoring

2019-07-22 Thread GitBox
esevastyanov commented on a change in pull request #8110: Response context refactoring URL: https://github.com/apache/incubator-druid/pull/8110#discussion_r305822424 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -0,0

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #8110: Response context refactoring

2019-07-22 Thread GitBox
esevastyanov commented on a change in pull request #8110: Response context refactoring URL: https://github.com/apache/incubator-druid/pull/8110#discussion_r305821917 ## File path: server/src/main/java/org/apache/druid/server/QueryResource.java ## @@ -83,6 +83,7 @@

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #8110: Response context refactoring

2019-07-22 Thread GitBox
esevastyanov commented on a change in pull request #8110: Response context refactoring URL: https://github.com/apache/incubator-druid/pull/8110#discussion_r305818660 ## File path: processing/src/main/java/org/apache/druid/query/spec/SpecificSegmentQueryRunner.java ## @@

  1   2   >