[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8047: optimize single input column multi-value expressions

clintropolis commented on a change in pull request #8047: optimize single input column multi-value expressions URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309544405 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -304,7

[GitHub] [incubator-druid] vogievetsky opened a new pull request #8213: Web console: add timeout to capabilities check

vogievetsky opened a new pull request #8213: Web console: add timeout to capabilities check URL: https://github.com/apache/incubator-druid/pull/8213 Checking if SQL is enables should be fast and should not hang. Also it is important to escape the SQL columns! ![image](https://user-

[GitHub] [incubator-druid] pjain1 commented on a change in pull request #8157: Enum of ResponseContext keys

pjain1 commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r309535072 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -76,56 +253,158

[GitHub] [incubator-druid] clintropolis opened a new pull request #8212: [Backport] Adjust NOTICE files

clintropolis opened a new pull request #8212: [Backport] Adjust NOTICE files URL: https://github.com/apache/incubator-druid/pull/8212 Backport of #7945 to 0.15.1-incubating. This is an automated message from the Apache Git Ser

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8197: Add IPv4 druid expressions

ccaominh commented on a change in pull request #8197: Add IPv4 druid expressions URL: https://github.com/apache/incubator-druid/pull/8197#discussion_r309524494 ## File path: processing/src/main/java/org/apache/druid/query/expression/IPv4AddressExprUtils.java ## @@ -0,0 +1,

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8197: Add IPv4 druid expressions

ccaominh commented on a change in pull request #8197: Add IPv4 druid expressions URL: https://github.com/apache/incubator-druid/pull/8197#discussion_r309524334 ## File path: processing/src/main/java/org/apache/druid/query/expression/IPv4AddressMatchExprMacro.java ## @@ -0,

[GitHub] [incubator-druid] dclim commented on issue #8154: Fix `is_realtime` column behavior in sys.segments table

dclim commented on issue #8154: Fix `is_realtime` column behavior in sys.segments table URL: https://github.com/apache/incubator-druid/pull/8154#issuecomment-517113826 👍 This is an automated message from the Apache Git Servic

[GitHub] [incubator-druid] dclim closed issue #8142: sys.segment's is_realtime flag once set, is never unset

dclim closed issue #8142: sys.segment's is_realtime flag once set, is never unset URL: https://github.com/apache/incubator-druid/issues/8142 This is an automated message from the Apache Git Service. To respond to the message

[incubator-druid] branch master updated: Fix `is_realtime` column behavior in sys.segments table (#8154)

This is an automated email from the ASF dual-hosted git repository. davidlim pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new f0ecdfe Fix `is_realtime` column beh

[GitHub] [incubator-druid] dclim merged pull request #8154: Fix `is_realtime` column behavior in sys.segments table

dclim merged pull request #8154: Fix `is_realtime` column behavior in sys.segments table URL: https://github.com/apache/incubator-druid/pull/8154 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [incubator-druid] Yuqingmu opened a new issue #8211: Check the Writable and Readable validity of the connection

Yuqingmu opened a new issue #8211: Check the Writable and Readable validity of the connection URL: https://github.com/apache/incubator-druid/issues/8211 Hi! We have a problem,That is mysql master-slave switch,but there is have DNS cache,So maybe druid still connect a Writable datab

[GitHub] [incubator-druid] vogievetsky commented on issue #8210: Web-Console: add go to task for datasources

vogievetsky commented on issue #8210: Web-Console: add go to task for datasources URL: https://github.com/apache/incubator-druid/pull/8210#issuecomment-517104050 @fjy that totes makes sense but I think out of scope if this particular PR. It is coming though. --

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #8210: Web-Console: add go to task for datasources

vogievetsky commented on a change in pull request #8210: Web-Console: add go to task for datasources URL: https://github.com/apache/incubator-druid/pull/8210#discussion_r309510572 ## File path: web-console/src/views/task-view/tasks-view.tsx ## @@ -208,7 +210,16 @@ ORDER BY

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8047: optimize single input column multi-value expressions

clintropolis commented on a change in pull request #8047: optimize single input column multi-value expressions URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309503937 ## File path: processing/src/main/java/org/apache/druid/segment/virtual/ExpressionSelectors.

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8047: optimize single input column multi-value expressions

clintropolis commented on a change in pull request #8047: optimize single input column multi-value expressions URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309503545 ## File path: processing/src/test/java/org/apache/druid/segment/filter/ExpressionFilterTest.

[GitHub] [incubator-druid] gianm commented on a change in pull request #8197: Add IPv4 druid expressions

gianm commented on a change in pull request #8197: Add IPv4 druid expressions URL: https://github.com/apache/incubator-druid/pull/8197#discussion_r309503072 ## File path: processing/src/main/java/org/apache/druid/query/expression/IPv4AddressExprUtils.java ## @@ -0,0 +1,82

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8047: optimize single input column multi-value expressions

clintropolis commented on a change in pull request #8047: optimize single input column multi-value expressions URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309503183 ## File path: core/src/main/java/org/apache/druid/math/expr/Function.java ## @@ -76

[GitHub] [incubator-druid] gianm commented on a change in pull request #8197: Add IPv4 druid expressions

gianm commented on a change in pull request #8197: Add IPv4 druid expressions URL: https://github.com/apache/incubator-druid/pull/8197#discussion_r309502150 ## File path: processing/src/main/java/org/apache/druid/query/expression/IPv4AddressMatchExprMacro.java ## @@ -0,0 +

[GitHub] [incubator-druid] gianm commented on a change in pull request #8197: Add IPv4 druid expressions

gianm commented on a change in pull request #8197: Add IPv4 druid expressions URL: https://github.com/apache/incubator-druid/pull/8197#discussion_r309480617 ## File path: docs/content/misc/math-expr.md ## @@ -195,3 +195,11 @@ See javadoc of java.lang.Math for detailed expla

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8047: optimize single input column multi-value expressions

clintropolis commented on a change in pull request #8047: optimize single input column multi-value expressions URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309502963 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -304,7

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8047: optimize single input column multi-value expressions

clintropolis commented on a change in pull request #8047: optimize single input column multi-value expressions URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309503012 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -824,7

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8047: optimize single input column multi-value expressions

clintropolis commented on a change in pull request #8047: optimize single input column multi-value expressions URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309503046 ## File path: core/src/main/java/org/apache/druid/math/expr/Function.java ## @@ -76

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8047: optimize single input column multi-value expressions

clintropolis commented on a change in pull request #8047: optimize single input column multi-value expressions URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309502912 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -248,6

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8047: optimize single input column multi-value expressions

clintropolis commented on a change in pull request #8047: optimize single input column multi-value expressions URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309502340 ## File path: core/src/main/java/org/apache/druid/math/expr/ApplyFunction.java ## @

[GitHub] [incubator-druid] asdf2014 merged pull request #8201: Simple memory allocation for CliIndexer tasks

asdf2014 merged pull request #8201: Simple memory allocation for CliIndexer tasks URL: https://github.com/apache/incubator-druid/pull/8201 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-druid] branch master updated: Simple memory allocation for CliIndexer tasks (#8201)

This is an automated email from the ASF dual-hosted git repository. asdf2014 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 41893d4 Simple memory allocation for

[GitHub] [incubator-druid] gianm commented on a change in pull request #8047: optimize single input column multi-value expressions

gianm commented on a change in pull request #8047: optimize single input column multi-value expressions URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309497062 ## File path: processing/src/main/java/org/apache/druid/segment/virtual/ExpressionSelectors.java #

[GitHub] [incubator-druid] gianm commented on a change in pull request #8047: optimize single input column multi-value expressions

gianm commented on a change in pull request #8047: optimize single input column multi-value expressions URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309495761 ## File path: processing/src/main/java/org/apache/druid/segment/virtual/ExpressionSelectors.java #

[GitHub] [incubator-druid] gianm commented on a change in pull request #8047: optimize single input column multi-value expressions

gianm commented on a change in pull request #8047: optimize single input column multi-value expressions URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309491269 ## File path: core/src/main/java/org/apache/druid/math/expr/Function.java ## @@ -76,6 +76,

[GitHub] [incubator-druid] gianm commented on a change in pull request #8047: optimize single input column multi-value expressions

gianm commented on a change in pull request #8047: optimize single input column multi-value expressions URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309002377 ## File path: core/src/main/java/org/apache/druid/math/expr/ApplyFunction.java ## @@ -60,6

[GitHub] [incubator-druid] gianm commented on a change in pull request #8047: optimize single input column multi-value expressions

gianm commented on a change in pull request #8047: optimize single input column multi-value expressions URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309491377 ## File path: core/src/main/java/org/apache/druid/math/expr/Function.java ## @@ -76,6 +76,

[GitHub] [incubator-druid] gianm commented on a change in pull request #8047: optimize single input column multi-value expressions

gianm commented on a change in pull request #8047: optimize single input column multi-value expressions URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309495618 ## File path: processing/src/test/java/org/apache/druid/segment/filter/ExpressionFilterTest.java #

[GitHub] [incubator-druid] gianm commented on a change in pull request #8047: optimize single input column multi-value expressions

gianm commented on a change in pull request #8047: optimize single input column multi-value expressions URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309489998 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -304,7 +334,37

[GitHub] [incubator-druid] gianm commented on a change in pull request #8047: optimize single input column multi-value expressions

gianm commented on a change in pull request #8047: optimize single input column multi-value expressions URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309489786 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -248,6 +256,24

[GitHub] [incubator-druid] gianm commented on a change in pull request #8047: optimize single input column multi-value expressions

gianm commented on a change in pull request #8047: optimize single input column multi-value expressions URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309490852 ## File path: core/src/main/java/org/apache/druid/math/expr/Expr.java ## @@ -824,7 +888,12

[GitHub] [incubator-druid] gianm commented on a change in pull request #8047: optimize single input column multi-value expressions

gianm commented on a change in pull request #8047: optimize single input column multi-value expressions URL: https://github.com/apache/incubator-druid/pull/8047#discussion_r309472589 ## File path: processing/src/test/java/org/apache/druid/query/groupby/GroupByQueryRunnerTest.java

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8197: Add IPv4 druid expressions

clintropolis commented on a change in pull request #8197: Add IPv4 druid expressions URL: https://github.com/apache/incubator-druid/pull/8197#discussion_r309482129 ## File path: processing/src/main/java/org/apache/druid/query/expression/IPv4AddressMatchExprMacro.java ## @

[GitHub] [incubator-druid] gianm commented on a change in pull request #8154: Fix `is_realtime` column behavior in sys.segments table

gianm commented on a change in pull request #8154: Fix `is_realtime` column behavior in sys.segments table URL: https://github.com/apache/incubator-druid/pull/8154#discussion_r309484150 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchema.java ##

[GitHub] [incubator-druid] fjy commented on issue #8210: Web-Console: add go to task for datasources

fjy commented on issue #8210: Web-Console: add go to task for datasources URL: https://github.com/apache/incubator-druid/pull/8210#issuecomment-517071666 I wish I could see number of tasks running as a column in the table, then click into those tasks to reach the tasks views. -

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8154: Fix `is_realtime` column behavior in sys.segments table

jon-wei commented on a change in pull request #8154: Fix `is_realtime` column behavior in sys.segments table URL: https://github.com/apache/incubator-druid/pull/8154#discussion_r309483085 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchema.java

[GitHub] [incubator-druid] mcbrewster commented on a change in pull request #8210: Web-Console: add go to task for datasources

mcbrewster commented on a change in pull request #8210: Web-Console: add go to task for datasources URL: https://github.com/apache/incubator-druid/pull/8210#discussion_r309480263 ## File path: web-console/src/views/task-view/tasks-view.tsx ## @@ -208,7 +210,16 @@ ORDER BY

[GitHub] [incubator-druid] mcbrewster opened a new pull request #8210: Web-Console: add go to task for datasources

mcbrewster opened a new pull request #8210: Web-Console: add go to task for datasources URL: https://github.com/apache/incubator-druid/pull/8210 ![localhost_18081_unified-console html (19)](https://user-images.githubusercontent.com/37322608/62256282-7d0d8000-b3b5-11e9-87ce-e99c632eb70a

[GitHub] [incubator-druid] clintropolis closed pull request #6633: make bitmap index usage optional for bloom filters

clintropolis closed pull request #6633: make bitmap index usage optional for bloom filters URL: https://github.com/apache/incubator-druid/pull/6633 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-druid] ccaominh commented on issue #8197: Add IPv4 druid expressions

ccaominh commented on issue #8197: Add IPv4 druid expressions URL: https://github.com/apache/incubator-druid/pull/8197#issuecomment-517065779 @gianm, @clintropolis: Ready for re-review This is an automated message from the Apa

[GitHub] [incubator-druid] clintropolis opened a new pull request #8209: add mechanism to control filter optimization in historical query processing

clintropolis opened a new pull request #8209: add mechanism to control filter optimization in historical query processing URL: https://github.com/apache/incubator-druid/pull/8209 ### Description This PR introduces the ability for most `DimFilter` implementations to control whether o

[GitHub] [incubator-druid] gianm commented on a change in pull request #8197: Add IPv4 druid expressions

gianm commented on a change in pull request #8197: Add IPv4 druid expressions URL: https://github.com/apache/incubator-druid/pull/8197#discussion_r309474666 ## File path: processing/src/main/java/org/apache/druid/query/expression/IPv4AddressStringifyExprMacro.java ## @@ -0

[GitHub] [incubator-druid] fjy closed issue #8118: GroupBy array based result rows

fjy closed issue #8118: GroupBy array based result rows URL: https://github.com/apache/incubator-druid/issues/8118 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [incubator-druid] fjy merged pull request #8196: GroupBy array-based result rows.

fjy merged pull request #8196: GroupBy array-based result rows. URL: https://github.com/apache/incubator-druid/pull/8196 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-druid] gianm commented on a change in pull request #8197: Add IPv4 druid expressions

gianm commented on a change in pull request #8197: Add IPv4 druid expressions URL: https://github.com/apache/incubator-druid/pull/8197#discussion_r309468575 ## File path: processing/src/main/java/org/apache/druid/query/expression/IPv4AddressMatchExprMacro.java ## @@ -0,0 +

[GitHub] [incubator-druid] gianm commented on a change in pull request #8197: Add IPv4 druid expressions

gianm commented on a change in pull request #8197: Add IPv4 druid expressions URL: https://github.com/apache/incubator-druid/pull/8197#discussion_r309468575 ## File path: processing/src/main/java/org/apache/druid/query/expression/IPv4AddressMatchExprMacro.java ## @@ -0,0 +

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8197: Add IPv4 druid expressions

ccaominh commented on a change in pull request #8197: Add IPv4 druid expressions URL: https://github.com/apache/incubator-druid/pull/8197#discussion_r309457099 ## File path: processing/src/main/java/org/apache/druid/query/expression/IPv4AddressExprUtils.java ## @@ -0,0 +1,

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8197: Add IPv4 druid expressions

ccaominh commented on a change in pull request #8197: Add IPv4 druid expressions URL: https://github.com/apache/incubator-druid/pull/8197#discussion_r309456745 ## File path: processing/src/main/java/org/apache/druid/query/expression/IPv4AddressStringifyExprMacro.java ## @@

[incubator-druid] branch master updated: Add 'Area - Metadata' tag to committer-instructions.md and stale.yml (#8170)

This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new b97b86a Add 'Area - Metadata' tag to c

[GitHub] [incubator-druid] jon-wei merged pull request #8170: Add 'Area - Metadata' tag to committer-instructions.md and stale.yml

jon-wei merged pull request #8170: Add 'Area - Metadata' tag to committer-instructions.md and stale.yml URL: https://github.com/apache/incubator-druid/pull/8170 This is an automated message from the Apache Git Service. To r

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys

esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r309446537 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -76,56 +1

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys

esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r309446537 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -76,56 +1

[GitHub] [incubator-druid] esevastyanov commented on issue #8157: Enum of ResponseContext keys

esevastyanov commented on issue #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#issuecomment-517034018 Thanks, everyone. I updated the logic of truncation and kept it as general as possible without mentioning custom context keys. New algorithm re

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8197: Add IPv4 druid expressions

ccaominh commented on a change in pull request #8197: Add IPv4 druid expressions URL: https://github.com/apache/incubator-druid/pull/8197#discussion_r309441495 ## File path: processing/src/main/java/org/apache/druid/query/expression/IPv4AddressMatchExprMacro.java ## @@ -0,

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8100: SQL support for t-digest based sketch aggregators

jon-wei commented on a change in pull request #8100: SQL support for t-digest based sketch aggregators URL: https://github.com/apache/incubator-druid/pull/8100#discussion_r309439326 ## File path: extensions-contrib/tdigestsketch/src/test/java/org/apache/druid/query/aggregation/tdig

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8100: SQL support for t-digest based sketch aggregators

jon-wei commented on a change in pull request #8100: SQL support for t-digest based sketch aggregators URL: https://github.com/apache/incubator-druid/pull/8100#discussion_r309439827 ## File path: processing/src/main/java/org/apache/druid/query/aggregation/AggregatorUtil.java #

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys

esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r309438890 ## File path: server/src/main/java/org/apache/druid/server/QueryResource.java ## @@ -252,24 +252,30 @@ publ

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys

esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r309437857 ## File path: processing/src/test/java/org/apache/druid/query/topn/TopNQueryRunnerTest.java ## @@ -1301,9

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys

esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r309437197 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQuery.java ## @@ -125,7 +126,7 @@ pu

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8100: SQL support for t-digest based sketch aggregators

jon-wei commented on a change in pull request #8100: SQL support for t-digest based sketch aggregators URL: https://github.com/apache/incubator-druid/pull/8100#discussion_r309434471 ## File path: extensions-contrib/tdigestsketch/src/main/java/org/apache/druid/query/aggregation/tdig

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8100: SQL support for t-digest based sketch aggregators

jon-wei commented on a change in pull request #8100: SQL support for t-digest based sketch aggregators URL: https://github.com/apache/incubator-druid/pull/8100#discussion_r309426670 ## File path: extensions-contrib/tdigestsketch/src/main/java/org/apache/druid/query/aggregation/tdig

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8100: SQL support for t-digest based sketch aggregators

jon-wei commented on a change in pull request #8100: SQL support for t-digest based sketch aggregators URL: https://github.com/apache/incubator-druid/pull/8100#discussion_r309431256 ## File path: extensions-contrib/tdigestsketch/src/main/java/org/apache/druid/query/aggregation/tdig

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8100: SQL support for t-digest based sketch aggregators

jon-wei commented on a change in pull request #8100: SQL support for t-digest based sketch aggregators URL: https://github.com/apache/incubator-druid/pull/8100#discussion_r309436210 ## File path: extensions-contrib/tdigestsketch/src/main/java/org/apache/druid/query/aggregation/tdig

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8100: SQL support for t-digest based sketch aggregators

jon-wei commented on a change in pull request #8100: SQL support for t-digest based sketch aggregators URL: https://github.com/apache/incubator-druid/pull/8100#discussion_r309429691 ## File path: extensions-contrib/tdigestsketch/src/main/java/org/apache/druid/query/aggregation/tdig

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8100: SQL support for t-digest based sketch aggregators

jon-wei commented on a change in pull request #8100: SQL support for t-digest based sketch aggregators URL: https://github.com/apache/incubator-druid/pull/8100#discussion_r309436047 ## File path: extensions-contrib/tdigestsketch/src/main/java/org/apache/druid/query/aggregation/tdig

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys

esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r309436441 ## File path: processing/src/main/java/org/apache/druid/query/scan/ScanQuery.java ## @@ -334,7 +336,7 @@ pu

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys

esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r309436593 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -76,56 +2

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys

esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r309436255 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -84,36 +1

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys

esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r309436208 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -44,9 +47

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys

esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r309436123 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -84,36 +1

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys

esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r309436161 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -44,9 +47

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys

esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r309435687 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -84,36 +1

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys

esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r309435833 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -84,36 +1

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys

esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r309430626 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -76,56 +1

[GitHub] [incubator-druid] esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys

esevastyanov commented on a change in pull request #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#discussion_r309430781 ## File path: processing/src/main/java/org/apache/druid/query/context/ResponseContext.java ## @@ -84,36 +1

[GitHub] [incubator-druid] WilliamWhispell commented on issue #4349: [Proposal] Improve Handling of Nulls in Druid

WilliamWhispell commented on issue #4349: [Proposal] Improve Handling of Nulls in Druid URL: https://github.com/apache/incubator-druid/issues/4349#issuecomment-517011059 I think the bug is with https://github.com/apache/incubator-druid/blob/82b248cc1778d24b6f37864e113d8c77250d0cdf/core/sr

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8201: Simple memory allocation for CliIndexer tasks

jon-wei commented on a change in pull request #8201: Simple memory allocation for CliIndexer tasks URL: https://github.com/apache/incubator-druid/pull/8201#discussion_r309417711 ## File path: server/src/main/java/org/apache/druid/segment/realtime/appenderator/UnifiedIndexerAppender

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8201: Simple memory allocation for CliIndexer tasks

jon-wei commented on a change in pull request #8201: Simple memory allocation for CliIndexer tasks URL: https://github.com/apache/incubator-druid/pull/8201#discussion_r309416636 ## File path: server/src/main/java/org/apache/druid/segment/realtime/appenderator/UnifiedIndexerAppender

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8201: Simple memory allocation for CliIndexer tasks

jon-wei commented on a change in pull request #8201: Simple memory allocation for CliIndexer tasks URL: https://github.com/apache/incubator-druid/pull/8201#discussion_r309416273 ## File path: server/src/main/java/org/apache/druid/segment/realtime/appenderator/UnifiedIndexerAppender

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8201: Simple memory allocation for CliIndexer tasks

jon-wei commented on a change in pull request #8201: Simple memory allocation for CliIndexer tasks URL: https://github.com/apache/incubator-druid/pull/8201#discussion_r309416102 ## File path: server/src/main/java/org/apache/druid/segment/realtime/appenderator/UnifiedIndexerAppender

[GitHub] [incubator-druid] himanshug commented on issue #8175: allow decommissioning Middle Manager nodes

himanshug commented on issue #8175: allow decommissioning Middle Manager nodes URL: https://github.com/apache/incubator-druid/issues/8175#issuecomment-517002503 > does that mean if we have a task with an 8 hour duration, we need to wait 8 hours? in general, yes however, after dis

[GitHub] [incubator-druid] himanshug edited a comment on issue #8157: Enum of ResponseContext keys

himanshug edited a comment on issue #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#issuecomment-516996774 > Also improved ResponseContext serialization. Previously the result of serialization was truncated if its length was greater than the limi

[GitHub] [incubator-druid] himanshug commented on issue #8157: Enum of ResponseContext keys

himanshug commented on issue #8157: Enum of ResponseContext keys URL: https://github.com/apache/incubator-druid/pull/8157#issuecomment-516996774 > Also improved ResponseContext serialization. Previously the result of serialization was truncated if its length was greater than the limit. I be

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8197: Add IPv4 druid expressions

ccaominh commented on a change in pull request #8197: Add IPv4 druid expressions URL: https://github.com/apache/incubator-druid/pull/8197#discussion_r309402516 ## File path: processing/src/main/java/org/apache/druid/query/expression/IPv4AddressMatchExprMacro.java ## @@ -0,

[GitHub] [incubator-druid] himanshug commented on issue #4888: How Druid should handle situation when string dimension column is queried as numeric?

himanshug commented on issue #4888: How Druid should handle situation when string dimension column is queried as numeric? URL: https://github.com/apache/incubator-druid/issues/4888#issuecomment-516994789 thanks to stalebot ,I had forgotten about this. It turns out I have now gotten

[GitHub] [incubator-druid] himanshug commented on issue #8126: [Proposal] BufferAggregator support for growable sketches.

himanshug commented on issue #8126: [Proposal] BufferAggregator support for growable sketches. URL: https://github.com/apache/incubator-druid/issues/8126#issuecomment-516993449 @Eshcar regarding memory management: I would like it to be an interface inside druid core and later be a pl

[GitHub] [incubator-druid] ArtyomyuS commented on issue #8205: Fixed a bug in HttpPostEmitter leading to ClassCastException

ArtyomyuS commented on issue #8205: Fixed a bug in HttpPostEmitter leading to ClassCastException URL: https://github.com/apache/incubator-druid/pull/8205#issuecomment-516990252 @leventov I updated. Thanks. This is an automate

[GitHub] [incubator-druid] WilliamWhispell commented on issue #4349: [Proposal] Improve Handling of Nulls in Druid

WilliamWhispell commented on issue #4349: [Proposal] Improve Handling of Nulls in Druid URL: https://github.com/apache/incubator-druid/issues/4349#issuecomment-516989358 I notice when ingesting csvs, where I want to allow for null values, I see: exceptions: [could not convert value

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8197: Add IPv4 druid expressions

clintropolis commented on a change in pull request #8197: Add IPv4 druid expressions URL: https://github.com/apache/incubator-druid/pull/8197#discussion_r309387019 ## File path: processing/src/main/java/org/apache/druid/query/expression/IPv4AddressMatchExprMacro.java ## @

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8197: Add IPv4 druid expressions

ccaominh commented on a change in pull request #8197: Add IPv4 druid expressions URL: https://github.com/apache/incubator-druid/pull/8197#discussion_r309369137 ## File path: processing/src/main/java/org/apache/druid/query/expression/IPv4AddressParseExprMacro.java ## @@ -0,

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8197: Add IPv4 druid expressions

ccaominh commented on a change in pull request #8197: Add IPv4 druid expressions URL: https://github.com/apache/incubator-druid/pull/8197#discussion_r309369137 ## File path: processing/src/main/java/org/apache/druid/query/expression/IPv4AddressParseExprMacro.java ## @@ -0,

[GitHub] [incubator-druid] AlexanderSaydakov commented on issue #8095: Incorrect quantiles result produced by quantilesDoublesSketch

AlexanderSaydakov commented on issue #8095: Incorrect quantiles result produced by quantilesDoublesSketch URL: https://github.com/apache/incubator-druid/issues/8095#issuecomment-516965006 I think this is the same issue as https://github.com/apache/incubator-druid/issues/8032 Should be

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8196: GroupBy array-based result rows.

clintropolis commented on a change in pull request #8196: GroupBy array-based result rows. URL: https://github.com/apache/incubator-druid/pull/8196#discussion_r309363616 ## File path: processing/src/main/java/org/apache/druid/query/groupby/GroupByQueryQueryToolChest.java #

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8197: Add IPv4 druid expressions

ccaominh commented on a change in pull request #8197: Add IPv4 druid expressions URL: https://github.com/apache/incubator-druid/pull/8197#discussion_r309358807 ## File path: processing/src/main/java/org/apache/druid/query/expression/IPv4AddressParseExprMacro.java ## @@ -0,

[GitHub] [incubator-druid] fjy merged pull request #8206: Spelling Error

fjy merged pull request #8206: Spelling Error URL: https://github.com/apache/incubator-druid/pull/8206 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[incubator-druid] branch master updated: Spelling Error (#8206)

This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 716ce7f Spelling Error (#8206) 716ce7f is

  1   2   >