[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #8304: Add group_id to the sys.tasks table

2019-08-20 Thread GitBox
surekhasaharan commented on a change in pull request #8304: Add group_id to the sys.tasks table URL: https://github.com/apache/incubator-druid/pull/8304#discussion_r316022297 ## File path: core/src/main/java/org/apache/druid/indexer/TaskInfo.java ## @@ -35,9 +35,12 @@ p

[GitHub] [incubator-druid] vogievetsky opened a new pull request #8351: LGTM alert squash + final fixes

2019-08-20 Thread GitBox
vogievetsky opened a new pull request #8351: LGTM alert squash + final fixes URL: https://github.com/apache/incubator-druid/pull/8351 This PR is the final fixes for the 0.16.0 release of the web console it addresses: - remaining issues from parallel with forceGuaranteedRollup mode

[GitHub] [incubator-druid] gianm commented on issue #8349: Fix ClassCastException for TopN with long-type dimension

2019-08-20 Thread GitBox
gianm commented on issue #8349: Fix ClassCastException for TopN with long-type dimension URL: https://github.com/apache/incubator-druid/pull/8349#issuecomment-523298171 > LGTM but a test of some sort would be appreciated. (Beyond the test in a live cluster, I mean.)

[GitHub] [incubator-druid] jihoonson opened a new pull request #8350: Fix the shuffle with TLS enabled for parallel indexing; add an integration test; improve unit tests

2019-08-20 Thread GitBox
jihoonson opened a new pull request #8350: Fix the shuffle with TLS enabled for parallel indexing; add an integration test; improve unit tests URL: https://github.com/apache/incubator-druid/pull/8350 ### Description - In native parallel indexing, the shuffle didn't work if TLS is ena

[GitHub] [incubator-druid] gianm merged pull request #8311: Docusaurus build framework + ingestion doc refresh.

2019-08-20 Thread GitBox
gianm merged pull request #8311: Docusaurus build framework + ingestion doc refresh. URL: https://github.com/apache/incubator-druid/pull/8311 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-druid] gianm commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh.

2019-08-20 Thread GitBox
gianm commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh. URL: https://github.com/apache/incubator-druid/pull/8311#discussion_r315994761 ## File path: docs/ingestion/data-formats.md ## @@ -56,18 +54,18 @@ _CSV_ _TSV (Delimited)

[GitHub] [incubator-druid] gianm commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh.

2019-08-20 Thread GitBox
gianm commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh. URL: https://github.com/apache/incubator-druid/pull/8311#discussion_r315994653 ## File path: docs/ingestion/index.md ## @@ -0,0 +1,769 @@ +--- +id: index +title: "Ingesti

[GitHub] [incubator-druid] vogievetsky commented on issue #8311: Docusaurus build framework + ingestion doc refresh.

2019-08-20 Thread GitBox
vogievetsky commented on issue #8311: Docusaurus build framework + ingestion doc refresh. URL: https://github.com/apache/incubator-druid/pull/8311#issuecomment-523289196 OMG! it looks good. It even passed my super strict broken link linter! Someone merge before there are more doc conflicts

[GitHub] [incubator-druid] asdf2014 merged pull request #8344: Add grade shield

2019-08-20 Thread GitBox
asdf2014 merged pull request #8344: Add grade shield URL: https://github.com/apache/incubator-druid/pull/8344 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[incubator-druid] branch master updated (e4aa7fb -> c4db836)

2019-08-20 Thread asdf2014
This is an automated email from the ASF dual-hosted git repository. asdf2014 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from e4aa7fb Web-console: fix alerts from lgtm (#8346) add c4db836 Add grade shield (#8344) No new revi

[incubator-druid] branch master updated (c87b68d -> e4aa7fb)

2019-08-20 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from c87b68d use Number instead of long for response context (#8342) add e4aa7fb Web-console: fix alerts f

[GitHub] [incubator-druid] clintropolis merged pull request #8346: Web-console: fix alerts from lgtm

2019-08-20 Thread GitBox
clintropolis merged pull request #8346: Web-console: fix alerts from lgtm URL: https://github.com/apache/incubator-druid/pull/8346 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-druid] stale[bot] closed issue #6468: Unexpected "Triggering JVM shutdown"

2019-08-20 Thread GitBox
stale[bot] closed issue #6468: Unexpected "Triggering JVM shutdown" URL: https://github.com/apache/incubator-druid/issues/6468 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-druid] stale[bot] commented on issue #6468: Unexpected "Triggering JVM shutdown"

2019-08-20 Thread GitBox
stale[bot] commented on issue #6468: Unexpected "Triggering JVM shutdown" URL: https://github.com/apache/incubator-druid/issues/6468#issuecomment-523265764 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can r

[incubator-druid] branch master updated (d5a1967 -> c87b68d)

2019-08-20 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from d5a1967 Remove fromPigAvroStorage from the docs (#8340) add c87b68d use Number instead of long for resp

[GitHub] [incubator-druid] gianm merged pull request #8342: use Number instead of long for response context

2019-08-20 Thread GitBox
gianm merged pull request #8342: use Number instead of long for response context URL: https://github.com/apache/incubator-druid/pull/8342 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-druid] gianm commented on a change in pull request #8342: use Number instead of long for response context

2019-08-20 Thread GitBox
gianm commented on a change in pull request #8342: use Number instead of long for response context URL: https://github.com/apache/incubator-druid/pull/8342#discussion_r315973105 ## File path: processing/src/test/java/org/apache/druid/query/context/ResponseContextTest.java

[GitHub] [incubator-druid] jon-wei opened a new pull request #8349: Fix ClassCastException for TopN with long-type dimension

2019-08-20 Thread GitBox
jon-wei opened a new pull request #8349: Fix ClassCastException for TopN with long-type dimension URL: https://github.com/apache/incubator-druid/pull/8349 This PR fixes #8348 by ensuring that `DimValHolder` converts dimension values to the output type specified in the dimension spec of the

[GitHub] [incubator-druid] pphust commented on issue #8323: Make sure ReferenceCountingSegment.decrement() is invoked correctly when useCache=true

2019-08-20 Thread GitBox
pphust commented on issue #8323: Make sure ReferenceCountingSegment.decrement() is invoked correctly when useCache=true URL: https://github.com/apache/incubator-druid/pull/8323#issuecomment-523261231 @leventov my pleasure to do something for Druid. I have closed the duplicated [PR8316]

[GitHub] [incubator-druid] pphust closed pull request #8316: fix issue8291: make sure ReferenceCountingSegment.decrement() is invoked correctly when useCache=true

2019-08-20 Thread GitBox
pphust closed pull request #8316: fix issue8291: make sure ReferenceCountingSegment.decrement() is invoked correctly when useCache=true URL: https://github.com/apache/incubator-druid/pull/8316 This is an automated message fr

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #8347: remove YeOldePlumberSchool.java, unused

2019-08-20 Thread GitBox
lgtm-com[bot] commented on issue #8347: remove YeOldePlumberSchool.java, unused URL: https://github.com/apache/incubator-druid/pull/8347#issuecomment-523258804 This pull request **fixes 1 alert** when merging ff24fa901f54f8885f3a8cb53f2c10e02fa16803 into 6fa22f6939d739170146e766d9c26ec3697

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh.

2019-08-20 Thread GitBox
jihoonson commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh. URL: https://github.com/apache/incubator-druid/pull/8311#discussion_r315965702 ## File path: docs/ingestion/data-formats.md ## @@ -56,18 +54,18 @@ _CSV_ _TSV (Delimi

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh.

2019-08-20 Thread GitBox
jihoonson commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh. URL: https://github.com/apache/incubator-druid/pull/8311#discussion_r315965197 ## File path: docs/ingestion/index.md ## @@ -0,0 +1,769 @@ +--- +id: index +title: "Ing

[GitHub] [incubator-druid] jon-wei opened a new issue #8348: Integer->Long ClassCastException in TopN query

2019-08-20 Thread GitBox
jon-wei opened a new issue #8348: Integer->Long ClassCastException in TopN query URL: https://github.com/apache/incubator-druid/issues/8348 `TopNNumericResultBuilder` can hit a ClassCastException on the broker when a query uses a long dimension, due to Jackson behavior where a number gets

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #8346: Web-console: fix alerts from lgtm

2019-08-20 Thread GitBox
vogievetsky commented on a change in pull request #8346: Web-console: fix alerts from lgtm URL: https://github.com/apache/incubator-druid/pull/8346#discussion_r315967041 ## File path: web-console/webpack.config.js ## @@ -124,10 +124,8 @@ module.exports = env => { ],

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #8346: Web-console: fix alerts from lgtm

2019-08-20 Thread GitBox
lgtm-com[bot] commented on issue #8346: Web-console: fix alerts from lgtm URL: https://github.com/apache/incubator-druid/pull/8346#issuecomment-523256886 This pull request **fixes 23 alerts** when merging 90f06f6a229e583794079f526ba5370634a50a84 into d5a19675dd37ac6ec876117bad5bcb53e33f46b

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #8311: Docusaurus build framework + ingestion doc refresh.

2019-08-20 Thread GitBox
lgtm-com[bot] commented on issue #8311: Docusaurus build framework + ingestion doc refresh. URL: https://github.com/apache/incubator-druid/pull/8311#issuecomment-523256350 This pull request **introduces 1 alert** when merging 1002b3e36d3b7c95c31b0a0aa44cfc3e75159338 into d5a19675dd37ac6ec

[GitHub] [incubator-druid] vogievetsky commented on issue #8346: Web-console: fix alerts from lgtm

2019-08-20 Thread GitBox
vogievetsky commented on issue #8346: Web-console: fix alerts from lgtm URL: https://github.com/apache/incubator-druid/pull/8346#issuecomment-523255599 LGTM after CI 👍 This is an automated message from the Apache Git Service.

[GitHub] [incubator-druid] mcbrewster commented on a change in pull request #8346: Web-console: fix alerts from lgtm

2019-08-20 Thread GitBox
mcbrewster commented on a change in pull request #8346: Web-console: fix alerts from lgtm URL: https://github.com/apache/incubator-druid/pull/8346#discussion_r315965696 ## File path: web-console/webpack.config.js ## @@ -124,10 +124,8 @@ module.exports = env => { ],

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8304: Add group_id to the sys.tasks table

2019-08-20 Thread GitBox
jihoonson commented on a change in pull request #8304: Add group_id to the sys.tasks table URL: https://github.com/apache/incubator-druid/pull/8304#discussion_r315958090 ## File path: core/src/main/java/org/apache/druid/indexer/TaskInfo.java ## @@ -35,9 +35,12 @@ privat

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #8346: Web-console: fix alerts from lgtm

2019-08-20 Thread GitBox
vogievetsky commented on a change in pull request #8346: Web-console: fix alerts from lgtm URL: https://github.com/apache/incubator-druid/pull/8346#discussion_r315960401 ## File path: web-console/webpack.config.js ## @@ -19,7 +19,6 @@ const process = require('process');

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #8346: Web-console: fix alerts from lgtm

2019-08-20 Thread GitBox
vogievetsky commented on a change in pull request #8346: Web-console: fix alerts from lgtm URL: https://github.com/apache/incubator-druid/pull/8346#discussion_r315959046 ## File path: web-console/src/components/show-log/show-log.tsx ## @@ -21,6 +21,7 @@ import axios from '

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #8346: Web-console: fix alerts from lgtm

2019-08-20 Thread GitBox
vogievetsky commented on a change in pull request #8346: Web-console: fix alerts from lgtm URL: https://github.com/apache/incubator-druid/pull/8346#discussion_r315960161 ## File path: web-console/src/visualization/stacked-bar-chart.tsx ## @@ -67,9 +67,10 @@ export class St

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #8346: Web-console: fix alerts from lgtm

2019-08-20 Thread GitBox
vogievetsky commented on a change in pull request #8346: Web-console: fix alerts from lgtm URL: https://github.com/apache/incubator-druid/pull/8346#discussion_r315959857 ## File path: web-console/src/views/query-view/column-tree/column-tree.tsx ## @@ -385,15 +396,9 @@ expo

svn commit: r35324 - /release/incubator/druid/0.15.0-incubating/

2019-08-20 Thread cwylie
Author: cwylie Date: Wed Aug 21 00:38:07 2019 New Revision: 35324 Log: remove 0.15.0-incubating from mirrors Removed: release/incubator/druid/0.15.0-incubating/ - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

[GitHub] [incubator-druid] gianm commented on issue #8311: Docusaurus build framework + ingestion doc refresh.

2019-08-20 Thread GitBox
gianm commented on issue #8311: Docusaurus build framework + ingestion doc refresh. URL: https://github.com/apache/incubator-druid/pull/8311#issuecomment-523245310 Pushed again to resolve some conflicts, fixed more broken links and anchors found by the new script `npm run lint`, and upload

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #8311: Docusaurus build framework + ingestion doc refresh.

2019-08-20 Thread GitBox
lgtm-com[bot] commented on issue #8311: Docusaurus build framework + ingestion doc refresh. URL: https://github.com/apache/incubator-druid/pull/8311#issuecomment-523244976 This pull request **introduces 1 alert** when merging 39af0ef698e341e3687c0047ff8dbb90effdfeae into d5a19675dd37ac6ec

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #8346: Web-console: fix alerts from lgtm

2019-08-20 Thread GitBox
lgtm-com[bot] commented on issue #8346: Web-console: fix alerts from lgtm URL: https://github.com/apache/incubator-druid/pull/8346#issuecomment-523244646 This pull request **fixes 23 alerts** when merging 3be0d946cbc396fbb30d40948d2ec80e2cb159fa into d5a19675dd37ac6ec876117bad5bcb53e33f46b

[GitHub] [incubator-druid] clintropolis commented on issue #8347: remove YeOldePlumberSchool.java, unused

2019-08-20 Thread GitBox
clintropolis commented on issue #8347: remove YeOldePlumberSchool.java, unused URL: https://github.com/apache/incubator-druid/pull/8347#issuecomment-523241444 >Look like it's also mentioned in docs/content/design/plumber.md, so that can be removed too Oops, had a `*.java` filter when

[GitHub] [incubator-druid] himanshug commented on issue #8319: string column handling for long/float min/max/sum aggregators

2019-08-20 Thread GitBox
himanshug commented on issue #8319: string column handling for long/float min/max/sum aggregators URL: https://github.com/apache/incubator-druid/pull/8319#issuecomment-523239402 @jihoonson thanks, I will fix the build tomorrow. --

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #8346: Web-console: fix alerts from lgtm

2019-08-20 Thread GitBox
lgtm-com[bot] commented on issue #8346: Web-console: fix alerts from lgtm URL: https://github.com/apache/incubator-druid/pull/8346#issuecomment-523237132 This pull request **fixes 10 alerts** when merging 85c5d77d04871336fa0f4b03cc26aea53a01 into 14a4238381d74cfc730c670a9f1fe9ed14226f9

[GitHub] [incubator-druid] jihoonson commented on issue #8319: string column handling for long/float min/max/sum aggregators

2019-08-20 Thread GitBox
jihoonson commented on issue #8319: string column handling for long/float min/max/sum aggregators URL: https://github.com/apache/incubator-druid/pull/8319#issuecomment-523236410 @himanshug I will take a look probably sometime this week. In the meantime, would you check the CI failure? It l

[GitHub] [incubator-druid] jihoonson commented on issue #8334: Add drone ci

2019-08-20 Thread GitBox
jihoonson commented on issue #8334: Add drone ci URL: https://github.com/apache/incubator-druid/pull/8334#issuecomment-523236050 Hi @stuartmclean, thank you for your contribution. Would you please update your PR description properly? It would be nice if it explains how Drone CI is differen

[incubator-druid] branch master updated (14a4238 -> d5a1967)

2019-08-20 Thread jihoonson
This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from 14a4238 Bump JUnitParams from 1.0.4 to 1.1.1 (#8017) add d5a1967 Remove fromPigAvroStorage from th

[GitHub] [incubator-druid] jihoonson merged pull request #8340: Remove fromPigAvroStorage from the docs

2019-08-20 Thread GitBox
jihoonson merged pull request #8340: Remove fromPigAvroStorage from the docs URL: https://github.com/apache/incubator-druid/pull/8340 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh.

2019-08-20 Thread GitBox
ccaominh commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh. URL: https://github.com/apache/incubator-druid/pull/8311#discussion_r315945457 ## File path: .travis.yml ## @@ -164,6 +164,10 @@ matrix: script: - $MVN

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8287: Cleanup appenderators and segment walkers in UnifiedIndexerAppenderatorsManager

2019-08-20 Thread GitBox
jihoonson commented on a change in pull request #8287: Cleanup appenderators and segment walkers in UnifiedIndexerAppenderatorsManager URL: https://github.com/apache/incubator-druid/pull/8287#discussion_r315943848 ## File path: server/src/main/java/org/apache/druid/segment/realtime

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8287: Cleanup appenderators and segment walkers in UnifiedIndexerAppenderatorsManager

2019-08-20 Thread GitBox
jon-wei commented on a change in pull request #8287: Cleanup appenderators and segment walkers in UnifiedIndexerAppenderatorsManager URL: https://github.com/apache/incubator-druid/pull/8287#discussion_r315943072 ## File path: server/src/main/java/org/apache/druid/segment/realtime/a

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #8311: Docusaurus build framework + ingestion doc refresh.

2019-08-20 Thread GitBox
lgtm-com[bot] commented on issue #8311: Docusaurus build framework + ingestion doc refresh. URL: https://github.com/apache/incubator-druid/pull/8311#issuecomment-523232025 This pull request **introduces 1 alert** when merging 8f98e002aee2b137173cbd7a08b758ad62183e2a into 6fa22f6939d739170

[GitHub] [incubator-druid] clintropolis merged pull request #8017: Bump JUnitParams from 1.0.4 to 1.1.1

2019-08-20 Thread GitBox
clintropolis merged pull request #8017: Bump JUnitParams from 1.0.4 to 1.1.1 URL: https://github.com/apache/incubator-druid/pull/8017 This is an automated message from the Apache Git Service. To respond to the message, please

[incubator-druid] branch master updated: Bump JUnitParams from 1.0.4 to 1.1.1 (#8017)

2019-08-20 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 14a4238 Bump JUnitParams from 1.0.4 to

[incubator-druid] branch master updated (3a58431 -> 8821ac3)

2019-08-20 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from 3a58431 Bump jackson-jq from 0.0.7 to 0.0.10 (#8293) add 8821ac3 Bump opencsv from 4.2 to 4.6 (#8294)

[GitHub] [incubator-druid] clintropolis merged pull request #8294: Bump opencsv from 4.2 to 4.6

2019-08-20 Thread GitBox
clintropolis merged pull request #8294: Bump opencsv from 4.2 to 4.6 URL: https://github.com/apache/incubator-druid/pull/8294 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-druid] clintropolis merged pull request #8293: Bump jackson-jq from 0.0.7 to 0.0.10

2019-08-20 Thread GitBox
clintropolis merged pull request #8293: Bump jackson-jq from 0.0.7 to 0.0.10 URL: https://github.com/apache/incubator-druid/pull/8293 This is an automated message from the Apache Git Service. To respond to the message, please

[incubator-druid] branch master updated (6fa22f6 -> 3a58431)

2019-08-20 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from 6fa22f6 Enable code coverage (#8303) add 3a58431 Bump jackson-jq from 0.0.7 to 0.0.10 (#8293) No new

[GitHub] [incubator-druid] clintropolis opened a new pull request #8347: remove YeOldePlumberSchool.java, unused

2019-08-20 Thread GitBox
clintropolis opened a new pull request #8347: remove YeOldePlumberSchool.java, unused URL: https://github.com/apache/incubator-druid/pull/8347 This is no longer used and can be removed. This is an automated message from t

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #8346: Web-console: fix alerts from lgtm

2019-08-20 Thread GitBox
lgtm-com[bot] commented on issue #8346: Web-console: fix alerts from lgtm URL: https://github.com/apache/incubator-druid/pull/8346#issuecomment-523226966 This pull request **introduces 2 alerts** and **fixes 11** when merging 3ee410c389a115dbe96de47133e62f3b1744adcc into 6fa22f6939d7391701

[GitHub] [incubator-druid] gianm commented on issue #8344: Add grade shield

2019-08-20 Thread GitBox
gianm commented on issue #8344: Add grade shield URL: https://github.com/apache/incubator-druid/pull/8344#issuecomment-52309 @asdf2014, apologies for introducing conflicts by merging #8303. Could you please fix them up -- afterwards this looks good to go. --

[incubator-druid] branch master updated (cb1339e -> 6fa22f6)

2019-08-20 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from cb1339e Bump derby from 10.11.1.1 to 10.14.2.0 (#8292) add 6fa22f6 Enable code coverage (#8303) No new

[GitHub] [incubator-druid] gianm merged pull request #8303: Enable code coverage

2019-08-20 Thread GitBox
gianm merged pull request #8303: Enable code coverage URL: https://github.com/apache/incubator-druid/pull/8303 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [incubator-druid] gianm closed issue #6009: Coveralls badge is pointing to old repo

2019-08-20 Thread GitBox
gianm closed issue #6009: Coveralls badge is pointing to old repo URL: https://github.com/apache/incubator-druid/issues/6009 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #8346: Web-console: fix alerts from lgtm

2019-08-20 Thread GitBox
lgtm-com[bot] commented on issue #8346: Web-console: fix alerts from lgtm URL: https://github.com/apache/incubator-druid/pull/8346#issuecomment-523220466 This pull request **introduces 1 alert** and **fixes 10** when merging f5abf1d510e57b384d7d5e0077f365b8c9e19b05 into cb1339e19a29ae0696c

[GitHub] [incubator-druid] mcbrewster opened a new pull request #8346: Web-console: fix alerts from lgtm

2019-08-20 Thread GitBox
mcbrewster opened a new pull request #8346: Web-console: fix alerts from lgtm URL: https://github.com/apache/incubator-druid/pull/8346 LGTM is reporting a bunch of alerts this should fix a bunch of them. - removes un used variables - prevents setting state directly - removes

[GitHub] [incubator-druid] sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations

2019-08-20 Thread GitBox
sashidhar commented on issue #8038: Making optimal usage of multiple segment cache locations URL: https://github.com/apache/incubator-druid/pull/8038#issuecomment-523213829 Yes Gian. I'm working on the review comments now. On Wed, Aug 21, 2019, 3:26 AM Gian Merlino wrote: > H

[GitHub] [incubator-druid] gianm commented on issue #8038: Making optimal usage of multiple segment cache locations

2019-08-20 Thread GitBox
gianm commented on issue #8038: Making optimal usage of multiple segment cache locations URL: https://github.com/apache/incubator-druid/pull/8038#issuecomment-523210766 Hi @sashidhar, have you had a chance to check out @jihoonson's comments yet? Thanks!!

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #8311: Docusaurus build framework + ingestion doc refresh.

2019-08-20 Thread GitBox
lgtm-com[bot] commented on issue #8311: Docusaurus build framework + ingestion doc refresh. URL: https://github.com/apache/incubator-druid/pull/8311#issuecomment-523195507 This pull request **introduces 1 alert** when merging 855413302e9f0c950b30e6b20a6f7feb9ba6ffeb into e2a25fb51e7f56959

[GitHub] [incubator-druid] gianm commented on issue #8311: Docusaurus build framework + ingestion doc refresh.

2019-08-20 Thread GitBox
gianm commented on issue #8311: Docusaurus build framework + ingestion doc refresh. URL: https://github.com/apache/incubator-druid/pull/8311#issuecomment-523194385 > I've pushed an update reflecting the comments above, with all broken links and anchors fixed, and re-uploaded a render to h

[GitHub] [incubator-druid] clintropolis merged pull request #8292: Bump derby from 10.11.1.1 to 10.14.2.0

2019-08-20 Thread GitBox
clintropolis merged pull request #8292: Bump derby from 10.11.1.1 to 10.14.2.0 URL: https://github.com/apache/incubator-druid/pull/8292 This is an automated message from the Apache Git Service. To respond to the message, plea

[incubator-druid] branch master updated (e2a25fb -> cb1339e)

2019-08-20 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from e2a25fb Add logging for LZ4Factory instance type (#8341) add cb1339e Bump derby from 10.11.1.1 to 10.

[GitHub] [incubator-druid] gianm commented on issue #8311: Docusaurus build framework + ingestion doc refresh.

2019-08-20 Thread GitBox
gianm commented on issue #8311: Docusaurus build framework + ingestion doc refresh. URL: https://github.com/apache/incubator-druid/pull/8311#issuecomment-523190109 I've pushed an update reflecting the comments above, with all broken links and anchors fixed, and re-uploaded a render to htt

[GitHub] [incubator-druid] jon-wei merged pull request #8341: Add logging for LZ4Factory instance type

2019-08-20 Thread GitBox
jon-wei merged pull request #8341: Add logging for LZ4Factory instance type URL: https://github.com/apache/incubator-druid/pull/8341 This is an automated message from the Apache Git Service. To respond to the message, please

[incubator-druid] branch master updated (5e35500 -> e2a25fb)

2019-08-20 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from 5e35500 Fix unused format argument (#8345) add e2a25fb Add logging for LZ4Factory instance type (#834

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #8311: Docusaurus build framework + ingestion doc refresh.

2019-08-20 Thread GitBox
lgtm-com[bot] commented on issue #8311: Docusaurus build framework + ingestion doc refresh. URL: https://github.com/apache/incubator-druid/pull/8311#issuecomment-523178779 This pull request **introduces 6 alerts** when merging 173047e81919c0c12215213467752e7cdce0388c into 5e35500e0e41ccaa

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8303: Enable code coverage

2019-08-20 Thread GitBox
ccaominh commented on a change in pull request #8303: Enable code coverage URL: https://github.com/apache/incubator-druid/pull/8303#discussion_r315884109 ## File path: pom.xml ## @@ -973,13 +973,33 @@ -org.codehaus.mojo -

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8287: Cleanup appenderators and segment walkers in UnifiedIndexerAppenderatorsManager

2019-08-20 Thread GitBox
jihoonson commented on a change in pull request #8287: Cleanup appenderators and segment walkers in UnifiedIndexerAppenderatorsManager URL: https://github.com/apache/incubator-druid/pull/8287#discussion_r315876828 ## File path: server/src/main/java/org/apache/druid/segment/realtime

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8287: Cleanup appenderators and segment walkers in UnifiedIndexerAppenderatorsManager

2019-08-20 Thread GitBox
jihoonson commented on a change in pull request #8287: Cleanup appenderators and segment walkers in UnifiedIndexerAppenderatorsManager URL: https://github.com/apache/incubator-druid/pull/8287#discussion_r315874460 ## File path: server/src/main/java/org/apache/druid/segment/realtime

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8303: Enable code coverage

2019-08-20 Thread GitBox
clintropolis commented on a change in pull request #8303: Enable code coverage URL: https://github.com/apache/incubator-druid/pull/8303#discussion_r315872432 ## File path: pom.xml ## @@ -973,13 +973,33 @@ -org.codehaus.mojo -

[incubator-druid] branch master updated (ffcbd1e -> 5e35500)

2019-08-20 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from ffcbd1e Ensure ReferenceCountingSegment.decrement() is invoked correctly (#8323) add 5e35500 Fix unu

[GitHub] [incubator-druid] clintropolis merged pull request #8345: Fix unused format argument

2019-08-20 Thread GitBox
clintropolis merged pull request #8345: Fix unused format argument URL: https://github.com/apache/incubator-druid/pull/8345 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-druid] leventov edited a comment on issue #8323: Make sure ReferenceCountingSegment.decrement() is invoked correctly when useCache=true

2019-08-20 Thread GitBox
leventov edited a comment on issue #8323: Make sure ReferenceCountingSegment.decrement() is invoked correctly when useCache=true URL: https://github.com/apache/incubator-druid/pull/8323#issuecomment-523151655 @pphust thanks a lot for your contribution! -

[incubator-druid] branch master updated (818bf49 -> ffcbd1e)

2019-08-20 Thread leventov
This is an automated email from the ASF dual-hosted git repository. leventov pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from 818bf49 Enable Spotbugs NP_NONNULL_RETURN_VIOLATION (#8234) add ffcbd1e Ensure ReferenceCountingSeg

[GitHub] [incubator-druid] leventov commented on issue #8323: Make sure ReferenceCountingSegment.decrement() is invoked correctly when useCache=true

2019-08-20 Thread GitBox
leventov commented on issue #8323: Make sure ReferenceCountingSegment.decrement() is invoked correctly when useCache=true URL: https://github.com/apache/incubator-druid/pull/8323#issuecomment-523151655 @pphust thanks a lot for contribution! -

[GitHub] [incubator-druid] leventov closed issue #8291: ReferenceCountedSegment is acquired too many times

2019-08-20 Thread GitBox
leventov closed issue #8291: ReferenceCountedSegment is acquired too many times URL: https://github.com/apache/incubator-druid/issues/8291 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [incubator-druid] leventov merged pull request #8323: Make sure ReferenceCountingSegment.decrement() is invoked correctly when useCache=true

2019-08-20 Thread GitBox
leventov merged pull request #8323: Make sure ReferenceCountingSegment.decrement() is invoked correctly when useCache=true URL: https://github.com/apache/incubator-druid/pull/8323 This is an automated message from the Apache

[GitHub] [incubator-druid] gianm commented on issue #8311: Docusaurus build framework + ingestion doc refresh.

2019-08-20 Thread GitBox
gianm commented on issue #8311: Docusaurus build framework + ingestion doc refresh. URL: https://github.com/apache/incubator-druid/pull/8311#issuecomment-523126280 There are a bunch of broken anchor-links I'll look at fixing later today. (Found by running `npm run anchor-lint`) --

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #8311: Docusaurus build framework + ingestion doc refresh.

2019-08-20 Thread GitBox
lgtm-com[bot] commented on issue #8311: Docusaurus build framework + ingestion doc refresh. URL: https://github.com/apache/incubator-druid/pull/8311#issuecomment-523121772 This pull request **introduces 6 alerts** when merging 20e9d79431db3aa5d9219dc729c9f2c4cd5a6a8b into 818bf4990c456cfb

[GitHub] [incubator-druid] kamaci commented on issue #6943: InterruptedExceptions should never be ignored in the code.

2019-08-20 Thread GitBox
kamaci commented on issue #6943: InterruptedExceptions should never be ignored in the code. URL: https://github.com/apache/incubator-druid/pull/6943#issuecomment-523121443 @leventov @jihoonson I've resolved the conflicts and all checks have passed. -

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8303: Enable code coverage

2019-08-20 Thread GitBox
ccaominh commented on a change in pull request #8303: Enable code coverage URL: https://github.com/apache/incubator-druid/pull/8303#discussion_r315818805 ## File path: pom.xml ## @@ -973,13 +973,33 @@ -org.codehaus.mojo -

[GitHub] [incubator-druid] gianm commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh.

2019-08-20 Thread GitBox
gianm commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh. URL: https://github.com/apache/incubator-druid/pull/8311#discussion_r315814930 ## File path: docs/ingestion/native-batch.md ## @@ -73,16 +78,19 @@ if one of them fails.

[GitHub] [incubator-druid] gianm commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh.

2019-08-20 Thread GitBox
gianm commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh. URL: https://github.com/apache/incubator-druid/pull/8311#discussion_r315814793 ## File path: docs/ingestion/index.md ## @@ -0,0 +1,768 @@ +--- +id: index +title: "Ingesti

[GitHub] [incubator-druid] gianm commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh.

2019-08-20 Thread GitBox
gianm commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh. URL: https://github.com/apache/incubator-druid/pull/8311#discussion_r315814737 ## File path: docs/ingestion/data-management.md ## @@ -0,0 +1,255 @@ +--- +id: data-managem

[GitHub] [incubator-druid] gianm commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh.

2019-08-20 Thread GitBox
gianm commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh. URL: https://github.com/apache/incubator-druid/pull/8311#discussion_r315814498 ## File path: docs/ingestion/index.md ## @@ -0,0 +1,768 @@ +--- +id: index +title: "Ingesti

[GitHub] [incubator-druid] gianm commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh.

2019-08-20 Thread GitBox
gianm commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh. URL: https://github.com/apache/incubator-druid/pull/8311#discussion_r315813786 ## File path: docs/ingestion/index.md ## @@ -0,0 +1,768 @@ +--- +id: index +title: "Ingesti

[GitHub] [incubator-druid] gianm commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh.

2019-08-20 Thread GitBox
gianm commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh. URL: https://github.com/apache/incubator-druid/pull/8311#discussion_r315812812 ## File path: docs/design/index.md ## @@ -0,0 +1,100 @@ +--- +id: index +title: "Introducti

[GitHub] [incubator-druid] gianm commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh.

2019-08-20 Thread GitBox
gianm commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh. URL: https://github.com/apache/incubator-druid/pull/8311#discussion_r315812269 ## File path: docs/ingestion/index.md ## @@ -0,0 +1,768 @@ +--- +id: index +title: "Ingesti

[GitHub] [incubator-druid] gianm commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh.

2019-08-20 Thread GitBox
gianm commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh. URL: https://github.com/apache/incubator-druid/pull/8311#discussion_r315812092 ## File path: docs/ingestion/index.md ## @@ -0,0 +1,768 @@ +--- +id: index +title: "Ingesti

[GitHub] [incubator-druid] gianm commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh.

2019-08-20 Thread GitBox
gianm commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh. URL: https://github.com/apache/incubator-druid/pull/8311#discussion_r315811572 ## File path: docs/design/processes.md ## @@ -88,18 +88,30 @@ Within a Data server, functio

[GitHub] [incubator-druid] gianm commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh.

2019-08-20 Thread GitBox
gianm commented on a change in pull request #8311: Docusaurus build framework + ingestion doc refresh. URL: https://github.com/apache/incubator-druid/pull/8311#discussion_r315811463 ## File path: docs/comparisons/druid-vs-elasticsearch.md ## @@ -22,19 +22,18 @@ title: "Apa

[GitHub] [incubator-druid] leventov commented on issue #8234: Enable Spotbugs NP_NONNULL_RETURN_VIOLATION

2019-08-20 Thread GitBox
leventov commented on issue #8234: Enable Spotbugs NP_NONNULL_RETURN_VIOLATION URL: https://github.com/apache/incubator-druid/pull/8234#issuecomment-523039083 @Fokko in general, please try to write to dev mailing list to draw attention of committers to the problem.

[incubator-druid] branch master updated (781873b -> 818bf49)

2019-08-20 Thread leventov
This is an automated email from the ASF dual-hosted git repository. leventov pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from 781873b Fix resource leak (#8337) add 818bf49 Enable Spotbugs NP_NONNULL_RETURN_VIOLATION (#8234)

  1   2   >