[GitHub] [incubator-druid] yunwan commented on issue #8591: issue with Hadoop indexing task and jdk9+

2019-09-26 Thread GitBox
yunwan commented on issue #8591: issue with Hadoop indexing task and jdk9+ URL: https://github.com/apache/incubator-druid/issues/8591#issuecomment-535376220 https://docs.oracle.com/en/java/javase/11/migrate/index.html#JSMIG-GUID-A868D0B9-026F-4D46-B979-901834343F9E ---

[GitHub] [incubator-druid] pzhdfy opened a new pull request #8596: bugfix: fix queuedSize not decrease in HttpLoadQueuePeon when load failed

2019-09-26 Thread GitBox
pzhdfy opened a new pull request #8596: bugfix: fix queuedSize not decrease in HttpLoadQueuePeon when load failed URL: https://github.com/apache/incubator-druid/pull/8596 LoadSegmentHolder in HttpLoadQueuePeon now only decrease queuedSize when load success. so if load fail queuedSize w

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #8550: JsonParserIterator.init future timeout

2019-09-26 Thread GitBox
lgtm-com[bot] commented on issue #8550: JsonParserIterator.init future timeout URL: https://github.com/apache/incubator-druid/pull/8550#issuecomment-535439147 This pull request **fixes 1 alert** when merging 08a2e8686bea502ef9836ecc87e97821bcedc561 into f4605f45be216cf65837c148a90ad7df05f9

[GitHub] [incubator-druid] FaxianZhao commented on a change in pull request #8272: Support incremental load in Druid lookups

2019-09-26 Thread GitBox
FaxianZhao commented on a change in pull request #8272: Support incremental load in Druid lookups URL: https://github.com/apache/incubator-druid/pull/8272#discussion_r328550816 ## File path: extensions-core/lookups-cached-global/src/main/java/org/apache/druid/server/lookup/namespac

[GitHub] [incubator-druid] bladecatcher opened a new issue #8597: stringLast / doubleLast aggregators fail when druid.generic.useDefaultValueForNull=false

2019-09-26 Thread GitBox
bladecatcher opened a new issue #8597: stringLast / doubleLast aggregators fail when druid.generic.useDefaultValueForNull=false URL: https://github.com/apache/incubator-druid/issues/8597 stringLast / doubleLast aggregators fail with NullPointerExceptions when druid.generic.useDefaultValueF

[GitHub] [incubator-druid] FaxianZhao opened a new pull request #8598: bug fix for lookup leak when we remove the last lookup from lookup tier

2019-09-26 Thread GitBox
FaxianZhao opened a new pull request #8598: bug fix for lookup leak when we remove the last lookup from lookup tier URL: https://github.com/apache/incubator-druid/pull/8598 Fixes bug which caused by #7852. ### Description Fixed the bug ... Due to #7852, coordinator won

[GitHub] [incubator-druid] wsjz commented on issue #8453: druid 0.12.1 cant load gplcompression

2019-09-26 Thread GitBox
wsjz commented on issue #8453: druid 0.12.1 cant load gplcompression URL: https://github.com/apache/incubator-druid/issues/8453#issuecomment-535474142 @vogievetsky I have solved it ,add LD_LIBRARY_PATH to druid-env.xml for ambari druid stack(HDP3.1 stack). -

[GitHub] [incubator-druid] wsjz closed issue #8453: druid 0.12.1 cant load gplcompression

2019-09-26 Thread GitBox
wsjz closed issue #8453: druid 0.12.1 cant load gplcompression URL: https://github.com/apache/incubator-druid/issues/8453 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [incubator-druid] quenlang commented on issue #8061: Native parallel batch indexing with shuffle

2019-09-26 Thread GitBox
quenlang commented on issue #8061: Native parallel batch indexing with shuffle URL: https://github.com/apache/incubator-druid/issues/8061#issuecomment-535510647 @jihoonson Thanks a lot! This is an automated message from the A

[GitHub] [incubator-druid] sebbASF opened a new issue #8599: Download page needs to include incubation disclaimer

2019-09-26 Thread GitBox
sebbASF opened a new issue #8599: Download page needs to include incubation disclaimer URL: https://github.com/apache/incubator-druid/issues/8599 As the subject says; it's important that downloaders are made aware of the incubation status --

[GitHub] [incubator-druid] himanshug closed issue #8071: add aggregators for computing mean/average

2019-09-26 Thread GitBox
himanshug closed issue #8071: add aggregators for computing mean/average URL: https://github.com/apache/incubator-druid/issues/8071 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-druid] himanshug merged pull request #8459: doubleMean aggregator to be used at query time

2019-09-26 Thread GitBox
himanshug merged pull request #8459: doubleMean aggregator to be used at query time URL: https://github.com/apache/incubator-druid/pull/8459 This is an automated message from the Apache Git Service. To respond to the message

[incubator-druid] branch master updated: doubleMean aggregator to be used at query time (#8459)

2019-09-26 Thread himanshug
This is an automated email from the ASF dual-hosted git repository. himanshug pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 9f1f5e1 doubleMean aggregator to be

[GitHub] [incubator-druid] himanshug commented on issue #8598: bug fix for lookup leak when we remove the last lookup from lookup tier

2019-09-26 Thread GitBox
himanshug commented on issue #8598: bug fix for lookup leak when we remove the last lookup from lookup tier URL: https://github.com/apache/incubator-druid/pull/8598#issuecomment-535554002 @FaxianZhao thanks for discovering and finding the root cause. ---

[GitHub] [incubator-druid] himanshug commented on a change in pull request #8598: bug fix for lookup leak when we remove the last lookup from lookup tier

2019-09-26 Thread GitBox
himanshug commented on a change in pull request #8598: bug fix for lookup leak when we remove the last lookup from lookup tier URL: https://github.com/apache/incubator-druid/pull/8598#discussion_r328685357 ## File path: server/src/main/java/org/apache/druid/server/lookup/cache/Look

[GitHub] [incubator-druid] himanshug commented on issue #8596: bugfix: fix queuedSize not decrease in HttpLoadQueuePeon when load failed

2019-09-26 Thread GitBox
himanshug commented on issue #8596: bugfix: fix queuedSize not decrease in HttpLoadQueuePeon when load failed URL: https://github.com/apache/incubator-druid/pull/8596#issuecomment-535566366 @pzhdfy thanks for finding and fixing it. --

[incubator-druid] branch master updated (9f1f5e1 -> a280c5d)

2019-09-26 Thread himanshug
This is an automated email from the ASF dual-hosted git repository. himanshug pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from 9f1f5e1 doubleMean aggregator to be used at query time (#8459) add a280c5d fix queuedSize not decr

[GitHub] [incubator-druid] himanshug merged pull request #8596: bugfix: fix queuedSize not decrease in HttpLoadQueuePeon when load failed

2019-09-26 Thread GitBox
himanshug merged pull request #8596: bugfix: fix queuedSize not decrease in HttpLoadQueuePeon when load failed URL: https://github.com/apache/incubator-druid/pull/8596 This is an automated message from the Apache Git Service

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-09-26 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r328694201 ## File path: benchmarks/src/main/java/org/apache/druid/benchmark/FloatCompressionBenchmarkFileGenerator.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-09-26 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r328694779 ## File path: benchmarks/src/main/java/org/apache/druid/benchmark/LongCompressionBenchmarkFileGenerator.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-09-26 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r328696122 ## File path: core/src/main/java/org/apache/druid/common/config/NullHandling.java ## @@ -29,6 +29,7 @

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-09-26 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r328694407 ## File path: benchmarks/src/main/java/org/apache/druid/benchmark/IncrementalIndexRowTypeBenchmark.java #

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-09-26 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r328695611 ## File path: benchmarks/src/main/java/org/apache/druid/benchmark/query/ScanBenchmark.java ## @@ -10

[GitHub] [incubator-druid] himanshug commented on issue #8489: Stateful auto compaction

2019-09-26 Thread GitBox
himanshug commented on issue #8489: Stateful auto compaction URL: https://github.com/apache/incubator-druid/issues/8489#issuecomment-535571305 > You mean if the compaction task has the exactly same tuningConfig? Then I think yes. I see, but then why segment is not candidate for comp

[GitHub] [incubator-druid] vogievetsky closed issue #7836: No scrolling in Web Interface

2019-09-26 Thread GitBox
vogievetsky closed issue #7836: No scrolling in Web Interface URL: https://github.com/apache/incubator-druid/issues/7836 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-druid] vogievetsky commented on issue #7836: No scrolling in Web Interface

2019-09-26 Thread GitBox
vogievetsky commented on issue #7836: No scrolling in Web Interface URL: https://github.com/apache/incubator-druid/issues/7836#issuecomment-535575099 This issue was fixed in 0.15 (and is still fixed in 0.16 :-p ) This is an a

[GitHub] [incubator-druid] leventov commented on issue #8167: Clarifying VersionedIntervalTimeline.findFullyOvershadowed()

2019-09-26 Thread GitBox
leventov commented on issue #8167: Clarifying VersionedIntervalTimeline.findFullyOvershadowed() URL: https://github.com/apache/incubator-druid/issues/8167#issuecomment-535575310 @jihoonson could you please answer here? This

[GitHub] [incubator-druid] glasser commented on issue #6284: include router node in rolling upgrade documentation

2019-09-26 Thread GitBox
glasser commented on issue #6284: include router node in rolling upgrade documentation URL: https://github.com/apache/incubator-druid/issues/6284#issuecomment-535622787 Given that the router is where the new web console lives, it is presumably no longer considered so experimental and shou

[GitHub] [incubator-druid] glasser edited a comment on issue #6284: include router node in rolling upgrade documentation

2019-09-26 Thread GitBox
glasser edited a comment on issue #6284: include router node in rolling upgrade documentation URL: https://github.com/apache/incubator-druid/issues/6284#issuecomment-535622787 Given that the router is where the new web console lives, it is presumably no longer considered so experimental a

[GitHub] [incubator-druid-website-src] rkingsland opened a new pull request #57: Update events.yml

2019-09-26 Thread GitBox
rkingsland opened a new pull request #57: Update events.yml URL: https://github.com/apache/incubator-druid-website-src/pull/57 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-druid-website-src] vogievetsky opened a new pull request #58: Fix Slack link

2019-09-26 Thread GitBox
vogievetsky opened a new pull request #58: Fix Slack link URL: https://github.com/apache/incubator-druid-website-src/pull/58 From ASF Infra channel: ![image](https://user-images.githubusercontent.com/177816/65727537-dd930380-e06c-11e9-9c3c-fe978711312a.png) Using `https://s.ap

[GitHub] [incubator-druid-website-src] clintropolis merged pull request #58: Fix Slack link

2019-09-26 Thread GitBox
clintropolis merged pull request #58: Fix Slack link URL: https://github.com/apache/incubator-druid-website-src/pull/58 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[incubator-druid-website-src] branch master updated: Fix Slack link (#58)

2019-09-26 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid-website-src.git The following commit(s) were added to refs/heads/master by this push: new dcfd861 Fix Slack link (#

[incubator-druid-website-src] 01/01: Add incubation disclaimer to downloads page

2019-09-26 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to branch disclaimer in repository https://gitbox.apache.org/repos/asf/incubator-druid-website-src.git commit 3779ad37b7d076e347217b5f06960d2400cbd9e0 Author: jon-wei AuthorDate: Thu Sep 26 14:55:48 2019

[incubator-druid-website-src] branch disclaimer created (now 3779ad3)

2019-09-26 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a change to branch disclaimer in repository https://gitbox.apache.org/repos/asf/incubator-druid-website-src.git. at 3779ad3 Add incubation disclaimer to downloads page This branch includes the following ne

[GitHub] [incubator-druid-website-src] jon-wei opened a new pull request #59: Add incubation disclaimer to downloads page

2019-09-26 Thread GitBox
jon-wei opened a new pull request #59: Add incubation disclaimer to downloads page URL: https://github.com/apache/incubator-druid-website-src/pull/59 This is an automated message from the Apache Git Service. To respond to th

[incubator-druid-website-src] branch master updated (dcfd861 -> 5b1a48a)

2019-09-26 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid-website-src.git. from dcfd861 Fix Slack link (#58) add 3779ad3 Add incubation disclaimer to downloads page

[GitHub] [incubator-druid-website-src] jon-wei merged pull request #59: Add incubation disclaimer to downloads page

2019-09-26 Thread GitBox
jon-wei merged pull request #59: Add incubation disclaimer to downloads page URL: https://github.com/apache/incubator-druid-website-src/pull/59 This is an automated message from the Apache Git Service. To respond to the messa

[incubator-druid-website-src] 01/01: Merge pull request #59 from apache/disclaimer

2019-09-26 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid-website-src.git commit 5b1a48afd863c010782758df4033ab0a16e77bd1 Merge: dcfd861 3779ad3 Author: Jonathan Wei AuthorDate: T

[incubator-druid-website-src] branch master updated: Update events.yml

2019-09-26 Thread vogievetsky
This is an automated email from the ASF dual-hosted git repository. vogievetsky pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid-website-src.git The following commit(s) were added to refs/heads/master by this push: new b79ddf8 Update event

[GitHub] [incubator-druid-website-src] vogievetsky commented on issue #57: Update events.yml

2019-09-26 Thread GitBox
vogievetsky commented on issue #57: Update events.yml URL: https://github.com/apache/incubator-druid-website-src/pull/57#issuecomment-535704980 gr 🎱 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-druid-website-src] vogievetsky merged pull request #57: Update events.yml

2019-09-26 Thread GitBox
vogievetsky merged pull request #57: Update events.yml URL: https://github.com/apache/incubator-druid-website-src/pull/57 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [incubator-druid-website] vogievetsky opened a new pull request #37: Autobuild

2019-09-26 Thread GitBox
vogievetsky opened a new pull request #37: Autobuild URL: https://github.com/apache/incubator-druid-website/pull/37 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-druid-website] clintropolis merged pull request #37: Autobuild

2019-09-26 Thread GitBox
clintropolis merged pull request #37: Autobuild URL: https://github.com/apache/incubator-druid-website/pull/37 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[incubator-druid-website] branch asf-site updated: Autobuild (#37)

2019-09-26 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-druid-website.git The following commit(s) were added to refs/heads/asf-site by this push: new d1b144b Autobuild (#37) d1

[GitHub] [incubator-druid] jon-wei opened a new pull request #8600: Fix download link in header links

2019-09-26 Thread GitBox
jon-wei opened a new pull request #8600: Fix download link in header links URL: https://github.com/apache/incubator-druid/pull/8600 This PR fixes the "Download" link when you're on a page under https://druid.apache.org/docs This PR has: - [x] been self-reviewed. -

[GitHub] [incubator-druid] jon-wei commented on issue #8126: [Proposal] BufferAggregator support for growable sketches.

2019-09-26 Thread GitBox
jon-wei commented on issue #8126: [Proposal] BufferAggregator support for growable sketches. URL: https://github.com/apache/incubator-druid/issues/8126#issuecomment-535718278 The proposal LGTM in general, there are a couple of areas I think need adjustment: - With vectorization, the gr

[incubator-druid] branch master updated (a280c5d -> 7f2b657)

2019-09-26 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from a280c5d fix queuedSize not decrease in HttpLoadQueuePeon when load failed (#8596) add 7f2b657 get ac

[GitHub] [incubator-druid] clintropolis merged pull request #8450: get active task by datasource when supervisor discover tasks

2019-09-26 Thread GitBox
clintropolis merged pull request #8450: get active task by datasource when supervisor discover tasks URL: https://github.com/apache/incubator-druid/pull/8450 This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-druid] jon-wei closed issue #8599: Download page needs to include incubation disclaimer

2019-09-26 Thread GitBox
jon-wei closed issue #8599: Download page needs to include incubation disclaimer URL: https://github.com/apache/incubator-druid/issues/8599 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-druid] jon-wei commented on issue #8599: Download page needs to include incubation disclaimer

2019-09-26 Thread GitBox
jon-wei commented on issue #8599: Download page needs to include incubation disclaimer URL: https://github.com/apache/incubator-druid/issues/8599#issuecomment-535723393 Thanks, we've added the disclaimer to the Download page. ---

[incubator-druid] branch master updated (7f2b657 -> 7781820)

2019-09-26 Thread jihoonson
This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from 7f2b657 get active task by datasource when supervisor discover tasks (#8450) add 7781820 JsonPars

[GitHub] [incubator-druid] jihoonson merged pull request #8550: JsonParserIterator.init future timeout

2019-09-26 Thread GitBox
jihoonson merged pull request #8550: JsonParserIterator.init future timeout URL: https://github.com/apache/incubator-druid/pull/8550 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-druid] clintropolis merged pull request #8600: Fix download link in doc page header links

2019-09-26 Thread GitBox
clintropolis merged pull request #8600: Fix download link in doc page header links URL: https://github.com/apache/incubator-druid/pull/8600 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-druid] branch master updated (7781820 -> 5f83cd8)

2019-09-26 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from 7781820 JsonParserIterator.init future timeout (#8550) add 5f83cd8 Fix download link in header links

[GitHub] [incubator-druid] clintropolis opened a new pull request #8601: [Backport] Fix download link in doc page header links

2019-09-26 Thread GitBox
clintropolis opened a new pull request #8601: [Backport] Fix download link in doc page header links URL: https://github.com/apache/incubator-druid/pull/8601 Backport of #8600 to 0.16.0-incubating. This is an automated message

[GitHub] [incubator-druid] SEKIRO-J commented on issue #7776: kafka indexing service should always use earliest offset for newly discovered topic-partitions instead of useEarliestOffset config

2019-09-26 Thread GitBox
SEKIRO-J commented on issue #7776: kafka indexing service should always use earliest offset for newly discovered topic-partitions instead of useEarliestOffset config URL: https://github.com/apache/incubator-druid/issues/7776#issuecomment-535747035 Seems like this feature already exists ba

[GitHub] [incubator-druid] clintropolis merged pull request #8601: [Backport] Fix download link in doc page header links

2019-09-26 Thread GitBox
clintropolis merged pull request #8601: [Backport] Fix download link in doc page header links URL: https://github.com/apache/incubator-druid/pull/8601 This is an automated message from the Apache Git Service. To respond to t

[incubator-druid] branch 0.16.0-incubating updated: Fix download link in header links (#8600) (#8601)

2019-09-26 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch 0.16.0-incubating in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/0.16.0-incubating by this push: new 3f623fb Fix down

[incubator-druid-website-src] branch download-from-doc-fix created (now 4b4b4f9)

2019-09-26 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch download-from-doc-fix in repository https://gitbox.apache.org/repos/asf/incubator-druid-website-src.git. at 4b4b4f9 update 0.16.0-incubating docs This branch includes the following new c

[GitHub] [incubator-druid-website-src] clintropolis opened a new pull request #60: update 0.16.0-incubating docs

2019-09-26 Thread GitBox
clintropolis opened a new pull request #60: update 0.16.0-incubating docs URL: https://github.com/apache/incubator-druid-website-src/pull/60 fix download link from docs section of website, https://github.com/apache/incubator-druid/pull/8601 -

[GitHub] [incubator-druid] FaxianZhao commented on a change in pull request #8598: bug fix for lookup leak when we remove the last lookup from lookup tier

2019-09-26 Thread GitBox
FaxianZhao commented on a change in pull request #8598: bug fix for lookup leak when we remove the last lookup from lookup tier URL: https://github.com/apache/incubator-druid/pull/8598#discussion_r328887741 ## File path: server/src/main/java/org/apache/druid/server/lookup/cache/Loo

[GitHub] [incubator-druid-website-src] clintropolis merged pull request #60: update 0.16.0-incubating docs

2019-09-26 Thread GitBox
clintropolis merged pull request #60: update 0.16.0-incubating docs URL: https://github.com/apache/incubator-druid-website-src/pull/60 This is an automated message from the Apache Git Service. To respond to the message, pleas

[incubator-druid-website-src] branch download-from-doc-fix deleted (was 4b4b4f9)

2019-09-26 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch download-from-doc-fix in repository https://gitbox.apache.org/repos/asf/incubator-druid-website-src.git. was 4b4b4f9 update 0.16.0-incubating docs The revisions that were on this branch a

[GitHub] [incubator-druid] SEKIRO-J edited a comment on issue #7776: kafka indexing service should always use earliest offset for newly discovered topic-partitions instead of useEarliestOffset config

2019-09-26 Thread GitBox
SEKIRO-J edited a comment on issue #7776: kafka indexing service should always use earliest offset for newly discovered topic-partitions instead of useEarliestOffset config URL: https://github.com/apache/incubator-druid/issues/7776#issuecomment-535747035 Seems like this feature already ex

[GitHub] [incubator-druid] SEKIRO-J edited a comment on issue #7776: kafka indexing service should always use earliest offset for newly discovered topic-partitions instead of useEarliestOffset config

2019-09-26 Thread GitBox
SEKIRO-J edited a comment on issue #7776: kafka indexing service should always use earliest offset for newly discovered topic-partitions instead of useEarliestOffset config URL: https://github.com/apache/incubator-druid/issues/7776#issuecomment-535747035 Seems like this feature already ex

[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #8590: update how to release doc

2019-09-26 Thread GitBox
asdf2014 commented on a change in pull request #8590: update how to release doc URL: https://github.com/apache/incubator-druid/pull/8590#discussion_r328897724 ## File path: distribution/asf-release-process-guide.md ## @@ -566,17 +663,17 @@ http://www.apache.org/legal/relea

[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #8590: update how to release doc

2019-09-26 Thread GitBox
asdf2014 commented on a change in pull request #8590: update how to release doc URL: https://github.com/apache/incubator-druid/pull/8590#discussion_r328896791 ## File path: distribution/asf-release-process-guide.md ## @@ -207,7 +207,7 @@ git clone g...@github.com:apache/inc

[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #8590: update how to release doc

2019-09-26 Thread GitBox
asdf2014 commented on a change in pull request #8590: update how to release doc URL: https://github.com/apache/incubator-druid/pull/8590#discussion_r328897320 ## File path: distribution/asf-release-process-guide.md ## @@ -601,31 +698,55 @@ Additionally, announce it to the D

[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #8590: update how to release doc

2019-09-26 Thread GitBox
asdf2014 commented on a change in pull request #8590: update how to release doc URL: https://github.com/apache/incubator-druid/pull/8590#discussion_r328897114 ## File path: distribution/asf-release-process-guide.md ## @@ -256,11 +256,28 @@ $ svn checkout https://dist.apach

[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #8590: update how to release doc

2019-09-26 Thread GitBox
asdf2014 commented on a change in pull request #8590: update how to release doc URL: https://github.com/apache/incubator-druid/pull/8590#discussion_r328897751 ## File path: distribution/asf-release-process-guide.md ## @@ -256,11 +256,28 @@ $ svn checkout https://dist.apach

[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #8590: update how to release doc

2019-09-26 Thread GitBox
asdf2014 commented on a change in pull request #8590: update how to release doc URL: https://github.com/apache/incubator-druid/pull/8590#discussion_r328896434 ## File path: distribution/asf-release-process-guide.md ## @@ -191,10 +191,10 @@ Next create an issue in the Druid

[GitHub] [incubator-druid] Fokko commented on issue #8404: Bump HttpClient to 4.5.10

2019-09-26 Thread GitBox
Fokko commented on issue #8404: Bump HttpClient to 4.5.10 URL: https://github.com/apache/incubator-druid/pull/8404#issuecomment-535788435 Any further comments before merging this @clintropolis ? I've added the license back. T

[GitHub] [incubator-druid] himanshug commented on a change in pull request #8598: bug fix for lookup leak when we remove the last lookup from lookup tier

2019-09-26 Thread GitBox
himanshug commented on a change in pull request #8598: bug fix for lookup leak when we remove the last lookup from lookup tier URL: https://github.com/apache/incubator-druid/pull/8598#discussion_r328915333 ## File path: server/src/main/java/org/apache/druid/server/lookup/cache/Look

[GitHub] [incubator-druid] himanshug commented on issue #6284: include router node in rolling upgrade documentation

2019-09-26 Thread GitBox
himanshug commented on issue #6284: include router node in rolling upgrade documentation URL: https://github.com/apache/incubator-druid/issues/6284#issuecomment-535789706 I agree. This is an automated message from the Apache

[GitHub] [incubator-druid] SandishKumarHN commented on issue #8558: 7227 : Prohibit Non Final Static Field

2019-09-26 Thread GitBox
SandishKumarHN commented on issue #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#issuecomment-535793321 @leventov fixed This is an automated message from the Apache Git S

[GitHub] [incubator-druid] jihoonson commented on issue #8489: Stateful auto compaction

2019-09-26 Thread GitBox
jihoonson commented on issue #8489: Stateful auto compaction URL: https://github.com/apache/incubator-druid/issues/8489#issuecomment-535794960 > I see, but then why segment is not candidate for compaction when it has same partitionSpec .. if tuningConfig is different then it could still pr

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8573: Stateful auto compaction

2019-09-26 Thread GitBox
jihoonson commented on a change in pull request #8573: Stateful auto compaction URL: https://github.com/apache/incubator-druid/pull/8573#discussion_r328919770 ## File path: server/src/main/java/org/apache/druid/server/coordinator/helper/DruidCoordinatorSegmentCompactor.java ###

[GitHub] [incubator-druid] jihoonson commented on issue #8573: Stateful auto compaction

2019-09-26 Thread GitBox
jihoonson commented on issue #8573: Stateful auto compaction URL: https://github.com/apache/incubator-druid/pull/8573#issuecomment-535796161 > i.e. user can explicitly run `CompactionTask` with any partitionSpec . Auto compaction does not take partitionsSpec as config ... right ? For

[GitHub] [incubator-druid] jihoonson commented on issue #8038: Making optimal usage of multiple segment cache locations

2019-09-26 Thread GitBox
jihoonson commented on issue #8038: Making optimal usage of multiple segment cache locations URL: https://github.com/apache/incubator-druid/pull/8038#issuecomment-535796597 @sashidhar thanks for the quick update! I'll finish my review once https://github.com/apache/incubator-druid/pull/803

[GitHub] [incubator-druid] tan31989 commented on issue #1341: SocketUtil.findOpenPort does not always find a desired port correctly for unit tests

2019-09-26 Thread GitBox
tan31989 commented on issue #1341: SocketUtil.findOpenPort does not always find a desired port correctly for unit tests URL: https://github.com/apache/incubator-druid/issues/1341#issuecomment-535803827 @fjy is this ticket still up for fix? -

[GitHub] [incubator-druid] sashidhar commented on a change in pull request #8038: Making optimal usage of multiple segment cache locations

2019-09-26 Thread GitBox
sashidhar commented on a change in pull request #8038: Making optimal usage of multiple segment cache locations URL: https://github.com/apache/incubator-druid/pull/8038#discussion_r328927992 ## File path: server/src/main/java/org/apache/druid/segment/loading/RoundRobinStorageLocati

[GitHub] [incubator-druid] FaxianZhao commented on a change in pull request #8598: bug fix for lookup leak when we remove the last lookup from lookup tier

2019-09-26 Thread GitBox
FaxianZhao commented on a change in pull request #8598: bug fix for lookup leak when we remove the last lookup from lookup tier URL: https://github.com/apache/incubator-druid/pull/8598#discussion_r328935622 ## File path: server/src/main/java/org/apache/druid/server/lookup/cache/Loo