[GitHub] [druid] himanshug commented on issue #9518: AWS RDS token based password provider

2020-03-26 Thread GitBox
himanshug commented on issue #9518: AWS RDS token based password provider URL: https://github.com/apache/druid/pull/9518#issuecomment-604267819 Update: This patch has been successfully running on few Druid clusters using AWS Aurora RDS DB clusters and accessing same without password but

[GitHub] [druid] jihoonson commented on issue #9518: AWS RDS token based password provider

2020-03-26 Thread GitBox
jihoonson commented on issue #9518: AWS RDS token based password provider URL: https://github.com/apache/druid/pull/9518#issuecomment-604269390 @himanshug thanks for the update. I removed the `Area - SQL` tag because I think it's about Druid SQL layer. I haven't looked through the whole PR

[GitHub] [druid] himanshug commented on issue #9518: AWS RDS token based password provider

2020-03-26 Thread GitBox
himanshug commented on issue #9518: AWS RDS token based password provider URL: https://github.com/apache/druid/pull/9518#issuecomment-604272488 removing `Area - SQL` makes sense now that I think about it. I actually thought of putting the new `PasswordProvider` in an extension.

[GitHub] [druid] aP0StAl opened a new pull request #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder

2020-03-26 Thread GitBox
aP0StAl opened a new pull request #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder URL: https://github.com/apache/druid/pull/9568 ### Description Fixed the bug with allocating a large amount of memory in the buffer --

[GitHub] [druid] soumyajose0784 opened a new issue #9569: SSO support in Druid

2020-03-26 Thread GitBox
soumyajose0784 opened a new issue #9569: SSO support in Druid URL: https://github.com/apache/druid/issues/9569 Could anyone guide me on enabling SSO in Druid? Please share the steps if available. We have Druid single node implementation in GKE, and had successfully tested LDAP and

[GitHub] [druid] himanshug commented on issue #9569: SSO support in Druid

2020-03-26 Thread GitBox
himanshug commented on issue #9569: SSO support in Druid URL: https://github.com/apache/druid/issues/9569#issuecomment-604538816 can you describe what you are hoping to achieve with SSO .. do you need this to ensure that only a limited set of people could use the router web console ?

[GitHub] [druid] jihoonson commented on issue #9518: AWS RDS token based password provider

2020-03-26 Thread GitBox
jihoonson commented on issue #9518: AWS RDS token based password provider URL: https://github.com/apache/druid/pull/9518#issuecomment-604546952 Thanks, I will review soon. This is an automated message from the Apache Git Serv

[GitHub] [druid] himanshug commented on issue #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder

2020-03-26 Thread GitBox
himanshug commented on issue #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder URL: https://github.com/apache/druid/pull/9568#issuecomment-604549897 +1 after build, thanks , good catch. How did you get to this? this was really sneaky.

[GitHub] [druid] suneet-s commented on issue #9559: error on value counter overflow instead of writing sad segments

2020-03-26 Thread GitBox
suneet-s commented on issue #9559: error on value counter overflow instead of writing sad segments URL: https://github.com/apache/druid/pull/9559#issuecomment-604604655 > but would also occur for any serializer given more than `Integer.MAX_VALUES` rows as input. Can this happen? `ma

[GitHub] [druid] himanshug commented on issue #9564: Framework for aggregate testing; Example tests with LongSumAggregatorFactory

2020-03-26 Thread GitBox
himanshug commented on issue #9564: Framework for aggregate testing; Example tests with LongSumAggregatorFactory URL: https://github.com/apache/druid/pull/9564#issuecomment-604608102 +1 , since it improves the current state. however, even after this there is significant effort required to

[GitHub] [druid] himanshug edited a comment on issue #9564: Framework for aggregate testing; Example tests with LongSumAggregatorFactory

2020-03-26 Thread GitBox
himanshug edited a comment on issue #9564: Framework for aggregate testing; Example tests with LongSumAggregatorFactory URL: https://github.com/apache/druid/pull/9564#issuecomment-604608102 +1 , since it improves the current state. however, even after this there is significant effort requ

[GitHub] [druid] suneet-s commented on a change in pull request #9559: error on value counter overflow instead of writing sad segments

2020-03-26 Thread GitBox
suneet-s commented on a change in pull request #9559: error on value counter overflow instead of writing sad segments URL: https://github.com/apache/druid/pull/9559#discussion_r398815721 ## File path: processing/src/main/java/org/apache/druid/segment/data/ColumnarDoublesSerializer.

[GitHub] [druid] vogievetsky commented on a change in pull request #9567: fix global filter input

2020-03-26 Thread GitBox
vogievetsky commented on a change in pull request #9567: fix global filter input URL: https://github.com/apache/druid/pull/9567#discussion_r398817796 ## File path: web-console/src/views/load-data-view/load-data-view.tsx ## @@ -2094,19 +2096,25 @@ export class LoadDataView e

[GitHub] [druid] aP0StAl commented on issue #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder

2020-03-26 Thread GitBox
aP0StAl commented on issue #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder URL: https://github.com/apache/druid/pull/9568#issuecomment-604623813 @himanshug I found this when I was trying to figure out how to implement a module to solve [this](https://github.com/apache/druid/issues/953

[GitHub] [druid] aP0StAl commented on issue #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder

2020-03-26 Thread GitBox
aP0StAl commented on issue #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder URL: https://github.com/apache/druid/pull/9568#issuecomment-604624356 @jihoonson Ok. I will add a test tomorrow. This is an automated message fro

[GitHub] [druid] himanshug commented on issue #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder

2020-03-26 Thread GitBox
himanshug commented on issue #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder URL: https://github.com/apache/druid/pull/9568#issuecomment-604626374 got it, so you were looking at the code and knew Long.SIZE wan't number of bytes but bits. > In some cases, the object may turn

[GitHub] [druid] aP0StAl commented on issue #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder

2020-03-26 Thread GitBox
aP0StAl commented on issue #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder URL: https://github.com/apache/druid/pull/9568#issuecomment-604641009 Are you sure? I had an exception before I fixed a similar code (deserialize and finalizeComputation): `} else if (object instanceof byte[

[GitHub] [druid] jihoonson commented on issue #9564: Framework for aggregate testing; Example tests with LongSumAggregatorFactory

2020-03-26 Thread GitBox
jihoonson commented on issue #9564: Framework for aggregate testing; Example tests with LongSumAggregatorFactory URL: https://github.com/apache/druid/pull/9564#issuecomment-604642637 > however, even after this there is significant effort required to thoroughly test a new aggregator that on

[GitHub] [druid] clintropolis commented on issue #9559: error on value counter overflow instead of writing sad segments

2020-03-26 Thread GitBox
clintropolis commented on issue #9559: error on value counter overflow instead of writing sad segments URL: https://github.com/apache/druid/pull/9559#issuecomment-604643356 >Can this happen? maxRowsPerSegment is an Integer in the partitionSpec It _shouldn't_ happen, but nothing in th

[GitHub] [druid] clintropolis commented on a change in pull request #9559: error on value counter overflow instead of writing sad segments

2020-03-26 Thread GitBox
clintropolis commented on a change in pull request #9559: error on value counter overflow instead of writing sad segments URL: https://github.com/apache/druid/pull/9559#discussion_r398844534 ## File path: processing/src/main/java/org/apache/druid/segment/data/ColumnarDoublesSeriali

[GitHub] [druid] suneet-s commented on a change in pull request #9559: error on value counter overflow instead of writing sad segments

2020-03-26 Thread GitBox
suneet-s commented on a change in pull request #9559: error on value counter overflow instead of writing sad segments URL: https://github.com/apache/druid/pull/9559#discussion_r398846944 ## File path: processing/src/main/java/org/apache/druid/segment/data/ColumnarDoublesSerializer.

[GitHub] [druid] michaelschiff commented on issue #8621: prometheus-emitter

2020-03-26 Thread GitBox
michaelschiff commented on issue #8621: prometheus-emitter URL: https://github.com/apache/druid/pull/8621#issuecomment-604654592 @cxlRay do you see the appropriate port open by each of the druid processes? If so can you try to `curl` the metrics endpoint there? --

[GitHub] [druid] himanshug commented on issue #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder

2020-03-26 Thread GitBox
himanshug commented on issue #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder URL: https://github.com/apache/druid/pull/9568#issuecomment-604655177 can you send me the druid query that reproduces that ? This is an autom

[GitHub] [druid] ccaominh merged pull request #9560: Instructions to run integration tests against quickstart

2020-03-26 Thread GitBox
ccaominh merged pull request #9560: Instructions to run integration tests against quickstart URL: https://github.com/apache/druid/pull/9560 This is an automated message from the Apache Git Service. To respond to the message,

[druid] branch master updated (55c08e0 -> e6e2836)

2020-03-26 Thread ccaominh
This is an automated email from the ASF dual-hosted git repository. ccaominh pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 55c08e0 DruidSegmentReader should work if timestamp is specified as a dimension (#9530) add e6e2836 Instruct

[GitHub] [druid] himanshug edited a comment on issue #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder

2020-03-26 Thread GitBox
himanshug edited a comment on issue #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder URL: https://github.com/apache/druid/pull/9568#issuecomment-604655177 can you send me the druid query that reproduces that of getting byte[] in doubleMean deserialaize(..) ? ---

[GitHub] [druid] himanshug edited a comment on issue #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder

2020-03-26 Thread GitBox
himanshug edited a comment on issue #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder URL: https://github.com/apache/druid/pull/9568#issuecomment-604655177 can you send me the druid query that reproduces that of getting byte[] in doubleMean deserialize(..) ?

[GitHub] [druid] stale[bot] commented on issue #7400: Allow users to use a provider for metadata username

2020-03-26 Thread GitBox
stale[bot] commented on issue #7400: Allow users to use a provider for metadata username URL: https://github.com/apache/druid/issues/7400#issuecomment-604693466 This issue has been marked as stale due to 280 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If

[GitHub] [druid] stale[bot] commented on issue #7132: [DISCUSS] Behavior of Granularity.getIterable()

2020-03-26 Thread GitBox
stale[bot] commented on issue #7132: [DISCUSS] Behavior of Granularity.getIterable() URL: https://github.com/apache/druid/issues/7132#issuecomment-604693473 This issue has been marked as stale due to 280 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If thi

[GitHub] [druid] himanshug edited a comment on issue #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder

2020-03-26 Thread GitBox
himanshug edited a comment on issue #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder URL: https://github.com/apache/druid/pull/9568#issuecomment-604655177 can you send me the druid query that reproduces behavior that of getting byte[] in doubleMean deserialize(..) ? ---

[GitHub] [druid] jihoonson commented on a change in pull request #9563: add lane enforcement for joinish queries

2020-03-26 Thread GitBox
jihoonson commented on a change in pull request #9563: add lane enforcement for joinish queries URL: https://github.com/apache/druid/pull/9563#discussion_r398895308 ## File path: server/src/main/java/org/apache/druid/server/LocalQuerySegmentWalker.java ## @@ -107,17 +116,

[GitHub] [druid] jihoonson commented on a change in pull request #9563: add lane enforcement for joinish queries

2020-03-26 Thread GitBox
jihoonson commented on a change in pull request #9563: add lane enforcement for joinish queries URL: https://github.com/apache/druid/pull/9563#discussion_r398887945 ## File path: server/src/main/java/org/apache/druid/server/ClientQuerySegmentWalker.java ## @@ -462,7 +462,

[GitHub] [druid] xvrl opened a new pull request #9570: fix nullhandling exceptions related to test ordering

2020-03-26 Thread GitBox
xvrl opened a new pull request #9570: fix nullhandling exceptions related to test ordering URL: https://github.com/apache/druid/pull/9570 Tests might get executed in different order depending on the maven version and the test environment. This may lead to `NullHandling module not initiali

[GitHub] [druid] jihoonson commented on a change in pull request #9570: fix nullhandling exceptions related to test ordering

2020-03-26 Thread GitBox
jihoonson commented on a change in pull request #9570: fix nullhandling exceptions related to test ordering URL: https://github.com/apache/druid/pull/9570#discussion_r398912755 ## File path: extensions-core/hdfs-storage/src/test/java/org/apache/druid/inputsource/hdfs/HdfsInputSourc

[GitHub] [druid] xvrl commented on a change in pull request #9570: fix nullhandling exceptions related to test ordering

2020-03-26 Thread GitBox
xvrl commented on a change in pull request #9570: fix nullhandling exceptions related to test ordering URL: https://github.com/apache/druid/pull/9570#discussion_r398915581 ## File path: extensions-core/hdfs-storage/src/test/java/org/apache/druid/inputsource/hdfs/HdfsInputSourceTest

[GitHub] [druid] jihoonson commented on a change in pull request #9570: fix nullhandling exceptions related to test ordering

2020-03-26 Thread GitBox
jihoonson commented on a change in pull request #9570: fix nullhandling exceptions related to test ordering URL: https://github.com/apache/druid/pull/9570#discussion_r398916305 ## File path: extensions-core/hdfs-storage/src/test/java/org/apache/druid/inputsource/hdfs/HdfsInputSourc

[GitHub] [druid] clintropolis commented on issue #9559: error on value counter overflow instead of writing sad segments

2020-03-26 Thread GitBox
clintropolis commented on issue #9559: error on value counter overflow instead of writing sad segments URL: https://github.com/apache/druid/pull/9559#issuecomment-604722125 >VSizeColumnarInts#get does this calculation Ah, i forgot to mention in the description that I didn't update `

[GitHub] [druid] suneet-s commented on issue #9559: error on value counter overflow instead of writing sad segments

2020-03-26 Thread GitBox
suneet-s commented on issue #9559: error on value counter overflow instead of writing sad segments URL: https://github.com/apache/druid/pull/9559#issuecomment-604725370 @clintropolis Makes sense. I'm just going to read through all the implementations now... ---

[GitHub] [druid] jihoonson opened a new issue #9571: Race in SegmentAllocateAction with segment lock

2020-03-26 Thread GitBox
jihoonson opened a new issue #9571: Race in SegmentAllocateAction with segment lock URL: https://github.com/apache/druid/issues/9571 ### Affected Version 0.16, 0.17 ### Description Before 0.16, everything was simple and there was only one type of task lock, i.e., time

[GitHub] [druid] himanshug commented on issue #9564: Framework for aggregate testing; Example tests with LongSumAggregatorFactory

2020-03-26 Thread GitBox
himanshug commented on issue #9564: Framework for aggregate testing; Example tests with LongSumAggregatorFactory URL: https://github.com/apache/druid/pull/9564#issuecomment-604735785 > Would you tell me more about this I was referring to all the extra code it took to test LongSum a

[GitHub] [druid] himanshug edited a comment on issue #9564: Framework for aggregate testing; Example tests with LongSumAggregatorFactory

2020-03-26 Thread GitBox
himanshug edited a comment on issue #9564: Framework for aggregate testing; Example tests with LongSumAggregatorFactory URL: https://github.com/apache/druid/pull/9564#issuecomment-604735785 > Would you tell me more about this I was referring to all the extra code it took to test Lo

[GitHub] [druid] stale[bot] commented on issue #7511: Support config files in yaml/json

2020-03-26 Thread GitBox
stale[bot] commented on issue #7511: Support config files in yaml/json URL: https://github.com/apache/druid/issues/7511#issuecomment-604736409 This issue has been marked as stale due to 280 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If this issue is stil

[druid] branch master updated (e6e2836 -> 2c49f6d)

2020-03-26 Thread jihoonson
This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from e6e2836 Instructions to run integration tests against quickstart (#9560) add 2c49f6d error on value counter

[GitHub] [druid] jihoonson merged pull request #9559: error on value counter overflow instead of writing sad segments

2020-03-26 Thread GitBox
jihoonson merged pull request #9559: error on value counter overflow instead of writing sad segments URL: https://github.com/apache/druid/pull/9559 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [druid] xvrl commented on a change in pull request #9570: fix nullhandling exceptions related to test ordering

2020-03-26 Thread GitBox
xvrl commented on a change in pull request #9570: fix nullhandling exceptions related to test ordering URL: https://github.com/apache/druid/pull/9570#discussion_r398967538 ## File path: extensions-core/hdfs-storage/src/test/java/org/apache/druid/inputsource/hdfs/HdfsInputSourceTest

[GitHub] [druid] clintropolis opened a new pull request #9572: [Backport] error on value counter overflow instead of writing sad segments

2020-03-26 Thread GitBox
clintropolis opened a new pull request #9572: [Backport] error on value counter overflow instead of writing sad segments URL: https://github.com/apache/druid/pull/9572 Backport of #9559 to 0.18.0. This is an automated message

[GitHub] [druid] stale[bot] commented on issue #7450: SQL: Support "subtotalsSpec"

2020-03-26 Thread GitBox
stale[bot] commented on issue #7450: SQL: Support "subtotalsSpec" URL: https://github.com/apache/druid/issues/7450#issuecomment-604807023 This issue has been marked as stale due to 280 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If this issue is still re

[GitHub] [druid] stale[bot] commented on issue #7426: druid-cassandra-storage doesn't include high-scale-lib dependency

2020-03-26 Thread GitBox
stale[bot] commented on issue #7426: druid-cassandra-storage doesn't include high-scale-lib dependency URL: https://github.com/apache/druid/issues/7426#issuecomment-604807027 This issue has been marked as stale due to 280 days of inactivity. It will be closed in 4 weeks if no further acti

[GitHub] [druid] soumyajose0784 commented on issue #9569: SSO support in Druid

2020-03-26 Thread GitBox
soumyajose0784 commented on issue #9569: SSO support in Druid URL: https://github.com/apache/druid/issues/9569#issuecomment-604812330 Hi Himanshu, Thanks for your response. By SSO(single sign on), we are looking to authenticate users to Druid with the exiting active login to the system u

[GitHub] [druid] aP0StAl commented on issue #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder

2020-03-26 Thread GitBox
aP0StAl commented on issue #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder URL: https://github.com/apache/druid/pull/9568#issuecomment-604826770 @himanshug It can be either deserialize or finalizeComputation: `{ "queryType": "groupBy", "dataSource": "test_4", "granula

[GitHub] [druid] aP0StAl closed pull request #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder

2020-03-26 Thread GitBox
aP0StAl closed pull request #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder URL: https://github.com/apache/druid/pull/9568 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [druid] aP0StAl edited a comment on issue #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder

2020-03-26 Thread GitBox
aP0StAl edited a comment on issue #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder URL: https://github.com/apache/druid/pull/9568#issuecomment-604826770 @himanshug It can be either deserialize or finalizeComputation: > { > "queryType": "groupBy", > "dataSource": "test_

[GitHub] [druid] aP0StAl opened a new pull request #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder

2020-03-26 Thread GitBox
aP0StAl opened a new pull request #9568: fix MAX_INTERMEDIATE_SIZE for DoubleMeanHolder URL: https://github.com/apache/druid/pull/9568 ### Description Fixed the bug with allocating a large amount of memory in the buffer ---

[GitHub] [druid] himanshug commented on issue #9569: SSO support in Druid

2020-03-26 Thread GitBox
himanshug commented on issue #9569: SSO support in Druid URL: https://github.com/apache/druid/issues/9569#issuecomment-604835405 I think https://druid.apache.org/docs/latest/development/extensions-core/druid-basic-security.html supports LDAP ---

[GitHub] [druid] 1ambda commented on issue #8663: Kafka indexing service duplicate entry exception in druid_pendingSegments

2020-03-26 Thread GitBox
1ambda commented on issue #8663: Kafka indexing service duplicate entry exception in druid_pendingSegments URL: https://github.com/apache/druid/issues/8663#issuecomment-604840829 Faced the same issue too. I am using 0.16.1 Th