[GitHub] [druid] lgtm-com[bot] commented on pull request #9898: support Aliyun OSS service as deep storage

2020-05-20 Thread GitBox
lgtm-com[bot] commented on pull request #9898: URL: https://github.com/apache/druid/pull/9898#issuecomment-631284211 This pull request **introduces 1 alert** when merging 2860f94b6304fb349b94b2da24cea6f57466bb60 into 5b4b5d77a81817baf4359574d61e2dd2acabddba - [view on LGTM.com](https://lg

[GitHub] [druid] maytasm opened a new pull request #9900: Remove warn log message when metricSpec is explicitly set to empty

2020-05-20 Thread GitBox
maytasm opened a new pull request #9900: URL: https://github.com/apache/druid/pull/9900 Remove warn log message when metricSpec is explicitly set to empty ### Description Saw the warning messages, `org.apache.druid.segment.indexing.DataSchema - No metricsSpec has been specifie

[GitHub] [druid] maytasm opened a new pull request #9901: Fix Hadoop IT Legacy test query json was not parameterized

2020-05-20 Thread GitBox
maytasm opened a new pull request #9901: URL: https://github.com/apache/druid/pull/9901 Fix Hadoop IT Legacy test query json was not parameterized ### Description Hadoop Integration test (like every other integration tests) can be run with -Dextra.datasource.name.suffix= to set th

[druid] branch master updated: Enforce code coverage (#9863)

2020-05-20 Thread ccaominh
This is an automated email from the ASF dual-hosted git repository. ccaominh pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 427239f Enforce code coverage (#9863) 427239f

[GitHub] [druid] ccaominh merged pull request #9863: Enforce code coverage

2020-05-20 Thread GitBox
ccaominh merged pull request #9863: URL: https://github.com/apache/druid/pull/9863 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [druid] stale[bot] commented on pull request #9428: Adding request logging support to the Kafka-Emitter extension

2020-05-20 Thread GitBox
stale[bot] commented on pull request #9428: URL: https://github.com/apache/druid/pull/9428#issuecomment-631588073 This pull request/issue is no longer marked as stale. This is an automated message from the Apache Git Serv

[GitHub] [druid] ccaominh commented on a change in pull request #9891: Fix deleting a data node tier causes load rules to display incorrectly

2020-05-20 Thread GitBox
ccaominh commented on a change in pull request #9891: URL: https://github.com/apache/druid/pull/9891#discussion_r428157803 ## File path: web-console/src/components/rule-editor/rule-editor.spec.tsx ## @@ -36,4 +36,64 @@ describe('rule editor', () => { const { container } =

[druid] branch master updated (427239f -> 2050f2b)

2020-05-20 Thread ccaominh
This is an automated email from the ASF dual-hosted git repository. ccaominh pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 427239f Enforce code coverage (#9863) add 2050f2b fix docs error: google to azure and hdfs to http (#9881) N

[GitHub] [druid] ccaominh merged pull request #9881: fix docs error: google to azure and hdfs to http

2020-05-20 Thread GitBox
ccaominh merged pull request #9881: URL: https://github.com/apache/druid/pull/9881 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [druid] ccaominh commented on a change in pull request #9885: add some details to the build doc

2020-05-20 Thread GitBox
ccaominh commented on a change in pull request #9885: URL: https://github.com/apache/druid/pull/9885#discussion_r428182451 ## File path: website/.spelling ## @@ -1750,3 +1750,5 @@ CVE-2019-17571 CVE-2019-12399 CVE-2018-17196 bin.tar.gz +Ddruid.console.skip Review comment:

[GitHub] [druid] clintropolis commented on a change in pull request #9893: Add REGEXP_LIKE, fix bugs in REGEXP_EXTRACT.

2020-05-20 Thread GitBox
clintropolis commented on a change in pull request #9893: URL: https://github.com/apache/druid/pull/9893#discussion_r427752016 ## File path: docs/querying/sql.md ## @@ -322,17 +322,18 @@ String functions accept strings, and return a type appropriate to the function. |`LOWER(e

[GitHub] [druid] clintropolis commented on a change in pull request #9731: ColumnCapabilities.hasMultipleValues refactor

2020-05-20 Thread GitBox
clintropolis commented on a change in pull request #9731: URL: https://github.com/apache/druid/pull/9731#discussion_r428254895 ## File path: processing/src/main/java/org/apache/druid/segment/incremental/IncrementalIndexStorageAdapter.java ## @@ -142,24 +141,8 @@ public Compara

[GitHub] [druid] clintropolis commented on a change in pull request #9731: ColumnCapabilities.hasMultipleValues refactor

2020-05-20 Thread GitBox
clintropolis commented on a change in pull request #9731: URL: https://github.com/apache/druid/pull/9731#discussion_r428255335 ## File path: processing/src/main/java/org/apache/druid/segment/ColumnSelectorBitmapIndexSelector.java ## @@ -160,11 +160,11 @@ public void close() th

[GitHub] [druid] maytasm closed pull request #9900: Remove warn log message when metricSpec is explicitly set to empty

2020-05-20 Thread GitBox
maytasm closed pull request #9900: URL: https://github.com/apache/druid/pull/9900 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [druid] maytasm commented on a change in pull request #9891: Fix deleting a data node tier causes load rules to display incorrectly

2020-05-20 Thread GitBox
maytasm commented on a change in pull request #9891: URL: https://github.com/apache/druid/pull/9891#discussion_r428336261 ## File path: web-console/src/components/rule-editor/rule-editor.spec.tsx ## @@ -36,4 +36,64 @@ describe('rule editor', () => { const { container } = r

[GitHub] [druid] jon-wei commented on a change in pull request #9879: Querying doc refresh tutorial

2020-05-20 Thread GitBox
jon-wei commented on a change in pull request #9879: URL: https://github.com/apache/druid/pull/9879#discussion_r428336359 ## File path: docs/tutorials/tutorial-query.md ## @@ -24,56 +24,165 @@ sidebar_label: "Querying data" --> -This tutorial will demonstrate how to quer

[GitHub] [druid] marcusgreer commented on issue #9842: Intermittent NullPointerExceptions in causing Task Failure

2020-05-20 Thread GitBox
marcusgreer commented on issue #9842: URL: https://github.com/apache/druid/issues/9842#issuecomment-631792744 Sorry for the delay. Yes, here are the logs surrounding the NPE, I can also pass along more information from these logs, ``` 2020-04-15T16:12:59,438 INFO [qtp930569137-80] o

[GitHub] [druid] marcusgreer edited a comment on issue #9842: Intermittent NullPointerExceptions in causing Task Failure

2020-05-20 Thread GitBox
marcusgreer edited a comment on issue #9842: URL: https://github.com/apache/druid/issues/9842#issuecomment-631792744 Sorry for the delay. Yes, here are the logs surrounding the NPE, I can also pass along more information from the full logs if needed ``` 2020-04-15T16:12:59,438 INFO [q

[druid] branch master updated: Fix deleting a data node tier causes load rules to display incorrectly (#9891)

2020-05-20 Thread ccaominh
This is an automated email from the ASF dual-hosted git repository. ccaominh pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new f470bcd Fix deleting a data node tier causes l

[GitHub] [druid] ccaominh merged pull request #9891: Fix deleting a data node tier causes load rules to display incorrectly

2020-05-20 Thread GitBox
ccaominh merged pull request #9891: URL: https://github.com/apache/druid/pull/9891 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [druid] xvrl opened a new pull request #9902: update kafka version to 2.5.0 and lz4 to 1.7.1

2020-05-20 Thread GitBox
xvrl opened a new pull request #9902: URL: https://github.com/apache/druid/pull/9902 Keeps LZ4 version in line with the version shipped with Kafka This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [druid] ccaominh opened a new pull request #9903: Suppress CVEs for openstack-keystone

2020-05-20 Thread GitBox
ccaominh opened a new pull request #9903: URL: https://github.com/apache/druid/pull/9903 ### Description CVE-2020-12689, CVE-2020-12691, and CVE-2020-12690 can be ignored for openstack-keystone as they are for the python SDK and druid uses the java SDK. This PR has:

[GitHub] [druid] yuanlihan opened a new issue #9904: Fail to compact overlapping segments

2020-05-20 Thread GitBox
yuanlihan opened a new issue #9904: URL: https://github.com/apache/druid/issues/9904 ### Affected Version Found in 0.16.x and 0.18.x. ### Description Compaction task will create segments with `VersionedIntervalTimeline` conflicting when compacting overlapping segments w

[GitHub] [druid] yuanlihan opened a new pull request #9905: Fix compact overlapping segments

2020-05-20 Thread GitBox
yuanlihan opened a new pull request #9905: URL: https://github.com/apache/druid/pull/9905 ### Description this PR fixes https://github.com/apache/druid/issues/9904 by unifying overlapping intervals to ensure overlapping segments compacting in the same `indexSpec`. This PR has

[GitHub] [druid] yuanlihan commented on issue #9894: Ineffective "segmentGranularity" with customized "duration granularity"

2020-05-20 Thread GitBox
yuanlihan commented on issue #9894: URL: https://github.com/apache/druid/issues/9894#issuecomment-631849831 Hi @qyb225, I also noticed this issue before and concluded that this feature only works in batch indexing task. Thi

[GitHub] [druid] jihoonson commented on pull request #9905: Fix compact overlapping segments

2020-05-20 Thread GitBox
jihoonson commented on pull request #9905: URL: https://github.com/apache/druid/pull/9905#issuecomment-631854837 If I'm reading this change correctly, the compaction task will read both old and new segments for those overlapping intervals. This doesn't seem right to me since the new segmen

[GitHub] [druid] yuanlihan commented on issue #9889: Add new configuration for kill task to skip segments that has been last modified within the config value time

2020-05-20 Thread GitBox
yuanlihan commented on issue #9889: URL: https://github.com/apache/druid/issues/9889#issuecomment-631864599 Hi @maytasm, I like this `druid.coordinator.kill.fromLastModified` idea while I have a few confusion about it. Does this `druid.coordinator.kill.fromLastModified` configuratio

[GitHub] [druid] clintropolis merged pull request #9901: Fix Hadoop IT Legacy test query json was not parameterized

2020-05-20 Thread GitBox
clintropolis merged pull request #9901: URL: https://github.com/apache/druid/pull/9901 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[druid] branch master updated (f470bcd -> 9db29b9)

2020-05-20 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from f470bcd Fix deleting a data node tier causes load rules to display incorrectly (#9891) add 9db29b9 Fix Hadoop

[GitHub] [druid] yuanlihan commented on pull request #9905: Fix compact partially overlapping segments

2020-05-20 Thread GitBox
yuanlihan commented on pull request #9905: URL: https://github.com/apache/druid/pull/9905#issuecomment-631867912 Hi @jihoonson, thanks for looking into this. It should be a kind of partial overlapping not one fully overlapping another one. And sorry for the misleading title. >

[GitHub] [druid] clintropolis merged pull request #9859: Updated Notice for Druid Copyright Year

2020-05-20 Thread GitBox
clintropolis merged pull request #9859: URL: https://github.com/apache/druid/pull/9859 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[druid] branch master updated: Fixed the Copyright year of Druid (#9859)

2020-05-20 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new ca5e66d Fixed the Copyright year of Druid (#9859

[GitHub] [druid] vogievetsky opened a new issue #9906: Stack overflow with SELECT ARRAY ['Hello', NULL]

2020-05-20 Thread GitBox
vogievetsky opened a new issue #9906: URL: https://github.com/apache/druid/issues/9906 ### Affected Version Druid 0.18.0 ### Description The query `SELECT ARRAY ['Hello', NULL]` returns a (HTML formatted) stack overflow ![image](https://user-images.githubusercon

[GitHub] [druid] yuanlihan edited a comment on pull request #9905: Fix compact partially overlapping segments

2020-05-20 Thread GitBox
yuanlihan edited a comment on pull request #9905: URL: https://github.com/apache/druid/pull/9905#issuecomment-631867912 Hi @jihoonson, thanks for looking into this. It should be a kind of partial overlapping not one fully overlapping another one. And sorry for the misleading title.

[GitHub] [druid] xvrl commented on pull request #9902: update kafka client version to 2.5.0

2020-05-20 Thread GitBox
xvrl commented on pull request #9902: URL: https://github.com/apache/druid/pull/9902#issuecomment-631902458 @clintropolis yep, I realized the rabbit hole was a little deeper. I think I fixed it now This is an automated messa

[GitHub] [druid] maytasm commented on issue #9889: Add new configuration for kill task to skip segments that has been last modified within the config value time

2020-05-20 Thread GitBox
maytasm commented on issue #9889: URL: https://github.com/apache/druid/issues/9889#issuecomment-631919882 @yuanlihan I am thinking that the segment will have to satisfy both conditions to be eligible for the kill task. The new `druid.coordinator.kill.fromLastModified` offers additional