[GitHub] [druid] liuxiaohui1221 opened a new pull request #10531: Add a internal Aggregator to fix overestimate thetaSketch,quantilesDoublesSketch in ingestion task

2020-10-26 Thread GitBox
liuxiaohui1221 opened a new pull request #10531: URL: https://github.com/apache/druid/pull/10531 Fixes #6743 . When the data source has one or more thetasketch,quantilesDoublesSketch,ingestion task(when maxBytesInMemory not -1) will generate a lot of small file

[GitHub] [druid] FrankChen021 commented on issue #10530: Allow zero period for TIMESTAMPADD to help make Tableau operable

2020-10-26 Thread GitBox
FrankChen021 commented on issue #10530: URL: https://github.com/apache/druid/issues/10530#issuecomment-716472662 I made some investigation about this problem, and I think it should be a bug. It's interesting that `TIMESTAMPADD` works fine with `DAY`, `MINUTE` when the 2nd parameter

[GitHub] [druid] FrankChen021 edited a comment on issue #10530: Allow zero period for TIMESTAMPADD to help make Tableau operable

2020-10-26 Thread GitBox
FrankChen021 edited a comment on issue #10530: URL: https://github.com/apache/druid/issues/10530#issuecomment-716472662 I made some investigation about this problem, and I think it should be a bug. It's interesting that `TIMESTAMPADD` works fine with `DAY`, `MINUTE` when the 2nd pa

[GitHub] [druid] ayushkul2910 commented on a change in pull request #10448: Added CronScheduler support as a proof to clock drift while emitting metrics

2020-10-26 Thread GitBox
ayushkul2910 commented on a change in pull request #10448: URL: https://github.com/apache/druid/pull/10448#discussion_r511941702 ## File path: core/src/main/java/org/apache/druid/java/util/common/concurrent/ScheduledExecutors.java ## @@ -167,6 +169,50 @@ public void run()

[GitHub] [druid] capistrant commented on issue #9816: Historical rack aware (or group aware) data replication

2020-10-26 Thread GitBox
capistrant commented on issue #9816: URL: https://github.com/apache/druid/issues/9816#issuecomment-716614390 for a case where number of groups or racks = number of replicas desired, sure. But a large enterprise cluster will have 10s of racks and will not want a replica on every rack due to

[GitHub] [druid] gianm commented on issue #10530: Allow zero period for TIMESTAMPADD to help make Tableau operable

2020-10-26 Thread GitBox
gianm commented on issue #10530: URL: https://github.com/apache/druid/issues/10530#issuecomment-716691106 > @gianm what do you think ? I'm not sure if it should be considered a bug or a feature, but either way, it'd be good to allow this. It looks like the restriction to disallow a

[GitHub] [druid] himanshug commented on pull request #9518: AWS RDS token based password provider

2020-10-26 Thread GitBox
himanshug commented on pull request #9518: URL: https://github.com/apache/druid/pull/9518#issuecomment-716716853 un-stale ! This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [druid] stale[bot] commented on pull request #9518: AWS RDS token based password provider

2020-10-26 Thread GitBox
stale[bot] commented on pull request #9518: URL: https://github.com/apache/druid/pull/9518#issuecomment-716716870 This issue is no longer marked as stale. This is an automated message from the Apache Git Service. To respo

[GitHub] [druid] himanshug commented on pull request #9507: optionally disable all of hardcoded zookeeper use

2020-10-26 Thread GitBox
himanshug commented on pull request #9507: URL: https://github.com/apache/druid/pull/9507#issuecomment-716718048 @clintropolis sorry, been a while, I am planning to fix the conflicts here and get it back to working... would you be able to review/merge ? ---

[GitHub] [druid] himanshug commented on issue #9053: [Proposal] Druid discovery extension for Kubernetes

2020-10-26 Thread GitBox
himanshug commented on issue #9053: URL: https://github.com/apache/druid/issues/9053#issuecomment-716720891 Just wanted to note an unforeseen advantage I am realizing from not using ZK but using K8S API server instead for the discovery is that AWS (and Probably GCP too) has a fixed cost of

[GitHub] [druid-website-src] druid-matt opened a new pull request #183: remove 10/19, 10/20, 10/23 and add 11/11

2020-10-26 Thread GitBox
druid-matt opened a new pull request #183: URL: https://github.com/apache/druid-website-src/pull/183 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [druid] himanshug commented on issue #9816: Historical rack aware (or group aware) data replication

2020-10-26 Thread GitBox
himanshug commented on issue #9816: URL: https://github.com/apache/druid/issues/9816#issuecomment-716747133 > for a case where number of groups or racks = number of replicas desired, sure. But a large enterprise cluster will have 10s of racks and will not want a replica on every rack due t

[GitHub] [druid] himanshug edited a comment on issue #9816: Historical rack aware (or group aware) data replication

2020-10-26 Thread GitBox
himanshug edited a comment on issue #9816: URL: https://github.com/apache/druid/issues/9816#issuecomment-716747133 > for a case where number of groups or racks = number of replicas desired, sure. But a large enterprise cluster will have 10s of racks and will not want a replica on every rac

[GitHub] [druid] leventov commented on a change in pull request #10448: Added CronScheduler support as a proof to clock drift while emitting metrics

2020-10-26 Thread GitBox
leventov commented on a change in pull request #10448: URL: https://github.com/apache/druid/pull/10448#discussion_r512203193 ## File path: core/src/main/java/org/apache/druid/java/util/common/concurrent/ScheduledExecutors.java ## @@ -167,6 +169,50 @@ public void run() );

[GitHub] [druid] clintropolis commented on pull request #9507: optionally disable all of hardcoded zookeeper use

2020-10-26 Thread GitBox
clintropolis commented on pull request #9507: URL: https://github.com/apache/druid/pull/9507#issuecomment-716766548 >@clintropolis sorry, been a while, I am planning to fix the conflicts here and get it back to working... would you be able to review/merge ? will do :+1: ---

[GitHub] [druid] clintropolis commented on issue #9053: [Proposal] Druid discovery extension for Kubernetes

2020-10-26 Thread GitBox
clintropolis commented on issue #9053: URL: https://github.com/apache/druid/issues/9053#issuecomment-716768021 Just curious, does this proposal support running multiple druid clusters within the same kubernetes cluster (similar to how Druid clusters can share a zookeeper by using separate

[GitHub] [druid] clintropolis edited a comment on issue #9053: [Proposal] Druid discovery extension for Kubernetes

2020-10-26 Thread GitBox
clintropolis edited a comment on issue #9053: URL: https://github.com/apache/druid/issues/9053#issuecomment-716768021 Just curious (i haven't looked at the code yet), does this proposal support running multiple druid clusters within the same kubernetes cluster (similar to how Druid cluster

[GitHub] [druid] clintropolis commented on issue #9053: [Proposal] Druid discovery extension for Kubernetes

2020-10-26 Thread GitBox
clintropolis commented on issue #9053: URL: https://github.com/apache/druid/issues/9053#issuecomment-716770884 >Just curious (i haven't looked at the code yet), does this proposal support running multiple druid clusters within the same kubernetes cluster (similar to how Druid clusters can

[GitHub] [druid] himanshug commented on issue #9053: [Proposal] Druid discovery extension for Kubernetes

2020-10-26 Thread GitBox
himanshug commented on issue #9053: URL: https://github.com/apache/druid/issues/9053#issuecomment-716773112 thanks for taking a look. this would totally allow multiple Druid clusters on same k8s cluster, even within same k8s namespace ... there is a `String K8sDiscoveryConfig.clusterIdenti

[GitHub] [druid] clintropolis commented on pull request #10290: Upgrade Guava to 28.2-jre version

2020-10-26 Thread GitBox
clintropolis commented on pull request #10290: URL: https://github.com/apache/druid/pull/10290#issuecomment-716773512 >@clintropolis PTAL Apologies for the delay. I haven't looked into upgrading Guava in a while, but I recall that there might be compatibility issues with the currentl

[GitHub] [druid] himanshug commented on issue #9053: [Proposal] Druid discovery extension for Kubernetes

2020-10-26 Thread GitBox
himanshug commented on issue #9053: URL: https://github.com/apache/druid/issues/9053#issuecomment-716774147 that said I haven't really tested multiple Druid clusters within same namespace part yet, so maybe I over-spoke .. however it could be made possible if not already [ I think] , forgo

[GitHub] [druid] clintropolis commented on issue #9053: [Proposal] Druid discovery extension for Kubernetes

2020-10-26 Thread GitBox
clintropolis commented on issue #9053: URL: https://github.com/apache/druid/issues/9053#issuecomment-716774504 Cool, yeah i just stumbled into that cluster identifier bit and was wondering what it was, thanks for the explanation :+1: ---

[GitHub] [druid] himanshug edited a comment on issue #9053: [Proposal] Druid discovery extension for Kubernetes

2020-10-26 Thread GitBox
himanshug edited a comment on issue #9053: URL: https://github.com/apache/druid/issues/9053#issuecomment-716774147 that said I haven't really tested multiple Druid clusters within same namespace part yet, so maybe I over-spoke .. however it could be made possible if not already [ I think]

[GitHub] [druid] clintropolis edited a comment on pull request #9507: optionally disable all of hardcoded zookeeper use

2020-10-26 Thread GitBox
clintropolis edited a comment on pull request #9507: URL: https://github.com/apache/druid/pull/9507#issuecomment-716788629 looks like a compilation failure on: ``` [ERROR] COMPILATION ERROR : [INFO] - [ERROR] /home/tr

[GitHub] [druid] clintropolis commented on pull request #9507: optionally disable all of hardcoded zookeeper use

2020-10-26 Thread GitBox
clintropolis commented on pull request #9507: URL: https://github.com/apache/druid/pull/9507#issuecomment-716788629 looks like a compilation failure on: ``` [ERROR] COMPILATION ERROR : [INFO] - [ERROR] /home/travis/bu

[GitHub] [druid] himanshug commented on pull request #9507: optionally disable all of hardcoded zookeeper use

2020-10-26 Thread GitBox
himanshug commented on pull request #9507: URL: https://github.com/apache/druid/pull/9507#issuecomment-716801466 yep, working on to fix the build This is an automated message from the Apache Git Service. To respond to the

[GitHub] [druid] ArvinZheng commented on issue #9816: Historical rack aware (or group aware) data replication

2020-10-26 Thread GitBox
ArvinZheng commented on issue #9816: URL: https://github.com/apache/druid/issues/9816#issuecomment-716802535 @himanshug , Yes, use multiple tiers can be an alternative for some cases, but it doesn't work in the case that you want to keep the same number of active replicants regardless o

[GitHub] [druid] ArvinZheng edited a comment on issue #9816: Historical rack aware (or group aware) data replication

2020-10-26 Thread GitBox
ArvinZheng edited a comment on issue #9816: URL: https://github.com/apache/druid/issues/9816#issuecomment-716802535 @himanshug , Yes, use multiple tiers can be an alternative for some cases, but it doesn't work in the case that you want to keep the same number of active replicants regar

[GitHub] [druid] jihoonson commented on a change in pull request #10383: Fix ingestion failure of pretty-formatted JSON message

2020-10-26 Thread GitBox
jihoonson commented on a change in pull request #10383: URL: https://github.com/apache/druid/pull/10383#discussion_r510469802 ## File path: core/src/main/java/org/apache/druid/data/input/InputRowListPlusRawValues.java ## @@ -82,8 +121,16 @@ private InputRowListPlusRawValues(

[GitHub] [druid] senthilkv commented on a change in pull request #10495: Added Request log updates for status change on cooridnator / overlord…

2020-10-26 Thread GitBox
senthilkv commented on a change in pull request #10495: URL: https://github.com/apache/druid/pull/10495#discussion_r512281247 ## File path: server/src/main/java/org/apache/druid/server/initialization/jetty/JettyRequestLog.java ## @@ -41,6 +45,20 @@ public void log(Request requ

[GitHub] [druid] himanshug commented on issue #9816: Historical rack aware (or group aware) data replication

2020-10-26 Thread GitBox
himanshug commented on issue #9816: URL: https://github.com/apache/druid/issues/9816#issuecomment-716844977 that is true and I am suggesting if possible, that enhancement could be made to tier concept itself rather than introducing another thing to do the grouping just for illustrat

[GitHub] [druid] himanshug commented on pull request #9507: optionally disable all of hardcoded zookeeper use

2020-10-26 Thread GitBox
himanshug commented on pull request #9507: URL: https://github.com/apache/druid/pull/9507#issuecomment-716878045 @clintropolis at this point build is fine except for the code coverage checks in some of the trivial changes which either can only execute when zk is disabled for real and druid

[GitHub] [druid] partomia09 commented on issue #7623: How to Enable HistoricalMetricsMonitor、QueryCountStatsMonitor metric for Historical 、Middle Manager ;Because I started both Historical and Middle

2020-10-26 Thread GitBox
partomia09 commented on issue #7623: URL: https://github.com/apache/druid/issues/7623#issuecomment-716878060 @terry19850829 QueryCountStats worked perfectly using the above config. We did not install Sigar and we tested the configs, its still working fine. Do you suggest to insta

[GitHub] [druid] partomia09 commented on issue #7623: How to Enable HistoricalMetricsMonitor、QueryCountStatsMonitor metric for Historical 、Middle Manager ;Because I started both Historical and Middle

2020-10-26 Thread GitBox
partomia09 commented on issue #7623: URL: https://github.com/apache/druid/issues/7623#issuecomment-716895838 @terry19850829 I figured that Sigar is required only for MiddleManager. Thanks Again! This is an automat

[GitHub] [druid] partomia09 edited a comment on issue #7623: How to Enable HistoricalMetricsMonitor、QueryCountStatsMonitor metric for Historical 、Middle Manager ;Because I started both Historical and

2020-10-26 Thread GitBox
partomia09 edited a comment on issue #7623: URL: https://github.com/apache/druid/issues/7623#issuecomment-716895838 @terry19850829 I figured that Sigar is required only for MiddleManager while enabling the TaskCountStats. The challenge is Sigar on Cento7 requires dependencies like glib

[GitHub] [druid] techdocsmith opened a new pull request #10532: Document correlation between credential iterations and query latency

2020-10-26 Thread GitBox
techdocsmith opened a new pull request #10532: URL: https://github.com/apache/druid/pull/10532 ### Description Documents the correlation between credential iterations and query latency. Includes some minor additional stylistic changes. This PR has: - [x] added documentation

[GitHub] [druid] techdocsmith commented on pull request #10532: Document correlation between credential iterations and query latency

2020-10-26 Thread GitBox
techdocsmith commented on pull request #10532: URL: https://github.com/apache/druid/pull/10532#issuecomment-716904050 @suneet-s , @2bethere PTAL. This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [druid] ArvinZheng commented on issue #9816: Historical rack aware (or group aware) data replication

2020-10-26 Thread GitBox
ArvinZheng commented on issue #9816: URL: https://github.com/apache/druid/issues/9816#issuecomment-716920480 I see your point, but people (like me) may have gotten used to leverage tiers to split data into cold and hot groups and allocation different resources for cold and hot tiers. While

[GitHub] [druid] clintropolis commented on pull request #9507: optionally disable all of hardcoded zookeeper use

2020-10-26 Thread GitBox
clintropolis commented on pull request #9507: URL: https://github.com/apache/druid/pull/9507#issuecomment-716941329 >@clintropolis at this point build is fine except for the code coverage checks in some of the trivial changes which either can only execute when zk is disabled for real and d

[GitHub] [druid] clintropolis merged pull request #10499: support for vectorizing expressions with non-existent inputs, more consistent type handling for non-vectorized expressions

2020-10-26 Thread GitBox
clintropolis merged pull request #10499: URL: https://github.com/apache/druid/pull/10499 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[druid] branch master updated (f3a2903 -> a966de5)

2020-10-26 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from f3a2903 Configurable Index Type (#10335) add a966de5 Add https to druid-influxdb-emitter extension (#9938) No

[druid] branch master updated (a966de5 -> d0821de)

2020-10-26 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from a966de5 Add https to druid-influxdb-emitter extension (#9938) add d0821de support for vectorizing expressions w

[GitHub] [druid] vogievetsky opened a new pull request #10533: Web console: improve make type preservation in ingestion configs in the data loader

2020-10-26 Thread GitBox
vogievetsky opened a new pull request #10533: URL: https://github.com/apache/druid/pull/10533 This PR fixes an issue that in the data loader if you toggle the rollup it loses any previously entered type information because it will simply rescan the sample. It makes a couple of other fixes

[GitHub] [druid] pjain1 commented on issue #9380: Fine grained config and state resources

2020-10-26 Thread GitBox
pjain1 commented on issue #9380: URL: https://github.com/apache/druid/issues/9380#issuecomment-716994867 @jon-wei ^^ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [druid] himanshug merged pull request #9507: optionally disable all of hardcoded zookeeper use

2020-10-26 Thread GitBox
himanshug merged pull request #9507: URL: https://github.com/apache/druid/pull/9507 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [druid] himanshug commented on pull request #9507: optionally disable all of hardcoded zookeeper use

2020-10-26 Thread GitBox
himanshug commented on pull request #9507: URL: https://github.com/apache/druid/pull/9507#issuecomment-716995239 @clintropolis thanks! This is an automated message from the Apache Git Service. To respond to the message, pleas

[druid] branch master updated (d0821de -> ee13630)

2020-10-26 Thread himanshug
This is an automated email from the ASF dual-hosted git repository. himanshug pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from d0821de support for vectorizing expressions with non-existent inputs, more consistent type handling for non-vecto

[druid] branch master updated (d0821de -> ee13630)

2020-10-26 Thread himanshug
This is an automated email from the ASF dual-hosted git repository. himanshug pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from d0821de support for vectorizing expressions with non-existent inputs, more consistent type handling for non-vecto

[GitHub] [druid] clintropolis merged pull request #10527: update quickstart docker-compose example, add to release instructions

2020-10-26 Thread GitBox
clintropolis merged pull request #10527: URL: https://github.com/apache/druid/pull/10527 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[druid] branch master updated (ee13630 -> aa9c0ec)

2020-10-26 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from ee13630 optionally disable all of hardcoded zookeeper use (#9507) add aa9c0ec update quickstart docker-compose

[GitHub] [druid] clintropolis opened a new pull request #10534: [Backport] update quickstart docker-compose example, add to release instructions

2020-10-26 Thread GitBox
clintropolis opened a new pull request #10534: URL: https://github.com/apache/druid/pull/10534 Backport of #10527 to 0.20.0. This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [druid] pjain1 edited a comment on issue #9380: Fine grained config and state resources

2020-10-26 Thread GitBox
pjain1 edited a comment on issue #9380: URL: https://github.com/apache/druid/issues/9380#issuecomment-716994867 @jon-wei read your comment again, your concern is that it might be confusing if both models exists at same place but creating namespaces totally depend on the extension implement