[GitHub] [druid] sajithms05 commented on issue #10580: Clickjacking on druid

sajithms05 commented on issue #10580: URL: https://github.com/apache/druid/issues/10580#issuecomment-730151104 @a2l007 Do I have to add X-Frame-Options: SAMEORIGIN to the common runtime properties file ? This is an

[GitHub] [druid] capistrant commented on pull request #10581: Web console: Double confirm before permanently delete unused segments

capistrant commented on pull request #10581: URL: https://github.com/apache/druid/pull/10581#issuecomment-730108940 > @capistrant Hi capistrant! Sorry to bother you , I have deployed this PR in our PRD druid cluster recently and it works fine. What should I do next? I'll merge it by

[druid] branch master updated (1272fb1 -> d7d2c80)

This is an automated email from the ASF dual-hosted git repository. suneet pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 1272fb1 modify druid.historical.cache.maxEntrySize property in Unified format (#10590) add d7d2c80 Add zero

[GitHub] [druid] suneet-s merged pull request #10550: Add zero period support to TIMESTAMPADD

suneet-s merged pull request #10550: URL: https://github.com/apache/druid/pull/10550 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [druid] FrankChen021 commented on pull request #10551: Remove hard limitation that druid(after 0.15.0) only can consume Kafka version 0.11.x or better

FrankChen021 commented on pull request #10551: URL: https://github.com/apache/druid/pull/10551#issuecomment-730084097 Hi, @jihoonson would you like to take a look at this change ? This is an automated message from the Apache

[GitHub] [druid] FrankChen021 commented on a change in pull request #10551: Remove hard limitation that druid(after 0.15.0) only can consume Kafka version 0.11.x or better

FrankChen021 commented on a change in pull request #10551: URL: https://github.com/apache/druid/pull/10551#discussion_r526550007 ## File path: extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisorTest.java ## @@

[GitHub] [druid] FrankChen021 commented on a change in pull request #10551: Remove hard limitation that druid(after 0.15.0) only can consume Kafka version 0.11.x or better

FrankChen021 commented on a change in pull request #10551: URL: https://github.com/apache/druid/pull/10551#discussion_r526549768 ## File path: extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaRecordSupplier.java ## @@ -37,6 +37,7 @@

[GitHub] [druid] himanshug commented on issue #10574: Java 11 Dockerfile builds the entire application again without using maven cache

himanshug commented on issue #10574: URL: https://github.com/apache/druid/issues/10574#issuecomment-730061642 I think Dockerfile is written in a way so as to not assume pre-built jars or maven on the host machine .. which works well for build environments specially. for dev, as a

[GitHub] [druid] himanshug edited a comment on pull request #10495: Added Request log updates for status change on cooridnator / overlord…

himanshug edited a comment on pull request #10495: URL: https://github.com/apache/druid/pull/10495#issuecomment-730056718 @senthilkv have you considered changing log level to debug ONLY for logger named "org.apache.druid.jetty.RequestLog" at coordinator/overlord nodes ? > If the

[GitHub] [druid] himanshug commented on pull request #10495: Added Request log updates for status change on cooridnator / overlord…

himanshug commented on pull request #10495: URL: https://github.com/apache/druid/pull/10495#issuecomment-730056718 @senthilkv have you considered changing log level to debug ONLY for logger named "org.apache.druid.jetty.RequestLog" at coordinator/overlord nodes ? > If the community

[GitHub] [druid] himanshug commented on issue #5582: Druid Helm Chart

himanshug commented on issue #5582: URL: https://github.com/apache/druid/issues/5582#issuecomment-730046266 Probably unrelated but relevant based on few comments (https://github.com/apache/druid/issues/5582#issuecomment-388367295 and

[GitHub] [druid] himanshug commented on pull request #10562: Add TravisCI job that builds and tests on ARM64 CPU architecture

himanshug commented on pull request #10562: URL: https://github.com/apache/druid/pull/10562#issuecomment-730042873 @martin-g curious about what makes ARM64 CPU architecture special for a pure java project ? This is an

[GitHub] [druid] zhangyue19921010 edited a comment on pull request #10581: Web console: Double confirm before permanently delete unused segments

zhangyue19921010 edited a comment on pull request #10581: URL: https://github.com/apache/druid/pull/10581#issuecomment-730039743 @capistrant Hi capistrant! Sorry to bother you , I have deployed this PR in our PRD druid cluster recently and it works fine. What should I do next?

[GitHub] [druid] zhangyue19921010 edited a comment on pull request #10581: Web console: Double confirm before permanently delete unused segments

zhangyue19921010 edited a comment on pull request #10581: URL: https://github.com/apache/druid/pull/10581#issuecomment-730039743 @capistrant Sorry to bother you , I have deployed this PR in our PRD druid cluster recently and it works fine. What should I do now?

[GitHub] [druid] zhangyue19921010 commented on pull request #10581: Web console: Double confirm before permanently delete unused segments

zhangyue19921010 commented on pull request #10581: URL: https://github.com/apache/druid/pull/10581#issuecomment-730039743 @capistrant Sorry to bother you , I have deployed this PR in our PRD druid cluster and it works fine. What should I do now?

[GitHub] [druid] cloventt opened a new pull request #10595: Fix issue causing incorrect config in Docker

cloventt opened a new pull request #10595: URL: https://github.com/apache/druid/pull/10595 ### Description Previously, when the Docker entrypoint script generated the config files, it would append the configuration without including a newline. This could

[GitHub] [druid] a2l007 edited a comment on issue #10580: Clickjacking on druid

a2l007 edited a comment on issue #10580: URL: https://github.com/apache/druid/issues/10580#issuecomment-730012967 If you're using a custom druid security extension, one way to handle this is to add the `X-Frame-Options: SAMEORIGIN` header along with responses sent back by the extension

[GitHub] [druid] a2l007 commented on issue #10580: Clickjacking on druid

a2l007 commented on issue #10580: URL: https://github.com/apache/druid/issues/10580#issuecomment-730012967 If you're using a custom druid security extension, one way to handle this is to add the `X-Frame-Options: SAMEORIGIN` header along with responses.

[GitHub] [druid] himanshug commented on a change in pull request #10591: druid-docker-image: add DRUID_DIRS_TO_CREATE variable to customize directories created on startup

himanshug commented on a change in pull request #10591: URL: https://github.com/apache/druid/pull/10591#discussion_r526476418 ## File path: distribution/docker/druid.sh ## @@ -148,5 +148,10 @@ then echo "$DRUID_LOG4J" >$COMMON_CONF_DIR/log4j2.xml fi -mkdir -p var/tmp

[GitHub] [druid] capistrant commented on pull request #10578: Add context dimension to DefaultQueryMetrics

capistrant commented on pull request #10578: URL: https://github.com/apache/druid/pull/10578#issuecomment-729964748 Hmm, I appear to be having an inspection problem after my `00efa42` commit. `QueryMetrics#context` is getting flagged with `Method is never used as a member of this

[GitHub] [druid] a2l007 commented on issue #10594: Vectorizing extraction dimension specs

a2l007 commented on issue #10594: URL: https://github.com/apache/druid/issues/10594#issuecomment-729952635 @clintropolis Sounds interesting. In the current state of the PR, does the dictionary building strategy apply for vectorizing string columns in general or is it supported only for

[GitHub] [druid] clintropolis commented on issue #10594: Vectorizing extraction dimension specs

clintropolis commented on issue #10594: URL: https://github.com/apache/druid/issues/10594#issuecomment-729917478 Moderately related, I have been working on a 'dictionary building' vector grouping strategy for string columns from my work related to vectorizing expressions, which I think is

[GitHub] [druid] a2l007 opened a new issue #10594: Vectorizing extraction dimension specs

a2l007 opened a new issue #10594: URL: https://github.com/apache/druid/issues/10594 The vectorization query engine in Druid presently doesn’t support vectorization of extraction dimension specs. I’m in the process of coming up with a design proposal for adding this support. Reviewing

[GitHub] [druid] jihoonson commented on a change in pull request #10592: Allow missing intervals for Parallel task with hash/range partitioning

jihoonson commented on a change in pull request #10592: URL: https://github.com/apache/druid/pull/10592#discussion_r526366690 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java ## @@ -541,9

[GitHub] [druid] capistrant commented on pull request #10578: Add context dimension to DefaultQueryMetrics

capistrant commented on pull request #10578: URL: https://github.com/apache/druid/pull/10578#issuecomment-729789544 @nishantmonu51 @jihoonson thank you for the review. I addressed the redundant call to `context()` in latest commit and added a release notes blurb in the PR description.

[GitHub] [druid] kroeders closed pull request #10427: ServerSelectorStrategy to filter servers with missing required lookups

kroeders closed pull request #10427: URL: https://github.com/apache/druid/pull/10427 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [druid] kroeders commented on pull request #10427: ServerSelectorStrategy to filter servers with missing required lookups

kroeders commented on pull request #10427: URL: https://github.com/apache/druid/pull/10427#issuecomment-729754115 reopening to restart travis-ci This is an automated message from the Apache Git Service. To respond to the

[GitHub] [druid] leventov commented on pull request #10448: Added CronScheduler support as a proof to clock drift while emitting metrics

leventov commented on pull request #10448: URL: https://github.com/apache/druid/pull/10448#issuecomment-729720774 d...@druid.apache.org mailing list This is an automated message from the Apache Git Service. To respond to the

[GitHub] [druid] trollhe closed issue #10579: startup druid data server exception Error in custom provider, org.apache.druid.java.util.common.ISE: Number overflow

trollhe closed issue #10579: URL: https://github.com/apache/druid/issues/10579 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [druid] trollhe commented on issue #10579: startup druid data server exception Error in custom provider, org.apache.druid.java.util.common.ISE: Number overflow

trollhe commented on issue #10579: URL: https://github.com/apache/druid/issues/10579#issuecomment-729711189 > Hi @gianm , > > Current implementation holds value of `druid.processing.buffer.sizeBytes` in integer which means the limit for this configuration is INT.MAX. > > And

[GitHub] [druid] liran-funaro opened a new pull request #10593: IncrementalIndex Tests and Benchmarks Refactor

liran-funaro opened a new pull request #10593: URL: https://github.com/apache/druid/pull/10593 Fixes #10494. ### Description **Note:** This PR only affects tests and benchmarks. #10335 added a per incremental-index builder, but the parent class builder

[GitHub] [druid] ayushkul2910 commented on pull request #10448: Added CronScheduler support as a proof to clock drift while emitting metrics

ayushkul2910 commented on pull request #10448: URL: https://github.com/apache/druid/pull/10448#issuecomment-729618624 Thanks @leventov for reviewing the PR. Can you please let me know, how can I reach out to other active maintainers?

[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #10592: Allow missing intervals for Parallel task with hash/range partitioning

abhishekagarwal87 commented on a change in pull request #10592: URL: https://github.com/apache/druid/pull/10592#discussion_r525876638 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java ## @@