[GitHub] [druid] JulianJaffePinterest commented on issue #9780: Support directly reading and writing Druid data from Spark

2020-12-13 Thread GitBox
JulianJaffePinterest commented on issue #9780: URL: https://github.com/apache/druid/issues/9780#issuecomment-744228708 No update from my side on this. I haven't had time to work on this and it appears that there isn't community appetite to _support_ direct Spark readers and writers (there

[GitHub] [druid] stale[bot] commented on pull request #9667: Thread-safety for ResponseContext.REGISTERED_KEYS

2020-12-13 Thread GitBox
stale[bot] commented on pull request #9667: URL: https://github.com/apache/druid/pull/9667#issuecomment-744201712 This pull request/issue is no longer marked as stale. This is an automated message from the Apache Git Serv

[GitHub] [druid] bowenli86 commented on issue #9780: Support directly reading and writing Druid data from Spark

2020-12-13 Thread GitBox
bowenli86 commented on issue #9780: URL: https://github.com/apache/druid/issues/9780#issuecomment-744157590 Hi folks, any update on this? This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [druid] zhangyue19921010 commented on pull request #10524: Dynamic auto scale Kafka-Stream ingest tasks

2020-12-13 Thread GitBox
zhangyue19921010 commented on pull request #10524: URL: https://github.com/apache/druid/pull/10524#issuecomment-744143180 > In my opinion, the dynamic scaling taskcount operation is related to the number of partitions in Kafka. when the data traffic increases, the taskcount has been adjust

[GitHub] [druid] clintropolis commented on pull request #10666: refactor numeric primitive aggregators in sql compatible mode

2020-12-13 Thread GitBox
clintropolis commented on pull request #10666: URL: https://github.com/apache/druid/pull/10666#issuecomment-744128011 This PR is going to fail the coverage check in CI on the 'processing' unit tests, because most of the code here is only used in SQL compatible mode. --

[GitHub] [druid] beepupa commented on issue #10674: Why? I started ues Deep storage is Cassandra ,when i change Deep storage For local disk , compact error

2020-12-13 Thread GitBox
beepupa commented on issue #10674: URL: https://github.com/apache/druid/issues/10674#issuecomment-744119101 > 如@ abhishekagarwal87所述,必须将cassandra扩展名保留在`druid.extensions.loadList`conf中,以便可以从Cassandra加载旧段。 Thank you for your advice

[GitHub] [druid] beepupa commented on issue #10674: Why? I started ues Deep storage is Cassandra ,when i change Deep storage For local disk , compact error

2020-12-13 Thread GitBox
beepupa commented on issue #10674: URL: https://github.com/apache/druid/issues/10674#issuecomment-744119041 > 使用Cassandra创建的分段作为深度存储,在其负载规格中仍引用Cassandra的位置。当压缩在这些旧段上运行时,由于无法扩展Cassandra路径,因此德鲁伊尝试读取其负载规格并失败。 Thank you for your advice. I'll try

[GitHub] [druid] FrankChen021 commented on issue #10674: Why? I started ues Deep storage is Cassandra ,when i change Deep storage For local disk , compact error

2020-12-13 Thread GitBox
FrankChen021 commented on issue #10674: URL: https://github.com/apache/druid/issues/10674#issuecomment-744112753 As @abhishekagarwal87 stated, Cassandra extension must be kept in the `druid.extensions.loadList` in your conf so that old segments could be loaded from Cassandra. ---

[GitHub] [druid] liran-funaro commented on pull request #10593: IncrementalIndex Tests and Benchmarks Parametrization

2020-12-13 Thread GitBox
liran-funaro commented on pull request #10593: URL: https://github.com/apache/druid/pull/10593#issuecomment-744045825 @a2l007 Thanks for your review. I made modifications accordingly. Let me know if you think more changes should be made, or if we can proceed to merge it. I have re

[GitHub] [druid] liran-funaro commented on a change in pull request #10593: IncrementalIndex Tests and Benchmarks Parametrization

2020-12-13 Thread GitBox
liran-funaro commented on a change in pull request #10593: URL: https://github.com/apache/druid/pull/10593#discussion_r541973485 ## File path: processing/src/test/java/org/apache/druid/segment/incremental/IncrementalIndexCreator.java ## @@ -0,0 +1,214 @@ +/* + * Licensed to th

[GitHub] [druid] liran-funaro commented on a change in pull request #10593: IncrementalIndex Tests and Benchmarks Parametrization

2020-12-13 Thread GitBox
liran-funaro commented on a change in pull request #10593: URL: https://github.com/apache/druid/pull/10593#discussion_r541967392 ## File path: benchmarks/src/test/java/org/apache/druid/benchmark/indexing/IncrementalIndexReadBenchmark.java ## @@ -110,28 +119,28 @@ public void s

[GitHub] [druid] andrewbridge edited a comment on issue #10609: Custom aggregation type name not registering correctly

2020-12-13 Thread GitBox
andrewbridge edited a comment on issue #10609: URL: https://github.com/apache/druid/issues/10609#issuecomment-744022039 I placed: ```java @JsonSubTypes(value = { @JsonSubTypes.Type(name = "doubleMinOf", value = DoubleMinOfAggregatorFactory.class) }) ``` into

[GitHub] [druid] andrewbridge commented on issue #10609: Custom aggregation type name not registering correctly

2020-12-13 Thread GitBox
andrewbridge commented on issue #10609: URL: https://github.com/apache/druid/issues/10609#issuecomment-744022039 I placed: ```java @JsonSubTypes(value = { @JsonSubTypes.Type(name = "doubleMinOf", value = DoubleMinOfAggregatorFactor.class) }) ``` into my exten

[GitHub] [druid] andrewbridge closed issue #10609: Custom aggregation type name not registering correctly

2020-12-13 Thread GitBox
andrewbridge closed issue #10609: URL: https://github.com/apache/druid/issues/10609 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [druid] andrewbridge opened a new issue #10675: Inconsistency in secondary column vaule selector behaviour between tests and real use

2020-12-13 Thread GitBox
andrewbridge opened a new issue #10675: URL: https://github.com/apache/druid/issues/10675 ### Affected Version 0.20.0 ### Description I have set up an aggregator extension which deals with two row values at a time in order to aggregate. It uses a collector object with t

[GitHub] [druid] liran-funaro commented on a change in pull request #10593: IncrementalIndex Tests and Benchmarks Parametrization

2020-12-13 Thread GitBox
liran-funaro commented on a change in pull request #10593: URL: https://github.com/apache/druid/pull/10593#discussion_r541911828 ## File path: processing/src/test/java/org/apache/druid/segment/incremental/IncrementalIndexCreator.java ## @@ -0,0 +1,214 @@ +/* + * Licensed to th

[GitHub] [druid] liran-funaro commented on a change in pull request #10593: IncrementalIndex Tests and Benchmarks Parametrization

2020-12-13 Thread GitBox
liran-funaro commented on a change in pull request #10593: URL: https://github.com/apache/druid/pull/10593#discussion_r541911683 ## File path: processing/src/test/java/org/apache/druid/segment/incremental/IncrementalIndexCreator.java ## @@ -0,0 +1,214 @@ +/* + * Licensed to th

[GitHub] [druid] liran-funaro commented on a change in pull request #10593: IncrementalIndex Tests and Benchmarks Parametrization

2020-12-13 Thread GitBox
liran-funaro commented on a change in pull request #10593: URL: https://github.com/apache/druid/pull/10593#discussion_r541911202 ## File path: processing/src/main/java/org/apache/druid/segment/generator/DataGenerator.java ## @@ -143,4 +151,54 @@ private long nextTimestamp()

[GitHub] [druid] liran-funaro commented on a change in pull request #10593: IncrementalIndex Tests and Benchmarks Parametrization

2020-12-13 Thread GitBox
liran-funaro commented on a change in pull request #10593: URL: https://github.com/apache/druid/pull/10593#discussion_r541910843 ## File path: processing/src/main/java/org/apache/druid/segment/incremental/OffheapIncrementalIndex.java ## @@ -150,18 +150,13 @@ protected AddToFac

[GitHub] [druid] liran-funaro commented on a change in pull request #10593: IncrementalIndex Tests and Benchmarks Parametrization

2020-12-13 Thread GitBox
liran-funaro commented on a change in pull request #10593: URL: https://github.com/apache/druid/pull/10593#discussion_r541903361 ## File path: benchmarks/src/test/java/org/apache/druid/benchmark/indexing/IncrementalIndexReadBenchmark.java ## @@ -110,28 +119,28 @@ public void s

[GitHub] [druid] doctording edited a comment on issue #10227: druid case_searched has poor performance

2020-12-13 Thread GitBox
doctording edited a comment on issue #10227: URL: https://github.com/apache/druid/issues/10227#issuecomment-743980497 +1; because each row of aggregated data will be calculated by the case_searched expression; especially when there are a lot of rows after aggregation and lots of `or` calcu

[GitHub] [druid] doctording commented on issue #10227: druid case_searched has poor performance

2020-12-13 Thread GitBox
doctording commented on issue #10227: URL: https://github.com/apache/druid/issues/10227#issuecomment-743980497 +1; because each row of aggregated data will be calculated by the case_searched expression; especially when there are a lot of rows after aggregation and lots of `or` calculations