[GitHub] [druid] abhishekagarwal87 commented on pull request #10653: Fix post-aggregator computation when used with subtotals

abhishekagarwal87 commented on pull request #10653: URL: https://github.com/apache/druid/pull/10653#issuecomment-745130663 Added the test for a nested groupBy query which fails in the current master. This is an automated mes

[GitHub] [druid] clintropolis commented on a change in pull request #10680: integration test for coordinator and overlord leadership client

clintropolis commented on a change in pull request #10680: URL: https://github.com/apache/druid/pull/10680#discussion_r543145989 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java ## @@ -586,7 +638,8 @@ public TableType getJdbcTableType()

[GitHub] [druid] liran-funaro commented on pull request #10593: IncrementalIndex Tests and Benchmarks Parametrization

liran-funaro commented on pull request #10593: URL: https://github.com/apache/druid/pull/10593#issuecomment-745142880 @a2l007 The benchmark run results are available here: https://pastebin.pl/view/raw/8a5559c7 This is an aut

[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #10680: integration test for coordinator and overlord leadership client

abhishekagarwal87 commented on a change in pull request #10680: URL: https://github.com/apache/druid/pull/10680#discussion_r543179132 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java ## @@ -586,7 +638,8 @@ public TableType getJdbcTableType(

[GitHub] [druid] lkm commented on a change in pull request #10543: Avatica protobuf

lkm commented on a change in pull request #10543: URL: https://github.com/apache/druid/pull/10543#discussion_r543281356 ## File path: sql/src/main/java/org/apache/druid/sql/avatica/DruidAvaticaProtobufHandler.java ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [druid] himanshug commented on issue #10542: Create a travis build that runs Druid on a K8S Cluster and runs the integration tests

himanshug commented on issue #10542: URL: https://github.com/apache/druid/issues/10542#issuecomment-745408396 thanks, yeah I will review that. This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [druid] a2l007 commented on a change in pull request #10677: Add URI based allowPrefexList and denyPrefixList

a2l007 commented on a change in pull request #10677: URL: https://github.com/apache/druid/pull/10677#discussion_r543549478 ## File path: core/src/main/java/org/apache/druid/data/input/impl/LocalInputSource.java ## @@ -72,15 +75,17 @@ public LocalInputSource( this.baseDir

[GitHub] [druid] jihoonson commented on pull request #10676: Allow client to configure batch ingestion task to wait to complete until segments are confirmed to be available by other

jihoonson commented on pull request #10676: URL: https://github.com/apache/druid/pull/10676#issuecomment-745473962 @capistrant thanks for the PR. This idea seems useful. I will take a look soon. This is an automated message

[GitHub] [druid] dayskipping opened a new issue #10681: TIME_CEIL/TIME_FLOOR SQL function throwing error when using origin/timezone

dayskipping opened a new issue #10681: URL: https://github.com/apache/druid/issues/10681 Version 0.18.1 Services 3 overlords, 3 coordinators 3 routers, 3 brokers 8 historicals, 8 middle managers 192 peons 136 running supervisors When attempting to run a SQL using

[GitHub] [druid] a2l007 commented on a change in pull request #10593: IncrementalIndex Tests and Benchmarks Parametrization

a2l007 commented on a change in pull request #10593: URL: https://github.com/apache/druid/pull/10593#discussion_r543642524 ## File path: benchmarks/src/test/java/org/apache/druid/benchmark/indexing/IncrementalIndexReadBenchmark.java ## @@ -110,28 +119,28 @@ public void setup()

[GitHub] [druid] AshishKapoor closed pull request #10408: Web console: single instance of axios for all network requests

AshishKapoor closed pull request #10408: URL: https://github.com/apache/druid/pull/10408 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [druid] himanshug commented on a change in pull request #10669: Do Integrate test for Druid base on K8s cluster

himanshug commented on a change in pull request #10669: URL: https://github.com/apache/druid/pull/10669#discussion_r543724622 ## File path: integration-tests/script/build_run_k8s_cluster.sh ## @@ -0,0 +1,82 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (

[GitHub] [druid] himanshug commented on pull request #10677: Add URI based allowPrefexList and denyPrefixList

himanshug commented on pull request #10677: URL: https://github.com/apache/druid/pull/10677#issuecomment-745616949 LGTM overall This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [druid] himanshug commented on a change in pull request #10677: Add URI based allowPrefexList and denyPrefixList

himanshug commented on a change in pull request #10677: URL: https://github.com/apache/druid/pull/10677#discussion_r543744946 ## File path: core/src/main/java/org/apache/druid/data/input/impl/InputSourceSecurityConfig.java ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache So

[GitHub] [druid] himanshug commented on a change in pull request #10680: integration test for coordinator and overlord leadership client

himanshug commented on a change in pull request #10680: URL: https://github.com/apache/druid/pull/10680#discussion_r543755037 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java ## @@ -159,6 +160,7 @@ .add("tier", ValueType.STRING)

[GitHub] [druid] himanshug commented on pull request #10680: integration test for coordinator and overlord leadership client

himanshug commented on pull request #10680: URL: https://github.com/apache/druid/pull/10680#issuecomment-745625392 LGTM , thanks. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [druid] capistrant commented on pull request #10676: Allow client to configure batch ingestion task to wait to complete until segments are confirmed to be available by other

capistrant commented on pull request #10676: URL: https://github.com/apache/druid/pull/10676#issuecomment-745628501 > @capistrant thanks for the PR. This idea seems useful. I will take a look soon. Thanks @jihoonson. I'm a little worried about concurrency issues in AbstractBatchInde

[GitHub] [druid] vogievetsky opened a new pull request #10682: Web console: remove extra word (typo)

vogievetsky opened a new pull request #10682: URL: https://github.com/apache/druid/pull/10682 Not sure where `.common` came from. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [druid] jihoonson commented on a change in pull request #10680: integration test for coordinator and overlord leadership client

jihoonson commented on a change in pull request #10680: URL: https://github.com/apache/druid/pull/10680#discussion_r543778952 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java ## @@ -159,6 +160,7 @@ .add("tier", ValueType.STRING)

[GitHub] [druid] suneet-s commented on a change in pull request #10682: Web console: remove extra word (typo)

suneet-s commented on a change in pull request #10682: URL: https://github.com/apache/druid/pull/10682#discussion_r543780077 ## File path: web-console/src/entry.ts ## @@ -73,7 +73,7 @@ if (consoleConfig.baseURL) { UrlBaser.baseUrl = consoleConfig.baseURL; } if (consoleConf

[GitHub] [druid] vogievetsky commented on a change in pull request #10682: Web console: remove extra word (typo)

vogievetsky commented on a change in pull request #10682: URL: https://github.com/apache/druid/pull/10682#discussion_r543783563 ## File path: web-console/src/entry.ts ## @@ -73,7 +73,7 @@ if (consoleConfig.baseURL) { UrlBaser.baseUrl = consoleConfig.baseURL; } if (consoleC

[GitHub] [druid] suneet-s commented on a change in pull request #10682: Web console: remove extra word (typo)

suneet-s commented on a change in pull request #10682: URL: https://github.com/apache/druid/pull/10682#discussion_r543784639 ## File path: web-console/src/entry.ts ## @@ -73,7 +73,7 @@ if (consoleConfig.baseURL) { UrlBaser.baseUrl = consoleConfig.baseURL; } if (consoleConf

[GitHub] [druid] FrankChen021 commented on issue #10681: TIME_CEIL/TIME_FLOOR SQL function throwing error when using origin/timezone

FrankChen021 commented on issue #10681: URL: https://github.com/apache/druid/issues/10681#issuecomment-745707260 In your SQL, `TIME_FLOOR("__time", 'PT1D', TIMESTAMP '2015-01-01 00:00:00', 'US/Eastern')`, the 2nd parameter should be `P1D`. `PT1D` is not a valid period string. See [Duration

[GitHub] [druid] belugabehr opened a new pull request #10683: Upgrade Guava to 27

belugabehr opened a new pull request #10683: URL: https://github.com/apache/druid/pull/10683 Fixes #. ### Description Fixed the bug ... Renamed the class ... Added a forbidden-apis entry ...

[GitHub] [druid] zhangyue19921010 commented on a change in pull request #10669: Do Integrate test for Druid base on K8s cluster

zhangyue19921010 commented on a change in pull request #10669: URL: https://github.com/apache/druid/pull/10669#discussion_r54386 ## File path: integration-tests/script/build_run_k8s_cluster.sh ## @@ -0,0 +1,82 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Found

[GitHub] [druid] zhangyue19921010 commented on a change in pull request #10669: Do Integrate test for Druid base on K8s cluster

zhangyue19921010 commented on a change in pull request #10669: URL: https://github.com/apache/druid/pull/10669#discussion_r543864107 ## File path: integration-tests/script/build_run_k8s_cluster.sh ## @@ -0,0 +1,82 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Found

[GitHub] [druid] zhangyue19921010 commented on a change in pull request #10669: Do Integrate test for Druid base on K8s cluster

zhangyue19921010 commented on a change in pull request #10669: URL: https://github.com/apache/druid/pull/10669#discussion_r543866895 ## File path: distribution/docker/DockerfileBuildTarAdvanced ## @@ -0,0 +1,62 @@ +# Review comment: Also. There are some changes between

[GitHub] [druid] zhangyue19921010 commented on pull request #10669: Do Integrate test for Druid base on K8s cluster

zhangyue19921010 commented on pull request #10669: URL: https://github.com/apache/druid/pull/10669#issuecomment-745732447 @himanshug Thanks for your review! This is an automated message from the Apache Git Service. To respond

[GitHub] [druid] dayskipping closed issue #10681: TIME_CEIL/TIME_FLOOR SQL function throwing error when using origin/timezone

dayskipping closed issue #10681: URL: https://github.com/apache/druid/issues/10681 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [druid] dayskipping commented on issue #10681: TIME_CEIL/TIME_FLOOR SQL function throwing error when using origin/timezone

dayskipping commented on issue #10681: URL: https://github.com/apache/druid/issues/10681#issuecomment-745738768 > In your SQL, `TIME_FLOOR("__time", 'PT1D', TIMESTAMP '2015-01-01 00:00:00', 'US/Eastern')`, the 2nd parameter should be `P1D`. `PT1D` is not a valid period string. See [Duratio

[GitHub] [druid] zhangyue19921010 commented on a change in pull request #10669: Do Integrate test for Druid base on K8s cluster

zhangyue19921010 commented on a change in pull request #10669: URL: https://github.com/apache/druid/pull/10669#discussion_r543866895 ## File path: distribution/docker/DockerfileBuildTarAdvanced ## @@ -0,0 +1,62 @@ +# Review comment: Also. There are some changes between

[GitHub] [druid] zhangyue19921010 edited a comment on pull request #10669: Do Integrate test for Druid base on K8s cluster

zhangyue19921010 edited a comment on pull request #10669: URL: https://github.com/apache/druid/pull/10669#issuecomment-745732447 @himanshug Thanks for your review! Job `71` is successful but `48`, `55`, `65` are failed unexpected. I am pretty sure these failures are not this PR related.

[GitHub] [druid] bharadwajrembar commented on issue #9528: How do I keep a dimension where all the values are empty？？？

bharadwajrembar commented on issue #9528: URL: https://github.com/apache/druid/issues/9528#issuecomment-745790562 Hey is there any update to this? We have also hit this. This is an automated message from the Apache Git Servic

[GitHub] [druid] bharadwajrembar commented on issue #4349: [Proposal] Improve Handling of Nulls in Druid

bharadwajrembar commented on issue #4349: URL: https://github.com/apache/druid/issues/4349#issuecomment-745797223 Hey @noskcire11 How did you overcome this? All segments have null values for the dimension so the dimension ends up being removed in the column metadata for that datasource.

[GitHub] [druid] bharadwajrembar edited a comment on issue #4349: [Proposal] Improve Handling of Nulls in Druid

bharadwajrembar edited a comment on issue #4349: URL: https://github.com/apache/druid/issues/4349#issuecomment-745797223 Hey @noskcire11 How did you overcome this? All segments have null values for the dimension so the dimension ends up being removed in the column metadata for that datasou

[GitHub] [druid] zhangyue19921010 edited a comment on pull request #10669: Do Integrate test for Druid base on K8s cluster

zhangyue19921010 edited a comment on pull request #10669: URL: https://github.com/apache/druid/pull/10669#issuecomment-745732447 @himanshug Thanks for your review! Job `71` is successful after changing as you suggested, but `48`, `55`, `65` are failed unexpected. I am pretty sure these f

[GitHub] [druid] vogievetsky merged pull request #10682: Web console: remove extra word (typo)

vogievetsky merged pull request #10682: URL: https://github.com/apache/druid/pull/10682 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[druid] branch master updated (7a8e9bb -> 55b8cc4)

This is an automated email from the ASF dual-hosted git repository. vogievetsky pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 7a8e9bb Fix hadoop docker copy script (#10671) add 55b8cc4 remove extra word (#10682) No new revisions we