[GitHub] [druid] dbardbar edited a comment on pull request #12078: Grouping on arrays as arrays

2021-12-21 Thread GitBox
dbardbar edited a comment on pull request #12078: URL: https://github.com/apache/druid/pull/12078#issuecomment-998812329 @cryptoe, The use-case is that some of the values in the MV field are not interesting for a specific query, and we would like to ignore them for the purpose of

[GitHub] [druid] kfaraz commented on pull request #12036: Docs: Fix column name in ingestion rollup doc

2021-12-21 Thread GitBox
kfaraz commented on pull request #12036: URL: https://github.com/apache/druid/pull/12036#issuecomment-999247471 Thanks for the reminder, @FrankChen021! I have updated the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [druid] FrankChen021 commented on issue #12090: Add a service start_time column, so you know when each of your services was started.

2021-12-21 Thread GitBox
FrankChen021 commented on issue #12090: URL: https://github.com/apache/druid/issues/12090#issuecomment-999243992 I think it's a good idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [druid] FrankChen021 commented on pull request #12036: Docs: Fix column name in ingestion rollup doc

2021-12-21 Thread GitBox
FrankChen021 commented on pull request #12036: URL: https://github.com/apache/druid/pull/12036#issuecomment-999243139 @kfaraz You need to update the spellchecking rule to fix the CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [druid] FrankChen021 commented on a change in pull request #12091: Standardizing SQL function docs

2021-12-21 Thread GitBox
FrankChen021 commented on a change in pull request #12091: URL: https://github.com/apache/druid/pull/12091#discussion_r773564295 ## File path: docs/querying/sql.md ## @@ -431,37 +431,37 @@ String functions accept strings, and return a type appropriate to the function.

[GitHub] [druid] FrankChen021 commented on a change in pull request #12091: Standardizing SQL function docs

2021-12-21 Thread GitBox
FrankChen021 commented on a change in pull request #12091: URL: https://github.com/apache/druid/pull/12091#discussion_r773564086 ## File path: docs/querying/sql.md ## @@ -431,37 +431,37 @@ String functions accept strings, and return a type appropriate to the function.

[GitHub] [druid] FrankChen021 commented on a change in pull request #12091: Standardizing SQL function docs

2021-12-21 Thread GitBox
FrankChen021 commented on a change in pull request #12091: URL: https://github.com/apache/druid/pull/12091#discussion_r773563661 ## File path: docs/querying/sql.md ## @@ -328,13 +328,13 @@ Only the COUNT, ARRAY_AGG, and STRING_AGG aggregations can accept the DISTINCT k

[GitHub] [druid] FrankChen021 commented on a change in pull request #12091: Standardizing SQL function docs

2021-12-21 Thread GitBox
FrankChen021 commented on a change in pull request #12091: URL: https://github.com/apache/druid/pull/12091#discussion_r773563582 ## File path: docs/querying/sql.md ## @@ -328,13 +328,13 @@ Only the COUNT, ARRAY_AGG, and STRING_AGG aggregations can accept the DISTINCT k

[GitHub] [druid] FrankChen021 commented on a change in pull request #12091: Standardizing SQL function docs

2021-12-21 Thread GitBox
FrankChen021 commented on a change in pull request #12091: URL: https://github.com/apache/druid/pull/12091#discussion_r773563503 ## File path: docs/querying/sql.md ## @@ -328,13 +328,13 @@ Only the COUNT, ARRAY_AGG, and STRING_AGG aggregations can accept the DISTINCT k

[GitHub] [druid] achimbab commented on pull request #11467: Functions that extract a value from a JSON-encoded string.

2021-12-21 Thread GitBox
achimbab commented on pull request #11467: URL: https://github.com/apache/druid/pull/11467#issuecomment-999219964 @suneet-s Hi, hope you are doing well. please let me know if there is something that I have to do in order to merge PR. Wish you a happy christmas. -- This is an

[druid] branch master updated: ARRAY_AGG and STRING_AGG will through errors if invoked on a complex datatype (#12089)

2021-12-21 Thread suneet
This is an automated email from the ASF dual-hosted git repository. suneet pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 1871a1a ARRAY_AGG and STRING_AGG will through

[GitHub] [druid] suneet-s merged pull request #12089: ARRAY_AGG and STRING_AGG will throw errors if invoked on a complex …

2021-12-21 Thread GitBox
suneet-s merged pull request #12089: URL: https://github.com/apache/druid/pull/12089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] vogievetsky commented on pull request #12085: Web console: new Ace, diff view, and cleanup. Decorating the console for the holidays ✨ 

2021-12-21 Thread GitBox
vogievetsky commented on pull request #12085: URL: https://github.com/apache/druid/pull/12085#issuecomment-999198154 Just realized that I updated the description with a screenshot for a different function than the one we were talking about, so here it is also:

[GitHub] [druid] vogievetsky opened a new pull request #12091: Standardizing SQL function docs

2021-12-21 Thread GitBox
vogievetsky opened a new pull request #12091: URL: https://github.com/apache/druid/pull/12091 Just making sure that the little details are consistent among the function docs. Specifically - Consistent formatting for optional arguments - Consistent code quoting for `expr`

[GitHub] [druid] vogievetsky commented on pull request #12085: Web console: new Ace, diff view, and cleanup. Decorating the console for the holidays ✨ 

2021-12-21 Thread GitBox
vogievetsky commented on pull request #12085: URL: https://github.com/apache/druid/pull/12085#issuecomment-999162806 Fixed and updated the screenshot in the description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [druid] churromorales opened a new issue #12090: Add a service start_time column, so you know when each of your services was started.

2021-12-21 Thread GitBox
churromorales opened a new issue #12090: URL: https://github.com/apache/druid/issues/12090 ### Description It would be nice to track server start time for each of the services that come up. ### Motivation Server start time is an important variable when it comes to

[druid] branch master updated: Removing unused processing threadpool on broker (#12070)

2021-12-21 Thread suneet
This is an automated email from the ASF dual-hosted git repository. suneet pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new c267b65 Removing unused processing threadpool

[GitHub] [druid] suneet-s commented on pull request #12070: Removing unused processing threadpool on broker

2021-12-21 Thread GitBox
suneet-s commented on pull request #12070: URL: https://github.com/apache/druid/pull/12070#issuecomment-999095021 Overruling Travis only failures are for lack of test coverage as explained in a previous comment and ITBroadcastJoinQueryTest which is aknown flaky test with an attempted fix

[GitHub] [druid] suneet-s merged pull request #12070: Removing unused processing threadpool on broker

2021-12-21 Thread GitBox
suneet-s merged pull request #12070: URL: https://github.com/apache/druid/pull/12070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] suneet-s commented on pull request #12089: ARRAY_AGG and STRING_AGG will through errors if invoked on a complex …

2021-12-21 Thread GitBox
suneet-s commented on pull request #12089: URL: https://github.com/apache/druid/pull/12089#issuecomment-999073683 close and re-open to try and trigger travis -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [druid] suneet-s closed pull request #12089: ARRAY_AGG and STRING_AGG will through errors if invoked on a complex …

2021-12-21 Thread GitBox
suneet-s closed pull request #12089: URL: https://github.com/apache/druid/pull/12089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] suneet-s commented on pull request #12070: Removing unused processing threadpool on broker

2021-12-21 Thread GitBox
suneet-s commented on pull request #12070: URL: https://github.com/apache/druid/pull/12070#issuecomment-999070182 > Travis will fail due to lack of coverage on openJDK11 and openJDK15 server module tests. This is expected as there is a piece of code in `BrokerProcessingModule` that

[GitHub] [druid] suneet-s edited a comment on pull request #12070: Removing unused processing threadpool on broker

2021-12-21 Thread GitBox
suneet-s edited a comment on pull request #12070: URL: https://github.com/apache/druid/pull/12070#issuecomment-999070182 > Travis will fail due to lack of coverage on openJDK11 and openJDK15 server module tests. This is expected as there is a piece of code in `BrokerProcessingModule` that

[GitHub] [druid] alborotogarcia commented on issue #12087: Deep storage on kubernetes

2021-12-21 Thread GitBox
alborotogarcia commented on issue #12087: URL: https://github.com/apache/druid/issues/12087#issuecomment-999051841 Hey @fhennig thanks for the reply, yes I am aware of that however, local deep storage seems to turn into problems between historical and middle manager [see this

[GitHub] [druid] somu-imply edited a comment on pull request #12070: Removing unused processing threadpool on broker

2021-12-21 Thread GitBox
somu-imply edited a comment on pull request #12070: URL: https://github.com/apache/druid/pull/12070#issuecomment-999050441 Travis will fail due to lack of coverage on openJDK11 and openJDK15 server module tests. This is expected as there is a piece of code in `BrokerProcessingModule` that

[GitHub] [druid] somu-imply commented on pull request #12070: Removing unused processing threadpool on broker

2021-12-21 Thread GitBox
somu-imply commented on pull request #12070: URL: https://github.com/apache/druid/pull/12070#issuecomment-999050441 Travis will fail due to lack of coverage on openJDK11 and openJDK15 server module tests. This is expected as there is a piece of code in `BrokerProcessingModule` that

[GitHub] [druid] somu-imply opened a new pull request #12089: ARRAY_AGG and STRING_AGG will through errors if invoked on a complex …

2021-12-21 Thread GitBox
somu-imply opened a new pull request #12089: URL: https://github.com/apache/druid/pull/12089 …datatype Added tests as well. This PR has: - [ x] been self-reviewed. - [ ] using the [concurrency

[GitHub] [druid] gianm commented on issue #12054: [Draft] 0.22.1 Release Notes

2021-12-21 Thread GitBox
gianm commented on issue #12054: URL: https://github.com/apache/druid/issues/12054#issuecomment-999010060 Hi @krishnat2, this is being discussed on the mailing list at: https://lists.apache.org/thread/06np4mml2gvyrdqkfqdjzs2dlp20n7hj We will be doing a new release with log4j 2.17,

[GitHub] [druid] lgtm-com[bot] commented on pull request #12032: Migrade Druid HttpClient from Netty 3 to 4

2021-12-21 Thread GitBox
lgtm-com[bot] commented on pull request #12032: URL: https://github.com/apache/druid/pull/12032#issuecomment-999002524 This pull request **introduces 3 alerts** when merging be46d9f0aa08165a53992c491e76e3c3f60abc74 into f34575936091f7e6944e4458b91396e904620727 - [view on

[GitHub] [druid] hellmarbecker opened a new pull request #12088: Clarify the use of the Lookup API

2021-12-21 Thread GitBox
hellmarbecker opened a new pull request #12088: URL: https://github.com/apache/druid/pull/12088 Clarifies how to call the Lookup API ### Description Clarifications: - The Lookup Update API is also for creating lookups - A caveat that there will be an error if you do not

[GitHub] [druid] fhennig commented on issue #12087: Deep storage on kubernetes

2021-12-21 Thread GitBox
fhennig commented on issue #12087: URL: https://github.com/apache/druid/issues/12087#issuecomment-998929620 Hey, there is also local deep storage, maybe you can use that instead: https://druid.apache.org/docs/latest/dependencies/deep-storage.html#local-mount Fro what you wrote it

[GitHub] [druid] applike-ss commented on issue #12082: Pull-deps extremely slow and not working in docker build

2021-12-21 Thread GitBox
applike-ss commented on issue #12082: URL: https://github.com/apache/druid/issues/12082#issuecomment-998873795 Even when doing that, i still see these via debug logs: ``` Downloading artifact io.prometheus:simpleclient:pom:0.7.0 from central (http://repo.maven.apache.org/maven2,

[GitHub] [druid] dbardbar commented on pull request #12078: Grouping on arrays as arrays

2021-12-21 Thread GitBox
dbardbar commented on pull request #12078: URL: https://github.com/apache/druid/pull/12078#issuecomment-998812329 @cryptoe, The use-case is that some of the values in the MV field are not interesting for a specific query, and we would like to ignore them for the purpose of the

[GitHub] [druid] alborotogarcia opened a new issue #12087: Deep storage on kubernetes

2021-12-21 Thread GitBox
alborotogarcia opened a new issue #12087: URL: https://github.com/apache/druid/issues/12087 Coordinator always restarts when I set minio/hdfs for deep storage ### Affected Version v0.22.1 ### Description I'm new to druid, I see that in order to persist segments

[GitHub] [druid] cryptoe commented on pull request #12078: Grouping on arrays as arrays

2021-12-21 Thread GitBox
cryptoe commented on pull request #12078: URL: https://github.com/apache/druid/pull/12078#issuecomment-998784656 > 1. Would this work also for a VirtualColumn which produces a multi-value? Specifically, VirtualColumn of type "mv-filtered". Is it possible to share a sample Q here. I

[GitHub] [druid] yannuokiss commented on issue #12086: ingest data from s3

2021-12-21 Thread GitBox
yannuokiss commented on issue #12086: URL: https://github.com/apache/druid/issues/12086#issuecomment-998712599 why loading agent.jar? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [druid] yannuokiss commented on issue #12086: ingest data from s3

2021-12-21 Thread GitBox
yannuokiss commented on issue #12086: URL: https://github.com/apache/druid/issues/12086#issuecomment-998712167 ![image](https://user-images.githubusercontent.com/16640669/146924923-3a0bf50b-7e55-4211-984b-e990a9570ae6.png) -- This is an automated message from the Apache Git Service.

[GitHub] [druid] FrankChen021 commented on issue #12082: Pull-deps extremely slow and not working in docker build

2021-12-21 Thread GitBox
FrankChen021 commented on issue #12082: URL: https://github.com/apache/druid/issues/12082#issuecomment-998711844 Use the -r option I mentioned above to download artifacts from https://repo1.maven.org/maven2/ -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [druid] yannuokiss opened a new issue #12086: ingest data from s3

2021-12-21 Thread GitBox
yannuokiss opened a new issue #12086: URL: https://github.com/apache/druid/issues/12086 Please provide a detailed title (e.g. "Broker crashes when using TopN query with Bound filter" instead of just "Broker crashes"). ### Affected Version The Druid version is 0.22.1

[GitHub] [druid] kaojunsong closed issue #12083: Druid startup failed with "Zookeeper is disabled, Can't create CuratorFramework." error without zookeeper

2021-12-21 Thread GitBox
kaojunsong closed issue #12083: URL: https://github.com/apache/druid/issues/12083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] kaojunsong commented on issue #12083: Druid startup failed with "Zookeeper is disabled, Can't create CuratorFramework." error without zookeeper

2021-12-21 Thread GitBox
kaojunsong commented on issue #12083: URL: https://github.com/apache/druid/issues/12083#issuecomment-998562962 I have solved this issue, it is caused by the space after "druid.zk.service.enabled=false " -- This is an automated message from the Apache Git Service. To respond to the