cryptoe commented on issue #11653:
URL: https://github.com/apache/druid/issues/11653#issuecomment-1241506691
@jasonwzm Is it reproducible under some conditions?
I am looking into how to repro this locally
It would be super helpful if one could share the logs of the overlord,
coordinat
gianm opened a new pull request, #13061:
URL: https://github.com/apache/druid/pull/13061
An exact quantile implementation, intended for usage when the number of data
points is small. It works well in conjuction with `ARRAY_AGG`.
Example:
```
SELECT
ARRAY_QUANTILE(ARRAY_
This is an automated email from the ASF dual-hosted git repository.
frankchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 48c99054d0 Update tutorial-kafka.md (#13056)
4
FrankChen021 merged PR #13056:
URL: https://github.com/apache/druid/pull/13056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid
imply-cheddar commented on code in PR #13052:
URL: https://github.com/apache/druid/pull/13052#discussion_r966554762
##
sql/src/main/java/org/apache/druid/sql/calcite/schema/SegmentMetadataCache.java:
##
@@ -905,9 +906,10 @@ protected Sequence
runSegmentMetadataQuery(
f
imply-cheddar commented on code in PR #13052:
URL: https://github.com/apache/druid/pull/13052#discussion_r966554342
##
sql/src/main/java/org/apache/druid/sql/calcite/schema/SegmentMetadataCache.java:
##
@@ -905,9 +906,10 @@ protected Sequence
runSegmentMetadataQuery(
f
imply-cheddar commented on code in PR #13052:
URL: https://github.com/apache/druid/pull/13052#discussion_r966551082
##
sql/src/main/java/org/apache/druid/sql/calcite/parser/DruidSqlInsert.java:
##
@@ -114,4 +114,9 @@ public void unparse(SqlWriter writer, int leftPrec, int
right
imply-cheddar commented on code in PR #13052:
URL: https://github.com/apache/druid/pull/13052#discussion_r966550933
##
core/src/main/java/org/apache/druid/guice/annotations/MSQ.java:
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mo
imply-cheddar commented on code in PR #13052:
URL: https://github.com/apache/druid/pull/13052#discussion_r966548543
##
sql/src/main/java/org/apache/druid/sql/http/SqlResource.java:
##
@@ -185,20 +178,24 @@ public Response doPost(
endLifecycle(stmt, e, os.get
This is an automated email from the ASF dual-hosted git repository.
cwylie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 6438f4198d improve nested column serializer (#130
clintropolis merged PR #13051:
URL: https://github.com/apache/druid/pull/13051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid
clintropolis commented on code in PR #13052:
URL: https://github.com/apache/druid/pull/13052#discussion_r966347741
##
core/src/main/java/org/apache/druid/guice/annotations/MSQ.java:
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mor
somu-imply commented on PR #13052:
URL: https://github.com/apache/druid/pull/13052#issuecomment-1241312356
Overall looks good, the Sequence has been changed to a QueryResponse with a
separate class and removing the old static QueryResponse class. Most of the
places which deal with sequences
somu-imply commented on code in PR #13052:
URL: https://github.com/apache/druid/pull/13052#discussion_r966482607
##
sql/src/main/java/org/apache/druid/sql/http/SqlResource.java:
##
@@ -185,20 +178,24 @@ public Response doPost(
endLifecycle(stmt, e, os.getCou
techdocsmith commented on PR #13060:
URL: https://github.com/apache/druid/pull/13060#issuecomment-1241307568
@vogievetsky , cool this is handled in the UI. I want to make sure from the
docs side we're making it clear about the appropriate use of quotes in query
syntax.
--
This is an auto
vogievetsky opened a new pull request, #13060:
URL: https://github.com/apache/druid/pull/13060
Auto complete should add the proper quotes if the column / datasource /
schema needs it (like if it is reserved).
https://user-images.githubusercontent.com/177816/189214161-43f2bc88-07dc-417
jasonwzm commented on issue #11653:
URL: https://github.com/apache/druid/issues/11653#issuecomment-1241162002
We are also experiencing this and have been manually intervening the
metadata store to fix this (not ideal). Does anyone have updates on this?
--
This is an automated message from
This is an automated email from the ASF dual-hosted git repository.
abhishek pushed a commit to branch 24.0.0
in repository https://gitbox.apache.org/repos/asf/druid.git
commit a6f5a7465001fd720ff207cf154b47d8f4535eb6
Author: Abhishek Agarwal <1477457+abhishekagarwa...@users.noreply.github.com>
A
This is an automated email from the ASF dual-hosted git repository.
abhishek pushed a change to branch 24.0.0
in repository https://gitbox.apache.org/repos/asf/druid.git
from 72f0fd0583 Reverting #12659 from 24.0 release (take 3) (#13053)
add 2319f10cb6 [maven-release-plugin] prepare re
dongjoon-hyun commented on PR #13024:
URL: https://github.com/apache/druid/pull/13024#issuecomment-1241091657
Could you rebase this PR to the master branch once more, @williamhyun ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
dongjoon-hyun commented on PR #13024:
URL: https://github.com/apache/druid/pull/13024#issuecomment-1241091224
Retest this please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
FrankChen021 commented on PR #13034:
URL: https://github.com/apache/druid/pull/13034#issuecomment-1241073286
Hi @599166320 Since there's a CI failure in this PR, I merged #13028 in
advance which brought some conflicts with what you have done in this PR.
Appreciate that if you can res
This is an automated email from the ASF dual-hosted git repository.
frankchen pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
from 99fd22c79b fix bug in /status/properties filtering (#13045)
add d57557d51d Improve doc and configuration of pro
FrankChen021 merged PR #13028:
URL: https://github.com/apache/druid/pull/13028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@druid
FrankChen021 opened a new pull request, #13059:
URL: https://github.com/apache/druid/pull/13059
These some improvements about Docker, including:
1. Update to run with JRE 11 by default
2. Update to use
[gcr.io/distroless/java11-debian11](https://github.com/GoogleContainerTools/dist
599166320 commented on code in PR #13031:
URL: https://github.com/apache/druid/pull/13031#discussion_r966252278
##
processing/src/main/java/org/apache/druid/collections/MultiColumnSorter.java:
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
599166320 commented on code in PR #13031:
URL: https://github.com/apache/druid/pull/13031#discussion_r966252278
##
processing/src/main/java/org/apache/druid/collections/MultiColumnSorter.java:
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
599166320 commented on code in PR #13031:
URL: https://github.com/apache/druid/pull/13031#discussion_r966246719
##
processing/src/main/java/org/apache/druid/query/scan/ScanQueryOrderByLimitRowIterator.java:
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation
599166320 commented on code in PR #13031:
URL: https://github.com/apache/druid/pull/13031#discussion_r966220104
##
processing/src/main/java/org/apache/druid/query/scan/ScanQueryEngine.java:
##
@@ -252,7 +260,295 @@ public void cleanup(Iterator
iterFromMake)
))
vogievetsky commented on code in PR #13050:
URL: https://github.com/apache/druid/pull/13050#discussion_r966196522
##
web-console/script/create-sql-docs.js:
##
@@ -90,15 +90,15 @@ const readDoc = async () => {
// Make sure there are enough functions found
const numFunctio
599166320 commented on PR #13031:
URL: https://github.com/apache/druid/pull/13031#issuecomment-1240942976
> [599166320](https://github.com/599166320), thanks for your contribution!
The native query engines are quite complex. See the comments for a few things
to think about.
>
> As it
Author: abhishek
Date: Thu Sep 8 16:13:11 2022
New Revision: 56746
Log:
add 24.0.0-rc1 artifacts
Added:
dev/druid/24.0.0-rc1/
dev/druid/24.0.0-rc1/apache-druid-24.0.0-bin.tar.gz (with props)
dev/druid/24.0.0-rc1/apache-druid-24.0.0-bin.tar.gz.asc (with props)
dev/druid/24.0.0
asdf2014 opened a new pull request, #13058:
URL: https://github.com/apache/druid/pull/13058
### Description
In K8s doc, the version of Druid docker image still is `0.16.0-incubating`,
this patch will fix it.
FrankChen021 commented on issue #13057:
URL: https://github.com/apache/druid/issues/13057#issuecomment-1240880480
Actually, the startup script `druid.sh` in docker is declared using `sh`
https://github.com/apache/druid/blob/99fd22c79be85763d48b1caf3ec67767a0c5f9ad/distribution/docker/
capistrant commented on code in PR #13020:
URL: https://github.com/apache/druid/pull/13020#discussion_r966114705
##
distribution/docker/druid.sh:
##
@@ -29,6 +29,8 @@
# Additional env vars:
# - DRUID_LOG4J -- set the entire log4j.xml verbatim
# - DRUID_LOG_LEVEL -- override t
FrankChen021 commented on issue #13057:
URL: https://github.com/apache/druid/issues/13057#issuecomment-1240864562
24.0.0 is also affected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
FrankChen021 opened a new issue, #13057:
URL: https://github.com/apache/druid/issues/13057
#12839 introduces a script `run-java` to start the peon tasks, and this
script requires bash to execute it.
However, the busybox that docker images installs does not ship bash but sh,
so when a
capistrant commented on issue #12999:
URL: https://github.com/apache/druid/issues/12999#issuecomment-1240859129
I think #13010 is a safe way to solve this. There is some unnecessary no-op
network traffic, but it should put a stop to wasteful counter resets
--
This is an automated message
capistrant commented on PR #13045:
URL: https://github.com/apache/druid/pull/13045#issuecomment-1240856243
@paul-rogers welp, I guess this got merged quickly since it needed to fix
the regression in backport. I think I will follow on with a PR to master
(no-backport) with a change to add th
This is an automated email from the ASF dual-hosted git repository.
abhishek pushed a change to annotated tag druid-24.0.0-rc1
in repository https://gitbox.apache.org/repos/asf/druid.git
*** WARNING: tag druid-24.0.0-rc1 was modified! ***
from 2319f10cb6 (commit)
to ff9ff56274 (tag)
599166320 commented on PR #13034:
URL: https://github.com/apache/druid/pull/13034#issuecomment-1240756583
> Sorry, I see now that I did not use precise language. My concern was not
the map of registered metrics itself, because once initialized, it is never
updated, only read from. But it do
599166320 commented on code in PR #13034:
URL: https://github.com/apache/druid/pull/13034#discussion_r966001181
##
extensions-contrib/prometheus-emitter/src/main/java/org/apache/druid/emitter/prometheus/Metrics.java:
##
@@ -63,6 +64,7 @@ public DimensionsAndCollector getByName(S
kfaraz commented on code in PR #13034:
URL: https://github.com/apache/druid/pull/13034#discussion_r965997237
##
extensions-contrib/prometheus-emitter/src/main/java/org/apache/druid/emitter/prometheus/Metrics.java:
##
@@ -63,6 +64,7 @@ public DimensionsAndCollector getByName(Stri
kfaraz commented on PR #13034:
URL: https://github.com/apache/druid/pull/13034#issuecomment-1240744432
Thanks for the clarification, @FrankChen021 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
FrankChen021 commented on code in PR #13056:
URL: https://github.com/apache/druid/pull/13056#discussion_r965992409
##
docs/tutorials/tutorial-kafka.md:
##
@@ -43,6 +43,11 @@ curl -O
https://archive.apache.org/dist/kafka/2.7.0/kafka_2.13-2.7.0.tgz
tar -xzf kafka_2.13-2.7.0.tgz
FrankChen021 commented on PR #13034:
URL: https://github.com/apache/druid/pull/13034#issuecomment-1240729090
Each metric is independent in prometheus, I think it's OK that first metric
is with the old value and 2nd is with the new.
--
This is an automated message from the Apache Git Serv
This is an automated email from the ASF dual-hosted git repository.
abhishek pushed a commit to branch 24.0.0
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/24.0.0 by this push:
new 72f0fd0583 Reverting #12659 from 24.0 release (
abhishekagarwal87 merged PR #13053:
URL: https://github.com/apache/druid/pull/13053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@
abhishekagarwal87 commented on PR #13053:
URL: https://github.com/apache/druid/pull/13053#issuecomment-1240697034
Merging since failures look unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
kfaraz commented on PR #13034:
URL: https://github.com/apache/druid/pull/13034#issuecomment-1240624863
Sorry, I see now that I did not use precise language. My concern was not the
map of registered metrics itself, because once initialized, it is never
updated, only read from. But it does no
sachidananda007 opened a new pull request, #13056:
URL: https://github.com/apache/druid/pull/13056
Added missing command to the doc for zookeeper before starting kafka
### Description
Added missing command for kafka ingestion doc
added missing comad for zookeeper
T
abhishekagarwal87 commented on issue #12318:
URL: https://github.com/apache/druid/issues/12318#issuecomment-1240556407
Fixed by #12404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
abhishekagarwal87 closed issue #12318: Metadata store query performance
degrades as the tasks in druid_tasks table grows
URL: https://github.com/apache/druid/issues/12318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
abhishekagarwal87 closed issue #13055: Test issue [Please ignore]
URL: https://github.com/apache/druid/issues/13055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
FrankChen021 commented on PR #13034:
URL: https://github.com/apache/druid/pull/13034#issuecomment-1240548397
> > The changes look good. I have some concerns about thread-safety though.
The `Metrics` object or the map of `registeredMetrics` inside it is not
thread-safe. Every invocation of `
599166320 commented on PR #13034:
URL: https://github.com/apache/druid/pull/13034#issuecomment-1240544273
> The changes look good. I have some concerns about thread-safety though.
The `Metrics` object or the map of `registeredMetrics` inside it is not
thread-safe. Every invocation of `emit`
FrankChen021 commented on code in PR #13022:
URL: https://github.com/apache/druid/pull/13022#discussion_r965779945
##
processing/src/main/java/org/apache/druid/query/QueryContexts.java:
##
@@ -503,7 +487,24 @@ public static String getAsString(
} else if (value instanceof St
FrankChen021 commented on code in PR #13022:
URL: https://github.com/apache/druid/pull/13022#discussion_r965773240
##
processing/src/main/java/org/apache/druid/query/QueryContexts.java:
##
@@ -399,12 +398,12 @@ public static Query verifyMaxQueryTimeout(Query
query, long maxQue
FrankChen021 commented on PR #13034:
URL: https://github.com/apache/druid/pull/13034#issuecomment-1240509396
@kfaraz Good point.
I looked through the code, the underlying `registeredMetrics` is intialized
when `PrometheusEmitter` is initialized and the map won't change after that.
W
599166320 commented on PR #13034:
URL: https://github.com/apache/druid/pull/13034#issuecomment-1240508471
>
I'll have a look later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
abhishekagarwal87 opened a new issue, #13055:
URL: https://github.com/apache/druid/issues/13055
Apache Druid 24.0 contains over [TBD] new features, bug fixes, performance
enhancements, documentation improvements, and additional test coverage from 81
contributors. [See the complete set of c
kfaraz commented on PR #13034:
URL: https://github.com/apache/druid/pull/13034#issuecomment-1240339747
The changes look good. I have some concerns about thread-safety though. The
`Metrics` object or the map of `registeredMetrics` inside it is not
thread-safe. Every invocation of `emit` upda
FrankChen021 commented on code in PR #13022:
URL: https://github.com/apache/druid/pull/13022#discussion_r965583376
##
processing/src/main/java/org/apache/druid/query/Query.java:
##
@@ -124,22 +124,130 @@ default QueryContext getQueryContext()
return null;
}
- Context
vogievetsky merged PR #182:
URL: https://github.com/apache/druid-website/pull/182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@dr
64 matches
Mail list logo
