paul-rogers opened a new pull request, #13780:
URL: https://github.com/apache/druid/pull/13780
This is a follow-up to the earlier PR that introduced input-source specific
table functions (e.g. `http`, `s3`, `localfiles`, etc.) This PR is mostly
cleanup and bug fixes and is a spin-off of
anshu-makkar commented on PR #13664:
URL: https://github.com/apache/druid/pull/13664#issuecomment-1423654934
Thank you @techdocsmith . Kindly merge it and Integration Test is failing on
this PR, might be because of some other bug in latest code.
--
This is an automated message from the
cheddar commented on PR #13698:
URL: https://github.com/apache/druid/pull/13698#issuecomment-1423653117
The change set looks good. I agree with Paul, need green checks from build
and then we are good.
--
This is an automated message from the Apache Git Service.
To respond to the
techdocsmith commented on code in PR #13485:
URL: https://github.com/apache/druid/pull/13485#discussion_r1088424991
##
examples/quickstart/jupyter-notebooks/druid-visualization.ipynb:
##
@@ -0,0 +1,620 @@
+{
+ "cells": [
+ {
+ "cell_type": "markdown",
+ "id": "ad4e60b6",
+
clintropolis commented on code in PR #13779:
URL: https://github.com/apache/druid/pull/13779#discussion_r1100962754
##
processing/src/main/java/org/apache/druid/segment/virtual/NestedFieldVirtualColumn.java:
##
@@ -647,7 +650,10 @@ public ColumnCapabilities
techdocsmith commented on PR #13468:
URL: https://github.com/apache/druid/pull/13468#issuecomment-1423603238
@ektravel , do you want to remove the lines referring to Segment sizing and
partitioning so we can merge this PR? Thanks!
--
This is an automated message from the Apache Git
techdocsmith merged PR #13465:
URL: https://github.com/apache/druid/pull/13465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
techdocsmith pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
from 714ac07b52 Allow users to add additional metadata to ingestion metrics
(#13760)
add 58d9720b00 docs:
imply-cheddar commented on code in PR #13779:
URL: https://github.com/apache/druid/pull/13779#discussion_r1100957121
##
processing/src/main/java/org/apache/druid/segment/virtual/NestedFieldVirtualColumn.java:
##
@@ -647,7 +650,10 @@ public ColumnCapabilities
abhishekagarwal87 commented on PR #13531:
URL: https://github.com/apache/druid/pull/13531#issuecomment-1423581151
I will merge this soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
imply-cheddar commented on code in PR #13779:
URL: https://github.com/apache/druid/pull/13779#discussion_r1100944253
##
processing/src/main/java/org/apache/druid/segment/virtual/NestedFieldVirtualColumn.java:
##
@@ -416,7 +417,7 @@ public VectorObjectSelector
clintropolis opened a new pull request, #13779:
URL: https://github.com/apache/druid/pull/13779
### Description
This PR fixes an issue when filtering on a `NestedFieldVirtualColumn` that
is using an input column that is not a nested column, such as a standard
string, long, float, or
paul-rogers opened a new pull request, #13778:
URL: https://github.com/apache/druid/pull/13778
This PR is a collection if minor edits done as part of the Catalog project.
Pulled out here to reduce the size of the catalog PR.
The edits include:
* Fix spacing
* Add type
jaegwonseo commented on PR #13531:
URL: https://github.com/apache/druid/pull/13531#issuecomment-1423519046
@abhishekagarwal87
i just change k8s config
is it related with this error? [build fail
link](https://app.travis-ci.com/github/apache/druid/jobs/595434161)
--
This is an
asdf2014 closed issue #13745: Helm chart forces zookeeper hosts to be set even
if using druid-kubernetes-extensions
URL: https://github.com/apache/druid/issues/13745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
This is an automated email from the ASF dual-hosted git repository.
suneet pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 714ac07b52 Allow users to add additional
suneet-s merged PR #13760:
URL: https://github.com/apache/druid/pull/13760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
paul-rogers opened a new pull request, #13777:
URL: https://github.com/apache/druid/pull/13777
DruidDruid has an `INFORMATION_SCHEMA` to provide metadata about Druid
tables and columns. Historically, columns that contain numbers (such as
`ORDINAL_POSITION`) were represented as `VARCHAR`.
suneet-s opened a new pull request, #13776:
URL: https://github.com/apache/druid/pull/13776
### Description
Update QueryException#toString to include more information about the
exception that occurred like error code, class, etc.
This PR has:
- [ ] been
somu-imply commented on code in PR #13764:
URL: https://github.com/apache/druid/pull/13764#discussion_r1100730560
##
sql/src/test/java/org/apache/druid/sql/calcite/util/TestDataBuilder.java:
##
@@ -351,6 +351,100 @@ public Optional build(
public static final List ROWS1 =
juhoautio-rovio opened a new issue, #13775:
URL: https://github.com/apache/druid/issues/13775
### Affected Version
25.0.0
### Description
Having a an empty string as a value and grouping by it doesn't make much
sense, but there happened to be a query like that, and it
paul-rogers commented on code in PR #13764:
URL: https://github.com/apache/druid/pull/13764#discussion_r1100676736
##
sql/src/test/java/org/apache/druid/sql/calcite/util/CalciteTests.java:
##
@@ -97,6 +97,7 @@
public static final String DATASOURCE3 = "numfoo";
public
somu-imply commented on code in PR #13736:
URL: https://github.com/apache/druid/pull/13736#discussion_r1100675117
##
docs/querying/sql.md:
##
@@ -82,6 +83,29 @@ FROM clause, metadata tables are not considered datasources.
They exist only in
For more information about table,
paul-rogers commented on code in PR #13766:
URL: https://github.com/apache/druid/pull/13766#discussion_r1100666897
##
sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidOperatorTable.java:
##
@@ -437,6 +442,12 @@ public DruidOperatorTable(
for
techdocsmith commented on code in PR #13664:
URL: https://github.com/apache/druid/pull/13664#discussion_r1100664367
##
docs/development/extensions-core/datasketches-theta.md:
##
@@ -95,6 +95,49 @@ This returns a summary of the sketch that can be used for
debugging. This is the
jwitko commented on code in PR #13747:
URL: https://github.com/apache/druid/pull/13747#discussion_r1100573665
##
helm/druid/templates/broker/deployment.yaml:
##
@@ -41,11 +41,15 @@ spec:
app: {{ include "druid.name" . }}
release: {{ .Release.Name }}
jwitko commented on code in PR #13747:
URL: https://github.com/apache/druid/pull/13747#discussion_r1100571768
##
helm/druid/templates/broker/role.yaml:
##
@@ -0,0 +1,21 @@
+{{- if .Values.rbac.create }}
+apiVersion: rbac.authorization.k8s.io/v1
+kind: Role
+metadata:
+ name:
zachjsh commented on code in PR #13766:
URL: https://github.com/apache/druid/pull/13766#discussion_r1100565821
##
sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidOperatorTable.java:
##
@@ -437,6 +442,12 @@ public DruidOperatorTable(
for (SqlOperatorConversion
zachjsh commented on code in PR #13766:
URL: https://github.com/apache/druid/pull/13766#discussion_r1100565324
##
sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidOperatorTable.java:
##
@@ -437,6 +442,12 @@ public DruidOperatorTable(
for (SqlOperatorConversion
zachjsh commented on code in PR #13766:
URL: https://github.com/apache/druid/pull/13766#discussion_r1100563840
##
sql/src/main/java/org/apache/druid/sql/calcite/planner/PlannerOperatorConversionConfig.java:
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation
zachjsh commented on code in PR #13766:
URL: https://github.com/apache/druid/pull/13766#discussion_r1100564226
##
sql/src/test/java/org/apache/druid/sql/calcite/planner/DruidOperatorTableTest.java:
##
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
zachjsh commented on code in PR #13766:
URL: https://github.com/apache/druid/pull/13766#discussion_r1100563578
##
sql/src/main/java/org/apache/druid/sql/calcite/planner/PlannerOperatorConversionConfig.java:
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation
zachjsh commented on code in PR #13766:
URL: https://github.com/apache/druid/pull/13766#discussion_r1100563357
##
sql/src/main/java/org/apache/druid/sql/calcite/planner/CalcitePlannerModule.java:
##
@@ -40,6 +40,7 @@ public void configure(Binder binder)
// We're actually
zachjsh commented on code in PR #13766:
URL: https://github.com/apache/druid/pull/13766#discussion_r1100563040
##
sql/src/main/java/org/apache/druid/sql/calcite/planner/PlannerOperatorConversionConfig.java:
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation
xvrl commented on code in PR #13341:
URL: https://github.com/apache/druid/pull/13341#discussion_r1100534123
##
helm/druid/Chart.yaml:
##
@@ -14,7 +14,7 @@
# limitations under the License.
apiVersion: v2
-appVersion: 0.23.0
+appVersion: 24.0.0
Review Comment:
shouldn't
dampcake commented on code in PR #13747:
URL: https://github.com/apache/druid/pull/13747#discussion_r1100528686
##
helm/druid/templates/broker/roleBinding.yaml:
##
@@ -0,0 +1,20 @@
+{{- if .Values.rbac.create }}
Review Comment:
Same question about checking enabled for the
tejaswini-imply commented on PR #13772:
URL: https://github.com/apache/druid/pull/13772#issuecomment-1422992653
@paul-rogers @imply-elliott Could you please review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
somu-imply commented on PR #13764:
URL: https://github.com/apache/druid/pull/13764#issuecomment-1422987126
@imply-cheddar it is the other way round the previous was
```
select * from mytest1, unnest(mv_to_array(c2)) as unnested(c3)
__time c1 c2 c3
2022-01-01T00:00:00.000Z 1
anshu-makkar commented on code in PR #13664:
URL: https://github.com/apache/druid/pull/13664#discussion_r1100432243
##
docs/development/extensions-core/datasketches-theta.md:
##
@@ -95,6 +95,49 @@ This returns a summary of the sketch that can be used for
debugging. This is the
techdocsmith commented on code in PR #13664:
URL: https://github.com/apache/druid/pull/13664#discussion_r1100427144
##
docs/development/extensions-core/datasketches-theta.md:
##
@@ -95,6 +95,49 @@ This returns a summary of the sketch that can be used for
debugging. This is the
jwitko commented on PR #13747:
URL: https://github.com/apache/druid/pull/13747#issuecomment-1422886636
> Thank you. I see that by default, helm charts are now going to create
service accounts per service. so can we keep the default off in top-level
`values.yaml`
anshu-makkar commented on PR #13664:
URL: https://github.com/apache/druid/pull/13664#issuecomment-1422838455
@techdocsmith Kindly let me know if any more changes are needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
abhishekagarwal87 commented on PR #13747:
URL: https://github.com/apache/druid/pull/13747#issuecomment-1422713735
Thank you. I see that by default, helm charts are now going to create
service accounts per service. so can we keep the default off in top-level
`values.yaml`
--
This is an
jwitko commented on PR #13747:
URL: https://github.com/apache/druid/pull/13747#issuecomment-1422665417
> can you elaborate a bit more on "Enabling per-service serviceAccounts
allows for finer grained RBAC"? Maybe take us through an example use-case that
you want to implement on your own
jwitko commented on PR #13747:
URL: https://github.com/apache/druid/pull/13747#issuecomment-1422651898
Merged upstream master into this branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kfaraz commented on code in PR #13303:
URL: https://github.com/apache/druid/pull/13303#discussion_r105172
##
indexing-hadoop/src/main/java/org/apache/druid/indexer/DeterminePartitionsJob.java:
##
@@ -603,6 +647,28 @@ protected void innerReduce(Context context, SortableBytes
kfaraz commented on code in PR #13303:
URL: https://github.com/apache/druid/pull/13303#discussion_r102653
##
core/src/test/java/org/apache/druid/timeline/partition/DimensionRangeShardSpecTest.java:
##
@@ -136,6 +136,61 @@ public void testShardSpecLookup()
);
}
+
This is an automated email from the ASF dual-hosted git repository.
abhishek pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
from 34c04daa9f Fix infinite iteration in http sync monitoring (#13731)
add d7a15be9bc Add assertions for counters
abhishekagarwal87 commented on PR #13726:
URL: https://github.com/apache/druid/pull/13726#issuecomment-1422416183
Merged since failures are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
abhishekagarwal87 merged PR #13726:
URL: https://github.com/apache/druid/pull/13726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
github-code-scanning[bot] commented on code in PR #12852:
URL: https://github.com/apache/druid/pull/12852#discussion_r1099894611
##
indexing-service/src/test/java/org/apache/druid/indexing/common/task/batch/parallel/AbstractMultiPhaseParallelIndexingTest.java:
##
@@ -243,22
This is an automated email from the ASF dual-hosted git repository.
amatya pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 34c04daa9f Fix infinite iteration in http sync
AmatyaAvadhanula merged PR #13731:
URL: https://github.com/apache/druid/pull/13731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
AmatyaAvadhanula commented on PR #13731:
URL: https://github.com/apache/druid/pull/13731#issuecomment-1422311781
@abhishekagarwal87 I've added tests.
Merging since the failures are due to code coverage
--
This is an automated message from the Apache Git Service.
To respond to the
github-code-scanning[bot] commented on code in PR #13774:
URL: https://github.com/apache/druid/pull/13774#discussion_r1099781790
##
integration-tests-ex/cases/src/test/java/org/apache/druid/testsEx/query/ITBroadcastJoinQueryTest.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to
55 matches
Mail list logo
