Re: [PR] Task concurrency management in K8s Task Scheduling extension (druid)

2024-03-03 Thread via GitHub
github-advanced-security[bot] commented on code in PR #15976: URL: https://github.com/apache/druid/pull/15976#discussion_r1510680741 ## extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesTaskRunner.java: ## @@ -144,24 +160,48

Re: [PR] Task concurrency management in K8s Task Scheduling extension (druid)

2024-03-03 Thread via GitHub
YongGang commented on PR #15976: URL: https://github.com/apache/druid/pull/15976#issuecomment-1975864810 Updated the PR in response to feedback: 1. Move task lane config classes to core Druid. `TaskLaneRegistry` remains in the extension code due to its ties with task runner capacity confi

Re: [PR] Improved Connection Count server select strategy (druid)

2024-03-03 Thread via GitHub
abhishekagarwal87 commented on code in PR #15975: URL: https://github.com/apache/druid/pull/15975#discussion_r1510658076 ## server/src/test/java/org/apache/druid/client/DirectDruidClientTest.java: ## @@ -427,4 +431,47 @@ public void testQueryTimeoutFromFuture() Assert.asser

Re: [PR] Improved Connection Count server select strategy (druid)

2024-03-03 Thread via GitHub
abhishekagarwal87 commented on code in PR #15975: URL: https://github.com/apache/druid/pull/15975#discussion_r1510658076 ## server/src/test/java/org/apache/druid/client/DirectDruidClientTest.java: ## @@ -427,4 +431,47 @@ public void testQueryTimeoutFromFuture() Assert.asser

Re: [PR] Improved Connection Count server select strategy (druid)

2024-03-03 Thread via GitHub
abhishekagarwal87 commented on code in PR #15975: URL: https://github.com/apache/druid/pull/15975#discussion_r1510645622 ## server/src/test/java/org/apache/druid/client/DirectDruidClientTest.java: ## @@ -427,4 +431,47 @@ public void testQueryTimeoutFromFuture() Assert.asser

Re: [PR] Support CPU resource configurable for Kubernates job under MoK Mode (druid)

2024-03-03 Thread via GitHub
fectrain commented on code in PR #16008: URL: https://github.com/apache/druid/pull/16008#discussion_r1510655965 ## docs/development/extensions-contrib/k8s-jobs.md: ## @@ -219,23 +219,24 @@ data: ``` ### Properties -|Property| Possible Values | Description

(druid) branch 29.0.1 updated: Fix redirects for streaming ingestion (#15943) (#16026)

2024-03-03 Thread abhishek
This is an automated email from the ASF dual-hosted git repository. abhishek pushed a commit to branch 29.0.1 in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/29.0.1 by this push: new b3e470dc4e5 Fix redirects for streaming ingesti

Re: [PR] [Backport] Docs: Fix redirects for streaming ingestion (#15943) (druid)

2024-03-03 Thread via GitHub
abhishekagarwal87 merged PR #16026: URL: https://github.com/apache/druid/pull/16026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

Re: [PR] Fix Windowing/scanAndSort query issues on top of Joins. (druid)

2024-03-03 Thread via GitHub
clintropolis commented on code in PR #15996: URL: https://github.com/apache/druid/pull/15996#discussion_r1510627892 ## processing/src/main/java/org/apache/druid/frame/read/columnar/DoubleFrameColumnReader.java: ## @@ -67,7 +67,7 @@ public ColumnPlus readColumn(final Frame frame)

Re: [PR] Explicitly bind ServiceStatusMonitor (druid)

2024-03-03 Thread via GitHub
kfaraz commented on PR #16025: URL: https://github.com/apache/druid/pull/16025#issuecomment-1975788845 @arunramani , could you please share some more details of the failed ingestion in the PR description, such as the exception message and some log lines? -- This is an automated message f

Re: [PR] refactor CompactionState since core and processing have been merged (druid)

2024-03-03 Thread via GitHub
kfaraz commented on PR #14932: URL: https://github.com/apache/druid/pull/14932#issuecomment-1975782775 @clintropolis , there are some conflicts that would need to be resolved before we can merge this. -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] Update docs to document breaking change in explain attributes (druid)

2024-03-03 Thread via GitHub
adarshsanjeev opened a new pull request, #16031: URL: https://github.com/apache/druid/pull/16031 Updates the docs to include a breaking change made regarding the attributes returned by an explain query. The return type of the field `targetDataSource` was changed to an object instead of a st

Re: [PR] Array overlap to allow numeric operand (druid)

2024-03-03 Thread via GitHub
sreemanamala commented on code in PR #15964: URL: https://github.com/apache/druid/pull/15964#discussion_r1510555069 ## sql/src/main/java/org/apache/druid/sql/calcite/planner/SqlParameterizerShuttle.java: ## @@ -129,13 +129,12 @@ private SqlNode createArrayLiteral(Object value, i

(druid) branch master updated: docs: mention acid-compliance for meta store (#16014)

2024-03-03 Thread asdf2014
This is an automated email from the ASF dual-hosted git repository. asdf2014 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new b3015bd7ced docs: mention acid-compliance for m

Re: [PR] docs: mention acid-compliance for meta store (druid)

2024-03-03 Thread via GitHub
asdf2014 merged PR #16014: URL: https://github.com/apache/druid/pull/16014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apa

Re: [PR] Configure FunctionArgsAlignmentRule (druid)

2024-03-03 Thread via GitHub
github-actions[bot] commented on PR #14937: URL: https://github.com/apache/druid/pull/14937#issuecomment-1975419364 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

Re: [PR] Adding unnest tests for join precedence when using multiple joins tog… (druid)

2024-03-03 Thread via GitHub
github-actions[bot] commented on PR #14969: URL: https://github.com/apache/druid/pull/14969#issuecomment-1975419448 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

Re: [I] Cluster Deployment Router Port (druid)

2024-03-03 Thread via GitHub
github-actions[bot] commented on issue #13723: URL: https://github.com/apache/druid/issues/13723#issuecomment-1975417881 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.

Re: [PR] Load cache files in parallel to speed up historical startup (druid)

2024-03-03 Thread via GitHub
github-actions[bot] commented on PR #11878: URL: https://github.com/apache/druid/pull/11878#issuecomment-1975417716 This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. -

Re: [PR] Load cache files in parallel to speed up historical startup (druid)

2024-03-03 Thread via GitHub
github-actions[bot] closed pull request #11878: Load cache files in parallel to speed up historical startup URL: https://github.com/apache/druid/pull/11878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] Cluster Deployment Router Port (druid)

2024-03-03 Thread via GitHub
github-actions[bot] closed issue #13723: Cluster Deployment Router Port URL: https://github.com/apache/druid/issues/13723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] Explicitly bind ServiceStatusMonitor (druid)

2024-03-03 Thread via GitHub
YongGang commented on code in PR #16025: URL: https://github.com/apache/druid/pull/16025#discussion_r1510388205 ## server/src/main/java/org/apache/druid/server/metrics/MetricsModule.java: ## @@ -210,4 +210,11 @@ public OshiSysMonitor getOshiSysMonitor(DataSourceTaskIdHolder dat

Re: [PR] gRPC query extension (druid)

2024-03-03 Thread via GitHub
github-advanced-security[bot] commented on code in PR #15982: URL: https://github.com/apache/druid/pull/15982#discussion_r1510239824 ## extensions-contrib/grpc-query/src/test/java/org/apache/druid/grpc/GrpcQueryTestClient.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache