Re: [I] supervisor endpoint not respecting frontCoded indexSpec formatVersion (druid)

2024-06-06 Thread via GitHub
gargvishesh commented on issue #16257: URL: https://github.com/apache/druid/issues/16257#issuecomment-2154160081 I wasn't able to reproduce this issue. Hope the `indexSpec` was being submitted as part of the `tuningConfig` as detailed at the [Supervisor API](https://druid.apache.org/docs/la

(druid) branch master updated (e9f723344b3 -> 03a38be4464)

2024-06-06 Thread karan
This is an automated email from the ASF dual-hosted git repository. karan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git from e9f723344b3 Disable event hubs when kafka extensions isn't loaded (#16559) add 03a38be4464 Optimize S3 storage wri

Re: [PR] Optimize S3 storage writing for MSQ durable storage (druid)

2024-06-06 Thread via GitHub
cryptoe commented on code in PR #16481: URL: https://github.com/apache/druid/pull/16481#discussion_r1621695546 ## extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/output/RetryableS3OutputStream.java: ## @@ -166,13 +176,25 @@ public void write(byte[] b, int

Re: [PR] Optimize S3 storage writing for MSQ durable storage (druid)

2024-06-06 Thread via GitHub
cryptoe merged PR #16481: URL: https://github.com/apache/druid/pull/16481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apac

[PR] Fix complex columns with export (druid)

2024-06-06 Thread via GitHub
adarshsanjeev opened a new pull request, #16572: URL: https://github.com/apache/druid/pull/16572 This PR fixes a few bugs with MSQ export. - Fixes printing of complex columns during export, included sketches and JSON. - Fixes an NPE if the writer has not been initialized Uni

Re: [I] [DRAFT] 30.0.0 release notes (druid)

2024-06-06 Thread via GitHub
adarshsanjeev commented on issue #16505: URL: https://github.com/apache/druid/issues/16505#issuecomment-2154078475 @acherla Thanks for testing the RC. These seem to be valid regressions, and should be fixed by https://github.com/apache/druid/pull/16571. Once it is backported, I will cre

Re: [PR] Optimise indexer resource usage based on CPU profile (druid)

2024-06-06 Thread via GitHub
saithal-confluent commented on code in PR #16517: URL: https://github.com/apache/druid/pull/16517#discussion_r1630658620 ## processing/src/main/java/org/apache/druid/segment/StringDimensionIndexer.java: ## @@ -132,12 +142,14 @@ public EncodedKeyComponent processRowValsToUnsorte

(druid-website) branch asf-staging updated (56885ebc6 -> d25fc2f65)

2024-06-06 Thread lakshsingla
This is an automated email from the ASF dual-hosted git repository. lakshsingla pushed a change to branch asf-staging in repository https://gitbox.apache.org/repos/asf/druid-website.git from 56885ebc6 Merge pull request #276 from adarshsanjeev/30.0.0-rc2-docs add 40317bf03 Update site f

(druid-website) 01/01: Merge pull request #277 from adarshsanjeev/30.0.0-rc3-docs

2024-06-06 Thread lakshsingla
This is an automated email from the ASF dual-hosted git repository. lakshsingla pushed a commit to branch asf-staging in repository https://gitbox.apache.org/repos/asf/druid-website.git commit d25fc2f65a61aa2bddccb137f31e370042e441b5 Merge: 56885ebc6 40317bf03 Author: Laksh Singla AuthorDate: Fr

Re: [PR] Update site for Druid 30 [druid-website]

2024-06-06 Thread via GitHub
LakshSingla merged PR #277: URL: https://github.com/apache/druid-website/pull/277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dr

Re: [PR] docs: Migration guide for MVDs to arrays (druid)

2024-06-06 Thread via GitHub
clintropolis commented on code in PR #16516: URL: https://github.com/apache/druid/pull/16516#discussion_r1630539993 ## docs/release-info/migr-mvd-array.md: ## @@ -0,0 +1,135 @@ +--- +id: migr-mvd-array +title: "Migration guide: MVDs to arrays" +sidebar_label: MVDs to arrays +---

Re: [PR] docs: Migration guide for MVDs to arrays (druid)

2024-06-06 Thread via GitHub
vtlim commented on code in PR #16516: URL: https://github.com/apache/druid/pull/16516#discussion_r1630526594 ## docs/release-info/migr-mvd-array.md: ## @@ -0,0 +1,135 @@ +--- +id: migr-mvd-array +title: "Migration guide: MVDs to arrays" +sidebar_label: MVDs to arrays +--- + + +

Re: [PR] docs: Migration guide for MVDs to arrays (druid)

2024-06-06 Thread via GitHub
vtlim commented on code in PR #16516: URL: https://github.com/apache/druid/pull/16516#discussion_r1630523803 ## docs/release-info/migr-mvd-array.md: ## @@ -0,0 +1,135 @@ +--- +id: migr-mvd-array +title: "Migration guide: MVDs to arrays" +sidebar_label: MVDs to arrays +--- + + +

Re: [PR] docs: Migration guide for MVDs to arrays (druid)

2024-06-06 Thread via GitHub
vtlim commented on code in PR #16516: URL: https://github.com/apache/druid/pull/16516#discussion_r1630523148 ## docs/release-info/migr-mvd-array.md: ## @@ -0,0 +1,135 @@ +--- +id: migr-mvd-array +title: "Migration guide: MVDs to arrays" +sidebar_label: MVDs to arrays +--- + + +

Re: [PR] docs: Migration guide for MVDs to arrays (druid)

2024-06-06 Thread via GitHub
vtlim commented on code in PR #16516: URL: https://github.com/apache/druid/pull/16516#discussion_r1630514874 ## docs/release-info/migr-mvd-array.md: ## @@ -0,0 +1,135 @@ +--- +id: migr-mvd-array +title: "Migration guide: MVDs to arrays" +sidebar_label: MVDs to arrays +--- + + +

Re: [PR] docs: Migration guide for MVDs to arrays (druid)

2024-06-06 Thread via GitHub
vtlim commented on code in PR #16516: URL: https://github.com/apache/druid/pull/16516#discussion_r1630505605 ## docs/release-info/migr-mvd-array.md: ## @@ -0,0 +1,135 @@ +--- +id: migr-mvd-array +title: "Migration guide: MVDs to arrays" +sidebar_label: MVDs to arrays +--- + + +

Re: [PR] docs: Migration guide for MVDs to arrays (druid)

2024-06-06 Thread via GitHub
vtlim commented on code in PR #16516: URL: https://github.com/apache/druid/pull/16516#discussion_r1630458114 ## docs/release-info/migr-mvd-array.md: ## @@ -0,0 +1,135 @@ +--- +id: migr-mvd-array +title: "Migration guide: MVDs to arrays" +sidebar_label: MVDs to arrays +--- + + +

Re: [PR] docs: Migration guide for MVDs to arrays (druid)

2024-06-06 Thread via GitHub
clintropolis commented on code in PR #16516: URL: https://github.com/apache/druid/pull/16516#discussion_r1630428345 ## docs/release-info/migr-mvd-array.md: ## @@ -0,0 +1,135 @@ +--- +id: migr-mvd-array +title: "Migration guide: MVDs to arrays" +sidebar_label: MVDs to arrays +---

Re: [I] Add apache pulsar based indexing service (druid)

2024-06-06 Thread via GitHub
github-actions[bot] commented on issue #7030: URL: https://github.com/apache/druid/issues/7030#issuecomment-2153619300 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time. --

Re: [I] Add apache pulsar based indexing service (druid)

2024-06-06 Thread via GitHub
github-actions[bot] closed issue #7030: Add apache pulsar based indexing service URL: https://github.com/apache/druid/issues/7030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] docs: Migration guide for MVDs to arrays (druid)

2024-06-06 Thread via GitHub
2bethere commented on code in PR #16516: URL: https://github.com/apache/druid/pull/16516#discussion_r1630433845 ## docs/release-info/migr-mvd-array.md: ## @@ -0,0 +1,135 @@ +--- +id: migr-mvd-array +title: "Migration guide: MVDs to arrays" +sidebar_label: MVDs to arrays +--- + +

Re: [PR] docs: Migration guide for MVDs to arrays (druid)

2024-06-06 Thread via GitHub
2bethere commented on code in PR #16516: URL: https://github.com/apache/druid/pull/16516#discussion_r1630431512 ## docs/release-info/migr-mvd-array.md: ## @@ -0,0 +1,135 @@ +--- +id: migr-mvd-array +title: "Migration guide: MVDs to arrays" +sidebar_label: MVDs to arrays +--- + +

(druid) branch master updated: Disable event hubs when kafka extensions isn't loaded (#16559)

2024-06-06 Thread abhishekrb
This is an automated email from the ASF dual-hosted git repository. abhishekrb pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new e9f723344b3 Disable event hubs when kafka ext

Re: [PR] Disable event hubs when kafka extensions isn't loaded (druid)

2024-06-06 Thread via GitHub
abhishekrb19 merged PR #16559: URL: https://github.com/apache/druid/pull/16559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid

Re: [I] Azure Events Hub tile is enabled when Kafka extension is not loaded (druid)

2024-06-06 Thread via GitHub
abhishekrb19 closed issue #10342: Azure Events Hub tile is enabled when Kafka extension is not loaded URL: https://github.com/apache/druid/issues/10342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [I] [DRAFT] 30.0.0 release notes (druid)

2024-06-06 Thread via GitHub
acherla commented on issue #16505: URL: https://github.com/apache/druid/issues/16505#issuecomment-2153447444 Testing 30.0.0-rc3 there are a number of bugs im noticing, 1. Seems like the "supervisors" UI tab doesnt have a way to paginate the running supervisors anymore that was available

Re: [PR] Support Dynamic Peon Pod Template Selection in K8s extension (druid)

2024-06-06 Thread via GitHub
YongGang commented on PR #16510: URL: https://github.com/apache/druid/pull/16510#issuecomment-2153326191 > -1 on this change because I do not understand the use of the new interfaces. It seems like what we want here is a config that is scoped to the pod template adapter, but this PR introdu

Re: [PR] docs: Migration guide for MVDs to arrays (druid)

2024-06-06 Thread via GitHub
vtlim commented on code in PR #16516: URL: https://github.com/apache/druid/pull/16516#discussion_r1630030691 ## docs/release-info/migr-mvd-array.md: ## @@ -0,0 +1,135 @@ +--- +id: migr-mvd-array +title: "Migration guide: MVDs to arrays" +sidebar_label: MVDs to arrays +--- + + +

[PR] Update site for Druid 30 [druid-website]

2024-06-06 Thread via GitHub
adarshsanjeev opened a new pull request, #277: URL: https://github.com/apache/druid-website/pull/277 Update 30.0.0 staging site -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[PR] docs: remove outdated druidversion var from a page (druid)

2024-06-06 Thread via GitHub
317brian opened a new pull request, #16570: URL: https://github.com/apache/druid/pull/16570 The `{{DRUIDVERSION}}` bits on this page were added awhile ago: Line 368: last year (26.0.0) Line 434: 4 years ago I think they should have been hardcoded at the time since the stateme

Re: [PR] Support Dynamic Peon Pod Template Selection in K8s extension (druid)

2024-06-06 Thread via GitHub
suneet-s commented on code in PR #16510: URL: https://github.com/apache/druid/pull/16510#discussion_r1630003561 ## extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/execution/ExecutionConfig.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed t

Re: [PR] Support Dynamic Peon Pod Template Selection in K8s extension (druid)

2024-06-06 Thread via GitHub
suneet-s commented on code in PR #16510: URL: https://github.com/apache/druid/pull/16510#discussion_r1630003561 ## extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/execution/ExecutionConfig.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed t

[PR] Update site for Druid 30 [druid-website-src]

2024-06-06 Thread via GitHub
adarshsanjeev opened a new pull request, #479: URL: https://github.com/apache/druid-website-src/pull/479 Update 30.0.0 staging site -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Add site for Druid 30 [druid-website-src]

2024-06-06 Thread via GitHub
adarshsanjeev closed pull request #478: Add site for Druid 30 URL: https://github.com/apache/druid-website-src/pull/478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

svn commit: r69571 - /dev/druid/30.0.0-rc3/

2024-06-06 Thread adarshsanjeev
Author: adarshsanjeev Date: Thu Jun 6 17:47:10 2024 New Revision: 69571 Log: Add 30.0.0-rc3 artifacts Added: dev/druid/30.0.0-rc3/ dev/druid/30.0.0-rc3/apache-druid-30.0.0-bin.tar.gz (with props) dev/druid/30.0.0-rc3/apache-druid-30.0.0-bin.tar.gz.asc dev/druid/30.0.0-rc3/apach

Re: [I] Bring Azure functionality to core functionality (druid)

2024-06-06 Thread via GitHub
zachjsh closed issue #9240: Bring Azure functionality to core functionality URL: https://github.com/apache/druid/issues/9240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] Bring Azure functionality to core functionality (druid)

2024-06-06 Thread via GitHub
zachjsh commented on issue #9240: URL: https://github.com/apache/druid/issues/9240#issuecomment-2153081065 This work was done in https://github.com/apache/druid/pull/9394, and previous commits that improved quality to this extension. Closing this out. -- This is an automated message from

(druid) annotated tag druid-30.0.0-rc3 updated (33b093408bc -> 28cdd5979fb)

2024-06-06 Thread adarshsanjeev
This is an automated email from the ASF dual-hosted git repository. adarshsanjeev pushed a change to annotated tag druid-30.0.0-rc3 in repository https://gitbox.apache.org/repos/asf/druid.git *** WARNING: tag druid-30.0.0-rc3 was modified! *** from 33b093408bc (commit) to 28cdd5979fb

Re: [PR] Move Azure extension into Core (druid)

2024-06-06 Thread via GitHub
amaechler commented on PR #9394: URL: https://github.com/apache/druid/pull/9394#issuecomment-2152892043 Closes #9240. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] Optimize S3 storage writing for MSQ durable storage (druid)

2024-06-06 Thread via GitHub
kfaraz commented on PR #16481: URL: https://github.com/apache/druid/pull/16481#issuecomment-2152891872 Happy to help, @Akshat-Jain ! 🙂 Thank you for the changes and for the discussion! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

(druid) branch 30.0.0 updated: [Backport] Fix backwards compatibility with centralized schema config in partial_index_merge tasks (#16566)

2024-06-06 Thread karan
This is an automated email from the ASF dual-hosted git repository. karan pushed a commit to branch 30.0.0 in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/30.0.0 by this push: new fb86ada253d [Backport] Fix backwards compatibility

Re: [PR] [Backport] Fix backwards compatibility with centralized schema config in partial_index_merge tasks (druid)

2024-06-06 Thread via GitHub
cryptoe merged PR #16566: URL: https://github.com/apache/druid/pull/16566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apac

Re: [PR] Pin Curator dependencies to 5.3.0 util CURATOR-696 has been resolved (druid)

2024-06-06 Thread via GitHub
cryptoe closed pull request #16444: Pin Curator dependencies to 5.3.0 util CURATOR-696 has been resolved URL: https://github.com/apache/druid/pull/16444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Pin Curator dependencies to 5.3.0 util CURATOR-696 has been resolved (druid)

2024-06-06 Thread via GitHub
cryptoe commented on PR #16444: URL: https://github.com/apache/druid/pull/16444#issuecomment-2152787612 Since we are already on the path for : https://github.com/apache/druid/pull/16528 closing this ticke.t -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] Optimize S3 storage writing for MSQ durable storage (druid)

2024-06-06 Thread via GitHub
Akshat-Jain commented on code in PR #16481: URL: https://github.com/apache/druid/pull/16481#discussion_r1629670678 ## extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/output/S3UploadManager.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software

Re: [PR] Optimize S3 storage writing for MSQ durable storage (druid)

2024-06-06 Thread via GitHub
Akshat-Jain commented on PR #16481: URL: https://github.com/apache/druid/pull/16481#issuecomment-2152681440 @kfaraz Thank you for the extremely exhaustive review comments, got to learn a LOT from them throughout this PR! 😄 -- This is an automated message from the Apache Git Service. To r

Re: [I] [DRAFT] 30.0.0 release notes (druid)

2024-06-06 Thread via GitHub
adarshsanjeev commented on issue #16505: URL: https://github.com/apache/druid/issues/16505#issuecomment-2152675032 @frankgrimes97 Currently, Druid 30 is at a stage where only regressions can be backported. -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] Remove incorrect utf8 conversion of ResultCache keys (druid)

2024-06-06 Thread via GitHub
github-advanced-security[bot] commented on code in PR #16569: URL: https://github.com/apache/druid/pull/16569#discussion_r1629654479 ## server/src/test/java/org/apache/druid/client/cache/CaffeineCacheTest.java: ## @@ -65,6 +69,16 @@ cache = CaffeineCache.create(cacheConfig)

Re: [I] /v2 and /v2/candidates endpoints not respecting broker partition pruning - range partition (druid)

2024-06-06 Thread via GitHub
ColeAtCharter commented on issue #16222: URL: https://github.com/apache/druid/issues/16222#issuecomment-2152602070 @gianm -- thanks for looking at this. I do think "Unexpected result example 1: /druid/v2 endpoint" should never happen if broker partition pruning is working. Druid returned

[PR] Remove incorrect utf8 conversion of ResultCache keys (druid)

2024-06-06 Thread via GitHub
kgyrtkirk opened a new pull request, #16569: URL: https://github.com/apache/druid/pull/16569 * remove the incorrect call to read the byte[] as utf8 * not sure about its origin - but this will push the contract for `Cache` implementations to handle the `byte[]` in `NamedKey` - its already

Re: [PR] Optimize S3 storage writing for MSQ durable storage (druid)

2024-06-06 Thread via GitHub
kfaraz commented on code in PR #16481: URL: https://github.com/apache/druid/pull/16481#discussion_r1629424508 ## extensions-core/s3-extensions/src/test/java/org/apache/druid/storage/s3/output/S3UploadManagerTest.java: ## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software

Re: [PR] Optimize S3 storage writing for MSQ durable storage (druid)

2024-06-06 Thread via GitHub
kfaraz commented on code in PR #16481: URL: https://github.com/apache/druid/pull/16481#discussion_r1629419675 ## extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/output/S3UploadManager.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Foun

[PR] Update pac4j version (druid)

2024-06-06 Thread via GitHub
pagrawal10 opened a new pull request, #16567: URL: https://github.com/apache/druid/pull/16567 Fixes #. ### Description Fixed the bug ... Renamed the class ... Added a forbidden-apis entry ...

Re: [PR] Optimize S3 storage writing for MSQ durable storage (druid)

2024-06-06 Thread via GitHub
Akshat-Jain commented on code in PR #16481: URL: https://github.com/apache/druid/pull/16481#discussion_r1629278464 ## extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/output/S3UploadManager.java: ## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software

[PR] [Backport] Fix backwards compatibility with centralized schema config in partial_index_merge tasks (druid)

2024-06-06 Thread via GitHub
findingrish opened a new pull request, #16566: URL: https://github.com/apache/druid/pull/16566 Backports https://github.com/apache/druid/pull/16556 & https://github.com/apache/druid/pull/16565 to Druid30. -- This is an automated message from the Apache Git Service. To respond to the messa

(druid) branch master updated: Revert log line to debug (#16565)

2024-06-06 Thread karan
This is an automated email from the ASF dual-hosted git repository. karan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 423c91f9e4d Revert log line to debug (#16565) 423c

Re: [PR] Log segment signature in AbstractSegmentMetadataCache at debug level (druid)

2024-06-06 Thread via GitHub
cryptoe merged PR #16565: URL: https://github.com/apache/druid/pull/16565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apac

[PR] Log segment signature in AbstractSegmentMetadataCache at debug level (druid)

2024-06-06 Thread via GitHub
findingrish opened a new pull request, #16565: URL: https://github.com/apache/druid/pull/16565 Logging signature for each segment could result in extensive logging, hence changing the log level to debug. -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [I] Broker OOM Error During SQL Execution. (druid)

2024-06-06 Thread via GitHub
lijie749808 closed issue #15343: Broker OOM Error During SQL Execution. URL: https://github.com/apache/druid/issues/15343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

(druid) branch master updated (277006446d7 -> e4f59e00b2b)

2024-06-06 Thread karan
This is an automated email from the ASF dual-hosted git repository. karan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git from 277006446d7 Fallback vectorization for FunctionExpr and BaseMacroFunctionExpr. (#16366) add e4f59e00b2b Fix backwa

Re: [PR] Fix backwards compatibility with centralized schema config in partial_index_merge tasks (druid)

2024-06-06 Thread via GitHub
cryptoe merged PR #16556: URL: https://github.com/apache/druid/pull/16556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apac

Re: [PR] Add IncrementalIndex test (druid)

2024-06-06 Thread via GitHub
kgyrtkirk commented on code in PR #16562: URL: https://github.com/apache/druid/pull/16562#discussion_r1628970678 ## extensions-contrib/spectator-histogram/src/test/java/org/apache/druid/spectator/histogram/SpectatorHistogramAggregatorTest.java: ## @@ -365,6 +383,60 @@ public voi