[GitHub] [druid] FrankChen021 commented on pull request #9898: support Aliyun OSS service as deep storage

2020-06-28 Thread GitBox
FrankChen021 commented on pull request #9898: URL: https://github.com/apache/druid/pull/9898#issuecomment-650723821 @asdf2014 It's done. Thank you for your instruction. This is an automated message from the Apache Git

[GitHub] [druid] FrankChen021 commented on pull request #9898: support Aliyun OSS service as deep storage

2020-06-28 Thread GitBox
FrankChen021 commented on pull request #9898: URL: https://github.com/apache/druid/pull/9898#issuecomment-650705280 Hi @jihoonson , CI excludes all other deep storage IT testcases through following property. I didn't found where this property is defined in project. Is it configured in CI

[GitHub] [druid] FrankChen021 commented on pull request #9898: support Aliyun OSS service as deep storage

2020-06-27 Thread GitBox
FrankChen021 commented on pull request #9898: URL: https://github.com/apache/druid/pull/9898#issuecomment-650678797 @jihoonson OK, I'll fix the doc. And for the IT test case, it seems like `BUCKET` and `PATH` are not configured. In my environment, I put these two parameters and

[GitHub] [druid] FrankChen021 commented on pull request #9898: support Aliyun OSS service as deep storage

2020-06-27 Thread GitBox
FrankChen021 commented on pull request #9898: URL: https://github.com/apache/druid/pull/9898#issuecomment-650667153 @jon-wei I agree with you This is an automated message from the Apache Git Service. To respond to the

[GitHub] [druid] FrankChen021 commented on pull request #9898: support Aliyun OSS service as deep storage

2020-06-27 Thread GitBox
FrankChen021 commented on pull request #9898: URL: https://github.com/apache/druid/pull/9898#issuecomment-650663610 Hi @jihoonson , using s3 extension with OSS, the exception is as below I think OSS was compatible at the time the doc was created, but as the s3 SDK evolves, OSS

[GitHub] [druid] FrankChen021 commented on pull request #9898: support Aliyun OSS service as deep storage

2020-06-27 Thread GitBox
FrankChen021 commented on pull request #9898: URL: https://github.com/apache/druid/pull/9898#issuecomment-650562183 Hi @jihoonson , s3 extension does not work with aliyun OSS although OSS provides compatibility with s3. I tested to utilize OSS with s3 extension in the past, but the

[GitHub] [druid] FrankChen021 commented on pull request #9898: support Aliyun OSS service as deep storage

2020-06-25 Thread GitBox
FrankChen021 commented on pull request #9898: URL: https://github.com/apache/druid/pull/9898#issuecomment-649602917 Hi @jon-wei , I've updated the code, and re-tested all core functions. IT testcases runs OK, and real time ingestion task, compact task, kill task runs well in our test

[GitHub] [druid] FrankChen021 commented on pull request #9898: support Aliyun OSS service as deep storage

2020-06-22 Thread GitBox
FrankChen021 commented on pull request #9898: URL: https://github.com/apache/druid/pull/9898#issuecomment-647895605 Hi @jon-wei @fjy Thank you for your opinions. I'm busy these days, and I will fix the code this week. This

[GitHub] [druid] FrankChen021 commented on pull request #9898: support Aliyun OSS service as deep storage

2020-06-10 Thread GitBox
FrankChen021 commented on pull request #9898: URL: https://github.com/apache/druid/pull/9898#issuecomment-642413836 > > CI reports insufficient unit test line/function/branch coverage. Is it mandatory to meet that requirement ? > > Given the nature of the extension, I feel like

[GitHub] [druid] FrankChen021 commented on pull request #9898: support Aliyun OSS service as deep storage

2020-05-26 Thread GitBox
FrankChen021 commented on pull request #9898: URL: https://github.com/apache/druid/pull/9898#issuecomment-634001052 @clintropolis CI reports insufficient unit test line/function/branch coverage. Is it mandatory to meet that requirement ?