[GitHub] [druid] abhishekagarwal87 commented on pull request #10635: Add SQL functions to format numbers into human readable format

2021-06-29 Thread GitBox
abhishekagarwal87 commented on pull request #10635: URL: https://github.com/apache/druid/pull/10635#issuecomment-870351762 @FrankChen021 Just one minor comment on the doc. Rest looks good to me. Thank you for your patience. -- This is an automated message from the Apache Git Service. To

[GitHub] [druid] abhishekagarwal87 commented on pull request #10635: Add SQL functions to format numbers into human readable format

2021-06-29 Thread GitBox
abhishekagarwal87 commented on pull request #10635: URL: https://github.com/apache/druid/pull/10635#issuecomment-870351762 @FrankChen021 Just one minor comment on the doc. Rest looks good to me. Thank you for your patience. -- This is an automated message from the Apache Git Service. To

[GitHub] [druid] abhishekagarwal87 commented on pull request #10635: Add SQL functions to format numbers into human readable format

2021-01-09 Thread GitBox
abhishekagarwal87 commented on pull request #10635: URL: https://github.com/apache/druid/pull/10635#issuecomment-757354535 I, for one, don't have a strong opinion. `decimal_format` here is equivalent to https://docs.oracle.com/en/java/javase/14/docs/api/java.base/java/text/CompactNumberFor

[GitHub] [druid] abhishekagarwal87 commented on pull request #10635: Add SQL functions to format numbers into human readable format

2021-01-09 Thread GitBox
abhishekagarwal87 commented on pull request #10635: URL: https://github.com/apache/druid/pull/10635#issuecomment-757354535 I, for one, don't have a strong opinion. `decimal_format` here is equivalent to https://docs.oracle.com/en/java/javase/14/docs/api/java.base/java/text/CompactNumberFor