[GitHub] [druid] abhishekagarwal87 commented on pull request #13747: helm: Add serviceAccounts, rbac, and small fixes

2023-02-22 Thread via GitHub
abhishekagarwal87 commented on PR #13747: URL: https://github.com/apache/druid/pull/13747#issuecomment-1441257378 thanks @jwitko. Thats an unrelated failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [druid] abhishekagarwal87 commented on pull request #13747: helm: Add serviceAccounts, rbac, and small fixes

2023-02-22 Thread via GitHub
abhishekagarwal87 commented on PR #13747: URL: https://github.com/apache/druid/pull/13747#issuecomment-1440358973 @jwitko - can you fix the static checks failures? LGTM otherwise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [druid] abhishekagarwal87 commented on pull request #13747: helm: Add serviceAccounts, rbac, and small fixes

2023-02-08 Thread via GitHub
abhishekagarwal87 commented on PR #13747: URL: https://github.com/apache/druid/pull/13747#issuecomment-1422713735 Thank you. I see that by default, helm charts are now going to create service accounts per service. so can we keep the default off in top-level `values.yaml` -- This is an a

[GitHub] [druid] abhishekagarwal87 commented on pull request #13747: helm: Add serviceAccounts, rbac, and small fixes

2023-02-07 Thread via GitHub
abhishekagarwal87 commented on PR #13747: URL: https://github.com/apache/druid/pull/13747#issuecomment-1422082044 can you elaborate a bit more on "Enabling per-service serviceAccounts allows for finer grained RBAC"? Maybe take us through an example use-case that you want to implement on you