[GitHub] [druid] ccaominh commented on pull request #10033: Allow append to existing datasources when dynamic partitioning is used

2020-06-25 Thread GitBox
ccaominh commented on pull request #10033: URL: https://github.com/apache/druid/pull/10033#issuecomment-649750336 Looking at the code coverage issue a bit more: All the ShardSpecs live in `core`: ``` find . -name "*ShardSpec.java"

[GitHub] [druid] ccaominh commented on pull request #10033: Allow append to existing datasources when dynamic partitioning is used

2020-06-25 Thread GitBox
ccaominh commented on pull request #10033: URL: https://github.com/apache/druid/pull/10033#issuecomment-649737980 > ``` > 133 F default boolean sharePartitionSpace(PartialShardSpec partialShardSpec) > 134 F { > 135 F | L | B(0/2)return