[GitHub] [druid] clintropolis commented on a change in pull request #10605: bitwise math function expressions

2021-01-20 Thread GitBox
clintropolis commented on a change in pull request #10605: URL: https://github.com/apache/druid/pull/10605#discussion_r560935104 ## File path: core/src/main/antlr4/org/apache/druid/math/expr/antlr/Expr.g4 ## @@ -51,9 +51,12 @@ numericElement : (LONG | DOUBLE | NULL);

[GitHub] [druid] clintropolis commented on a change in pull request #10605: bitwise math function expressions

2021-01-20 Thread GitBox
clintropolis commented on a change in pull request #10605: URL: https://github.com/apache/druid/pull/10605#discussion_r560934713 ## File path: docs/misc/math-expr.md ## @@ -119,13 +119,14 @@ See javadoc of java.lang.Math for detailed explanation for each function.

[GitHub] [druid] clintropolis commented on a change in pull request #10605: bitwise math function expressions

2021-01-12 Thread GitBox
clintropolis commented on a change in pull request #10605: URL: https://github.com/apache/druid/pull/10605#discussion_r556267351 ## File path: docs/misc/math-expr.md ## @@ -119,6 +119,13 @@ See javadoc of java.lang.Math for detailed explanation for each function.

[GitHub] [druid] clintropolis commented on a change in pull request #10605: bitwise math function expressions

2021-01-09 Thread GitBox
clintropolis commented on a change in pull request #10605: URL: https://github.com/apache/druid/pull/10605#discussion_r553810003 ## File path: core/src/main/java/org/apache/druid/math/expr/Evals.java ## @@ -71,4 +71,14 @@ public static boolean asBoolean(@Nullable String x)

[GitHub] [druid] clintropolis commented on a change in pull request #10605: bitwise math function expressions

2021-01-08 Thread GitBox
clintropolis commented on a change in pull request #10605: URL: https://github.com/apache/druid/pull/10605#discussion_r554206473 ## File path: docs/misc/math-expr.md ## @@ -119,6 +119,13 @@ See javadoc of java.lang.Math for detailed explanation for each function.

[GitHub] [druid] clintropolis commented on a change in pull request #10605: bitwise math function expressions

2021-01-08 Thread GitBox
clintropolis commented on a change in pull request #10605: URL: https://github.com/apache/druid/pull/10605#discussion_r553811715 ## File path: core/src/test/java/org/apache/druid/math/expr/FunctionTest.java ## @@ -519,6 +519,31 @@ public void testLeast()

[GitHub] [druid] clintropolis commented on a change in pull request #10605: bitwise math function expressions

2021-01-08 Thread GitBox
clintropolis commented on a change in pull request #10605: URL: https://github.com/apache/druid/pull/10605#discussion_r553810857 ## File path: docs/misc/math-expr.md ## @@ -119,6 +119,13 @@ See javadoc of java.lang.Math for detailed explanation for each function.

[GitHub] [druid] clintropolis commented on a change in pull request #10605: bitwise math function expressions

2021-01-08 Thread GitBox
clintropolis commented on a change in pull request #10605: URL: https://github.com/apache/druid/pull/10605#discussion_r553810678 ## File path: docs/misc/math-expr.md ## @@ -119,6 +119,13 @@ See javadoc of java.lang.Math for detailed explanation for each function.

[GitHub] [druid] clintropolis commented on a change in pull request #10605: bitwise math function expressions

2021-01-08 Thread GitBox
clintropolis commented on a change in pull request #10605: URL: https://github.com/apache/druid/pull/10605#discussion_r553810003 ## File path: core/src/main/java/org/apache/druid/math/expr/Evals.java ## @@ -71,4 +71,14 @@ public static boolean asBoolean(@Nullable String x)