[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r58743 ## File path: processing/src/main/java/org/apache/druid/query/filter/DruidPredicateFactory.java ## @@ -32,4 +32,15 @@ DruidFloatPredicate makeFlo

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r587431712 ## File path: processing/src/main/java/org/apache/druid/segment/vector/VectorColumnSelectorFactory.java ## @@ -62,16 +66,29 @@ default int getMaxVec

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r587431424 ## File path: processing/src/main/java/org/apache/druid/segment/column/ColumnCapabilitiesImpl.java ## @@ -177,6 +177,21 @@ public static ColumnCapab

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r587431276 ## File path: processing/src/main/java/org/apache/druid/query/dimension/DimensionSpec.java ## @@ -70,6 +71,11 @@ default MultiValueDimensionVectorSe

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r584199144 ## File path: processing/src/main/java/org/apache/druid/query/dimension/DimensionSpec.java ## @@ -70,6 +71,11 @@ default MultiValueDimensionVectorSe

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r579010273 ## File path: core/src/main/java/org/apache/druid/math/expr/IdentifierExpr.java ## @@ -149,13 +150,14 @@ public boolean canVectorize(InputBindingInsp

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r579003843 ## File path: processing/src/main/java/org/apache/druid/segment/filter/ExpressionFilter.java ## @@ -55,6 +69,105 @@ public ExpressionFilter(final Su

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r579003158 ## File path: core/src/main/java/org/apache/druid/math/expr/IdentifierExpr.java ## @@ -149,13 +150,14 @@ public boolean canVectorize(InputBindingInsp

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r578985027 ## File path: processing/src/main/java/org/apache/druid/query/filter/DruidPredicateFactory.java ## @@ -27,6 +27,13 @@ { Predicate makeStringPred

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r578982727 ## File path: core/src/main/java/org/apache/druid/math/expr/BinaryLogicalOperatorExpr.java ## @@ -74,7 +74,7 @@ public ExprType getOutputType(InputB

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r578967958 ## File path: core/src/main/java/org/apache/druid/math/expr/ExprTypeConversion.java ## @@ -20,24 +20,29 @@ package org.apache.druid.math.expr; im

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r578964740 ## File path: processing/src/main/java/org/apache/druid/segment/DimensionHandlerUtils.java ## @@ -305,17 +305,29 @@ private static ColumnCapabilitie

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r578964617 ## File path: processing/src/main/java/org/apache/druid/segment/filter/ExpressionFilter.java ## @@ -55,6 +69,105 @@ public ExpressionFilter(final Su

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r578961978 ## File path: processing/src/main/java/org/apache/druid/segment/filter/ExpressionFilter.java ## @@ -55,6 +69,105 @@ public ExpressionFilter(final Su

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r578961003 ## File path: processing/src/main/java/org/apache/druid/segment/filter/ExpressionFilter.java ## @@ -55,6 +69,105 @@ public ExpressionFilter(final Su

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r578960768 ## File path: processing/src/main/java/org/apache/druid/segment/vector/VectorColumnSelectorFactory.java ## @@ -57,6 +57,15 @@ default int getMaxVect

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r558121651 ## File path: core/src/main/java/org/apache/druid/math/expr/BinaryLogicalOperatorExpr.java ## @@ -74,7 +74,7 @@ public ExprType getOutputType(InputB

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r553814648 ## File path: processing/src/main/java/org/apache/druid/segment/DimensionHandlerUtils.java ## @@ -305,17 +305,29 @@ private static ColumnCapabilitie

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r553847083 ## File path: core/src/main/java/org/apache/druid/math/expr/BinaryLogicalOperatorExpr.java ## @@ -74,7 +74,7 @@ public ExprType getOutputType(InputB

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r553845596 ## File path: processing/src/main/java/org/apache/druid/query/dimension/DimensionSpec.java ## @@ -70,6 +71,11 @@ default MultiValueDimensionVectorSe

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r553840570 ## File path: processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/vector/GroupByVectorColumnProcessorFactory.java ## @@ -64,7 +65,

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r553833318 ## File path: processing/src/main/java/org/apache/druid/query/filter/DruidPredicateFactory.java ## @@ -27,6 +27,13 @@ { Predicate makeStringPred

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r553833052 ## File path: processing/src/main/java/org/apache/druid/query/filter/DruidPredicateFactory.java ## @@ -27,6 +27,13 @@ { Predicate makeStringPred

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r553820619 ## File path: processing/src/main/java/org/apache/druid/segment/vector/VectorColumnSelectorFactory.java ## @@ -57,6 +57,15 @@ default int getMaxVect

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r553818153 ## File path: processing/src/main/java/org/apache/druid/segment/filter/ExpressionFilter.java ## @@ -55,6 +69,105 @@ public ExpressionFilter(final Su

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r553816206 ## File path: processing/src/main/java/org/apache/druid/segment/filter/ExpressionFilter.java ## @@ -55,6 +69,105 @@ public ExpressionFilter(final Su

[GitHub] [druid] clintropolis commented on a change in pull request #10613: expression filter support for vectorized query engines

clintropolis commented on a change in pull request #10613: URL: https://github.com/apache/druid/pull/10613#discussion_r553814648 ## File path: processing/src/main/java/org/apache/druid/segment/DimensionHandlerUtils.java ## @@ -305,17 +305,29 @@ private static ColumnCapabilitie