[GitHub] [druid] dampcake commented on a diff in pull request #13747: helm: Add serviceAccounts, rbac, and small fixes

2023-02-10 Thread via GitHub
dampcake commented on code in PR #13747: URL: https://github.com/apache/druid/pull/13747#discussion_r1103435989 ## helm/druid/templates/broker/role.yaml: ## @@ -0,0 +1,21 @@ +{{- if .Values.rbac.create }} +apiVersion: rbac.authorization.k8s.io/v1 +kind: Role +metadata: + name:

[GitHub] [druid] dampcake commented on a diff in pull request #13747: helm: Add serviceAccounts, rbac, and small fixes

2023-02-10 Thread via GitHub
dampcake commented on code in PR #13747: URL: https://github.com/apache/druid/pull/13747#discussion_r1103435620 ## helm/druid/README.md: ## @@ -96,10 +96,16 @@ The following table lists the configurable parameters of the Druid chart and the | `configVars`

[GitHub] [druid] dampcake commented on a diff in pull request #13747: helm: Add serviceAccounts, rbac, and small fixes

2023-02-08 Thread via GitHub
dampcake commented on code in PR #13747: URL: https://github.com/apache/druid/pull/13747#discussion_r1100528686 ## helm/druid/templates/broker/roleBinding.yaml: ## @@ -0,0 +1,20 @@ +{{- if .Values.rbac.create }} Review Comment: Same question about checking enabled for the dr