[GitHub] [druid] gianm commented on issue #10072: Average aggregate does not ignore nulls in long column when druid.generic.useDefaultValueForNull=false

2020-07-01 Thread GitBox
gianm commented on issue #10072: URL: https://github.com/apache/druid/issues/10072#issuecomment-652550179 It's possible both cases (nullable and non-nullable) would be covered by existing tests, but if not, please add enough tests to cover both to CalciteQueryTest. --

[GitHub] [druid] gianm commented on issue #10072: Average aggregate does not ignore nulls in long column when druid.generic.useDefaultValueForNull=false

2020-07-01 Thread GitBox
gianm commented on issue #10072: URL: https://github.com/apache/druid/issues/10072#issuecomment-652548762 Hi @damnMeddlingKid, Looks like this is a bug and you got the right fix. The logic is similar to what's in CountSqlAggregator already, so I'd suggest extracting it to a helper f