jihoonson commented on a change in pull request #9698: fixes for inline
subqueries when multi-value dimension is present
URL: https://github.com/apache/druid/pull/9698#discussion_r410507374
##########
File path:
processing/src/main/java/org/apache/druid/query/topn/TopNQueryEngine.java
##########
@@ -132,7 +132,7 @@ private TopNMapFn getMapFn(
topNAlgorithm = new TimeExtractionTopNAlgorithm(adapter, query);
} else if (selector.isHasExtractionFn()) {
topNAlgorithm = new HeapBasedTopNAlgorithm(adapter, query);
- } else if (columnCapabilities != null && !(columnCapabilities.getType() ==
ValueType.STRING
+ } else if (columnCapabilities == null || !(columnCapabilities.getType() ==
ValueType.STRING
Review comment:
nit: maybe nice to comment when `columnCapabilities` can be null?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
