[GitHub] [druid] jihoonson commented on pull request #10082: Fix RetryQueryRunner to actually do the job

2020-07-01 Thread GitBox
jihoonson commented on pull request #10082: URL: https://github.com/apache/druid/pull/10082#issuecomment-652645612 @gianm @clintropolis thank you for the review. I'll address @gianm's last comments in follow-ups. This is an

[GitHub] [druid] jihoonson commented on pull request #10082: Fix RetryQueryRunner to actually do the job

2020-07-01 Thread GitBox
jihoonson commented on pull request #10082: URL: https://github.com/apache/druid/pull/10082#issuecomment-652572586 @gianm thanks for the review. As Travis is extremely slow recently, I'd like to address your last comments in a follow-up with doc for the known issue with response context no

[GitHub] [druid] jihoonson commented on pull request #10082: Fix RetryQueryRunner to actually do the job

2020-06-30 Thread GitBox
jihoonson commented on pull request #10082: URL: https://github.com/apache/druid/pull/10082#issuecomment-652097170 The test coverage check now complains about these classes: ``` -- | lines |

[GitHub] [druid] jihoonson commented on pull request #10082: Fix RetryQueryRunner to actually do the job

2020-06-29 Thread GitBox
jihoonson commented on pull request #10082: URL: https://github.com/apache/druid/pull/10082#issuecomment-651465790 BTW, I'm not sure whether or not our tests test `CachingClusteredClient` in the following cases, so tested them manually. - With/without broker cache - With/without r