[GitHub] [druid] jwitko commented on a diff in pull request #13747: helm: Add serviceAccounts, rbac, and small fixes

2023-02-14 Thread via GitHub
jwitko commented on code in PR #13747: URL: https://github.com/apache/druid/pull/13747#discussion_r1106720148 ## helm/druid/README.md: ## @@ -199,6 +225,11 @@ The following table lists the configurable parameters of the Druid chart and the | `router.replicaCount`

[GitHub] [druid] jwitko commented on a diff in pull request #13747: helm: Add serviceAccounts, rbac, and small fixes

2023-02-14 Thread via GitHub
jwitko commented on code in PR #13747: URL: https://github.com/apache/druid/pull/13747#discussion_r1106689531 ## helm/druid/templates/historical/roleBinding.yaml: ## @@ -0,0 +1,20 @@ +{{- if and (.Values.rbac.create) (.Values.historical.enabled) }} +apiVersion: rbac.authorizatio

[GitHub] [druid] jwitko commented on a diff in pull request #13747: helm: Add serviceAccounts, rbac, and small fixes

2023-02-14 Thread via GitHub
jwitko commented on code in PR #13747: URL: https://github.com/apache/druid/pull/13747#discussion_r1106685564 ## helm/druid/README.md: ## @@ -199,6 +225,11 @@ The following table lists the configurable parameters of the Druid chart and the | `router.replicaCount`

[GitHub] [druid] jwitko commented on a diff in pull request #13747: helm: Add serviceAccounts, rbac, and small fixes

2023-02-14 Thread via GitHub
jwitko commented on code in PR #13747: URL: https://github.com/apache/druid/pull/13747#discussion_r1106323308 ## helm/druid/values.yaml: ## @@ -193,7 +233,7 @@ historical: druid_processing_numMergeBuffers: 2 druid_processing_numThreads: 1 # druid_monitoring_monito

[GitHub] [druid] jwitko commented on a diff in pull request #13747: helm: Add serviceAccounts, rbac, and small fixes

2023-02-11 Thread via GitHub
jwitko commented on code in PR #13747: URL: https://github.com/apache/druid/pull/13747#discussion_r1103668685 ## helm/druid/templates/broker/role.yaml: ## @@ -0,0 +1,21 @@ +{{- if .Values.rbac.create }} +apiVersion: rbac.authorization.k8s.io/v1 +kind: Role +metadata: + name: {{

[GitHub] [druid] jwitko commented on a diff in pull request #13747: helm: Add serviceAccounts, rbac, and small fixes

2023-02-11 Thread via GitHub
jwitko commented on code in PR #13747: URL: https://github.com/apache/druid/pull/13747#discussion_r1103667806 ## helm/druid/README.md: ## @@ -96,10 +96,16 @@ The following table lists the configurable parameters of the Druid chart and the | `configVars`

[GitHub] [druid] jwitko commented on a diff in pull request #13747: helm: Add serviceAccounts, rbac, and small fixes

2023-02-11 Thread via GitHub
jwitko commented on code in PR #13747: URL: https://github.com/apache/druid/pull/13747#discussion_r1103667650 ## helm/druid/templates/broker/role.yaml: ## @@ -0,0 +1,21 @@ +{{- if .Values.rbac.create }} +apiVersion: rbac.authorization.k8s.io/v1 +kind: Role +metadata: + name: {{

[GitHub] [druid] jwitko commented on a diff in pull request #13747: helm: Add serviceAccounts, rbac, and small fixes

2023-02-10 Thread via GitHub
jwitko commented on code in PR #13747: URL: https://github.com/apache/druid/pull/13747#discussion_r1103116424 ## helm/druid/templates/broker/role.yaml: ## @@ -0,0 +1,21 @@ +{{- if .Values.rbac.create }} +apiVersion: rbac.authorization.k8s.io/v1 +kind: Role +metadata: + name: {{

[GitHub] [druid] jwitko commented on a diff in pull request #13747: helm: Add serviceAccounts, rbac, and small fixes

2023-02-10 Thread via GitHub
jwitko commented on code in PR #13747: URL: https://github.com/apache/druid/pull/13747#discussion_r1102885445 ## helm/druid/templates/broker/role.yaml: ## @@ -0,0 +1,21 @@ +{{- if .Values.rbac.create }} +apiVersion: rbac.authorization.k8s.io/v1 +kind: Role +metadata: + name: {{

[GitHub] [druid] jwitko commented on a diff in pull request #13747: helm: Add serviceAccounts, rbac, and small fixes

2023-02-10 Thread via GitHub
jwitko commented on code in PR #13747: URL: https://github.com/apache/druid/pull/13747#discussion_r1102886257 ## helm/druid/templates/broker/role.yaml: ## @@ -0,0 +1,21 @@ +{{- if .Values.rbac.create }} +apiVersion: rbac.authorization.k8s.io/v1 +kind: Role +metadata: + name: {{

[GitHub] [druid] jwitko commented on a diff in pull request #13747: helm: Add serviceAccounts, rbac, and small fixes

2023-02-10 Thread via GitHub
jwitko commented on code in PR #13747: URL: https://github.com/apache/druid/pull/13747#discussion_r1102872783 ## helm/druid/templates/broker/deployment.yaml: ## @@ -41,11 +41,15 @@ spec: app: {{ include "druid.name" . }} release: {{ .Release.Name }} co

[GitHub] [druid] jwitko commented on a diff in pull request #13747: helm: Add serviceAccounts, rbac, and small fixes

2023-02-08 Thread via GitHub
jwitko commented on code in PR #13747: URL: https://github.com/apache/druid/pull/13747#discussion_r1100573665 ## helm/druid/templates/broker/deployment.yaml: ## @@ -41,11 +41,15 @@ spec: app: {{ include "druid.name" . }} release: {{ .Release.Name }} co

[GitHub] [druid] jwitko commented on a diff in pull request #13747: helm: Add serviceAccounts, rbac, and small fixes

2023-02-08 Thread via GitHub
jwitko commented on code in PR #13747: URL: https://github.com/apache/druid/pull/13747#discussion_r1100571768 ## helm/druid/templates/broker/role.yaml: ## @@ -0,0 +1,21 @@ +{{- if .Values.rbac.create }} +apiVersion: rbac.authorization.k8s.io/v1 +kind: Role +metadata: + name: {{