liran-funaro commented on pull request #10335:
URL: https://github.com/apache/druid/pull/10335#issuecomment-715372075
@jihoonson Do we need more approval before merge?
This is an automated message from the Apache Git
liran-funaro commented on pull request #10335:
URL: https://github.com/apache/druid/pull/10335#issuecomment-714791644
Passed CI.
Thanks @jihoonson and @a2l007
This is an automated message from the Apache Git Service.
liran-funaro commented on pull request #10335:
URL: https://github.com/apache/druid/pull/10335#issuecomment-713496656
@jihoonson Thanks. I address all your comments.
Please let me know if you see any other required modifications, or that we
could proceed to merge this PR.
liran-funaro commented on pull request #10335:
URL: https://github.com/apache/druid/pull/10335#issuecomment-712906532
@jihoonson Do you have any more comments or can we proceed to merge this PR?
This is an automated message
liran-funaro commented on pull request #10335:
URL: https://github.com/apache/druid/pull/10335#issuecomment-709566461
@a2l007 Thanks!
This is an automated message from the Apache Git Service.
To respond to the message,
liran-funaro commented on pull request #10335:
URL: https://github.com/apache/druid/pull/10335#issuecomment-709328478
@a2l007 I addressed all your comments. Is there anything else I need to do
to move this PR forward?
This
liran-funaro commented on pull request #10335:
URL: https://github.com/apache/druid/pull/10335#issuecomment-705564572
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
liran-funaro commented on pull request #10335:
URL: https://github.com/apache/druid/pull/10335#issuecomment-705693671
> Could you please fix the CI failures as well? Looks like there is coverage
failure.
The coverage gap comes from `ParallelIndexTuningConfig.equals()` and it was
liran-funaro commented on pull request #10335:
URL: https://github.com/apache/druid/pull/10335#issuecomment-705564572
Thanks, @a2l007
I addressed all your comments in the codes, or with follow-up questions.
Regarding the integration tests, I added tests to all the `TuningConfig`
