[GitHub] [druid] liran-funaro commented on pull request #10593: IncrementalIndex Tests and Benchmarks Parametrization

2021-01-09 Thread GitBox
liran-funaro commented on pull request #10593: URL: https://github.com/apache/druid/pull/10593#issuecomment-756795145 Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [druid] liran-funaro commented on pull request #10593: IncrementalIndex Tests and Benchmarks Parametrization

2021-01-08 Thread GitBox
liran-funaro commented on pull request #10593: URL: https://github.com/apache/druid/pull/10593#issuecomment-756795145 Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [druid] liran-funaro commented on pull request #10593: IncrementalIndex Tests and Benchmarks Parametrization

2021-01-06 Thread GitBox
liran-funaro commented on pull request #10593: URL: https://github.com/apache/druid/pull/10593#issuecomment-755211304 Can we proceed to merge this PR? This is an automated message from the Apache Git Service. To respond to

[GitHub] [druid] liran-funaro commented on pull request #10593: IncrementalIndex Tests and Benchmarks Parametrization

2020-12-16 Thread GitBox
liran-funaro commented on pull request #10593: URL: https://github.com/apache/druid/pull/10593#issuecomment-746756807 @a2l007 I added a "User Experience Changes" section in the PR description. Thanks! This is an automated

[GitHub] [druid] liran-funaro commented on pull request #10593: IncrementalIndex Tests and Benchmarks Parametrization

2020-12-16 Thread GitBox
liran-funaro commented on pull request #10593: URL: https://github.com/apache/druid/pull/10593#issuecomment-746070511 Thanks, @a2l007. Please let me know what other modifications are required to approve this PR. Regarding your question: > Also I'm curious if you've noticed

[GitHub] [druid] liran-funaro commented on pull request #10593: IncrementalIndex Tests and Benchmarks Parametrization

2020-12-15 Thread GitBox
liran-funaro commented on pull request #10593: URL: https://github.com/apache/druid/pull/10593#issuecomment-745142880 @a2l007 The benchmark run results are available here: https://pastebin.pl/view/raw/8a5559c7 This is an

[GitHub] [druid] liran-funaro commented on pull request #10593: IncrementalIndex Tests and Benchmarks Parametrization

2020-12-13 Thread GitBox
liran-funaro commented on pull request #10593: URL: https://github.com/apache/druid/pull/10593#issuecomment-744045825 @a2l007 Thanks for your review. I made modifications accordingly. Let me know if you think more changes should be made, or if we can proceed to merge it. I have