maytasm opened a new pull request #9831: URL: https://github.com/apache/druid/pull/9831
Add equivalent test coverage for all RHS join impls ### Description This PR adds unit tests to make sure that we have equal coverage for all RHS join impls. We currently have 2 implementations of "joins", join against a lookup and join against an indexed table. We already have equal coverage tests for LookupJoinable and IndexedTableJoinable via LookupJoinableTest and IndexedTableJoinableTest (added from PR https://github.com/apache/druid/pull/9760). This PR adds the remaining missing tests for LookupJoinMatcher and IndexedTableJoinMatcher (so that we have equal coverage for LookupJoinMatcher and IndexedTableJoinMatcher too). This PR has: - [x] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
