[GitHub] [incubator-druid] aditya-r-m commented on issue #8682: implement FiniteFirehoseFactory in InlineFirehose

2019-10-16 Thread GitBox
aditya-r-m commented on issue #8682: implement FiniteFirehoseFactory in InlineFirehose URL: https://github.com/apache/incubator-druid/pull/8682#issuecomment-542927214 @jihoonson implemented the suggested updates. This is an

[GitHub] [incubator-druid] aditya-r-m commented on issue #8682: implement FiniteFirehoseFactory in InlineFirehose

2019-10-15 Thread GitBox
aditya-r-m commented on issue #8682: implement FiniteFirehoseFactory in InlineFirehose URL: https://github.com/apache/incubator-druid/pull/8682#issuecomment-542422193 @jihoonson thank you for your guidance. I will update the PR with the both of the points asap.

[GitHub] [incubator-druid] aditya-r-m commented on issue #8682: implement FiniteFirehoseFactory in InlineFirehose

2019-10-15 Thread GitBox
aditya-r-m commented on issue #8682: implement FiniteFirehoseFactory in InlineFirehose URL: https://github.com/apache/incubator-druid/pull/8682#issuecomment-542421231 @ccaominh @jihoonson the approach mentioned on the ticket is implemented here. I have tested it with basic inline