himanshug commented on a change in pull request #7716: Fix memory problem (OOM/FGC) when expression is used in metricsSpec URL: https://github.com/apache/incubator-druid/pull/7716#discussion_r287845275
########## File path: processing/src/main/java/org/apache/druid/query/aggregation/AggregatorUtil.java ########## @@ -196,7 +246,7 @@ static BaseFloatColumnValueSelector makeColumnValueSelectorWithFloatDefault( if (fieldName != null) { return metricFactory.makeColumnValueSelector(fieldName); } else { - final Expr expr = Parser.parse(fieldExpression, macroTable); + final Expr expr = parseIfAbsent(fieldExpression, macroTable); Review comment: @viongpanzi changes look good, thanks. also, not sure if you know/understood but when I raised https://github.com/viongpanzi/incubator-druid/pull/1 , I would expect you to merge the PR instead of copying the changes so that original commit stays alongside your commits . something for next time :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org