[GitHub] [incubator-druid] leventov commented on issue #7073: Remove unnecessary check for contains() in LoadRule

2019-03-06 Thread GitBox
leventov commented on issue #7073: Remove unnecessary check for contains() in LoadRule URL: https://github.com/apache/incubator-druid/pull/7073#issuecomment-470282165 @fjy I'm going to merge this PR next Monday unless you will leave some comments. -

[GitHub] [incubator-druid] leventov commented on issue #7073: Remove unnecessary check for contains() in LoadRule

2019-03-04 Thread GitBox
leventov commented on issue #7073: Remove unnecessary check for contains() in LoadRule URL: https://github.com/apache/incubator-druid/pull/7073#issuecomment-469387816 > @samarthjain could you please add a comment to the check in DruidCoordinatorBalancer explaining this matter? Howev

[GitHub] [incubator-druid] leventov commented on issue #7073: Remove unnecessary check for contains() in LoadRule

2019-03-04 Thread GitBox
leventov commented on issue #7073: Remove unnecessary check for contains() in LoadRule URL: https://github.com/apache/incubator-druid/pull/7073#issuecomment-469296307 Note that a similar check can *not* be removed (currently) in `DruidCoordinatorBalancer`, here: https://github.com/apac