[GitHub] [incubator-druid] sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put()

2019-05-27 Thread GitBox
sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put() URL: https://github.com/apache/incubator-druid/pull/7764#discussion_r287790197 ## File path: .idea/inspectionProfiles/Druid.xml ## @@ -306,6 +303,11 @@

[GitHub] [incubator-druid] sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put()

2019-05-27 Thread GitBox
sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put() URL: https://github.com/apache/incubator-druid/pull/7764#discussion_r287863927 ## File path: .idea/inspectionProfiles/Druid.xml ## @@ -161,7 +158,7 @@

[GitHub] [incubator-druid] sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put()

2019-05-27 Thread GitBox
sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put() URL: https://github.com/apache/incubator-druid/pull/7764#discussion_r287864332 ## File path: .idea/inspectionProfiles/Druid.xml ## @@ -306,6 +303,11 @@

[GitHub] [incubator-druid] sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put()

2019-05-27 Thread GitBox
sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put() URL: https://github.com/apache/incubator-druid/pull/7764#discussion_r287866951 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/firehose/IngestS

[GitHub] [incubator-druid] sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put()

2019-05-27 Thread GitBox
sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put() URL: https://github.com/apache/incubator-druid/pull/7764#discussion_r287866880 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/firehose/IngestS

[GitHub] [incubator-druid] sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put()

2019-05-27 Thread GitBox
sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put() URL: https://github.com/apache/incubator-druid/pull/7764#discussion_r287867297 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/firehose/IngestS

[GitHub] [incubator-druid] sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put()

2019-05-28 Thread GitBox
sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put() URL: https://github.com/apache/incubator-druid/pull/7764#discussion_r288209037 ## File path: .idea/inspectionProfiles/Druid.xml ## @@ -88,9 +88,6 @@

[GitHub] [incubator-druid] sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put()

2019-05-28 Thread GitBox
sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put() URL: https://github.com/apache/incubator-druid/pull/7764#discussion_r288209231 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/firehose/IngestS

[GitHub] [incubator-druid] sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put()

2019-05-28 Thread GitBox
sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put() URL: https://github.com/apache/incubator-druid/pull/7764#discussion_r288209191 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/Inde

[GitHub] [incubator-druid] sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put()

2019-05-28 Thread GitBox
sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put() URL: https://github.com/apache/incubator-druid/pull/7764#discussion_r288209118 ## File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/DetermineHashedPar

[GitHub] [incubator-druid] sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put()

2019-05-28 Thread GitBox
sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put() URL: https://github.com/apache/incubator-druid/pull/7764#discussion_r288209148 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/appenderator/Act

[GitHub] [incubator-druid] sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put()

2019-05-28 Thread GitBox
sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put() URL: https://github.com/apache/incubator-druid/pull/7764#discussion_r288209231 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/firehose/IngestS

[GitHub] [incubator-druid] sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put()

2019-05-28 Thread GitBox
sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put() URL: https://github.com/apache/incubator-druid/pull/7764#discussion_r288209191 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/Inde

[GitHub] [incubator-druid] sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put()

2019-05-28 Thread GitBox
sashidhar commented on a change in pull request #7764: #7316 Use Map.putIfAbsent() instead of containsKey() + put() URL: https://github.com/apache/incubator-druid/pull/7764#discussion_r288209118 ## File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/DetermineHashedPar