[GitHub] gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics

2019-01-11 Thread GitBox
gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics URL: https://github.com/apache/incubator-druid/pull/6302#discussion_r247175297 ## File path: server/src/main/java/org/apache/druid/server/RequestLogLine.java ## @@ -58,10 +78,12 @@ pub

[GitHub] gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics

2019-01-08 Thread GitBox
gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics URL: https://github.com/apache/incubator-druid/pull/6302#discussion_r246158941 ## File path: sql/src/main/java/org/apache/druid/sql/SqlLifecycle.java ## @@ -0,0 +1,361 @@ +/* + * Licen

[GitHub] gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics

2019-01-08 Thread GitBox
gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics URL: https://github.com/apache/incubator-druid/pull/6302#discussion_r246157958 ## File path: server/src/main/java/org/apache/druid/server/RequestLogLine.java ## @@ -58,10 +78,12 @@ pub

[GitHub] gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics

2019-01-08 Thread GitBox
gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics URL: https://github.com/apache/incubator-druid/pull/6302#discussion_r246160712 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/view/DruidViewMacro.java ## @@ -51,10 +52,1

[GitHub] gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics

2019-01-08 Thread GitBox
gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics URL: https://github.com/apache/incubator-druid/pull/6302#discussion_r246158328 ## File path: server/src/main/java/org/apache/druid/server/log/FileRequestLogger.java ## @@ -127,12 +130

[GitHub] gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics

2019-01-08 Thread GitBox
gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics URL: https://github.com/apache/incubator-druid/pull/6302#discussion_r246160808 ## File path: sql/src/main/java/org/apache/druid/sql/http/SqlResource.java ## @@ -81,16 +85,21 @@ public

[GitHub] gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics

2019-01-08 Thread GitBox
gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics URL: https://github.com/apache/incubator-druid/pull/6302#discussion_r246156359 ## File path: server/src/main/java/org/apache/druid/server/RequestLogLine.java ## @@ -58,10 +78,12 @@ pub

[GitHub] gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics

2019-01-08 Thread GitBox
gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics URL: https://github.com/apache/incubator-druid/pull/6302#discussion_r246145054 ## File path: docs/content/configuration/index.md ## @@ -1244,7 +1256,7 @@ The Druid SQL server is config

[GitHub] gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics

2019-01-08 Thread GitBox
gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics URL: https://github.com/apache/incubator-druid/pull/6302#discussion_r246145924 ## File path: processing/src/main/java/org/apache/druid/query/BaseQuery.java ## @@ -224,13 +225,25 @@ pub

[GitHub] gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics

2019-01-08 Thread GitBox
gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics URL: https://github.com/apache/incubator-druid/pull/6302#discussion_r246159853 ## File path: sql/src/main/java/org/apache/druid/sql/SqlLifecycle.java ## @@ -0,0 +1,361 @@ +/* + * Licen

[GitHub] gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics

2019-01-08 Thread GitBox
gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics URL: https://github.com/apache/incubator-druid/pull/6302#discussion_r246158816 ## File path: sql/src/main/java/org/apache/druid/sql/SqlLifecycle.java ## @@ -0,0 +1,361 @@ +/* + * Licen

[GitHub] gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics

2019-01-08 Thread GitBox
gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics URL: https://github.com/apache/incubator-druid/pull/6302#discussion_r246159807 ## File path: sql/src/main/java/org/apache/druid/sql/SqlLifecycle.java ## @@ -0,0 +1,361 @@ +/* + * Licen

[GitHub] gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics

2019-01-08 Thread GitBox
gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics URL: https://github.com/apache/incubator-druid/pull/6302#discussion_r246161506 ## File path: sql/src/main/java/org/apache/druid/sql/http/SqlResource.java ## @@ -148,12 +159,20 @@ publi

[GitHub] gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics

2018-09-28 Thread GitBox
gianm commented on a change in pull request #6302: Add SQL id, request logs, and metrics URL: https://github.com/apache/incubator-druid/pull/6302#discussion_r221352359 ## File path: server/src/main/java/org/apache/druid/server/log/AbstractFileRequestLogger.java ## @@ -0,0