Re: [PR] Fix complex columns with export (druid)

2024-06-23 Thread via GitHub
adarshsanjeev merged PR #16572: URL: https://github.com/apache/druid/pull/16572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@drui

Re: [PR] Fix complex columns with export (druid)

2024-06-21 Thread via GitHub
LakshSingla commented on code in PR #16572: URL: https://github.com/apache/druid/pull/16572#discussion_r1647501428 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/results/ExportResultsFrameProcessor.java: ## @@ -167,9 +175,23 @@ private void expo

Re: [PR] Fix complex columns with export (druid)

2024-06-17 Thread via GitHub
adarshsanjeev commented on code in PR #16572: URL: https://github.com/apache/druid/pull/16572#discussion_r1643725455 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/results/ExportResultsFrameProcessor.java: ## @@ -167,9 +175,22 @@ private void ex

Re: [PR] Fix complex columns with export (druid)

2024-06-17 Thread via GitHub
adarshsanjeev commented on code in PR #16572: URL: https://github.com/apache/druid/pull/16572#discussion_r1643685742 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/results/ExportResultsFrameProcessorFactory.java: ## @@ -63,19 +64,22 @@ public cl

Re: [PR] Fix complex columns with export (druid)

2024-06-16 Thread via GitHub
LakshSingla commented on code in PR #16572: URL: https://github.com/apache/druid/pull/16572#discussion_r164664 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/results/ExportResultsFrameProcessor.java: ## @@ -167,9 +175,22 @@ private void expo

Re: [PR] Fix complex columns with export (druid)

2024-06-11 Thread via GitHub
adarshsanjeev commented on code in PR #16572: URL: https://github.com/apache/druid/pull/16572#discussion_r1633422793 ## extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQExportTest.java: ## @@ -133,7 +133,142 @@ public void testNumberOfRowsPerFile()

Re: [PR] Fix complex columns with export (druid)

2024-06-10 Thread via GitHub
adarshsanjeev commented on code in PR #16572: URL: https://github.com/apache/druid/pull/16572#discussion_r1633422793 ## extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQExportTest.java: ## @@ -133,7 +133,142 @@ public void testNumberOfRowsPerFile()

[PR] Fix complex columns with export (druid)

2024-06-06 Thread via GitHub
adarshsanjeev opened a new pull request, #16572: URL: https://github.com/apache/druid/pull/16572 This PR fixes a few bugs with MSQ export. - Fixes printing of complex columns during export, included sketches and JSON. - Fixes an NPE if the writer has not been initialized Uni