[incubator-druid] branch 0.12.3 updated: RowBasedKeySerde should use empty dictionary in constructor (#6256) (#6261)

[jihoonson]

This is an automated email from the ASF dual-hosted git repository.

jihoonson pushed a commit to branch 0.12.3
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git


The following commit(s) were added to refs/heads/0.12.3 by this push:
     new af61373  RowBasedKeySerde should use empty dictionary in constructor 
(#6256) (#6261)
af61373 is described below

commit af61373582943f3d074bb849e76da17ef8f6c89b
Author: Gian Merlino <gianmerl...@gmail.com>
AuthorDate: Tue Aug 28 19:05:50 2018 -0700

    RowBasedKeySerde should use empty dictionary in constructor (#6256) (#6261)
---
 .../io/druid/query/groupby/epinephelinae/RowBasedGrouperHelper.java  | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git 
a/processing/src/main/java/io/druid/query/groupby/epinephelinae/RowBasedGrouperHelper.java
 
b/processing/src/main/java/io/druid/query/groupby/epinephelinae/RowBasedGrouperHelper.java
index fa4f2a9..aec0676 100644
--- 
a/processing/src/main/java/io/druid/query/groupby/epinephelinae/RowBasedGrouperHelper.java
+++ 
b/processing/src/main/java/io/druid/query/groupby/epinephelinae/RowBasedGrouperHelper.java
@@ -916,7 +916,6 @@ public class RowBasedGrouperHelper
 
   private static class RowBasedKeySerde implements 
Grouper.KeySerde<RowBasedGrouperHelper.RowBasedKey>
   {
-    private static final int DICTIONARY_INITIAL_CAPACITY = 10000;
     private static final int UNKNOWN_DICTIONARY_ID = -1;
 
     private final boolean includeTimestamp;
@@ -962,9 +961,9 @@ public class RowBasedGrouperHelper
       this.valueTypes = valueTypes;
       this.limitSpec = limitSpec;
       this.enableRuntimeDictionaryGeneration = dictionary == null;
-      this.dictionary = enableRuntimeDictionaryGeneration ? new 
ArrayList<>(DICTIONARY_INITIAL_CAPACITY) : dictionary;
+      this.dictionary = enableRuntimeDictionaryGeneration ? new ArrayList<>() 
: dictionary;
       this.reverseDictionary = enableRuntimeDictionaryGeneration ?
-                               new 
Object2IntOpenHashMap<>(DICTIONARY_INITIAL_CAPACITY) :
+                               new Object2IntOpenHashMap<>() :
                                new Object2IntOpenHashMap<>(dictionary.size());
       this.reverseDictionary.defaultReturnValue(UNKNOWN_DICTIONARY_ID);
       this.maxDictionarySize = maxDictionarySize;


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org