This is an automated email from the ASF dual-hosted git repository.
jihoonson pushed a commit to branch 0.13.0-incubating
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
The following commit(s) were added to refs/heads/0.13.0-incubating by this push:
new de3fdc6 remove backpressure time from DefaultQueryMetrics pending
on-going discussion (#6631) (#6632)
de3fdc6 is described below
commit de3fdc6a5c135cdb8fb8147d5258e6bd97f7442c
Author: David Lim <david...@apache.org>
AuthorDate: Thu Nov 15 21:09:06 2018 -0700
remove backpressure time from DefaultQueryMetrics pending on-going
discussion (#6631) (#6632)
---
.../src/main/java/org/apache/druid/query/DefaultQueryMetrics.java | 3 ++-
.../test/java/org/apache/druid/query/DefaultQueryMetricsTest.java | 5 -----
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git
a/processing/src/main/java/org/apache/druid/query/DefaultQueryMetrics.java
b/processing/src/main/java/org/apache/druid/query/DefaultQueryMetrics.java
index b332fec..bedcffe 100644
--- a/processing/src/main/java/org/apache/druid/query/DefaultQueryMetrics.java
+++ b/processing/src/main/java/org/apache/druid/query/DefaultQueryMetrics.java
@@ -246,7 +246,8 @@ public class DefaultQueryMetrics<QueryType extends
Query<?>> implements QueryMet
@Override
public QueryMetrics<QueryType> reportBackPressureTime(long timeNs)
{
- return reportMillisTimeMetric("query/node/backpressure", timeNs);
+ // Don't emit by default.
+ return this;
}
@Override
diff --git
a/processing/src/test/java/org/apache/druid/query/DefaultQueryMetricsTest.java
b/processing/src/test/java/org/apache/druid/query/DefaultQueryMetricsTest.java
index 6f837d9..72121b2 100644
---
a/processing/src/test/java/org/apache/druid/query/DefaultQueryMetricsTest.java
+++
b/processing/src/test/java/org/apache/druid/query/DefaultQueryMetricsTest.java
@@ -152,10 +152,5 @@ public class DefaultQueryMetricsTest
actualEvent = cachingEmitter.getLastEmittedEvent().toMap();
Assert.assertEquals("query/node/bytes", actualEvent.get("metric"));
Assert.assertEquals(10L, actualEvent.get("value"));
-
- queryMetrics.reportBackPressureTime(11000001).emit(serviceEmitter);
- actualEvent = cachingEmitter.getLastEmittedEvent().toMap();
- Assert.assertEquals("query/node/backpressure", actualEvent.get("metric"));
- Assert.assertEquals(11L, actualEvent.get("value"));
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
