[GitHub] [echarts] pissang commented on a diff in pull request #18032: fix(ssr): fix label doesn't show in line series when `ssr` is enabled

2022-12-20 Thread GitBox
pissang commented on code in PR #18032: URL: https://github.com/apache/echarts/pull/18032#discussion_r1053199855 ## src/chart/line/LineView.ts: ## @@ -644,7 +644,7 @@ class LineView extends ChartView { const lineGroup = this._lineGroup; -const hasAnimation =

[GitHub] [echarts] pissang commented on a diff in pull request #18032: fix(ssr): fix label doesn't show in line series when `ssr` is enabled

2022-12-07 Thread GitBox
pissang commented on code in PR #18032: URL: https://github.com/apache/echarts/pull/18032#discussion_r1042862485 ## src/chart/line/LineView.ts: ## @@ -644,7 +644,7 @@ class LineView extends ChartView { const lineGroup = this._lineGroup; -const hasAnimation =