gooroodev commented on PR #19602:
URL: https://github.com/apache/echarts/pull/19602#issuecomment-2131318923
### 1. Summary of Changes
The pull request addresses an issue where stacked areas overflow on null
values when the `connectNulls` option is set to true. The changes involve
updatin
admsev commented on PR #19602:
URL: https://github.com/apache/echarts/pull/19602#issuecomment-2131318380
@gooroodev review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
visakadev commented on PR #19602:
URL: https://github.com/apache/echarts/pull/19602#issuecomment-2104475038
> > addressed areas stacking when connectNulls is enabled
>
> I think _connectNulls_ should not be enabled in stacked area charts since
it makes ECharts display fake totals.
helgasoft commented on PR #19602:
URL: https://github.com/apache/echarts/pull/19602#issuecomment-1968086176
A strong argument in favor would be to find out whether another charting
library (highcharts, amcharts, ?) has taken a chance on implementing it.
--
This is an automated message fro
github-actions[bot] commented on PR #19602:
URL: https://github.com/apache/echarts/pull/19602#issuecomment-1943412471
The changes brought by this PR can be previewed at:
https://echarts.apache.org/examples/editor?version=PR-19602@e4ed74c
--
This is an automated message from the Ap
helgasoft commented on PR #19602:
URL: https://github.com/apache/echarts/pull/19602#issuecomment-1943221779
> addressed areas stacking when connectNulls is enabled
I think _connectNulls_ should not be enabled in stacked area charts since it
makes ECharts display fake totals.
H
alxnddr commented on PR #19602:
URL: https://github.com/apache/echarts/pull/19602#issuecomment-1941795702
@helgasoft thanks for your feedback. In my pull request I addressed areas
stacking when `connectNulls` is enabled so that it literally connects polygon
lines on null values instead of d
helgasoft commented on PR #19602:
URL: https://github.com/apache/echarts/pull/19602#issuecomment-1936374853
The purpose of stacked lines is to show totals. This PR would make totals at
**all red points incorrect**.
I think responsibility for such "fixes" belongs to the developer, not to t
echarts-bot[bot] commented on PR #19602:
URL: https://github.com/apache/echarts/pull/19602#issuecomment-1934842305
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the
coding standard](https://echarts.apache.org/en/coding-standard.html) a
alxnddr opened a new pull request, #19602:
URL: https://github.com/apache/echarts/pull/19602
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
The pull request fixes the logic o
10 matches
Mail list logo
